Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-28 Thread Tony Lindgren
* Aaro Koskinen [190828 18:23]: > On Wed, Aug 28, 2019 at 03:02:36PM +0200, Arnd Bergmann wrote: > > I assume you checked that the uart output wasn't already broken > > by one of the earlier patches, right? > > Correct, it's only with the mapping change patch it hangs. > > > Also, looking at

Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()

2019-08-28 Thread Tony Lindgren
* Ladislav Michl [190827 18:15]: > On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote: > > * Markus Elfring [190826 06:31]: > > > From: Markus Elfring > > > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > > > > > A null pointer would be pass

[PATCH] leds: lm3532: Avoid potentially unpaired regulator calls

2019-08-27 Thread Tony Lindgren
We may currently get unpaired regulator calls when configuring the LED brightness via sysfs in case of regulator calls producing errors. Let's fix this by maintaining local state for enabled. Signed-off-by: Tony Lindgren --- drivers/leds/leds-lm3532.c | 26 -- 1 file

Re: [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode

2019-08-27 Thread Tony Lindgren
* Dan Murphy [190827 16:20]: > Tony > > On 8/27/19 11:04 AM, Tony Lindgren wrote: > > * Dan Murphy [190827 13:02]: > > > Hello > > > > > > On 8/27/19 7:44 AM, Dan Murphy wrote: > > > > Tony > > > > > > > > On 8

Re: [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode

2019-08-27 Thread Tony Lindgren
* Dan Murphy [190827 13:02]: > Hello > > On 8/27/19 7:44 AM, Dan Murphy wrote: > > Tony > > > > On 8/27/19 7:18 AM, Pavel Machek wrote: > > > On Mon 2019-08-26 15:44:37, Tony Lindgren wrote: > > > > * Pavel Machek [190826 22:14]: > >

Re: [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode

2019-08-26 Thread Tony Lindgren
* Pavel Machek [190826 22:14]: > On Mon 2019-08-26 14:58:22, Tony Lindgren wrote: > > Hi, > > > > * Dan Murphy [190820 19:53]: > > > Fix the brightness control for I2C mode. Instead of > > > changing the full scale current register update the ALS target &

Re: [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode

2019-08-26 Thread Tony Lindgren
Hi, * Dan Murphy [190820 19:53]: > Fix the brightness control for I2C mode. Instead of > changing the full scale current register update the ALS target > register for the appropriate banks. > > In addition clean up some code errors and random misspellings found > during coding. > > Tested on

Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()

2019-08-26 Thread Tony Lindgren
* Markus Elfring [190826 06:31]: > From: Markus Elfring > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > A null pointer would be passed to a call of the function "kfree" directly > after a call of the function "kzalloc" failed at one place. > Remove this superfluous function call. > > This issue

Re: [PATCH] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2

2019-08-26 Thread Tony Lindgren
* Masahiro Yamada [190822 19:59]: > is only generated and included by > arch/arm/mach-omap2/, so it does not need to reside in the globally > visible include/generated/. > > I renamed it to arch/arm/mach-omap2/pm-asm-offsets.h since the prefix > 'ti-' is just redundant in mach-omap2/. > > My

Re: [PATCH v4] bus: ti-sysc: Change return types of functions

2019-08-26 Thread Tony Lindgren
* Roger Quadros [190815 13:03]: > On 15/08/2019 08:46, Nishka Dasgupta wrote: > > Change return type of functions sysc_check_one_child() and > > sysc_check_children() from int to void as neither ever returns an error. > > Modify call sites of both functions accordingly. > > > > Signed-off-by:

Re: Lay common foundation to make PVR/SGX work without hacks on OMAP34xx, OMAP36xx, AM335x and potentially OMAP4, OMAP5

2019-08-21 Thread Tony Lindgren
* Adam Ford [190819 19:26]: > On Sat, Aug 17, 2019 at 2:03 AM Tony Lindgren wrote: > > > > * Adam Ford [190816 23:02]: > > > On Wed, Aug 14, 2019 at 8:16 AM Tony Lindgren wrote: > > > > Well I just posted some sgx interconnect target module patches. We m

Re: Lay common foundation to make PVR/SGX work without hacks on OMAP34xx, OMAP36xx, AM335x and potentially OMAP4, OMAP5

2019-08-17 Thread Tony Lindgren
* Adam Ford [190816 23:02]: > On Wed, Aug 14, 2019 at 8:16 AM Tony Lindgren wrote: > > Well I just posted some sgx interconnect target module patches. We might > > still have them in v5.4 assuming people manage to review and test them. > > Nikolaus, > > I tested Tony

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-14 Thread Tony Lindgren
* Arnd Bergmann [190814 10:37]: > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > * Arnd Bergmann [190813 19:34]: > > > On Tue, Aug 13, 2019 at 8:12 PM Aaro Koskinen > > > wrote: > > > diff --git a/arch/arm/mach-omap1/hardware.h > > >

Re: Lay common foundation to make PVR/SGX work without hacks on OMAP34xx, OMAP36xx, AM335x and potentially OMAP4, OMAP5

2019-08-14 Thread Tony Lindgren
* H. Nikolaus Schaller [190814 10:34]: > > > Am 14.08.2019 um 11:47 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [190814 08:57]: > >> I also have pushed good news to > >> > >>https://github.com/openpvrsgx-devgroup/linux_openpvr

Re: Lay common foundation to make PVR/SGX work without hacks on OMAP34xx, OMAP36xx, AM335x and potentially OMAP4, OMAP5

2019-08-14 Thread Tony Lindgren
* H. Nikolaus Schaller [190814 08:57]: > I also have pushed good news to > > https://github.com/openpvrsgx-devgroup/linux_openpvrsgx/tree/letux-pvr > > Thanks to the help from the Pyra community, I was able to get a (binary) > reference > implementation using DRM that works on

Re: "PM / wakeup: Show wakeup sources stats in sysfs" causes boot warnings

2019-08-14 Thread Tony Lindgren
* Stephen Boyd [691231 23:00]: > I also notice that device_set_wakeup_capable() has a check to see if the > device is registered yet and it skips creating sysfs entries for the > device if it isn't created in sysfs yet. Why? Just so it can be called > before the device is created? I guess the

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-14 Thread Tony Lindgren
* Arnd Bergmann [190813 19:34]: > On Tue, Aug 13, 2019 at 8:12 PM Aaro Koskinen wrote: > > On Tue, Aug 13, 2019 at 01:02:16PM +0200, Arnd Bergmann wrote: > > > On Tue, Aug 13, 2019 at 12:36 PM Tony Lindgren wrote: > > > > > - I force CONFIG_PCI to

Re: Regression in Linux next with show wakeup sources stats in sysfs

2019-08-14 Thread Tony Lindgren
* Stephen Boyd [190814 07:09]: > Quoting Tony Lindgren (2019-08-13 23:38:03) > > Hi all, > > > > Looks like commit 986845e747af ("PM / wakeup: Show wakeup sources stats > > in sysfs") has caused a regression in Linux next where I can now get >

Regression in Linux next with show wakeup sources stats in sysfs

2019-08-14 Thread Tony Lindgren
Hi all, Looks like commit 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs") has caused a regression in Linux next where I can now get some errors like this during the boot: kobject_add_internal failed for wakeup10 (error: -2 parent: usb) Any ideas why this might be happening?

Re: [PATCH -next] soc: ti: pm33xx: Make two symbols static

2019-08-13 Thread Tony Lindgren
* Yue Haibing [190413 07:13]: > From: YueHaibing > > Fix sparse warnings: > > drivers/soc/ti/pm33xx.c:144:27: warning: symbol 'rtc_wake_src' was not > declared. Should it be static? > drivers/soc/ti/pm33xx.c:160:5: warning: symbol 'am33xx_rtc_only_idle' was not > declared. Should it be

Re: [PATCH] soc: ti: pm33xx: Fix static checker warnings

2019-08-13 Thread Tony Lindgren
* Keerthy [190626 00:50]: > The patch fixes a bunch of static checker warnings. Sorry I just noticed that this one is still pending, applying into fixes. Tony

Re: [PATCH] ARM: OMAP: dma: Mark expected switch fall-throughs

2019-08-13 Thread Tony Lindgren
* Kees Cook [190729 16:35]: > On Sun, Jul 28, 2019 at 06:22:40PM -0500, Gustavo A. R. Silva wrote: > > Mark switch cases where we are expecting to fall through. > > > > This patch fixes the following warnings: > > > > arch/arm/plat-omap/dma.c: In function 'omap_set_dma_src_burst_mode': > >

Re: [PATCH v2] ARM: dts: am335x-boneblue: Use of am335x-osd335x-common.dtsi

2019-08-13 Thread Tony Lindgren
* David Lechner [190807 13:10]: > This makes use of the am335x-osd335x-common.dtsi file that contains the > common device tree components for Octavo Systems AM335x System-in- > Package that is used on the BeagleBone Blue. > > This has two minor side-effects: > 1. pinmux_i2c0_pins is renamed to

Re: [PATCH 1/2] DTS: ARM: gta04: define chosen/stdout-path

2019-08-13 Thread Tony Lindgren
* H. Nikolaus Schaller [190708 14:46]: > This allows to remove the console= entry in the kernel command line. Applying this patch into omap-for-v5.4/dt thanks. Tony

Re: [PATCH v3 2/2] bus: ti-sysc: sysc_check_children(): Change return type to void

2019-08-13 Thread Tony Lindgren
* Roger Quadros [190813 11:14]: > > On 13/08/2019 10:55, Nishka Dasgupta wrote: > > Change return type of function sysc_check_children() from int to void as > > it always returns 0. Remove its return statement as well. > > At call site, remove the variable that was used to store the return > >

Re: [PATCH -next] bus: ti-sysc: remove set but not used variable 'quirks'

2019-08-13 Thread Tony Lindgren
* YueHaibing [190627 21:17]: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/bus/ti-sysc.c: In function sysc_reset: > drivers/bus/ti-sysc.c:1452:50: warning: variable quirks set but not used > [-Wunused-but-set-variable] > > It is never used since commit e0db94fe87da ("bus:

Re: [PATCH 0/3] bus: ti-sysc: fixes for reset handling

2019-08-13 Thread Tony Lindgren
* Tero Kristo [190807 05:47]: > Hi, > > Here are a few patches to fix reset handling for ti-sysc bus driver. > Without these, the iommu won't be working properly at least. Applying these into omap-for-v5.4/ti-sysc since the prm rstctrl driver is not yet merged and these should not be needed as

Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc

2019-08-13 Thread Tony Lindgren
* Jyri Sarha [190813 11:05]: > On 23/07/2019 22:03, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > >> We currently get a warning for lcdc because of a difference > >> with dts provided configuration compared to the legacy p

Re: [PATCH 5/5] bus: ti-sysc: Simplify cleanup upon failures in sysc_probe()

2019-08-13 Thread Tony Lindgren
* Suman Anna [190627 15:24]: > On 6/27/19 7:11 AM, Tony Lindgren wrote: > > Hi, > > > > * Suman Anna [190625 23:33]: > >> The clocks are not yet parsed and prepared until after a successful > >> sysc_get_clocks(), so there is no need to unprepare

Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc

2019-08-13 Thread Tony Lindgren
* Suman Anna [190724 18:29]: > On 7/24/19 1:31 AM, Tony Lindgren wrote: > > OK thanks for testing. Let's drop this for now, sounds like there is > > some midlemode configuration happening even with no flags set. > > You were dropping the ti,sysc-midle property in patch

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-13 Thread Tony Lindgren
Hi, * Arnd Bergmann [190808 21:34]: > The ISA I/O space handling in omap_cf is incompatible with > PCI drivers in a multiplatform kernel, and requires a custom > mach/io.h. > > Change the driver to use pci_ioremap_io() like PCI drivers do, > so the generic ioport access can work across

Re: [PATCH for v5.3] ARM: OMAP1: ams-delta-fiq: Fix missing irq_ack

2019-08-13 Thread Tony Lindgren
* Janusz Krzysztofik [190811 01:48]: > Non-serio path of Amstrad Delta FIQ deferred handler depended on > irq_ack() method provided by OMAP GPIO driver. That method has been > removed by commit 693de831c6e5 ("gpio: omap: remove irq_ack method"). > Remove useless code from the deferred handler

Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put

2019-08-13 Thread Tony Lindgren
* Takashi Iwai [190809 08:24]: > On Fri, 09 Aug 2019 09:46:43 +0200, > Tony Lindgren wrote: > > > > * Takashi Iwai [190809 07:25]: > > > On Fri, 09 Aug 2019 09:00:03 +0200, > > > Tony Lindgren wrote: > > > > > > > > Hi, > > >

Re: [PATCH] ARM: dts: dra74x: Fix iodelay configuration for mmc3

2019-08-13 Thread Tony Lindgren
* Faiz Abbas [190807 03:53]: > According to the latest am572x[1] and dra74x[2] data manuals, mmc3 > default, hs, sdr12 and sdr25 modes use iodelay values given in > MMC3_MANUAL1. Set the MODE_SELECT bit for these so that manual mode is > selected and correct iodelay values can be configured.

Re: [PATCH 1/1] ARM: dts: am335x: Fix UARTs length

2019-08-13 Thread Tony Lindgren
Hi, * Emmanuel Vadot [190724 05:24]: > As seen on the AM335x TRM all the UARTs controller only are 0x1000 in size. > Fix this in the DTS. Thanks applying into fixes. FYI, the module size is usually (but not always) 0x1000 with additional 0x1000 for the interconnect related registers. Regards,

Re: [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level

2019-08-13 Thread Tony Lindgren
* Andreas Klinger [190709 11:32]: > mmc cards on mmc1 are not detected because of wrong card detect (cd) level. > > Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW. > > This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc: > Delete platform data GPIO CD and WP") > >

Re: [PATCH] bus: ti-sysc: Remove if-block in sysc_check_children()

2019-08-13 Thread Tony Lindgren
* Roger Quadros [190813 06:26]: > None of those functions return anything. > Maybe you can fix sysc_check_one_child() to return void? > I think you can retain your patch but get rid of error variable. Makes sense to me. Regards, Tony

Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put

2019-08-09 Thread Tony Lindgren
* Takashi Iwai [190809 07:25]: > On Fri, 09 Aug 2019 09:00:03 +0200, > Tony Lindgren wrote: > > > > Hi, > > > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add > > snd_soc_component_get/put()") causes a regression where trying > >

Regression in next with codec unload and snd_soc_component_get/put

2019-08-09 Thread Tony Lindgren
Hi, Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add snd_soc_component_get/put()") causes a regression where trying to rmmod a codec driver fails with module is in use error after rmmod of snd-soc-audio-graph-card for example. Any ideas what goes wrong there? BTW, looks like the

Re: [PATCH] kernfs: fix memleak in kernel_ops_readdir()

2019-08-07 Thread Tony Lindgren
Hi, * Tejun Heo [691231 23:00]: > From: Andrea Arcangeli > > If getdents64 is killed or hits on segfault, it'll leave cgroups > directories in sysfs pinned leaking memory because the kernfs node > won't be freed on rmdir and the parent neither. Somehow this causes a regression in Linux next

Re: [PATCH 5/8] ARM: dts: Drop bogus ahclkr clocks for dra7 mcasp 3 to 8

2019-07-24 Thread Tony Lindgren
* Suman Anna [190723 21:02]: > Hi Tony, > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > > The ahclkr clkctrl clock bit 28 only exists for mcasp 1 and 2 on dra7. > > Otherwise we get the following warning on beagle-x15: ... &

Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc

2019-07-24 Thread Tony Lindgren
* Keerthy [190724 05:50]: > > On 24/07/19 12:33 AM, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > > > We currently get a warning for lcdc because of a difference > > > with dts provided configuration compared to the l

Re: [PATCH 3/4] ARM: dts: am33xx: Add nodes for eQEP

2019-07-23 Thread Tony Lindgren
* David Lechner [190723 14:46]: > On 7/23/19 3:42 AM, Tony Lindgren wrote: > > * David Lechner [190722 15:46]: > > > This adds new nodes for the Texas Instruments Enhanced Quadrature > > > Encoder Pulse (eQEP) module in the PWM subsystem on AM33XX. > > >

[PATCH] serial: 8250_omap: Fix idling for unloaded serdev drivers

2019-07-23 Thread Tony Lindgren
in that case. And the serdev driver can idle the port during runtime when suitable if an out-of-band wake-up GPIO line exists for example. Let's also add some comments to the workaround while at it. Cc: Johan Hovold Signed-off-by: Tony Lindgren --- drivers/tty/serial/8250/8250_omap.c | 11

[PATCH 8/8] ARM: dts: Fix lcdc sysc flags for am3

2019-07-23 Thread Tony Lindgren
red so let's remove that property. Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi --- a/arch/arm/boot/dts/am33xx-l4.dtsi +++ b/arch/arm/bo

[PATCH 7/8] ARM: dts: Fix incorrect dcan register mapping for am3, am4 and dra7

2019-07-23 Thread Tony Lindgren
We are currently using a wrong register for dcan revision. Although this is currently only used for detecting the dcan module, let's fix it to avoid confusion. Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/am33xx-l4.dtsi | 4 arch/arm/boot/dts/am437x-l4.dtsi | 4 arch/arm/boot

[PATCH 6/8] ARM: dts: Fix flags for gpio7

2019-07-23 Thread Tony Lindgren
-on-init Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi | 2 +- arch/arm/boot/dts/dra7-evm.dts | 2 +- arch/arm/boot/dts/dra7-l4.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/am57xx

[PATCH 0/8] ti-sysc related warning fixes for v5.3-rc cycle

2019-07-23 Thread Tony Lindgren
two fixes for the ti-sysc driver while looking at the warnings. Regards, Tony Tony Lindgren (8): ARM: OMAP2+: Fix missing SYSC_HAS_RESET_STATUS for dra7 epwmss ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc bus: ti-sysc: Fix handling of forced idle bus: ti-sysc: Fix using

[PATCH 1/8] ARM: OMAP2+: Fix missing SYSC_HAS_RESET_STATUS for dra7 epwmss

2019-07-23 Thread Tony Lindgren
-by: Tony Lindgren --- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c +++ b/arch/arm/mach-omap2

[PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc

2019-07-23 Thread Tony Lindgren
that the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c

[PATCH 4/8] bus: ti-sysc: Fix using configured sysc mask value

2019-07-23 Thread Tony Lindgren
We have cases where there are no softreset bits like with am335x lcdc. In that case ti,sysc-mask = <0> needs to be handled properly. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drive

[PATCH 5/8] ARM: dts: Drop bogus ahclkr clocks for dra7 mcasp 3 to 8

2019-07-23 Thread Tony Lindgren
The ahclkr clkctrl clock bit 28 only exists for mcasp 1 and 2 on dra7. Otherwise we get the following warning on beagle-x15: ti-sysc 48468000.target-module: could not add child clock ahclkr: -19 Fixes: 5241ccbf2819 ("ARM: dts: Add missing ranges for dra7 mcasp l3 ports") Signed-of

[PATCH 3/8] bus: ti-sysc: Fix handling of forced idle

2019-07-23 Thread Tony Lindgren
") Cc: Roger Quadros Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -949,7 +949,7 @@ static int sysc_best_idl

Re: [PATCH 3/4] ARM: dts: am33xx: Add nodes for eQEP

2019-07-23 Thread Tony Lindgren
* David Lechner [190722 15:46]: > This adds new nodes for the Texas Instruments Enhanced Quadrature > Encoder Pulse (eQEP) module in the PWM subsystem on AM33XX. > > Signed-off-by: David Lechner > --- > arch/arm/boot/dts/am33xx-l4.dtsi | 27 +++ > 1 file changed, 27

Re: nl80211 wlcore regression in next

2019-07-23 Thread Tony Lindgren
* Johannes Berg [190723 05:08]: > Hi, > > > Looks like this one crept back as the fix is missing from v5.3-rc1. > > > > Forgot to include in the pull request? > > More like forgot to send the pull request, my bad. I eventually realized > a couple of days ago and it'll be coming upstream soon.

Re: nl80211 wlcore regression in next

2019-07-22 Thread Tony Lindgren
Hi, * Johannes Berg [190625 08:03]: > On Tue, 2019-06-25 at 01:00 -0700, Tony Lindgren wrote: > > Hi, > > > > * Johannes Berg [190625 07:47]: > > > On Tue, 2019-06-25 at 00:38 -0700, Tony Lindgren wrote: > > > > Hi, > > > > > > >

Re: [PATCH 5/5] bus: ti-sysc: Simplify cleanup upon failures in sysc_probe()

2019-06-27 Thread Tony Lindgren
Hi, * Suman Anna [190625 23:33]: > The clocks are not yet parsed and prepared until after a successful > sysc_get_clocks(), so there is no need to unprepare the clocks upon > any failure of any of the prior functions in sysc_probe(). The current > code path would have been a no-op because of the

Re: [PATCH] ARM: dts: am57xx: Disable voltage switching for SD card

2019-06-27 Thread Tony Lindgren
* Faiz Abbas [190619 03:25]: > If UHS speed modes are enabled, a compatible SD card switches down to > 1.8V during enumeration. If after this a software reboot/crash takes > place and on-chip ROM tries to enumerate the SD card, the difference in > IO voltages (host @ 3.3V and card @ 1.8V) may end

Re: nl80211 wlcore regression in next

2019-06-25 Thread Tony Lindgren
Hi, * Johannes Berg [190625 07:47]: > On Tue, 2019-06-25 at 00:38 -0700, Tony Lindgren wrote: > > Hi, > > > > Looks like at least drivers/net/wireless/ti wlcore driver has stopped > > working in Linux next with commit 901bb9891855 ("nl80211: require and &g

nl80211 wlcore regression in next

2019-06-25 Thread Tony Lindgren
Hi, Looks like at least drivers/net/wireless/ti wlcore driver has stopped working in Linux next with commit 901bb9891855 ("nl80211: require and validate vendor command policy"). Reverting the commit above makes it work again. It fails with the warning below, any ideas what goes wrong? Regards,

Re: [PATCH-next 00/20] gpio: gpio-omap: set of fixes and big clean-up

2019-06-11 Thread Tony Lindgren
ot;. But that one still needs a bit more work and is a separate fix from this series. So for this whole series, please feel free to add: Tested-by: Tony Lindgren > Code can be found at: > g...@git.ti.com:~gragst/ti-linux-kernel/gragsts-ti-linux-kernel.git > branch: > lkml-next-

Re: [PATCH] soc: ti: pm33xx: Add a print while entering RTC only mode with DDR in self-refresh

2019-06-10 Thread Tony Lindgren
* Tony Lindgren [190429 18:43]: > * santosh.shilim...@oracle.com [190429 18:40]: > > On 4/28/19 9:44 PM, Keerthy wrote: > > > Currently there is no way to distinguish if the SoC entered DS0 > > > mode or the RTC only mode. Hence add a print before enter

Re: [PATCH -next] ARM: OMAP2+: Make some variables static

2019-06-10 Thread Tony Lindgren
Hi, * Yue Haibing [190413 07:18]: > From: YueHaibing > > Fix sparse warnings: > > arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c:532:25: warning: > symbol 'am33xx_gpio_hwmod_class' was not declared. Should it be static? >

[PATCH] bus: ti-sysc: Add support for module specific reset quirks

2019-06-10 Thread Tony Lindgren
, i2c and watchdog. Later on we can add more modules like msdi and dss as they get tested. For dra7 pcie, we should be able to just use the rstctrl reset driver when available. Signed-off-by: Tony Lindgren --- This is based on the following series I posted earlier: [PATCHv2 00/13] ti-sysc driver

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-10 Thread Tony Lindgren
Hi, * Kalle Valo [190610 07:01]: > Eugeniu Rosca writes: > > > The wl1837mod datasheet [1] says about the WL_IRQ pin: > > > > ---8<--- > > SDIO available, interrupt out. Active high. [..] > > Set to rising edge (active high) on powerup. > > ---8<--- > > > > That's the reason of seeing the

Re: [PATCH] arm: dts: dra72x: Disable usb4_tm target module

2019-06-10 Thread Tony Lindgren
* Keerthy [190603 23:13]: > usb4_tm is unsed on dra72 and accessing the module > with ti,sysc is causing a boot crash hence disable its target > module. Thanks for testing and fixing this, applying into fixes. Tony

Re: [PATCHv6 0/4] omapdrm: DSI command mode panel support

2019-05-29 Thread Tony Lindgren
* Tomi Valkeinen [190529 07:06]: > On 28/05/2019 13:18, Tony Lindgren wrote: > > > > My board is x15 rev A3, attached to AM5 EVM. I've also attached my kernel > > > config. > > > > Strange that this is not affecting other x15? I think timer12 would

Re: [PATCH 01/12] bus: ti-sysc: Support 16-bit writes too

2019-05-28 Thread Tony Lindgren
* David Laight [190528 11:06]: > From: Tony Lindgren > > Sent: 27 May 2019 13:14 > > We need to also support 16-bit writes for i2c in addition to the reads > > when we start configuring the sysconfig register for reset and idle modes. > > > > Signed-off-by: To

[PATCH 07/13] bus: ti-sysc: Handle swsup idle mode quirks

2019-05-28 Thread Tony Lindgren
. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -872,10 +872,15 @@ static int

[PATCH 01/13] bus: ti-sysc: Add support for missing clockdomain handling

2019-05-28 Thread Tony Lindgren
one patch as there's is still an unlikely chance we may need to apply this as a fix for v5.2 for dropping legacy platform data for some devices. We also do have the option of adding back the platform data if needed in case of trouble. Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/omap_hwmod.c

[PATCH 10/13] bus: ti-sysc: Do rstctrl reset handling in two phases

2019-05-28 Thread Tony Lindgren
atus after reset. Note that depends on a proper PRM rstctrl driver, so far I've only tested this with earlier reset-simple patches. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/bus/t

[PATCH 05/13] bus: ti-sysc: Enable interconnect target module autoidle bit on enable

2019-05-28 Thread Tony Lindgren
For interconnect target modules with autoidle bit wired, we need to manage it for enable and disable. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c

[PATCH 03/13] bus: ti-sysc: Make OCP reset work for sysstatus and sysconfig reset bits

2019-05-28 Thread Tony Lindgren
status in sysstatus or sysconfig register so we can use the new functions for sysc_enable_module() and sysc_disable_module() without "ti,hwmods" property in the following patches. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 72 --- inc

[PATCH 09/13] bus: ti-sysc: Add support for disabling module without legacy mode

2019-05-28 Thread Tony Lindgren
the disable_on_idle flag to reconfigure sysconfig register for PM modes requesting it. Let's also make the other flags use bitfield while at it instead of bool. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git

[PATCH 06/13] bus: ti-sysc: Handle clockactivity for enable and disable

2019-05-28 Thread Tony Lindgren
Modules with clockactivity need it configured during enable. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -845,6 +845,7

[PATCH 11/13] bus: ti-sysc: Detect uarts also on omap34xx

2019-05-28 Thread Tony Lindgren
this change as a fix. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -1205,8 +1205,10 @@ static const struct

[PATCH 04/13] bus: ti-sysc: Allow QUIRK_LEGACY_IDLE even if legacy_mode is not set

2019-05-28 Thread Tony Lindgren
We need to specify QUIRK_LEGACY_IDLE for device drivers that still have pm_runtime_irq_safe() set like 8250. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c

[PATCH 08/13] bus: ti-sysc: Set ENAWAKEUP if available

2019-05-28 Thread Tony Lindgren
Some modules have ENAWAKEUP bit that we need to configure when not relying on platform data callbacks. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b

[PATCH 13/13] ARM: dts: Drop legacy custom hwmods property for omap4 mmc

2019-05-28 Thread Tony Lindgren
-by: Tony Lindgren --- arch/arm/boot/dts/omap4-l4.dtsi | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm/boot/dts/omap4-l4.dtsi b/arch/arm/boot/dts/omap4-l4.dtsi --- a/arch/arm/boot/dts/omap4-l4.dtsi +++ b/arch/arm/boot/dts/omap4-l4.dtsi @@ -2103,7 +2103,6 @@ target-module

[PATCH 12/13] ARM: dts: Drop legacy custom hwmods property for omap4 uart

2019-05-28 Thread Tony Lindgren
With recent ti-sysc driver changes, we can now finally probe most modules without needing the custom ti,hwmods property. Let's start with omap4 uart as we can test that for runtime PM for core retention idle mode. Cc: devicet...@vger.kernel.org Cc: Rob Herring Signed-off-by: Tony Lindgren

[PATCH 02/13] bus: ti-sysc: Support 16-bit writes too

2019-05-28 Thread Tony Lindgren
We need to also support 16-bit writes for i2c in addition to the reads when we start configuring the sysconfig register for reset and idle modes. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus

[PATCHv2 00/13] ti-sysc driver changes to drop custom hwmods property

2019-05-28 Thread Tony Lindgren
properties as they get tested. Regards, Tony Changes since v1: - Repost the series against v5.2-rc1 as the first patch in the series got accidentally left out for patch "bus: ti-sysc: Add support for missing clockdomain handling" Tony Lindgren (13): bus: ti-sysc: Add support f

Re: [PATCH 00/12] ti-sysc driver changes to drop custom hwmods property

2019-05-28 Thread Tony Lindgren
* Keerthy [190528 00:58]: > > > On 27/05/19 5:43 PM, Tony Lindgren wrote: > > Hi all, > > > > Here are changes to improve ti-sysc driver to the point where we can > > finally drop the custom hwmods property for most cases. This series > > drops hwmo

Re: 5.2-rc1 on droid4: spi crash

2019-05-27 Thread Tony Lindgren
* Noralf Trønnes [190527 13:16]: > > > Den 2019-05-27 07:53, skrev Tony Lindgren: > > Hi, > > > > * Sebastian Reichel [190523 09:33]: > > > Hi, > > > > > > On Thu, May 23, 2019 at 11:09:26AM +0200, Pavel Machek wrote: > >

[PATCH 01/12] bus: ti-sysc: Support 16-bit writes too

2019-05-27 Thread Tony Lindgren
We need to also support 16-bit writes for i2c in addition to the reads when we start configuring the sysconfig register for reset and idle modes. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus

[PATCH 08/12] bus: ti-sysc: Add support for disabling module without legacy mode

2019-05-27 Thread Tony Lindgren
the disable_on_idle flag to reconfigure sysconfig register for PM modes requesting it. Let's also make the other flags use bitfield while at it instead of bool. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git

[PATCH 07/12] bus: ti-sysc: Set ENAWAKEUP if available

2019-05-27 Thread Tony Lindgren
Some modules have ENAWAKEUP bit that we need to configure when not relying on platform data callbacks. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b

[PATCH 11/12] ARM: dts: Drop legacy custom hwmods property for omap4 uart

2019-05-27 Thread Tony Lindgren
With recent ti-sysc driver changes, we can now finally probe most modules without needing the custom ti,hwmods property. Let's start with omap4 uart as we can test that for runtime PM for core retention idle mode. Cc: devicet...@vger.kernel.org Cc: Rob Herring Signed-off-by: Tony Lindgren

[PATCH 04/12] bus: ti-sysc: Enable interconnect target module autoidle bit on enable

2019-05-27 Thread Tony Lindgren
For interconnect target modules with autoidle bit wired, we need to manage it for enable and disable. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c

[PATCH 12/12] ARM: dts: Drop legacy custom hwmods property for omap4 mmc

2019-05-27 Thread Tony Lindgren
-by: Tony Lindgren --- arch/arm/boot/dts/omap4-l4.dtsi | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm/boot/dts/omap4-l4.dtsi b/arch/arm/boot/dts/omap4-l4.dtsi --- a/arch/arm/boot/dts/omap4-l4.dtsi +++ b/arch/arm/boot/dts/omap4-l4.dtsi @@ -2103,7 +2103,6 @@ target-module

[PATCH 10/12] bus: ti-sysc: Detect uarts also on omap34xx

2019-05-27 Thread Tony Lindgren
this change as a fix. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -1205,8 +1205,10 @@ static const struct

[PATCH 03/12] bus: ti-sysc: Allow QUIRK_LEGACY_IDLE even if legacy_mode is not set

2019-05-27 Thread Tony Lindgren
We need to specify QUIRK_LEGACY_IDLE for device drivers that still have pm_runtime_irq_safe() set like 8250. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c

[PATCH 06/12] bus: ti-sysc: Handle swsup idle mode quirks

2019-05-27 Thread Tony Lindgren
. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -872,10 +872,15 @@ static int

[PATCH 02/12] bus: ti-sysc: Make OCP reset work for sysstatus and sysconfig reset bits

2019-05-27 Thread Tony Lindgren
status in sysstatus or sysconfig register so we can use the new functions for sysc_enable_module() and sysc_disable_module() without "ti,hwmods" property in the following patches. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 72 --- inc

[PATCH 09/12] bus: ti-sysc: Do rstctrl reset handling in two phases

2019-05-27 Thread Tony Lindgren
atus after reset. Note that depends on a proper PRM rstctrl driver, so far I've only tested this with earlier reset-simple patches. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/bus/t

[PATCH 05/12] bus: ti-sysc: Handle clockactivity for enable and disable

2019-05-27 Thread Tony Lindgren
Modules with clockactivity need it configured during enable. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -845,6 +845,7

[PATCH 00/12] ti-sysc driver changes to drop custom hwmods property

2019-05-27 Thread Tony Lindgren
properties as they get tested. Regards, Tony Tony Lindgren (12): bus: ti-sysc: Support 16-bit writes too bus: ti-sysc: Make OCP reset work for sysstatus and sysconfig reset bits bus: ti-sysc: Allow QUIRK_LEGACY_IDLE even if legacy_mode is not set bus: ti-sysc: Enable interconnect target

Re: [Qemu-devel] Running linux on qemu omap

2019-05-27 Thread Tony Lindgren
Hi, * Philippe Mathieu-Daudé [190523 12:01]: > What I use as reference for testing ARM boards [*] is the work of > Guenter Roeck: > https://github.com/groeck/linux-build-test/blob/master/rootfs/arm/run-qemu-arm.sh I think Guenter also has v2.3.50-local-linaro branch in his github repo that has

Re: 5.2-rc1 on droid4: spi crash

2019-05-26 Thread Tony Lindgren
Hi, * Sebastian Reichel [190523 09:33]: > Hi, > > On Thu, May 23, 2019 at 11:09:26AM +0200, Pavel Machek wrote: > > This was greeting me overnight... I don't yet know how reproducible it > > is, it happened once so far. > > Please pipe the stacktrace into ./scripts/decode_stacktrace.sh > to

Re: [PATCH] arm64: arch_k3: Fix kconfig dependency warning

2019-05-10 Thread Tony Lindgren
* Marc Zyngier [190510 18:30]: > On Fri, 10 May 2019 06:16:38 +0100, > Lokesh Vutla wrote: > > > > > > > > On 10/05/19 9:22 AM, YueHaibing wrote: > > > Fix Kbuild warning when SOC_TI is not set > > > > > > WARNING: unmet direct dependencies detected for TI_SCI_INTA_IRQCHIP > > > Depends on

<    2   3   4   5   6   7   8   9   10   11   >