[PATCH] media: media-request: Fix crash if memory allocation fails

ted-by: syzbot+6bed2d543cf7e48b8...@syzkaller.appspotmail.com Cc: sta...@vger.kernel.org Signed-off-by: Tuomas Tynkkynen --- drivers/media/mc/mc-request.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/media/mc/mc-request.c b/drivers/media

[PATCH] usbnet: smsc95xx: Fix use-after-free after removal

in use by the concurrently running workqueue callback. Thus switch to using cancel_delayed_work_sync() to ensure the work callback really is no longer active. Reported-by: syzbot+29dc7d4ae19b703ff...@syzkaller.appspotmail.com Signed-off-by: Tuomas Tynkkynen --- Compile tested only. --- drivers/net

[PATCH 2/7] staging: vc04_services: Drop 'connection' field from SERVICE_CREATION_T

The connection field of SERVICE_CREATION_T is assigned to but its value is never read. Drop the field and the resulting no longer needed code from bcm2835-audio and bcm2835-camera. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 --- drivers

[PATCH 2/7] staging: vc04_services: Drop 'connection' field from SERVICE_CREATION_T

The connection field of SERVICE_CREATION_T is assigned to but its value is never read. Drop the field and the resulting no longer needed code from bcm2835-audio and bcm2835-camera. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 --- drivers

[PATCH 7/7] staging: vc04_services: Drop no longer needed headers

Previously, connection.h was only required for the definition of VCHI_CONNECTION_T, but now all usages of it are gone. Remove this unused header. After connection.h is gone, message.h and vchi_cfg_internal.h are no longer referenced by anything either. Drop them as well. Signed-off-by: Tuomas

[PATCH 5/7] staging: vc04_services: Drop VCHI_SERVICE_INIT and SERVICE_INFO_T

These types are not used anywhere, remove them. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/interface/vchi/vchi.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi

[PATCH 7/7] staging: vc04_services: Drop no longer needed headers

Previously, connection.h was only required for the definition of VCHI_CONNECTION_T, but now all usages of it are gone. Remove this unused header. After connection.h is gone, message.h and vchi_cfg_internal.h are no longer referenced by anything either. Drop them as well. Signed-off-by: Tuomas

[PATCH 5/7] staging: vc04_services: Drop VCHI_SERVICE_INIT and SERVICE_INFO_T

These types are not used anywhere, remove them. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/interface/vchi/vchi.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi

[PATCH 3/7] staging: vc04_services: Drop trivially unused fields from SERVICE_CREATION_T

These fields are only initialized with constants and never read. Drop them. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 - .../staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 5 - drivers/staging/vc04_services/interface/vchi/vchi.h

[PATCH 0/7] staging: vc04_services: Some dead code removal

. Tuomas Tynkkynen (7): staging: vc04_services: Drop pointless stub functions staging: vc04_services: Drop 'connection' field from SERVICE_CREATION_T staging: vc04_services: Drop trivially unused fields from SERVICE_CREATION_T staging: vc04_services: Drop declaration of vchi_crc_control

[PATCH 1/7] staging: vc04_services: Drop pointless stub functions

These functions do nothing besides returning NULL and are unused. Just drop them. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/interface/vchi/vchi.h | 11 .../interface/vchiq_arm/vchiq_shim.c | 27 --- 2 files changed, 38 deletions(-) diff --git

[PATCH 0/7] staging: vc04_services: Some dead code removal

. Tuomas Tynkkynen (7): staging: vc04_services: Drop pointless stub functions staging: vc04_services: Drop 'connection' field from SERVICE_CREATION_T staging: vc04_services: Drop trivially unused fields from SERVICE_CREATION_T staging: vc04_services: Drop declaration of vchi_crc_control

[PATCH 1/7] staging: vc04_services: Drop pointless stub functions

These functions do nothing besides returning NULL and are unused. Just drop them. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/interface/vchi/vchi.h | 11 .../interface/vchiq_arm/vchiq_shim.c | 27 --- 2 files changed, 38 deletions(-) diff --git

[PATCH 3/7] staging: vc04_services: Drop trivially unused fields from SERVICE_CREATION_T

These fields are only initialized with constants and never read. Drop them. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 - .../staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 5 - drivers/staging/vc04_services/interface/vchi/vchi.h

[PATCH 4/7] staging: vc04_services: Drop declaration of vchi_crc_control()

There is no definition for this unused function, so drop its prototype. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/interface/vchi/vchi.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging

[PATCH 6/7] staging: vc04_services: Drop unused parameters from vchi_connect()

Remove two parameters which are never used and all where all callers just pass in dummy values anyway. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +- .../staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +- drivers/staging/vc04_services

[PATCH 4/7] staging: vc04_services: Drop declaration of vchi_crc_control()

There is no definition for this unused function, so drop its prototype. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/interface/vchi/vchi.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging

[PATCH 6/7] staging: vc04_services: Drop unused parameters from vchi_connect()

Remove two parameters which are never used and all where all callers just pass in dummy values anyway. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +- .../staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +- drivers/staging/vc04_services

[PATCH] staging: vc04_services: Remove unused vchiq_genversion script

As far as I can tell, this has never been used. Signed-off-by: Tuomas Tynkkynen --- .../interface/vchiq_arm/vchiq_genversion | 88 -- 1 file changed, 88 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_genversion diff --git

[PATCH] staging: vc04_services: Remove unused vchiq_genversion script

As far as I can tell, this has never been used. Signed-off-by: Tuomas Tynkkynen --- .../interface/vchiq_arm/vchiq_genversion | 88 -- 1 file changed, 88 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_genversion diff --git

[PATCH v2] ARM: dts: imx6qdl-wandboard: Add stdout-path

Setting a stdout-path in the .dtb is convenient because then the user gets a serial console on the RS-232 connector without any extra effort of figuring out the relevant 'console=' boot parameter. Reviewed-by: Fabio Estevam Signed-off-by: Tuomas Tynkkynen --- v2: Make subject line consistent

[PATCH v2] ARM: dts: imx6qdl-wandboard: Add stdout-path

Setting a stdout-path in the .dtb is convenient because then the user gets a serial console on the RS-232 connector without any extra effort of figuring out the relevant 'console=' boot parameter. Reviewed-by: Fabio Estevam Signed-off-by: Tuomas Tynkkynen --- v2: Make subject line consistent

[PATCH] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3

Setting GPIO 21 high seems to be required to enable power to USB ports on the WNDR3400v3. As there is already similar code for WNR3500L, make the existing USB power GPIO code generic and use that. Signed-off-by: Tuomas Tynkkynen --- arch/mips/bcm47xx/workarounds.c | 8 +--- 1 file changed

[PATCH] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3

Setting GPIO 21 high seems to be required to enable power to USB ports on the WNDR3400v3. As there is already similar code for WNR3500L, make the existing USB power GPIO code generic and use that. Signed-off-by: Tuomas Tynkkynen --- arch/mips/bcm47xx/workarounds.c | 8 +--- 1 file changed

Re: AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"

Hi, On 08/16/2018 08:57 PM, John Stultz wrote: On Thu, Aug 16, 2018 at 3:22 AM, Will Deacon wrote: Hi Tuomas, [+John] ... Out of interest -- do you know if Hikey960 is used by any boot-testing farms? The patch above has been in linux-next for ages, but we didn't see any complaints until it

Re: AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"

Hi, On 08/16/2018 08:57 PM, John Stultz wrote: On Thu, Aug 16, 2018 at 3:22 AM, Will Deacon wrote: Hi Tuomas, [+John] ... Out of interest -- do you know if Hikey960 is used by any boot-testing farms? The patch above has been in linux-next for ages, but we didn't see any complaints until it

Re: AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"

Hi, On 08/16/2018 01:22 PM, Will Deacon wrote: Hi Tuomas, [+John] On Thu, Aug 16, 2018 at 02:38:51AM +0300, Tuomas Tynkkynen wrote: Booting Linus's master of today with the usual arm64 defconfig fails for me on the Hikey960 board. I've bisected it down to: commit

Re: AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"

Hi, On 08/16/2018 01:22 PM, Will Deacon wrote: Hi Tuomas, [+John] On Thu, Aug 16, 2018 at 02:38:51AM +0300, Tuomas Tynkkynen wrote: Booting Linus's master of today with the usual arm64 defconfig fails for me on the Hikey960 board. I've bisected it down to: commit

AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"

Hello, Booting Linus's master of today with the usual arm64 defconfig fails for me on the Hikey960 board. I've bisected it down to: commit 693350a7998018391852c48f68956cf0f855b2b9 (HEAD, refs/bisect/bad) Author: Will Deacon Date: Tue Jun 19 17:55:28 2018 +0100 arm64: insn: Don't

AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"

Hello, Booting Linus's master of today with the usual arm64 defconfig fails for me on the Hikey960 board. I've bisected it down to: commit 693350a7998018391852c48f68956cf0f855b2b9 (HEAD, refs/bisect/bad) Author: Will Deacon Date: Tue Jun 19 17:55:28 2018 +0100 arm64: insn: Don't

[PATCH] ARM: dts: imx6: Add stdout-path to Wandboard

Setting a stdout-path in the .dtb is convenient because then the user gets a serial console on the RS-232 connector without any extra effort of figuring out the relevant 'console=' boot parameter. Signed-off-by: Tuomas Tynkkynen --- Tested on a Wandboard Quad with mainline U-Boot 2018.05

[PATCH] ARM: dts: imx6: Add stdout-path to Wandboard

Setting a stdout-path in the .dtb is convenient because then the user gets a serial console on the RS-232 connector without any extra effort of figuring out the relevant 'console=' boot parameter. Signed-off-by: Tuomas Tynkkynen --- Tested on a Wandboard Quad with mainline U-Boot 2018.05

[PATCH 1/2] ARM: dts: sunxi: Don't use cd-inverted in sun8i-r40-bananapi-m2-ultra

Another user of cd-inverted seems to have crept in. Switch it away from cd-inverted to be consistent with other sunxi boards. Signed-off-by: Tuomas Tynkkynen --- arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot

[PATCH 1/2] ARM: dts: sunxi: Don't use cd-inverted in sun8i-r40-bananapi-m2-ultra

Another user of cd-inverted seems to have crept in. Switch it away from cd-inverted to be consistent with other sunxi boards. Signed-off-by: Tuomas Tynkkynen --- arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot

[PATCH 2/2] arm64: dts: sunxi: Don't use cd-inverted in sun50i-a64-pinebook

Another user of cd-inverted seems to have crept in. Switch it away from cd-inverted to be consistent with other sunxi boards. Signed-off-by: Tuomas Tynkkynen --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch

[PATCH 2/2] arm64: dts: sunxi: Don't use cd-inverted in sun50i-a64-pinebook

Another user of cd-inverted seems to have crept in. Switch it away from cd-inverted to be consistent with other sunxi boards. Signed-off-by: Tuomas Tynkkynen --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch

[PATCH 2/2] staging: bcm2835-audio: Don't leak workqueue if open fails

Currently, if bcm2835_audio_open() fails partway, the allocated workqueue is leaked. Avoid that. While at it, propagate the return value of bcm2835_audio_open_connection() on failure instead of returning -1. Signed-off-by: Tuomas Tynkkynen --- .../staging/vc04_services/bcm2835-audio/bcm2835

[PATCH 1/2] staging: bcm2835-audio: Check if workqueue allocation failed

rid of the rather pointless one-line function my_workqueue_init(). Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c| 111 ++--- 1 file changed, 50 insertions(+), 61 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835

[PATCH 2/2] staging: bcm2835-audio: Don't leak workqueue if open fails

Currently, if bcm2835_audio_open() fails partway, the allocated workqueue is leaked. Avoid that. While at it, propagate the return value of bcm2835_audio_open_connection() on failure instead of returning -1. Signed-off-by: Tuomas Tynkkynen --- .../staging/vc04_services/bcm2835-audio/bcm2835

[PATCH 1/2] staging: bcm2835-audio: Check if workqueue allocation failed

rid of the rather pointless one-line function my_workqueue_init(). Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c| 111 ++--- 1 file changed, 50 insertions(+), 61 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835

[PATCH] ARM: dts: sunxi: Change sun7i-a20-olimex-som204-evb to not use cd-inverted

d-inverted. Switch it away from using cd-inverted to be consistent with rest of the sunxi boards. Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- arch/arm/boot/dts/sun7i-a20-olimex-som204-evb.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/

[PATCH] ARM: dts: sunxi: Change sun7i-a20-olimex-som204-evb to not use cd-inverted

d-inverted. Switch it away from using cd-inverted to be consistent with rest of the sunxi boards. Signed-off-by: Tuomas Tynkkynen --- arch/arm/boot/dts/sun7i-a20-olimex-som204-evb.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som204-

[PATCH] ARM: multi_v7_defconfig: Enable serial console on RPi 3

The Raspberry Pi 3 uses the 8250-based auxilary UART of the BCM2837 SoC as the primary serial console of the board, so enable it in the multiplatform defconfig. Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- arch/arm/configs/multi_v7_defconfig | 3 +++ 1 file changed, 3 inse

[PATCH] ARM: multi_v7_defconfig: Enable serial console on RPi 3

The Raspberry Pi 3 uses the 8250-based auxilary UART of the BCM2837 SoC as the primary serial console of the board, so enable it in the multiplatform defconfig. Signed-off-by: Tuomas Tynkkynen --- arch/arm/configs/multi_v7_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch

Re: [PATCH 1/2] ARM: dts: sunxi: Switch MMC nodes away from cd-inverted property

Hi Maxime, On Thu, 2018-01-04 at 16:03 +0100, Maxime Ripard wrote: > On Fri, Dec 22, 2017 at 10:57:37PM +0200, Tuomas Tynkkynen wrote: > > Using the cd-inverted property is not useful when GPIOs are used as > > card > > detects since the polarity can be specified with the u

Re: [PATCH 1/2] ARM: dts: sunxi: Switch MMC nodes away from cd-inverted property

Hi Maxime, On Thu, 2018-01-04 at 16:03 +0100, Maxime Ripard wrote: > On Fri, Dec 22, 2017 at 10:57:37PM +0200, Tuomas Tynkkynen wrote: > > Using the cd-inverted property is not useful when GPIOs are used as > > card > > detects since the polarity can be specified with the u

[PATCH] mmc: Don't reference Linux-specific OF_GPIO_ACTIVE_LOW flag in DT binding

OF_GPIO_ACTIVE_LOW is a Linux implementation detail. The binding document should be referring to GPIO_ACTIVE_LOW found in include/dt-bindings/gpio/gpio.h. Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- Documentation/devicetree/bindings/mmc/mmc.txt | 4 ++-- 1 file changed, 2 inse

[PATCH] mmc: Don't reference Linux-specific OF_GPIO_ACTIVE_LOW flag in DT binding

OF_GPIO_ACTIVE_LOW is a Linux implementation detail. The binding document should be referring to GPIO_ACTIVE_LOW found in include/dt-bindings/gpio/gpio.h. Signed-off-by: Tuomas Tynkkynen --- Documentation/devicetree/bindings/mmc/mmc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 1/2] ARM: dts: sunxi: Switch MMC nodes away from cd-inverted property

Using the cd-inverted property is not useful when GPIOs are used as card detects since the polarity can be specified with the usual GPIO_ACTIVE_(HIGH|LOW) GPIO flags. It has also caused confusion for U-Boot developers, so migrate all sunxi boards away from cd-inverted. Signed-off-by: Tuomas

[PATCH 1/2] ARM: dts: sunxi: Switch MMC nodes away from cd-inverted property

Using the cd-inverted property is not useful when GPIOs are used as card detects since the polarity can be specified with the usual GPIO_ACTIVE_(HIGH|LOW) GPIO flags. It has also caused confusion for U-Boot developers, so migrate all sunxi boards away from cd-inverted. Signed-off-by: Tuomas

[PATCH 2/2] arm64: dts: sunxi: Switch MMC nodes away from cd-inverted property

Using the cd-inverted property is not useful when GPIOs are used as card detects since the polarity can be specified with the usual GPIO_ACTIVE_(HIGH|LOW) GPIO flags. It has also caused confusion for U-Boot developers, so migrate all sunxi boards away from cd-inverted. Signed-off-by: Tuomas

[PATCH 2/2] arm64: dts: sunxi: Switch MMC nodes away from cd-inverted property

Using the cd-inverted property is not useful when GPIOs are used as card detects since the polarity can be specified with the usual GPIO_ACTIVE_(HIGH|LOW) GPIO flags. It has also caused confusion for U-Boot developers, so migrate all sunxi boards away from cd-inverted. Signed-off-by: Tuomas

[PATCH] ARM: dts: sun7i: Enable HDMI on pcDuino3 Nano

The board has a regular-sized HDMI connector, so enable the display the pipeline and HDMI output for it. Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 25 + 1 file changed, 25 insertions(+) diff --git a/ar

[PATCH] ARM: dts: sun7i: Enable HDMI on pcDuino3 Nano

The board has a regular-sized HDMI connector, so enable the display the pipeline and HDMI output for it. Signed-off-by: Tuomas Tynkkynen --- arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20

[PATCH] 9p: Fix missing commas in mount options

org # 4.13+ Fixes: c4fac9100456 ("9p: Implement show_options") Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- net/9p/client.c | 2 +- net/9p/trans_fd.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/9p/client.c b/net/9p/client.c index

[PATCH] 9p: Fix missing commas in mount options

org # 4.13+ Fixes: c4fac9100456 ("9p: Implement show_options") Signed-off-by: Tuomas Tynkkynen --- net/9p/client.c | 2 +- net/9p/trans_fd.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/9p/client.c b/net/9p/client.c index 4674235b0d9b..b2583ee2fbe9

Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

Hi Al, On Fri, 2017-10-20 at 21:11 +0100, Al Viro wrote: > On Tue, Sep 26, 2017 at 04:10:14PM +0300, Tuomas Tynkkynen wrote: > > Hi Al, > > > > On Wed, 2017-09-06 at 17:59 +0300, Tuomas Tynkkynen wrote: > > > These two patches fix two hard-to-hit (but really an

Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

Hi Al, On Fri, 2017-10-20 at 21:11 +0100, Al Viro wrote: > On Tue, Sep 26, 2017 at 04:10:14PM +0300, Tuomas Tynkkynen wrote: > > Hi Al, > > > > On Wed, 2017-09-06 at 17:59 +0300, Tuomas Tynkkynen wrote: > > > These two patches fix two hard-to-hit (but really an

Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

Al, Linus Can one of you please pick these patches? They've been on the list for a month now, with an ack from Latchesar Ionkov. Thanks! Tuomas On Wed, 2017-09-06 at 17:59 +0300, Tuomas Tynkkynen wrote: > These two patches fix two hard-to-hit (but really annoying) bugs in > 9p. > The

Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

Al, Linus Can one of you please pick these patches? They've been on the list for a month now, with an ack from Latchesar Ionkov. Thanks! Tuomas On Wed, 2017-09-06 at 17:59 +0300, Tuomas Tynkkynen wrote: > These two patches fix two hard-to-hit (but really annoying) bugs in > 9p. > The

Changing the ARM variant reported by 'uname -m'

Hi, For our distro (NixOS), I've experimented with building packages for ARMv6 on ARMv7 hardware. This has generally worked fine, except that some build scripts (in coreutils, for example) notice that `uname -m` returns 'armv7l' and thus decide to e.g. add some ARMv7-specific gcc flags,

Changing the ARM variant reported by 'uname -m'

Hi, For our distro (NixOS), I've experimented with building packages for ARMv6 on ARMv7 hardware. This has generally worked fine, except that some build scripts (in coreutils, for example) notice that `uname -m` returns 'armv7l' and thus decide to e.g. add some ARMv7-specific gcc flags,

[PATCH] arm64: defconfig: Enable Tegra PCI controller

The driver has supported the 64-bit Tegra210 for a while now, so enable it in the defconfig. Signed-off-by: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi> --- I didn't personally test this but got a report from our distro users that it works. arch/arm64/configs/defconfig | 1 + 1 file chan

[PATCH] arm64: defconfig: Enable Tegra PCI controller

The driver has supported the 64-bit Tegra210 for a while now, so enable it in the defconfig. Signed-off-by: Tuomas Tynkkynen --- I didn't personally test this but got a report from our distro users that it works. arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

Hi Al, On Wed, 2017-09-06 at 17:59 +0300, Tuomas Tynkkynen wrote: > These two patches fix two hard-to-hit (but really annoying) bugs in > 9p. > The first one was posted earlier in February (with one R-b), the > second > is a new one. > > Both of these have had soaking

Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

Hi Al, On Wed, 2017-09-06 at 17:59 +0300, Tuomas Tynkkynen wrote: > These two patches fix two hard-to-hit (but really annoying) bugs in > 9p. > The first one was posted earlier in February (with one R-b), the > second > is a new one. > > Both of these have had soaking

[PATCH 0/2] 9p: Fixes for hard-to-hit bugs

These two patches fix two hard-to-hit (but really annoying) bugs in 9p. The first one was posted earlier in February (with one R-b), the second is a new one. Both of these have had soaking in NixOS distribution kernels for a couple of months with no ill effects. Tuomas Tynkkynen (2): fs/9p

[PATCH 0/2] 9p: Fixes for hard-to-hit bugs

These two patches fix two hard-to-hit (but really annoying) bugs in 9p. The first one was posted earlier in February (with one R-b), the second is a new one. Both of these have had soaking in NixOS distribution kernels for a couple of months with no ill effects. Tuomas Tynkkynen (2): fs/9p

[PATCH 1/2] fs/9p: Compare qid.path in v9fs_test_inode

u...@ionkov.net> Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- fs/9p/vfs_inode.c | 3 +++ fs/9p/vfs_inode_dotl.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index 2a5de610dd8f..bdabb2765d1b 100644 --- a/fs/9p/vfs_inode.c +

[PATCH 1/2] fs/9p: Compare qid.path in v9fs_test_inode

he can now accidentally locate a completely wrong inode from the same inode hash bucket if the other fields (qid.type and qid.version) match. Fixes: fd2421f54423 ("fs/9p: When doing inode lookup compare qid details and inode mode bits.") Cc: sta...@vger.kernel.org Reviewed-by: Latchesar Ionkov S

[PATCH 2/2] net/9p: Switch to wait_event_killable()

(). In practice, hitting the problem is rare and needs a really slow/bogged down 9p server. Cc: sta...@vger.kernel.org Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- net/9p/client.c | 3 +-- net/9p/trans_virtio.c | 13 ++--- net/9p/trans_xen.c| 4 ++-- 3 files chan

[PATCH 2/2] net/9p: Switch to wait_event_killable()

(). In practice, hitting the problem is rare and needs a really slow/bogged down 9p server. Cc: sta...@vger.kernel.org Signed-off-by: Tuomas Tynkkynen --- net/9p/client.c | 3 +-- net/9p/trans_virtio.c | 13 ++--- net/9p/trans_xen.c| 4 ++-- 3 files changed, 9 insertions(+), 11

[PATCH] soc/tegra: Fix bad of_node_put() in powergate init

ented" but then only at the very end of the docstring the crucial part "Decrements the refcount of prev" is mentioned.) Fixes: a38045121bf42 ("soc/tegra: pmc: Add generic PM domain support") Signed-off-by: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi> --- Compile tested only

[PATCH] soc/tegra: Fix bad of_node_put() in powergate init

ented" but then only at the very end of the docstring the crucial part "Decrements the refcount of prev" is mentioned.) Fixes: a38045121bf42 ("soc/tegra: pmc: Add generic PM domain support") Signed-off-by: Tuomas Tynkkynen --- Compile tested only (backtrace received via a distro

9p and EINTR?

Hi fsdevel, Some users of our distro (NixOS) ran into some 9p funkiness again... Eventually it was traced down to many 9p filesystem calls getting interrupted by signals (here, it was bash receiving SIGCHLDs from background jobs exiting) and returning with -EINTR. E.g. stat() manpage doesn't list

9p and EINTR?

Hi fsdevel, Some users of our distro (NixOS) ran into some 9p funkiness again... Eventually it was traced down to many 9p filesystem calls getting interrupted by signals (here, it was bash receiving SIGCHLDs from background jobs exiting) and returning with -EINTR. E.g. stat() manpage doesn't list

Re: [PATCH] fs/9p: Compare qid.path in v9fs_test_inode

On Wed, 22 Feb 2017 02:06:29 +0200 Tuomas Tynkkynen <tuo...@tuxera.com> wrote: > Commit fd2421f54423 ("fs/9p: When doing inode lookup compare qid details > and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked() > instead of iget_locked(). How

Re: [PATCH] fs/9p: Compare qid.path in v9fs_test_inode

On Wed, 22 Feb 2017 02:06:29 +0200 Tuomas Tynkkynen wrote: > Commit fd2421f54423 ("fs/9p: When doing inode lookup compare qid details > and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked() > instead of iget_locked(). However, the test() callback is not

[PATCH] fs/9p: Compare qid.path in v9fs_test_inode

he can now accidentally locate a completely wrong inode from the same inode hash bucket if the other fields (qid.type and qid.version) match. Fixes: fd2421f54423 ("fs/9p: When doing inode lookup compare qid details and inode mode bits.") Cc: sta...@vger.kernel.org Signed-off-by: Tuomas Tynkkyne

[PATCH] fs/9p: Compare qid.path in v9fs_test_inode

he can now accidentally locate a completely wrong inode from the same inode hash bucket if the other fields (qid.type and qid.version) match. Fixes: fd2421f54423 ("fs/9p: When doing inode lookup compare qid details and inode mode bits.") Cc: sta...@vger.kernel.org Signed-off-by: Tuomas Tynkkynen

Re: [V9fs-developer] 9pfs hangs since 4.7

On Sat, 7 Jan 2017 17:19:10 + Al Viro wrote: > On Sat, Jan 07, 2017 at 04:10:45PM +0100, Greg Kurz wrote: > > > virtqueue_push(), but pdu freeing is delayed until v9fs_flush() gets woken > > > up. In the meanwhile, another request arrives into the slot of freed by >

Re: [V9fs-developer] 9pfs hangs since 4.7

On Sat, 7 Jan 2017 17:19:10 + Al Viro wrote: > On Sat, Jan 07, 2017 at 04:10:45PM +0100, Greg Kurz wrote: > > > virtqueue_push(), but pdu freeing is delayed until v9fs_flush() gets woken > > > up. In the meanwhile, another request arrives into the slot of freed by > > > that

Re: 9pfs hangs since 4.7

On Wed, 4 Jan 2017 01:47:53 + Al Viro <v...@zeniv.linux.org.uk> wrote: > On Wed, Jan 04, 2017 at 01:34:50AM +0200, Tuomas Tynkkynen wrote: > > > I got these logs from the server & client with 9p tracepoints enabled: > > > > https:/

Re: 9pfs hangs since 4.7

On Wed, 4 Jan 2017 01:47:53 + Al Viro wrote: > On Wed, Jan 04, 2017 at 01:34:50AM +0200, Tuomas Tynkkynen wrote: > > > I got these logs from the server & client with 9p tracepoints enabled: > > > > https://gist.githubusercontent.com/dezgeg/02447100

Re: 9pfs hangs since 4.7

On Mon, 2 Jan 2017 16:23:09 + Al Viro wrote: > > What I'd like to see is a log of 9p traffic in those; to hell with the > payloads, just the type and tag of from each message [...] Thanks for the suggestions. With the following patch to QEMU: diff --git

Re: 9pfs hangs since 4.7

On Mon, 2 Jan 2017 16:23:09 + Al Viro wrote: > > What I'd like to see is a log of 9p traffic in those; to hell with the > payloads, just the type and tag of from each message [...] Thanks for the suggestions. With the following patch to QEMU: diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c

Re: 9pfs hangs since 4.7

handling update from Al Viro. Al, do you have any ideas about this problem with 9pfs I've been observing (quoted below in full)? Many thanks in advance! On Thu, 24 Nov 2016 21:50:23 +0200 Tuomas Tynkkynen <tuo...@tuxera.com> wrote: > Hi fsdevel, > > I have been observing hangs when r

Re: 9pfs hangs since 4.7

handling update from Al Viro. Al, do you have any ideas about this problem with 9pfs I've been observing (quoted below in full)? Many thanks in advance! On Thu, 24 Nov 2016 21:50:23 +0200 Tuomas Tynkkynen wrote: > Hi fsdevel, > > I have been observing hangs when running xfstests ge

Re: 9pfs hangs since 4.7

On Tue, 29 Nov 2016 10:39:39 -0600 Eric Van Hensbergen wrote: > Any idea of what xfstests is doing at this point in time? I'd be a > bit worried about some sort of loop in the namespace since it seems to > be in path traversal. Could also be some sort of resource leak or >

Re: 9pfs hangs since 4.7

On Tue, 29 Nov 2016 10:39:39 -0600 Eric Van Hensbergen wrote: > Any idea of what xfstests is doing at this point in time? I'd be a > bit worried about some sort of loop in the namespace since it seems to > be in path traversal. Could also be some sort of resource leak or > fragmentation, I'll

9pfs hangs since 4.7

Hi fsdevel, I have been observing hangs when running xfstests generic/224. Curiously enough, the test is *not* causing problems on the FS under test (I've tried both ext4 and f2fs) but instead it's causing the 9pfs that I'm using as the root filesystem to crap out. How it shows up is that the

9pfs hangs since 4.7

Hi fsdevel, I have been observing hangs when running xfstests generic/224. Curiously enough, the test is *not* causing problems on the FS under test (I've tried both ext4 and f2fs) but instead it's causing the 9pfs that I'm using as the root filesystem to crap out. How it shows up is that the

[PATCH RESEND 2/2] ARM: multi_v7_defconfig: Enable ARM_IMX6Q_CPUFREQ

The Wandboard Quad can make use of the cpufreq support provided by the driver. Enable it and its dependency, REGULATOR_ANATOP, by default. Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- Resent for the i.MX maintainers to apply. arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file c

[PATCH RESEND 1/2] ARM: multi_v7_defconfig: Enable AHCI_IMX

The Wandboard Quad comes with a SATA port. Enable the IMX SATA driver by default to make it easy to have the root filesystem on it. Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- Resent for the i.MX maintainers to apply. arch/arm/configs/multi_v7_defconfig | 1 + 1 file chan

[PATCH RESEND 2/2] ARM: multi_v7_defconfig: Enable ARM_IMX6Q_CPUFREQ

The Wandboard Quad can make use of the cpufreq support provided by the driver. Enable it and its dependency, REGULATOR_ANATOP, by default. Signed-off-by: Tuomas Tynkkynen --- Resent for the i.MX maintainers to apply. arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions

[PATCH RESEND 1/2] ARM: multi_v7_defconfig: Enable AHCI_IMX

The Wandboard Quad comes with a SATA port. Enable the IMX SATA driver by default to make it easy to have the root filesystem on it. Signed-off-by: Tuomas Tynkkynen --- Resent for the i.MX maintainers to apply. arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 2/2] ARM: multi_v7_defconfig: Enable ARM_IMX6Q_CPUFREQ

The Wandboard Quad can make use of the cpufreq support provided by the driver. Enable it and its dependency, REGULATOR_ANATOP, by default. Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ar

[PATCH 2/2] ARM: multi_v7_defconfig: Enable ARM_IMX6Q_CPUFREQ

The Wandboard Quad can make use of the cpufreq support provided by the driver. Enable it and its dependency, REGULATOR_ANATOP, by default. Signed-off-by: Tuomas Tynkkynen --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs

[PATCH 1/2] ARM: multi_v7_defconfig: Enable AHCI_IMX

The Wandboard Quad comes with a SATA port. Enable the IMX SATA driver by default to make it easy to have the root filesystem on it. Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/c

[PATCH 1/2] ARM: multi_v7_defconfig: Enable AHCI_IMX

The Wandboard Quad comes with a SATA port. Enable the IMX SATA driver by default to make it easy to have the root filesystem on it. Signed-off-by: Tuomas Tynkkynen --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b

  1   2   3   4   5   >