Re: [PATCH] phy: samsung: Fix build break in USB2 PHY driver for Exynos5420 SoCs

2020-12-01 Thread Vinod Koul
On 01-12-20, 18:09, Marek Szyprowski wrote: > Exynos5420 variant of USB2 PHY is handled by the same code as the > Exynos5250 one. Introducing a separate Kconfig symbol for it was an > over-engineering, which turned out to cause build break for certain > configurations: > > ERROR: modpost: "exynos5

Re: [PATCH v3 0/2] phy: ralink: phy-mt7621-pci: some fixes for COMPILE_TEST

2020-12-01 Thread Vinod Koul
On 01-12-20, 12:20, Sergio Paracuellos wrote: > Hi Vinod, > > After merging the phy-next tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such > file or directory > 17 | #include > | ^

Re: [PATCH 1/3] phy: ralink: phy-mt7621-pci: add include search path in Makefile

2020-12-01 Thread Vinod Koul
On 01-12-20, 11:47, Sergio Paracuellos wrote: > Hi Vinod, > > On Tue, Dec 1, 2020 at 11:42 AM Vinod Koul wrote: > > > > On 01-12-20, 11:16, Sergio Paracuellos wrote: > > > This driver includes the following two files directly: > > > - mt7621.h > >

Re: [PATCH 1/3] phy: ralink: phy-mt7621-pci: add include search path in Makefile

2020-12-01 Thread Vinod Koul
On 01-12-20, 11:16, Sergio Paracuellos wrote: > This driver includes the following two files directly: > - mt7621.h > - ralink_regs.h > > Compilation for its related platform properly works because > its real path is included in 'arch/mips/ralink/Platform' as > cflags. > > This driver depends on

Re: linux-next: build failure after merge of the phy-next tree

2020-12-01 Thread Vinod Koul
On 01-12-20, 07:45, Sergio Paracuellos wrote: > Hi Stephen, > > On Tue, Dec 1, 2020 at 7:07 AM Stephen Rothwell wrote: > > > > Hi all, > > > > After merging the phy-next tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/phy/ralink/phy-mt7621-pci.c:17:10: f

[PATCH] dt-bindings: qcom,pdc: Add compatible for SM8250

2020-11-30 Thread Vinod Koul
Add the compatible string for SM8250 SoC from Qualcomm. This compatible is used already in DTS files but not documented yet Signed-off-by: Vinod Koul --- .../devicetree/bindings/interrupt-controller/qcom,pdc.txt| 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v2 2/2] arm64: dts: qcom: db845c: Enable gpi_dma0 node

2020-11-30 Thread Vinod Koul
gpi_dma0 can be used for spi and i2c transfers on db845c, so enable it Signed-off-by: Vinod Koul --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index

[PATCH v2 1/2] arm64: dts: qcom: sdm845: Add gpi dma node

2020-11-30 Thread Vinod Koul
This add the device node for gpi_dma0 and gpi_dma1 instances found in sdm845. Signed-off-by: Vinod Koul --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 50 1 file changed, 50 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom

Re: [PATCH v2 0/5] regmap/SoundWire/ASoC: Add SoundWire SDCA support

2020-11-30 Thread Vinod Koul
On 01-12-20, 02:42, Liao, Bard wrote: > Hi Vinod/Mark, > > Could we take this series into Vinod's tree with Mark's Acked-by? > It failed to build on Mark's tree. I see Mark has already applied 1-3 .. Thanks -- ~Vinod

Re: [PATCH] arm64: dts: qcom: sdm845: Add gpi dma node

2020-11-30 Thread Vinod Koul
On 30-11-20, 21:20, Bjorn Andersson wrote: > On Mon 30 Nov 00:39 CST 2020, Vinod Koul wrote: > > > This add the device node for gpi_dma0 and gpi_dma1 instances found in > > sdm845. > > > > Signed-off-by: Vinod Koul > > --- > >

Re: [PATCH] dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml

2020-11-30 Thread Vinod Koul
On 16-11-20, 08:46, Rafał Miłecki wrote: > From: Rafał Miłecki > > 1. Change syntax from txt to yaml > 2. Drop "Driver for" from the title > 3. Drop "reg = <0x0>;" from example (noticed by dt_binding_check) > 4. Specify license > > Signed-off-by: Rafał Miłecki > --- > I think this should go thr

Re: [PATCH v2] phy: mediatek: Make PHY_MTK_{XSPHY,TPHY} depend on HAS_IOMEM and OF_ADDRESS to fix build errors

2020-11-30 Thread Vinod Koul
On 25-11-20, 15:37, Tiezhu Yang wrote: > devm_ioremap_resource() will be not built in lib/devres.c if > CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be > not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not > set, and then there exists two build errors about undefined > refer

Re: [PATCH v1] phy: tegra: xusb: Fix usb_phy device driver field

2020-11-30 Thread Vinod Koul
On 17-11-20, 16:38, JC Kuo wrote: > In commit "phy: tegra: xusb: Add usb-phy support", an OTG capable PHY > device, such as phy-usb2.0 device of Jetson-TX1 platform, will be > bound to the tegra-xusb-padctl driver by the following line in > tegra_xusb_setup_usb_role_switch(). > > port->usb_p

Re: [PATCH] dt-bindings: phy: Convert Broadcom SATA PHY to YAML

2020-11-30 Thread Vinod Koul
Hi Florian, On 21-11-20, 19:29, Florian Fainelli wrote: > Update the Broadcom SATA PHY Device Tree binding to a YAML format. > > Suggested-by: Vinod Koul > Signed-off-by: Florian Fainelli I am getting these warns: Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:19

Re: [PATCH] phy: amlogic: replace devm_reset_control_array_get()

2020-11-30 Thread Vinod Koul
On 18-11-20, 10:36, Yejune Deng wrote: > devm_reset_control_array_get_exclusive() looks more readable Applied, thanks -- ~Vinod

Re: [PATCH v3] phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode

2020-11-30 Thread Vinod Koul
On 20-11-20, 16:38, Neil Armstrong wrote: > In order to keep OTG ID detection even when in Host mode, the ID line of > the PHY (if the current phy is an OTG one) pull-up should be kept > enable in both modes. > > This fixes OTG switch on GXL, GXM & AXG platforms, otherwise once switched > to Host,

Re: [PATCH] phy: amlogic: meson-axg-mipi-pcie-analog: replace DSI_LANE definitions with BIT() macro

2020-11-30 Thread Vinod Koul
On 20-11-20, 16:03, Neil Armstrong wrote: > For consistency, replace DSI_LANE definitions with BIT() macro and remove the > unused > DSI_LANE_MASK definition. Applied, thanks -- ~Vinod

Re: [PATCH 1/2] phy: samsung: Add support for the Exynos5420 variant of the USB2 PHY

2020-11-30 Thread Vinod Koul
On 20-11-20, 09:56, Marek Szyprowski wrote: > Exynos5420 differs a bit from Exynos5250 in USB2 PHY related registers in > the PMU region. Add a variant for the Exynos5420 case. Till now, USB2 PHY > worked only because the bootloader enabled the PHY, but then driver messed > USB 3.0 DRD related regi

Re: [PATCH v6 0/4] MT7621 PCIe PHY

2020-11-30 Thread Vinod Koul
On 21-11-20, 16:50, Sergio Paracuellos wrote: > This series adds support for the PCIe PHY found in the Mediatek > MT7621 SoC. > > There is also a 'mt7621-pci' driver which is the controller part > which is still in staging and is a client of this phy. > > Both drivers have been tested together in

Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-30 Thread Vinod Koul
On 17-11-20, 07:14, Chun-Kuang Hu wrote: > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_mipi_dsi_phy driver into phy driver folder. Acked-By: Vinod Koul I am thinking this wou

Re: [PATCH 1/8] phy: phy-hi3670-usb3: move driver from staging into phy

2020-11-30 Thread Vinod Koul
On 16-11-20, 13:59, Mauro Carvalho Chehab wrote: > +#define CTRL7_USB2_REFCLKSEL_MASK(3 << 3) > +#define CTRL7_USB2_REFCLKSEL_ABB (3 << 3) > +#define CTRL7_USB2_REFCLKSEL_PAD (2 << 3) This should use GENMASK() > + > +#define CFG50_USB3_PHY_TEST_POWERDOWNBIT(23) > + > +#define

Re: [PATCH v4 0/2] phy: intel: Add Keem Bay USB PHY support

2020-11-30 Thread Vinod Koul
On 16-11-20, 20:08, Wan Ahmad Zainie wrote: > Hi. > > Intel Keem Bay USB subsystem incorporates DesignWare USB3.1 controller, > an USB3.1 (Gen1/2) PHY and an USB2.0 PHY. It is a Dual Role Device > (DRD), operating as either a USB host or a USB device. Applied all, thanks -- ~Vinod

[PATCH] arm64: dts: qcom: sdm845: Add gpi dma node

2020-11-29 Thread Vinod Koul
This add the device node for gpi_dma0 and gpi_dma1 instances found in sdm845. Signed-off-by: Vinod Koul --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 45 1 file changed, 45 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom

Re: [PATCH] soundwire: master: use pm_runtime_set_active() on add

2020-11-26 Thread Vinod Koul
On 26-11-20, 09:52, Vinod Koul wrote: > > > > @@ -154,7 +163,12 @@ int sdw_master_device_add(struct sdw_bus *bus, > > > struct device *parent, > > > > bus->dev = &md->dev; > > > > bus->md = md; > > &g

[PATCH 2/2] regulator: qcom-rpmh: Add support for SDX55

2020-11-26 Thread Vinod Koul
Add support from RPMH regulators found in SDX55 platform Signed-off-by: Vinod Koul --- drivers/regulator/qcom-rpmh-regulator.c | 31 + 1 file changed, 31 insertions(+) diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c index

[PATCH 1/2] regulator: dt-bindings: Add PMX55 compatibles

2020-11-26 Thread Vinod Koul
Add PMX55 compatibles for PMIC found in SDX55 platform Signed-off-by: Vinod Koul --- .../devicetree/bindings/regulator/qcom,rpmh-regulator.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt b/Documentation

[PATCH 2/2] soc: qcom: rpmhpd: Add SDX55 power domains

2020-11-26 Thread Vinod Koul
This adds the power domains found in SDX55 SoC. Downstream code tells me that we have 3 power domains so add them Signed-off-by: Vinod Koul --- drivers/soc/qcom/rpmhpd.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c

[PATCH 1/2] dt-bindings: power: Add rpm power domain bindings for sdx55

2020-11-26 Thread Vinod Koul
Add RPM power domain bindings for the SDX55 SoC Signed-off-by: Vinod Koul --- Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + include/dt-bindings/power/qcom-rpmpd.h | 5 + 2 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/power

[PATCH 2/2] pinctrl: qcom-pmic-gpio: Add support for pmx55

2020-11-26 Thread Vinod Koul
PM55 pmic support gpio controller so add compatible and comment for gpio holes Signed-off-by: Vinod Koul --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index

[PATCH 1/2] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx55 support

2020-11-26 Thread Vinod Koul
Add support for the PMX55 GPIO support to the Qualcomm PMIC GPIO binding. Signed-off-by: Vinod Koul --- Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b

Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.

2020-11-25 Thread Vinod Koul
On 25-11-20, 18:39, Reddy, MallikarjunaX wrote: > > > > > desc needs to be configure for each dma channel and the remapped > > > > > address of > > > > > the IGP & EGP is desc base adress. > > > > Why should this address not passed as src_addr/dst_addr? > > > src_addr/dst_addr is the data pointer

Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'

2020-11-25 Thread Vinod Koul
On 25-11-20, 09:31, Randy Dunlap wrote: > On 11/24/20 9:51 PM, Vinod Koul wrote: > > From: Vinod Koul > > Date: Wed, 25 Nov 2020 11:15:22 +0530 > > Subject: [PATCH] soundwire: qcom: Fix build failure when slimbus is module > > > > Commit 5bd773242f75 (&quo

Re: [PATCH] soundwire: master: use pm_runtime_set_active() on add

2020-11-25 Thread Vinod Koul
On 26-11-20, 03:11, Liao, Bard wrote: > > -Original Message- > > From: Vinod Koul > > Sent: Wednesday, November 25, 2020 1:05 PM > > To: Bard Liao > > Cc: alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; > > gre...@linuxfoundation.org; j.

Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'

2020-11-24 Thread Vinod Koul
ode. Per the Documentation if we are using imply we should use IS_REACHABLE() rather than IS_ENABLED. This seems to take care of build failure for me on arm64 and x64 builds. Can you confirm with below patch: ---><8--- From: Vinod Koul Date: Wed, 25 Nov 2020 11:15:22 +0530 Subject: [PATCH]

Re: [PATCH] soundwire: master: use pm_runtime_set_active() on add

2020-11-24 Thread Vinod Koul
On 24-11-20, 21:07, Bard Liao wrote: > From: Pierre-Louis Bossart > > The 'master' device acts as a glue layer used during bus > initialization only, and it needs to be 'transparent' for pm_runtime > management. Its behavior should be that it becomes active when one of > its children becomes acti

Re: [PATCH 0/5] soundwire: only clear valid interrupts

2020-11-24 Thread Vinod Koul
On 24-11-20, 09:33, Bard Liao wrote: > We wrote 1 to the handled interrupts bits along with 0 to all other bits > to the SoundWire DPx interrupt register. However, DP0 has reserved fields > and the read-only SDCA_CASCADE bit. DPN also has reserved fields. We should > not try to write values in thes

Re: [PATCH] arm64: defconfig: Enable Qualcomm PON driver

2020-11-24 Thread Vinod Koul
On 24-11-20, 20:38, Bjorn Andersson wrote: > The PON block in the PMIC provides, among other things, support for > "reboot reason", power key and reset "key" handling. Let's enable the > driver for this block. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH 1/6] dmaengine: jz4780: drop of_match_ptr from of_device_id table

2020-11-24 Thread Vinod Koul
On 20-11-20, 17:22, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it is not relevant here). This fixes > compile warning (!CONFIG_O

Re: [PATCH] dmaengine: mv_xor_v2: Fix error return code in mv_xor_v2_probe()

2020-11-24 Thread Vinod Koul
On 24-11-20, 09:08, Zhihao Cheng wrote: > Return the corresponding error code when first_msi_entry() returns > NULL in mv_xor_v2_probe(). Applied, thanks -- ~Vinod

Re: [PATCH v9 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC

2020-11-24 Thread Vinod Koul
On 24-11-20, 00:30, Reddy, MallikarjunaX wrote: > Hi Vinod, > > Thanks for your valuable review. My comments inline. > > On 11/21/2020 8:19 PM, Vinod Koul wrote: > > On 20-11-20, 19:30, Reddy, MallikarjunaX wrote: > > > Hi Vinod, > > > Thanks for the revi

Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.

2020-11-24 Thread Vinod Koul
On 24-11-20, 00:29, Reddy, MallikarjunaX wrote: > Hi Vinod, > > Thanks for your valuable review comments. Please see my comments inline. > > On 11/21/2020 8:17 PM, Vinod Koul wrote: > > On 20-11-20, 19:30, Reddy, MallikarjunaX wrote: > > > Hi Vinod, > >

Re: [PATCH v7 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-11-24 Thread Vinod Koul
Hello Vitaly, On 24-11-20, 09:23, Vitaly Mayatskih wrote: > On Wed, Nov 18, 2020 at 7:20 AM Vinod Koul wrote: > > > this should be single line > > Vinod, do you see any obvious functional defects still present in the > driver, or can it be finally merged for us to start te

Re: [PATCH] dt-bindings: dmaengine: Convert Qualcomm ADM bindings to yaml

2020-11-24 Thread Vinod Koul
On 15-11-20, 18:12, Jonathan McDowell wrote: > Converts the device tree bindings for the Qualcomm Application Data > Mover (ADM) DMA controller over to YAML schemas. Rob ? > > Signed-off-by: Jonathan McDowell > --- > .../devicetree/bindings/dma/qcom,adm.yaml | 102 ++ > ...

Re: [PATCH v2 00/19] dmaengine/soc: k3-udma: Add support for BCDMA and PKTDMA

2020-11-24 Thread Vinod Koul
On 17-11-20, 12:56, Peter Ujfalusi wrote: > Hi, > > The series have build dependency on ti_sci/soc series (v2): > https://lore.kernel.org/lkml/20201008115224.1591-1-peter.ujfal...@ti.com/ > > Santosh kindly created immutable branch holdinf the series: > git://git.kernel.org/pub/scm/linux/kernel/g

Re: [PATCH] soc: qcom: Introduce debugfs interface to smem

2020-11-24 Thread Vinod Koul
On 24-11-20, 10:39, Bjorn Andersson wrote: > On Tue 24 Nov 09:34 CST 2020, Vinod Koul wrote: > > > On 22-11-20, 23:21, Bjorn Andersson wrote: > > > Every now and then it's convenient to be able to inspect the content of > > > SMEM items. Rather than carrying

Re: [PATCH] soc: qcom: Introduce debugfs interface to smem

2020-11-24 Thread Vinod Koul
On 22-11-20, 23:21, Bjorn Andersson wrote: > Every now and then it's convenient to be able to inspect the content of > SMEM items. Rather than carrying some hack locally let's upstream a > driver that when inserted exposes a debugfs interface for dumping > available items. > > Signed-off-by: Bjorn

Re: [PATCH 2/2] arm64: dts: qcom: sm8150-mtp: Enable WiFi node

2020-11-24 Thread Vinod Koul
On 20-11-20, 21:58, Bjorn Andersson wrote: > From: Jonathan Marek > > Enable the WiFi node and specify its supply regulators. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH 1/2] arm64: dts: qcom: sm8150: Add wifi node

2020-11-24 Thread Vinod Koul
On 20-11-20, 21:58, Bjorn Andersson wrote: > From: Jonathan Marek > > Add a node for the WCN3990 WiFi module. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH] arm64: dts: qcom: sm8150-mtp: Specify remoteproc firmware

2020-11-24 Thread Vinod Koul
On 20-11-20, 21:56, Bjorn Andersson wrote: > Point the various remoteprocs of SM8150 MTP to a place with the platform > specific firmware. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH] soundwire: SDCA: detect sdca_cascade interrupt

2020-11-24 Thread Vinod Koul
On 04-11-20, 23:23, Bard Liao wrote: > From: Pierre-Louis Bossart > > The SoundWire 1.2 specification defines an "SDCA cascade" bit which > handles a logical OR of all SDCA interrupt sources (up to 30 defined). > > Due to limitations of the addressing space, this bit is located in the > SDW_DP0_

Re: [PATCH] soundwire: Fix DEBUG_LOCKS_WARN_ON for uninitialized attribute

2020-11-24 Thread Vinod Koul
On 04-11-20, 11:29, Srinivas Kandagatla wrote: > running kernel with CONFIG_DEBUG_LOCKS_ALLOC enabled will below warning: > > BUG: key 502e09807098 has not been registered! > DEBUG_LOCKS_WARN_ON(1) > WARNING: CPU: 5 PID: 129 at kernel/locking/lockdep.c:4623 > lockdep_init_map_waits+0xe8/

Re: [PATCH 2/5] regmap/SoundWire: sdw: add support for SoundWire 1.2 MBQ

2020-11-24 Thread Vinod Koul
that CONFIG_REGMAP would not > be selected with CONFIG_REGMAP_MBQ selected. However there's no > functional dependency between the two modules so they can be selected > separately. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH 1/5] soundwire: SDCA: add helper macro to access controls

2020-11-24 Thread Vinod Koul
(((ctl) & 0x30) << 15) | > \ > + (((ctl) & 0x0f) << 3) | > \ > + (((ch) & 0x38) << 12) | > \ > + ((ch) & 0x07)) > + > +#define SDW_SDCA_MBQ_CTL(reg)((reg) | BIT(13)) > +#define SDW_SDCA_NEXT_CTL(reg) ((reg) | BIT(14)) Ideally would have liked to use defines with GENMASK etc instead of numbers, but this is not a strong issue so: Acked-By: Vinod Koul -- ~Vinod

Re: Reusing DTS from arm64 to arm

2020-11-23 Thread Vinod Koul
Hello Chen-Yu, On 24-11-20, 13:36, Chen-Yu Tsai wrote: > Hi, > > On Tue, Nov 24, 2020 at 1:28 PM Vinod Koul wrote: > > > > Hello Olof, Rob, > > > > We have Qualcomm arm platform which uses PMIC PM8150B. This PMIC was > > also used in SM8150 board a

Reusing DTS from arm64 to arm

2020-11-23 Thread Vinod Koul
Hello Olof, Rob, We have Qualcomm arm platform which uses PMIC PM8150B. This PMIC was also used in SM8150 board and is already upstream [1] but in arm64. So, what is the guidance to share DTS files between 32 and 64 variants? Does a solution already exist which I may not be aware of..? I can thi

Re: [PATCH v2] arm64: dts: sdm845: Add iommus property to qup

2020-11-23 Thread Vinod Koul
the right SID and mask so this works. Reviewed-by: Vinod Koul on DB845c with GSI DMA: Tested-by: Vinod Koul -- ~Vinod

Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels

2020-11-23 Thread Vinod Koul
On 23-11-20, 11:46, Robert Foss wrote: > 4k requires two dsi pipes, so don't report MODE_OK when only a > single pipe is configured. But rather report MODE_PANEL to > signal that requirements of the panel are not being met. Acked-By: Vinod Koul > Reported-by: Peter Collingbourn

Re: [PATCH v9 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC

2020-11-21 Thread Vinod Koul
On 20-11-20, 19:30, Reddy, MallikarjunaX wrote: > Hi Vinod, > Thanks for the review. My comments inline. > > On 11/18/2020 11:55 PM, Vinod Koul wrote: > > On 12-11-20, 13:38, Amireddy Mallikarjuna reddy wrote: > > > Add DT bindings YAML schema for DMA controller driver

Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.

2020-11-21 Thread Vinod Koul
On 20-11-20, 19:30, Reddy, MallikarjunaX wrote: > Hi Vinod, > > Thanks for the review. My comments inline. > > On 11/19/2020 1:38 AM, Vinod Koul wrote: > > On 12-11-20, 13:38, Amireddy Mallikarjuna reddy wrote: > > > Add DMA controller driver for Lightning

Re: [PATCH v5 0/4] MT7621 PCIe PHY

2020-11-21 Thread Vinod Koul
On 20-11-20, 17:20, Sergio Paracuellos wrote: > Hi Vinod, > > On Thu, Nov 19, 2020 at 4:43 PM Sergio Paracuellos > wrote: > > > > This series adds support for the PCIe PHY found in the Mediatek > > MT7621 SoC. > > > > There is also a 'mt7621-pci' driver which is the controller part > > which is s

[GIT PULL]: dmaengine fixes for v5.10-rc5

2020-11-20 Thread Vinod Koul
Hello Linus Please consider pull to receive the dmaengine subsystem fixes for v5.10-rc5 The includes a solitary core fixes and few driver fixes. All the patches are in linux-next The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -

[GIT PULL]: Generic phy fixes for 5.10

2020-11-20 Thread Vinod Koul
Hello Greg Please consider PULL to recive fixes for 5.10 for Generic phy. All minor fixes to drivers, already in linux-next The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://

Re: [PATCH v4 4/5 REBASED RESEND] phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 PCIe PHY

2020-11-20 Thread Vinod Koul
anks My scripts found a typo, have applied fix for that as well From: Vinod Koul Date: Fri, 20 Nov 2020 16:04:01 +0530 Subject: [PATCH] phy: samsung: phy-exynos-pcie: fix typo 'tunning' Fix the typo s/tunning/tuning Fixes: 496db029142f ("phy: samsung: phy-exynos-pcie: rewor

Re: [PATCH v4 4/5] phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 PCIe PHY

2020-11-20 Thread Vinod Koul
On 20-11-20, 10:58, Marek Szyprowski wrote: > Hi Vinod, > > On 20.11.2020 10:41, Vinod Koul wrote: > > On 13-11-20, 18:01, Marek Szyprowski wrote: > >> From: Jaehoon Chung > >> > >> Exynos5440 SoC support has been dropped since commit 8c83315da1cf

Re: [PATCH 3/3] phy: sun4i-usb: Use power efficient workqueue for debounce and poll

2020-11-20 Thread Vinod Koul
On 09-11-20, 20:12, Frank Lee wrote: > From: Yangtao Li > > The debounce and poll time is generally quite long and the work not > performance critical so allow the scheduler to run the work anywhere > rather than in the normal per-CPU workqueue. Applied, thanks -- ~Vinod

Re: [PATCH v2 1/1] dt-bindings: phy: phy-stm32-usbphyc: convert bindings to json-schema

2020-11-20 Thread Vinod Koul
On 16-11-20, 18:19, Amelie Delaunay wrote: > Convert the STM32 USB PHY Controller (USBPHYC) bindings to DT schema format > using json-schema. Applied, thanks -- ~Vinod

Re: [RESEND PATCH v3 0/3] phy: amlogic: add MIPI DSI function to analog MIPI+PCIe PHY

2020-11-20 Thread Vinod Koul
On 16-11-20, 11:16, Neil Armstrong wrote: > The AXG Analog MIPI-DSI PHY also provides functions to the PCIe PHY, > thus we need to have inclusive support for both interfaces at runtime. > > This fixes the regmap get from parent node, removes cell param > to select a mode and implement runtime conf

Re: [RESEND PATCH v3 0/2] phy: amlogic: Add support for AXG MIPI D-PHY

2020-11-20 Thread Vinod Koul
On 16-11-20, 11:13, Neil Armstrong wrote: > The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI > panels, this adds the bindings. > > This D-PHY depends on a separate analog PHY. Applied, thanks -- ~Vinod

Re: [RESEND PATCH v3 3/3] phy: amlogic: phy-meson-axg-mipi-pcie-analog: add support for MIPI DSI analog

2020-11-20 Thread Vinod Koul
On 16-11-20, 11:16, Neil Armstrong wrote: > The AXG Analog MIPI-DSI PHY also provides functions to the PCIe PHY, > thus we need to have inclusive support for both interfaces at runtime. > > This fixes the regmap get from parent node, removes cell param > to select a mode and implement runtime conf

Re: [PATCH v4 4/5] phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 PCIe PHY

2020-11-20 Thread Vinod Koul
ng this series to go thru PCI tree, so: Acked-By: Vinod Koul -- ~Vinod

Re: [PATCH] arm64: defconfig: Enable QCOM_SCM as builtin

2020-11-19 Thread Vinod Koul
system locking up as soon as any form of data > transfer is attempted from any of the affected peripherals. > > Mark QCOM_SCM as builtin, to avoid this. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH] dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml

2020-11-18 Thread Vinod Koul
On 16-11-20, 08:46, Rafał Miłecki wrote: > From: Rafał Miłecki > > 1. Change syntax from txt to yaml > 2. Drop "Driver for" from the title > 3. Drop "reg = <0x0>;" from example (noticed by dt_binding_check) > 4. Specify license You missed Ccing Rob > > Signed-off-by: Rafał Miłecki > --- > I t

Re: [PATCH] phy: phy-bcm-ns-usb3: drop support for deprecated DT binding

2020-11-18 Thread Vinod Koul
On 13-11-20, 12:34, Rafał Miłecki wrote: > From: Rafał Miłecki > > Initially this PHY driver was implementing MDIO access on its own. It > was caused by lack of proper hardware design understanding. > > It has been changed back in 2017. DT bindings were changed and driver > was updated to use MD

Re: [RESEND PATCH 09/19] phy: allwinner: Convert to devm_platform_ioremap_* API

2020-11-18 Thread Vinod Koul
On 10-11-20, 14:35, Frank Lee wrote: > From: Yangtao Li > > Use the devm_platform_ioremap_resource_byname() and > devm_platform_ioremap_resource helper to simplify the code. This fails to apply for me, pls rebase -- ~Vinod

Re: [RESEND PATCH 08/19] phy: sun4i-usb: remove enable_pmu_unk1 from sun50i_h6_cfg

2020-11-18 Thread Vinod Koul
On 10-11-20, 14:32, Frank Lee wrote: > From: Yangtao Li > > For the current code, enable_pmu_unk1 only works in non-a83t and non-h6 > types. So let's delete it from the sun50i_h6_cfg. Applied, thanks -- ~Vinod

Re: [PATCH v2 2/4] phy: Add ethernet serdes configuration option

2020-11-18 Thread Vinod Koul
On 10-11-20, 15:49, Steen Hegelund wrote: > Provide a new ethernet phy configuration structure, that > allow PHYs used for ethernet to be configured with > speed, media type and clock information. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > --- > include/linux/phy/phy-ethe

Re: [PATCH v2 1/4] dt-bindings: phy: Add sparx5-serdes bindings

2020-11-18 Thread Vinod Koul
On 10-11-20, 15:49, Steen Hegelund wrote: > Document the Sparx5 ethernet serdes phy driver bindings. Rob ..? Also pls cc devicet...@vger.kernel.org > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > --- > .../bindings/phy/microchip,sparx5-serdes.yaml | 283 ++ >

Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.

2020-11-18 Thread Vinod Koul
On 12-11-20, 13:38, Amireddy Mallikarjuna reddy wrote: > Add DMA controller driver for Lightning Mountain (LGM) family of SoCs. > > The main function of the DMA controller is the transfer of data from/to any > peripheral to/from the memory. A memory to memory copy capability can also > be configur

Re: [PATCH v9 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC

2020-11-18 Thread Vinod Koul
On 12-11-20, 13:38, Amireddy Mallikarjuna reddy wrote: > Add DT bindings YAML schema for DMA controller driver > of Lightning Mountain (LGM) SoC. > > Signed-off-by: Amireddy Mallikarjuna reddy > > --- > v1: > - Initial version. > > v2: > - Fix bot errors. > > v3: > - No change. > > v4: > - Ad

Re: [PATCH v5] dmaengine: qcom: Add ADM driver

2020-11-18 Thread Vinod Koul
On 14-11-20, 14:02, Jonathan McDowell wrote: > Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA > controller found in the MSM8x60 and IPQ/APQ8064 platforms. > > The ADM supports both memory to memory transactions and memory > to/from peripheral device transactions. The cont

Re: [PATCH v7 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-11-18 Thread Vinod Koul
On 16-10-20, 02:39, Sanjay R Mehta wrote: > diff --git a/drivers/dma/ptdma/ptdma-dmaengine.c > b/drivers/dma/ptdma/ptdma-dmaengine.c > new file mode 100644 > index 000..9b9b77c > --- /dev/null > +++ b/drivers/dma/ptdma/ptdma-dmaengine.c > @@ -0,0 +1,554 @@ > +// SPDX-License-Identifier: GPL-2

Re: [PATCH v7 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

2020-11-18 Thread Vinod Koul
On 16-10-20, 02:39, Sanjay R Mehta wrote: > From: Sanjay R Mehta > > Adding support for AMD PTDMA controller. It performs high-bandwidth Add support or Adds support.. would be apt! > memory to memory and IO copy operation. Device commands are managed > via a circular queue of 'descriptors', eac

Re: [RESEND PATCH 04/19] dt-bindings: dma: allwinner,sun50i-a64-dma: Add A100 compatible

2020-11-18 Thread Vinod Koul
On 10-11-20, 14:26, Frank Lee wrote: > From: Yangtao Li > > Add a binding for A100's dma controller. Applied, thanks -- ~Vinod

Re: [RESEND PATCH 05/19] dmaengine: sun6i: Add support for A100 DMA

2020-11-18 Thread Vinod Koul
On 10-11-20, 14:28, Frank Lee wrote: > From: Yangtao Li > > The dma of a100 is similar to h6, with some minor changes to > support greater addressing capabilities. > > Add support for it. Applied, thanks -- ~Vinod

Re: [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs.

2020-11-18 Thread Vinod Koul
On 07-11-20, 20:20, 周琰杰 (Zhou Yanjie) wrote: > Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC from Ingenic. > > 周琰杰 (Zhou Yanjie) (2): > dt-bindings: dmaengine: Add JZ4775 bindings. > dt-bindings: dmaengine: Add X2000 bindings. Applied, thanks -- ~Vinod

Re: [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs.

2020-11-18 Thread Vinod Koul
On 10-11-20, 08:54, Paul Cercueil wrote: > Hi Zhou, > > Le sam. 7 nov. 2020 à 20:20, 周琰杰 (Zhou Yanjie) > a écrit : > > Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC from > > Ingenic. > > > > 周琰杰 (Zhou Yanjie) (2): > > dt-bindings: dmaengine: Add JZ4775 bindings. > > dt-bind

Re: linux-next: build failure after merge of the phy-next tree

2020-11-17 Thread Vinod Koul
On 18-11-20, 13:56, Stephen Rothwell wrote: > Hi Vinod, > > On Tue, 17 Nov 2020 15:30:56 +0530 Vinod Koul wrote: > > > > On 17-11-20, 13:40, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the phy-next tree, today's linux-

Re: linux-next: build failure after merge of the phy-next tree

2020-11-17 Thread Vinod Koul
Hello Stephen, On 17-11-20, 13:40, Stephen Rothwell wrote: > Hi all, > > After merging the phy-next tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/soc/amlogic/meson-ee-pwrc.c: In function 'meson_ee_pwrc_init_domain': > drivers/soc/amlogic/meson-ee-pwrc.c:

Re: [PATCH 1/8] phy: phy-hi3670-usb3: move driver from staging into phy

2020-11-17 Thread Vinod Koul
On 17-11-20, 07:55, Mauro Carvalho Chehab wrote: > Em Mon, 16 Nov 2020 09:31:06 -0600 > Rob Herring escreveu: > > > On Mon, Nov 16, 2020 at 01:59:27PM +0100, Mauro Carvalho Chehab wrote: > > > The phy USB3 driver for Hisilicon 970 (hi3670) is ready > > > for mainstream. Mode it from staging into

Re: [PATCH] dmaengine: pl330: _prep_dma_memcpy: Fix wrong burst size

2020-11-16 Thread Vinod Koul
On 14-11-20, 11:55, Sugar Zhang wrote: > Actually, burst size is equal to '1 << desc->rqcfg.brst_size'. > we should use burst size, not desc->rqcfg.brst_size. > > dma memcpy performance on Rockchip RV1126 > @ 1512MHz A7, 1056MHz LPDDR3, 200MHz DMA: > > dmatest: > > /# echo dma0chan0 > /sys/modul

Re: [PATCH] dmaengine: ioatdma: remove unused function missed during dma_v2 removal

2020-11-16 Thread Vinod Koul
On 13-11-20, 09:12, Lukas Bulwahn wrote: > Commit 7f832645d0e5 ("dmaengine: ioatdma: remove ioatdma v2 registration") > missed to remove dca2_tag_map_valid() during its removal. Hence, since > then, dca2_tag_map_valid() is unused and make CC=clang W=1 warns: > > drivers/dma/ioat/dca.c:44:19: >

Re: [PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-16 Thread Vinod Koul
On 17-11-20, 00:17, Chun-Kuang Hu wrote: > Hi, Vinod: > > Vinod Koul 於 2020年11月16日 週一 下午3:25寫道: > > > > On 02-11-20, 07:08, Chun-Kuang Hu wrote: > > > + Vinod: > > > > > > Hi, Chunfeng: > > > > > > Chunfeng Yun 於 2020年10月30日 週五

Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral

2020-11-16 Thread Vinod Koul
On 16-11-20, 09:02, Amelie DELAUNAY wrote: > Hi Vinod, > > On 11/16/20 8:37 AM, Vinod Koul wrote: > > On 10-11-20, 11:23, Amelie Delaunay wrote: > > > Change stm32-usbphyc driver to not print an error message when the device > > > probe operation is defer

Re: [PATCH v3 0/2] phy: amlogic: Add support for AXG MIPI D-PHY

2020-11-16 Thread Vinod Koul
On 16-11-20, 09:47, Neil Armstrong wrote: > Hi Vinod, Kishon, > > > On 04/11/2020 14:47, Neil Armstrong wrote: > > The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI > > panels, this adds the bindings. > > > > This D-PHY depends on a separate analog PHY. Am not sure why but these

Re: [PATCH v2] phy: mapphone-mdm6600: return error when timed out powering up

2020-11-16 Thread Vinod Koul
On 16-11-20, 17:11, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The value of variable error is overwritten by the following call > devm_request_threaded_irq() in phy_mdm6600_device_power_on(), actually > we should return error when timed out powering up. > > Reported-by: Tosk Robot > Si

Re: [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors

2020-11-15 Thread Vinod Koul
On 13-11-20, 15:12, Bryan O'Donoghue wrote: > kernel build robot fired this email at me about an hour ago > https://lkml.org/lkml/2020/11/13/414 > > The build robot has flagged the super-speed PHY driver but both Kconfig > entries have the same error. Fix those now. > > verified with "make menuco

Re: [PATCH] phy: mediatek: fix spelling mistake in Kconfig "veriosn" -> "version"

2020-11-15 Thread Vinod Koul
On 14-11-20, 12:05, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in the Kconfig. Fix it. Applied, thanks -- ~Vinod

Re: [PATCH] phy: mapphone-mdm6600: remove the unused variable error value assignment

2020-11-15 Thread Vinod Koul
On 13-11-20, 16:34, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The value of variable error is overwritten by the following call > devm_request_threaded_irq() in phy_mdm6600_device_power_on(), so here the > value assignment is useless. Remove it. > > Reported-by: Tosk Robot > Signed-off

Re: [PATCH] phy: tegra: Don't warn on probe deferral

2020-11-15 Thread Vinod Koul
On 11-11-20, 10:37, Jon Hunter wrote: > Deferred probe is an expected return value for devm_regulator_bulk_get(). > Given that the driver deals with it properly, there's no need to output a > warning that may potentially confuse users. Applied, thanks -- ~Vinod

Re: [PATCH v2 0/2] phy: phy-brcm-sata: Allow configuration SATA AFE TX amplitude

2020-11-15 Thread Vinod Koul
On 22-10-20, 13:50, Florian Fainelli wrote: > Hi Vinod, Kishon, > > This patch series allows the configuration of the Broadcom SATA PHY TX > amplitude which may be required in order to meet specific tests. Applied, thanks Btw please do convert the binding doc to yaml Thanks -- ~Vinod

<    1   2   3   4   5   6   7   8   9   10   >