Hi Lee
On 02/20/2013 10:56 AM, Roberts, Lee A. wrote:
From: Lee A. Roberts lee.robe...@hp.com
Resolve SCTP association hangs observed during SCTP stress
testing. Observable symptoms include communications hangs
with data being held in the association reassembly and/or lobby
(ordering) queues.
On 02/20/2013 02:24 PM, Roberts, Lee A. wrote:
Vlad,
-Original Message-
From: Vlad Yasevich [mailto:vyasev...@gmail.com]
Sent: Wednesday, February 20, 2013 11:06 AM
To: Roberts, Lee A.
Cc: linux-s...@vger.kernel.org; net...@vger.kernel.org; linux-
ker...@vger.kernel.org
Subject: Re
.
Signed-off-by: Tejun Heo
Acked-by: Neil Horman
Cc: Vlad Yasevich
Acked-by: Vlad Yasevich
-vlad
Cc: Sridhar Samudrala
Cc: linux-s...@vger.kernel.org
---
net/sctp/associola.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/net/sctp
.
Signed-off-by: Tejun Heo t...@kernel.org
Acked-by: Neil Horman nhor...@tuxdriver.com
Cc: Vlad Yasevich vyasev...@gmail.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
-vlad
Cc: Sridhar Samudrala s...@us.ibm.com
Cc: linux-s...@vger.kernel.org
---
net/sctp/associola.c | 31
On 02/02/2013 08:21 PM, Tejun Heo wrote:
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo
Cc: Vlad Yasevich
Cc: Sridhar Samudrala
Cc: Neil Horman
Cc: linux-s...@vger.kernel.org
---
This patch depends on an earlier idr changes and I think it would
On 02/02/2013 08:21 PM, Tejun Heo wrote:
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Vlad Yasevich vyasev...@gmail.com
Cc: Sridhar Samudrala s...@us.ibm.com
Cc: Neil Horman nhor...@tuxdriver.com
Cc: linux-s...@vger.kernel.org
with DATA chunks.
Signed-off-by: Xufeng Zhang
Acked-by: Vlad Yasevich
-vlad
---
v2:
- Put the SCTP_CMD_NEW_STATE command before SCTP_CMD_REPLY and after
SCTP_CMD_EVENT_ULP
suggested by Vlad and Neil
- Improve the last paragraph of the commit header
net/sctp/sm_statefuns.c |4 +++-
1
COOKIE_ACK is bundled
with DATA chunks.
Signed-off-by: Xufeng Zhang xufeng.zh...@windriver.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
-vlad
---
v2:
- Put the SCTP_CMD_NEW_STATE command before SCTP_CMD_REPLY and after
SCTP_CMD_EVENT_ULP
suggested by Vlad and Neil
- Improve the last
On 01/23/2013 08:46 AM, Neil Horman wrote:
On Wed, Jan 23, 2013 at 03:38:40PM +0800, xufengzhang.m...@gmail.com wrote:
From: Xufeng Zhang
While sctp handling a duplicate COOKIE-ECHO and the action is
'Association restart', sctp_sf_do_dupcook_a() will processing
the unexpected COOKIE-ECHO for
On 01/23/2013 08:46 AM, Neil Horman wrote:
On Wed, Jan 23, 2013 at 03:38:40PM +0800, xufengzhang.m...@gmail.com wrote:
From: Xufeng Zhang xufeng.zh...@windriver.com
While sctp handling a duplicate COOKIE-ECHO and the action is
'Association restart', sctp_sf_do_dupcook_a() will processing
the
On 12/16/2012 11:47 AM, Simon Arlott wrote:
The following commit breaks IPv6 TCP transmission for me:
Commit 75fe83c32248d99e6d5fe64155e519b78bb90481
Author: Vlad Yasevich
Date: Fri Nov 16 09:41:21 2012 +
ipv6: Preserve ipv6 functionality needed by NET
On 12/16/2012 11:47 AM, Simon Arlott wrote:
The following commit breaks IPv6 TCP transmission for me:
Commit 75fe83c32248d99e6d5fe64155e519b78bb90481
Author: Vlad Yasevich vyase...@redhat.com
Date: Fri Nov 16 09:41:21 2012 +
ipv6: Preserve ipv6 functionality
On 10/29/2012 11:49 AM, Michael S. Tsirkin wrote:
It seems that to avoid deadlocks it is enough to poll vq before
we are going to use the last buffer. This should be faster than
c70aa540c7a9f67add11ad3161096fb95233aa2e.
Signed-off-by: Michael S. Tsirkin
---
drivers/vhost/net.c | 12
On 10/29/2012 11:49 AM, Michael S. Tsirkin wrote:
Orphaning frags for zero copy skbs needs to allocate data in atomic
context so is has a chance to fail. If it does we currently discard
the skb which is safe, but we don't report anything to the caller,
so it can not recover by e.g. disabling
On 10/29/2012 11:49 AM, Michael S. Tsirkin wrote:
Orphaning frags for zero copy skbs needs to allocate data in atomic
context so is has a chance to fail. If it does we currently discard
the skb which is safe, but we don't report anything to the caller,
so it can not recover by e.g. disabling
On 10/29/2012 11:49 AM, Michael S. Tsirkin wrote:
It seems that to avoid deadlocks it is enough to poll vq before
we are going to use the last buffer. This should be faster than
c70aa540c7a9f67add11ad3161096fb95233aa2e.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
On 10/23/2012 04:04 PM, Kees Cook wrote:
This config item has not carried much meaning for a while now and is
almost always enabled by default. As agreed during the Linux kernel
summit, remove it.
CC: Vlad Yasevich
CC: Sridhar Samudrala
CC: "David S. Miller"
Signed-off-by: Kees Coo
On 10/23/2012 04:04 PM, Kees Cook wrote:
This config item has not carried much meaning for a while now and is
almost always enabled by default. As agreed during the Linux kernel
summit, remove it.
CC: Vlad Yasevich vyasev...@gmail.com
CC: Sridhar Samudrala s...@us.ibm.com
CC: David S. Miller da
On 10/05/2012 10:50 AM, Masanari Iida wrote:
Correct spelling typo in net/sctp/socket.c
Signed-off-by: Masanari Iida
Acked-by: Vlad Yasevich
-vlad
---
net/sctp/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index
On 10/05/2012 10:50 AM, Masanari Iida wrote:
Correct spelling typo in net/sctp/socket.c
Signed-off-by: Masanari Iida standby2...@gmail.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
-vlad
---
net/sctp/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp
On 08/04/2012 05:30 PM, Jan Ariyasu wrote:
The following set of patches enable network-namespaces for the SCTP protocol.
The multitude of global parameters are stored in a net_generic
structure, and the bulk of the patches enable the protocol to access
the parameters on a per-namespace basis.
On 08/13/2012 04:18 PM, Eric W. Biederman wrote:
From: "Eric W. Biederman"
Cc: David Miller
Cc: Alexey Kuznetsov
Cc: James Morris
Cc: Hideaki YOSHIFUJI
Cc: Patrick McHardy
Cc: Remi Denis-Courmont
Cc: Arnaldo Carvalho de Melo
Cc: Vlad Yasevich
Cc: Sridhar Samudrala
Acked
into sctp_verify_ext_param
sctp: Making sysctl tunables per net
Eric
Acked-by: Vlad Yasevich
To this entire follow-on series. This is much better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
On 08/07/2012 01:23 PM, Eric W. Biederman wrote:
Start with an empty sctp_net_table that will be populated as the various
tunable sysctls are made per net.
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
include/net/netns/sctp.h |6 +-
include/net/s
On 08/06/2012 02:47 PM, Eric W. Biederman wrote:
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
include/net/netns/sctp.h |3 +
include/net/sctp/sctp.h |9 +--
net/sctp/associola.c |2 +-
net/sctp/chunk.c |2 +-
net/sctp/end
On 08/06/2012 02:46 PM, Eric W. Biederman wrote:
- Fix the sctp_af operations to work in all namespaces
- Enable sctp socket creation in all network namespaces.
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
net/sctp/ipv6.c | 12 ++--
net/sctp/
namespace.
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
include/net/netns/sctp.h |5 +++
include/net/sctp/sctp.h | 16 +-
net/sctp/proc.c | 59 +++
net/sctp/protocol.c
On 08/06/2012 02:44 PM, Eric W. Biederman wrote:
The percpu sctp socket counter has nothing at all to do with the sctp
proc files, and having it in the wrong initialization is confusing,
and makes network namespace support a pain.
Signed-off-by: "Eric W. Biederman"
Acked-by: Vla
On 08/06/2012 02:43 PM, Eric W. Biederman wrote:
- Kill sctp_get_ctl_sock, it is useless now.
- Pass struct net where needed so net->sctp.ctl_sock is accessible.
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
include/net/netns/sctp.h |8 +++
inc
into struct net
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
include/net/net_namespace.h |4 +
include/net/netns/sctp.h| 21 +++
include/net/sctp/sctp.h |4 +-
include/net/sctp/structs.h | 22 +---
net/sctp/associola.c|
do the association lookup.
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
include/net/sctp/sctp.h|6 ++--
include/net/sctp/structs.h |3 +-
net/sctp/associola.c |4 ++-
net/sctp/endpointola.c |6 +++-
net/sctp/input.c
On 08/06/2012 02:40 PM, Eric W. Biederman wrote:
- Use struct net in the hash calculation
- Use sock_net(endpoint.base.sk) in the endpoint lookups.
- On receive calculate the network namespace from skb->dev.
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
for.
With these changes lookups in the port hash table becomes
safe to use in multiple network namespaces.
Signed-off-by: "Eric W. Biederman"
Acked-by: Vlad Yasevich
---
include/net/sctp/sctp.h|4 ++--
include/net/sctp/structs.h |1 +
net/sctp/socket.c
On 08/14/2012 05:14 PM, David Miller wrote:
Come on Vlad, please review this stuff some time this century. If you
want inclusion to be dependent upon your review, then the onus is on
you to review it in a timely manner. And you are not doing so here.
I'm not letting Eric's patches rot in
On 08/14/2012 05:14 PM, David Miller wrote:
Come on Vlad, please review this stuff some time this century. If you
want inclusion to be dependent upon your review, then the onus is on
you to review it in a timely manner. And you are not doing so here.
I'm not letting Eric's patches rot in
for.
With these changes lookups in the port hash table becomes
safe to use in multiple network namespaces.
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
---
include/net/sctp/sctp.h|4 ++--
include/net/sctp/structs.h |1 +
net/sctp
On 08/06/2012 02:40 PM, Eric W. Biederman wrote:
- Use struct net in the hash calculation
- Use sock_net(endpoint.base.sk) in the endpoint lookups.
- On receive calculate the network namespace from skb-dev.
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev
the association lookup.
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
---
include/net/sctp/sctp.h|6 ++--
include/net/sctp/structs.h |3 +-
net/sctp/associola.c |4 ++-
net/sctp/endpointola.c |6 +++-
net/sctp
into struct net
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
---
include/net/net_namespace.h |4 +
include/net/netns/sctp.h| 21 +++
include/net/sctp/sctp.h |4 +-
include/net/sctp/structs.h | 22 +---
net/sctp
On 08/06/2012 02:43 PM, Eric W. Biederman wrote:
- Kill sctp_get_ctl_sock, it is useless now.
- Pass struct net where needed so net-sctp.ctl_sock is accessible.
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
---
include/net/netns/sctp.h
-by: Vlad Yasevich vyasev...@gmail.com
---
net/sctp/protocol.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 6193d20..976d765 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -93,8 +93,6 @@ int
namespace.
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
---
include/net/netns/sctp.h |5 +++
include/net/sctp/sctp.h | 16 +-
net/sctp/proc.c | 59 +++
net/sctp/protocol.c | 77
On 08/06/2012 02:46 PM, Eric W. Biederman wrote:
- Fix the sctp_af operations to work in all namespaces
- Enable sctp socket creation in all network namespaces.
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
---
net/sctp/ipv6.c
On 08/06/2012 02:47 PM, Eric W. Biederman wrote:
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
---
include/net/netns/sctp.h |3 +
include/net/sctp/sctp.h |9 +--
net/sctp/associola.c |2 +-
net/sctp/chunk.c
On 08/07/2012 01:23 PM, Eric W. Biederman wrote:
Start with an empty sctp_net_table that will be populated as the various
tunable sysctls are made per net.
Signed-off-by: Eric W. Biederman ebied...@xmission.com
Acked-by: Vlad Yasevich vyasev...@gmail.com
---
include/net/netns/sctp.h
into sctp_verify_ext_param
sctp: Making sysctl tunables per net
Eric
Acked-by: Vlad Yasevich vyasev...@gmail.com
To this entire follow-on series. This is much better.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
: Remi Denis-Courmont courmi...@gmail.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Vlad Yasevich vyasev...@gmail.com
Cc: Sridhar Samudrala s...@us.ibm.com
Acked-by: Serge Hallyn serge.hal...@canonical.com
Signed-off-by: Eric W. Biederman ebied...@xmission.com
ACK sctp parts
Acked
On 08/04/2012 05:30 PM, Jan Ariyasu wrote:
The following set of patches enable network-namespaces for the SCTP protocol.
The multitude of global parameters are stored in a net_generic
structure, and the bulk of the patches enable the protocol to access
the parameters on a per-namespace basis.
On 08/09/2012 02:20 AM, David Miller wrote:
From: ebied...@xmission.com (Eric W. Biederman)
Date: Tue, 07 Aug 2012 10:17:02 -0700
Since I am motivated to get things done, and since there has been much
grumbling about my patches not implementing tunables, I have added
tunable support on top of
On 08/09/2012 02:20 AM, David Miller wrote:
From: ebied...@xmission.com (Eric W. Biederman)
Date: Tue, 07 Aug 2012 10:17:02 -0700
Since I am motivated to get things done, and since there has been much
grumbling about my patches not implementing tunables, I have added
tunable support on top of
On 08/06/2012 04:47 PM, David Miller wrote:
From: ebied...@xmission.com (Eric W. Biederman)
Date: Mon, 06 Aug 2012 12:50:46 -0700
Vlad Yasevich writes:
Hi Eric
Associations are looked up by ports, but then verifyed by addresses.
Also, associations belong to sockets and simply validating
On 08/06/2012 03:50 PM, Eric W. Biederman wrote:
Vlad Yasevich writes:
Hi Eric
Associations are looked up by ports, but then verifyed by addresses.
Also, associations belong to sockets and simply validating the socket
namespace should be sufficient.
True. Your set of patches isn't quite
On 08/06/2012 02:20 PM, Eric W. Biederman wrote:
Jan Ariyasu writes:
The following set of patches enable network-namespaces for the SCTP protocol.
The multitude of global parameters are stored in a net_generic
structure, and the bulk of the patches enable the protocol to access
the
On 08/06/2012 02:20 PM, Eric W. Biederman wrote:
Jan Ariyasu jan.ariy...@gmail.com writes:
The following set of patches enable network-namespaces for the SCTP protocol.
The multitude of global parameters are stored in a net_generic
structure, and the bulk of the patches enable the protocol to
On 08/06/2012 03:50 PM, Eric W. Biederman wrote:
Vlad Yasevich vyasev...@gmail.com writes:
Hi Eric
Associations are looked up by ports, but then verifyed by addresses.
Also, associations belong to sockets and simply validating the socket
namespace should be sufficient.
True. Your set
On 08/06/2012 04:47 PM, David Miller wrote:
From: ebied...@xmission.com (Eric W. Biederman)
Date: Mon, 06 Aug 2012 12:50:46 -0700
Vlad Yasevich vyasev...@gmail.com writes:
Hi Eric
Associations are looked up by ports, but then verifyed by addresses.
Also, associations belong to sockets
On 07/31/2012 02:51 AM, xufeng zhang wrote:
Sorry, please ignore the above patch, there was an paste error.
Please check the following patch.
I'm wondering if the below solution is fine to you which is based on
your changes.
BTW, I have verified this
On 07/31/2012 02:51 AM, xufeng zhang wrote:
Sorry, please ignore the above patch, there was an paste error.
Please check the following patch.
I'm wondering if the below solution is fine to you which is based on
your changes.
BTW, I have verified this
here is an untested prototype of what I was talking about. This should
handle multiple data chunks.
-vlad
---
include/net/sctp/command.h |1 +
net/sctp/sm_sideeffect.c | 22 ++
net/sctp/sm_statefuns.c| 18 ++
3 files changed, 33
here is an untested prototype of what I was talking about. This should
handle multiple data chunks.
-vlad
---
include/net/sctp/command.h |1 +
net/sctp/sm_sideeffect.c | 22 ++
net/sctp/sm_statefuns.c| 18 ++
3 files changed, 33
Xufeng Zhang wrote:
>On 7/26/12, Xufeng Zhang wrote:
>> On 7/25/12, Vlad Yasevich wrote:
>>>> And after take a moment to look into the relative codes, I think we
>>>> can implement it
>>>> by below way:
>>>> 1). Add a flag(isi_err_n
Xufeng Zhang wrote:
>On 7/25/12, Vlad Yasevich wrote:
>>> And after take a moment to look into the relative codes, I think we
>>> can implement it
>>> by below way:
>>> 1). Add a flag(isi_err_needed) in the embedded struct peer of struct
>>> s
On 07/25/2012 05:22 AM, Xufeng Zhang wrote:
On 7/25/12, Xufeng Zhang wrote:
On 7/25/12, Vlad Yasevich wrote:
Actually not true. AUTH can be before SACK. So can any addip chunks
that
aid in locating an association.
Now AUTH isn't a big issue since its autogenerated to the packet but
ADDIP
Xufeng Zhang wrote:
>On 7/24/12, Vlad Yasevich wrote:
>>>>> And I should clarify the above judgment code.
>>>>> AFAIK, there should be two cases for the bundling when invalid
>>>stream
>>>>> identifier error happens:
>>>>>
Xufeng Zhang xufengzhang.m...@gmail.com wrote:
On 7/25/12, Vlad Yasevich vyasev...@gmail.com wrote:
And after take a moment to look into the relative codes, I think we
can implement it
by below way:
1). Add a flag(isi_err_needed) in the embedded struct peer of struct
struct sctp_association
Xufeng Zhang xufengzhang.m...@gmail.com wrote:
On 7/26/12, Xufeng Zhang xufengzhang.m...@gmail.com wrote:
On 7/25/12, Vlad Yasevich vyasev...@gmail.com wrote:
And after take a moment to look into the relative codes, I think we
can implement it
by below way:
1). Add a flag(isi_err_needed
Xufeng Zhang xufengzhang.m...@gmail.com wrote:
On 7/24/12, Vlad Yasevich vyasev...@gmail.com wrote:
And I should clarify the above judgment code.
AFAIK, there should be two cases for the bundling when invalid
stream
identifier error happens:
1). COOKIE_ACK ERROR SACK
2). ERROR SACK
So I
On 07/25/2012 05:22 AM, Xufeng Zhang wrote:
On 7/25/12, Xufeng Zhang xufengzhang.m...@gmail.com wrote:
On 7/25/12, Vlad Yasevich vyasev...@gmail.com wrote:
Actually not true. AUTH can be before SACK. So can any addip chunks
that
aid in locating an association.
Now AUTH isn't a big issue
xufeng zhang wrote:
>On 07/24/2012 10:27 AM, Vlad Yasevich wrote:
>> xufeng zhang wrote:
>>
>>
>>> On 07/19/2012 01:57 PM, xufengzhang.m...@gmail.com wrote:
>>>
>>>> When "Invalid Stream Identifier" ERROR happens
xufeng zhang xufeng.zh...@windriver.com wrote:
On 07/24/2012 10:27 AM, Vlad Yasevich wrote:
xufeng zhangxufeng.zh...@windriver.com wrote:
On 07/19/2012 01:57 PM, xufengzhang.m...@gmail.com wrote:
When Invalid Stream Identifier ERROR happens after process the
received DATA chunks
xufeng zhang wrote:
>On 07/19/2012 01:57 PM, xufengzhang.m...@gmail.com wrote:
>> When "Invalid Stream Identifier" ERROR happens after process the
>> received DATA chunks, this ERROR chunk is enqueued into outqueue
>> before SACK chunk, so when bundling ERROR chunk with SACK chunk,
>> the ERROR
xufeng zhang xufeng.zh...@windriver.com wrote:
On 07/19/2012 01:57 PM, xufengzhang.m...@gmail.com wrote:
When Invalid Stream Identifier ERROR happens after process the
received DATA chunks, this ERROR chunk is enqueued into outqueue
before SACK chunk, so when bundling ERROR chunk with SACK
Ilpo Järvinen wrote:
On Wed, 20 Feb 2008, Vlad Yasevich wrote:
Ilpo Järvinen wrote:
I added inline to sctp_add_cmd and appropriate comment there to
avoid adding another call into the call chain. This works at least
with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alt
Ilpo Järvinen wrote:
On Wed, 20 Feb 2008, Vlad Yasevich wrote:
Ilpo Järvinen wrote:
I added inline to sctp_add_cmd and appropriate comment there to
avoid adding another call into the call chain. This works at least
with gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13). Alternatively
Ilpo Järvinen wrote:
I added inline to sctp_add_cmd and appropriate comment there to
avoid adding another call into the call chain. This works at least
with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alternatively,
__sctp_add_cmd could be introduced to .h.
My only concern was performance
Ilpo Järvinen wrote:
I added inline to sctp_add_cmd and appropriate comment there to
avoid adding another call into the call chain. This works at least
with gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13). Alternatively,
__sctp_add_cmd could be introduced to .h.
My only concern was performance
Alexey Dobriyan wrote:
On Sun, Feb 10, 2008 at 09:16:04PM +0100, Julia Lawall wrote:
--- a/include/net/sctp/sctp.h
+++ b/include/net/sctp/sctp.h
@@ -618,7 +618,7 @@ static inline int param_type2af(__be16 t
static inline int sctp_sanity_check(void)
{
SCTP_ASSERT(sizeof(struct
Alexey Dobriyan wrote:
On Sun, Feb 10, 2008 at 09:16:04PM +0100, Julia Lawall wrote:
--- a/include/net/sctp/sctp.h
+++ b/include/net/sctp/sctp.h
@@ -618,7 +618,7 @@ static inline int param_type2af(__be16 t
static inline int sctp_sanity_check(void)
{
SCTP_ASSERT(sizeof(struct
Chris Friesen wrote:
Eric Dumazet wrote:
Chris Friesen a écrit :
Based on the profiling information we're spending time in
sctp_endpoint_lookup_assoc() which doesn't actually use hashes, so I
can't see how the hash would be related. I'm pretty new to SCTP
though, so I may be missing
Chris Friesen wrote:
Eric Dumazet wrote:
Chris Friesen a écrit :
Based on the profiling information we're spending time in
sctp_endpoint_lookup_assoc() which doesn't actually use hashes, so I
can't see how the hash would be related. I'm pretty new to SCTP
though, so I may be missing
Joe Perches wrote:
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
Thanks... I am surprised this is all you found :)
ACK.
-vlad
> ---
> net/sctp/sm_make_chunk.c |8
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c
Joe Perches wrote:
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Thanks... I am surprised this is all you found :)
ACK.
-vlad
---
net/sctp/sm_make_chunk.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
Ingo Molnar wrote:
* Vlad Yasevich <[EMAIL PROTECTED]> wrote:
this is a build regression over v2.6.23. config attached.
the patch below fix it (or rather, works it around).
The patch is an OK workaround, but may not yield a working SCTP.
Let me see if I can do better..
i'd b
Ingo Molnar wrote:
* Ingo Molnar <[EMAIL PROTECTED]> wrote:
a similar build bug happens with latest -git as well, with SCTP:
net/built-in.o: In function `rxrpc_destroy_s':
ar-key.c:(.text+0xc5a2b): undefined reference to `crypto_free_tfm'
net/built-in.o: In function `rxrpc_instantiate_s':
Ingo Molnar wrote:
* Ingo Molnar [EMAIL PROTECTED] wrote:
a similar build bug happens with latest -git as well, with SCTP:
net/built-in.o: In function `rxrpc_destroy_s':
ar-key.c:(.text+0xc5a2b): undefined reference to `crypto_free_tfm'
net/built-in.o: In function `rxrpc_instantiate_s':
Ingo Molnar wrote:
* Vlad Yasevich [EMAIL PROTECTED] wrote:
this is a build regression over v2.6.23. config attached.
the patch below fix it (or rather, works it around).
The patch is an OK workaround, but may not yield a working SCTP.
Let me see if I can do better..
i'd be glad to test
Jesper Juhl wrote:
> From: Jesper Juhl <[EMAIL PROTECTED]>
>
> In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
> the storage allocated for 'abort' by returning from the function
> without using or freeing it. This happens in case
> "sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)"
Jesper Juhl wrote:
From: Jesper Juhl [EMAIL PROTECTED]
In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
the storage allocated for 'abort' by returning from the function
without using or freeing it. This happens in case
sctp_auth_recv_cid(SCTP_CID_ABORT, asoc) is true and
Herbert Xu wrote:
> [CRYPTO] users: Fix up scatterlist conversion errors
>
> This patch fixes the errors made in the users of the crypto layer during
> the sg_init_table conversion. It also adds a few conversions that were
> missing altogether.
>
> Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
David Miller wrote:
> From: Vlad Yasevich <[EMAIL PROTECTED]>
> Date: Thu, 25 Oct 2007 16:07:17 -0400
>
>> Crypto now uses SG helper functions. Fix hmac_digest to use those
>> functions correctly and fix the oops associated with it.
>>
>> Signed-
David Miller wrote:
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Thu, 25 Oct 2007 16:07:17 -0400
Crypto now uses SG helper functions. Fix hmac_digest to use those
functions correctly and fix the oops associated with it.
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
Since I keep hitting
Herbert Xu wrote:
[CRYPTO] users: Fix up scatterlist conversion errors
This patch fixes the errors made in the users of the crypto layer during
the sg_init_table conversion. It also adds a few conversions that were
missing altogether.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---
Crypto now uses SG helper functions. Fix hmac_digest to use those
functions correctly and fix the oops associated with it.
Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]>
---
crypto/hmac.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/crypto/hmac.c b/
Crypto now uses SG helper functions. Fix hmac_digest to use those
functions correctly and fix the oops associated with it.
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
---
crypto/hmac.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/crypto/hmac.c b/crypto/hmac.c
David Stevens wrote:
> My bad -- I see what it's doing, and it looks ok after all.
>
> I thought I saw an INMSGS (but didn't). These are ICMP errors that
> went through icmp_rcv() and were counted correctly before getting
> to the protocol error handlers. These are failures due mostly to not
>
David Stevens wrote:
> My bad -- I see what it's doing, and it looks ok after all.
>
jinx, crossed in flight. ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
David Stevens wrote:
> I took a look at the DCCP references, and I think they're just
> incrementing the wrong MIB variable -- e.g., it's incrementing
> ICMP_MIB_INERRORS when the skb length is less than the
> header indicates. That's not an ICMP_MIB_INERRORS error,
> that's an
Adrian Bunk wrote:
> sctp_update_copy_cksum() is no longer used.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
ACK.
-vlad
>
> ---
>
> include/net/sctp/sctp.h |1 -
> net/sctp/crc32c.c |2 ++
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>
Adrian Bunk wrote:
> This patch makes three needlessly global functions static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
ACK. Thanks for catching these..
-vlad
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More
David Stevens wrote:
> I took a look at the DCCP references, and I think they're just
> incrementing the wrong MIB variable -- e.g., it's incrementing
> ICMP_MIB_INERRORS when the skb length is less than the
> header indicates. That's not an ICMP_MIB_INERRORS error,
> that's an
201 - 300 of 338 matches
Mail list logo
