Re: [PATCH] drm/i915/gvt: remove useless function

ry, unsigned long index) > -{ > - _ppgtt_set_root_entry(mm, entry, index, true); > -} > - > static inline void ppgtt_set_shadow_root_entry(struct intel_vgpu_mm *mm, > struct intel_gvt_gtt_entry *entry, unsigned long index) > { > -- Reviewed-by: Zhenyu Wang Thanks for covering me on this! Queue this up. signature.asc Description: PGP signature

Re: Regression: gvt: vgpu 1: MI_LOAD_REGISTER_MEM handler error

rework. Thanks for reporting! > > commit f18d417a57438498e0de481d3a0bc900c2b0e057 > Author: Yan Zhao > Date: Wed Dec 23 11:45:08 2020 +0800 > > drm/i915/gvt: filter cmds "srm" and "lrm" in cmd_handler > > do not allow "sr

Re: drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

4466881d6 Zhi Wang 2016-03-28 266 > > 054f4eba2a2985b Zhi Wang 2017-10-10 @267 static inline int get_pt_type(int > > type) > > 054f4eba2a2985b Zhi Wang 2017-10-10 268 { > > 054f4eba2a2985b Zhi Wang 2017-10-10 269return > > gtt_type_table[type].pt_type; > >

Re: [PATCH] drivers: gnu: drm: i915: gvt: Fixed couple of spellings in the file gtt.c

On 2021.02.22 06:22:37 -0800, Randy Dunlap wrote: > On 2/22/21 6:21 AM, Randy Dunlap wrote: > > On 2/22/21 12:18 AM, Bhaskar Chowdhury wrote: > >> > >> s/negtive/negative/ > >> s/possilbe/possible/ > >> > >> Signed-off-by: Bhaskar Chowdhury > > > > Acked-by: Randy Dunlap > > except the Subject

Re: [PATCH] drm/i915/gvt/kvmgt: Fix the build failure in kvmgt.

On 2021.02.09 02:52:10 +0800, Yu Zhang wrote: > Previously, commit 531810caa9f4 ("KVM: x86/mmu: Use > an rwlock for the x86 MMU") replaced KVM's mmu_lock > with type rwlock_t. This will cause a build failure > in kvmgt, which uses the same lock when trying to add/ > remove some GFNs to/from the

Re: [FYI PATCH] i915: kvmgt: the KVM mmu_lock is now an rwlock

On 2021.02.08 06:34:37 -0500, Paolo Bonzini wrote: > Adjust the KVMGT page tracking callbacks. > > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc: intel-gvt-...@lists.freedesktop.org > Cc: intel-...@lists.freedesktop.org > Signed-off-by: Paolo Bonzini > --- Thanks for that

Re: [PATCH] drm/i915/gvt: fix uninitialized return in intel_gvt_update_reg_whitelist()

On 2021.01.25 09:44:53 +, Chris Wilson wrote: > Quoting Dan Carpenter (2021-01-25 08:48:30) > > Smatch found an uninitialized variable bug in this code: > > > > drivers/gpu/drm/i915/gvt/cmd_parser.c:3191 > > intel_gvt_update_reg_whitelist() > > error: uninitialized symbol 'ret'. > >

Re: [PATCH] drm/i915/gvt: return error when failing to take the module reference

mdev core doesn't take >* a reference for vendor driver. >*/ > - if (!try_module_get(THIS_MODULE)) > + if (!try_module_get(THIS_MODULE)) { > + ret = -ENODEV; > goto undo_group; > + } > > ret = kvmgt_guest_init(mdev); &g

Re: [PATCH] drm/i915/gvt: replace idr_init() by idr_init_base()

t;dmabuf_lock); > INIT_LIST_HEAD(>dmabuf_obj_list_head); > INIT_RADIX_TREE(>page_track_tree, GFP_KERNEL); > - idr_init(>object_idr); > + idr_init_base(>object_idr, 1); > intel_vgpu_init_cfg_space(vgpu, param->primary); > vgpu->d3_ent

Re: [PATCH] drm/i915/gvt: print actionable error message when gm runs out

ut what actions a user can > take to resolve this situation. > > Cc: Thomas Prescher > Cc: Zhenyu Wang > Signed-off-by: Julian Stecklina > --- > drivers/gpu/drm/i915/gvt/aperture_gm.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH] drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

On 2020.05.18 22:00:52 +0100, Chris Wilson wrote: > Quoting Aishwarya Ramakrishnan (2020-05-18 16:03:36) > > Prefer ARRAY_SIZE instead of using sizeof > > > > Fixes coccicheck warning: Use ARRAY_SIZE > > > > Signed-off-by: Aishwarya Ramakrishnan > Reviewed-by: Chris Wilson Applied, thanks!

Re: [PATCH] drm/i915: Mark check_shadow_context_ppgtt as maybe unused

context *c, struct > intel_vgpu_mm *m) > { > if (m->ppgtt_mm.root_entry_type == GTT_TYPE_PPGTT_ROOT_L4_ENTRY) { > > base-commit: bdecf38f228bcca73b31ada98b5b7ba1215eb9c9 Thanks for the fix! Acked-by: Zhenyu Wang I'll pick up for gvt-next-fixes pull. -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 signature.asc Description: PGP signature

Re: [PATCH v5 4/6] drm/i915/gvt: Deliver vGPU refresh event to userspace

On 2019.08.16 10:35:26 +0800, Tina Zhang wrote: > Deliver the display refresh events to the user land. Userspace can use > the irq mask/unmask mechanism to disable or enable the event delivery. > > As we know, delivering refresh event at each vblank safely avoids > tearing and unexpected event

Re: [RFC PATCH v4 1/6] vfio: Define device specific irq type capability

On 2019.07.19 09:02:33 +, Lu, Kechen wrote: > Hi, > > > -Original Message- > > From: Zhenyu Wang [mailto:zhen...@linux.intel.com] > > Sent: Friday, July 19, 2019 2:06 PM > > To: Lu, Kechen > > Cc: intel-gvt-...@lists.freedesktop.org; k

Re: [RFC PATCH v4 6/6] drm/i915/gvt: Add cursor plane reg update trap emulation handler

On 2019.07.18 23:56:40 +0800, Kechen Lu wrote: > This patch adds the cursor plane CURBASE reg update trap handler > in order to : > > - Deliver the cursor refresh event at each vblank emulation, > the flip_done_event bit check is supposed to do here. If cursor > plane updates happen, deliver the

Re: [RFC PATCH v4 4/6] drm/i915/gvt: Deliver vGPU refresh event to userspace

On 2019.07.18 23:56:38 +0800, Kechen Lu wrote: > From: Tina Zhang > > Deliver the display refresh events to the user land. Userspace can use > the irq mask/unmask mechanism to disable or enable the event delivery. > > As we know, delivering refresh event at each vblank safely avoids > tearing

Re: [RFC PATCH v4 1/6] vfio: Define device specific irq type capability

On 2019.07.18 23:56:35 +0800, Kechen Lu wrote: > From: Tina Zhang > > Cap the number of irqs with fixed indexes and use capability chains > to chain device specific irqs. > > Signed-off-by: Tina Zhang > Signed-off-by: Eric Auger > --- > include/uapi/linux/vfio.h | 19 ++- > 1

Re: [RFC PATCH v3 0/4] Deliver vGPU display vblank event to userspace

lay. If userspace doesn't set irq for vfio gfx display, it would just use own timer. > > > -Original Message- > > From: Zhang, Tina > > Sent: Friday, June 28, 2019 4:45 PM > > To: 'Gerd Hoffmann' ; Zhenyu Wang > > > > Cc: Tian, Kevin ; k...@vger.kern

Re: [RFC PATCH v3 0/4] Deliver vGPU display vblank event to userspace

On 2019.06.28 07:43:46 +0200, Gerd Hoffmann wrote: > On Fri, Jun 28, 2019 at 11:21:49AM +0800, Zhenyu Wang wrote: > > On 2019.06.27 12:31:33 +0200, Gerd Hoffmann wrote: > > > > > Hi, > > > > > > > > > > > Instead of delivering page flip e

Re: [RFC PATCH v3 0/4] Deliver vGPU display vblank event to userspace

On 2019.06.27 12:31:33 +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > Instead of delivering page flip events, we choose to post display > > > > vblank event. Handling page flip events for both primary plane and > > > > cursor plane may make user space quite busy, although we have the > > >

Re: [RFC PATCH v2 1/3] vfio: Use capability chains to handle device specific irq

On 2019.06.04 17:55:32 +0800, Tina Zhang wrote: > Caps the number of irqs with fixed indexes and uses capability chains > to chain device specific irqs. > > VFIO vGPU leverages this mechanism to trigger primary plane and cursor > plane page flip event to the user space. > > Signed-off-by: Tina

Re: [PATCH 1/2] vfio: ABI for setting mdev display flip eventfd

On 2019.05.27 14:22:37 +0200, Gerd Hoffmann wrote: > On Mon, May 27, 2019 at 05:07:41PM +0800, Zhenyu Wang wrote: > > On 2019.05.27 16:43:11 +0800, Tina Zhang wrote: > > > Add VFIO_DEVICE_SET_GFX_FLIP_EVENTFD ioctl command to set eventfd > > > based signaling mechanism

Re: [PATCH 2/2] drm/i915/gvt: Support delivering page flip event to userspace

On 2019.05.27 16:43:12 +0800, Tina Zhang wrote: > Use the eventfd based signaling mechanism provided by vfio/display > to deliver vGPU framebuffer page flip event to userspace. > > Signed-off-by: Tina Zhang > --- > drivers/gpu/drm/i915/gvt/dmabuf.c | 31 + >

Re: [PATCH 1/2] vfio: ABI for setting mdev display flip eventfd

On 2019.05.27 16:43:11 +0800, Tina Zhang wrote: > Add VFIO_DEVICE_SET_GFX_FLIP_EVENTFD ioctl command to set eventfd > based signaling mechanism to deliver vGPU framebuffer page flip > event to userspace. > Should we add probe to see if driver can support gfx flip event? > Signed-off-by: Tina

Re: [PATCH 7/8] drm/i915/gvt: vGPU device config data save/restore interface

not include dirty pages in system memory produced by vGPU. > > Signed-off-by: Yulei Zhang > Signed-off-by: Xiao Zheng > Signed-off-by: Zhenyu Wang > Signed-off-by: Yan Zhao ... > + > +#ifndef __GVT_MIGRATE_H__ > +#define __GVT_MIGRATE_H__ > + > +#define MIGRATION_DI

Re: [PATCH 1/2] vfio: add edid api for display (vgpu) devices.

On 2018.09.17 10:50:33 +0200, Gerd Hoffmann wrote: > > > +#define VFIO_DEVICE_INFO_CAP_EDID1 > > > + > > > +struct vfio_device_info_edid_cap { > > > + struct vfio_info_cap_header header; > > > + __u32 max_x; /* Max display height (zero == no limit) */ > > > + __u32 max_y; /*

Re: [PATCH 1/2] vfio: add edid api for display (vgpu) devices.

On 2018.09.17 10:50:33 +0200, Gerd Hoffmann wrote: > > > +#define VFIO_DEVICE_INFO_CAP_EDID1 > > > + > > > +struct vfio_device_info_edid_cap { > > > + struct vfio_info_cap_header header; > > > + __u32 max_x; /* Max display height (zero == no limit) */ > > > + __u32 max_y; /*

Re: [PATCH 1/2] vfio: add edid api for display (vgpu) devices.

On 2018.09.14 14:25:52 +0200, Gerd Hoffmann wrote: > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 1aa7b82e81..901f279033 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -200,12 +200,25 @@ struct vfio_device_info { > #define

Re: [PATCH 1/2] vfio: add edid api for display (vgpu) devices.

On 2018.09.14 14:25:52 +0200, Gerd Hoffmann wrote: > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 1aa7b82e81..901f279033 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -200,12 +200,25 @@ struct vfio_device_info { > #define

Re: [PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices

equivalent course grained serialization if > necessary. Of course it would be better to implement that sooner > rather than later if required. > > I see that __intel_gvt_create_vgpu() makes use of gvt->lock, which > would seem to already provide this level of per-parent l

Re: [PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices

gt; rather than later if required. > > I see that __intel_gvt_create_vgpu() makes use of gvt->lock, which > would seem to already provide this level of per-parent locking. The > remove path makes use of this same lock, so I think we're ok, but > looking for an explicit ack so there are no surprises. I'd like > to queue this series for v4.18. Thanks, > yeah, we don't expect mdev core for parent serialization for create and remove of mdev device. Series look good to me. Acked-by: Zhenyu Wang > Alex > > [1] https://lkml.org/lkml/2018/5/18/1035 -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 signature.asc Description: PGP signature

Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs

On 2018.03.22 21:31:33 +, Chris Wilson wrote: > Quoting Gustavo A. R. Silva (2018-03-22 18:21:54) > > The checks are misleading and not required [1]. > > > > [1] https://lkml.org/lkml/2018/3/19/1792 > > > > Addresses-Coverity-ID: 1466017 > > Cc: Chris Wilson > >

Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs

On 2018.03.22 21:31:33 +, Chris Wilson wrote: > Quoting Gustavo A. R. Silva (2018-03-22 18:21:54) > > The checks are misleading and not required [1]. > > > > [1] https://lkml.org/lkml/2018/3/19/1792 > > > > Addresses-Coverity-ID: 1466017 > > Cc: Chris Wilson > > Signed-off-by: Gustavo A. R.

Re: [PATCH][drm-next] drm/i915/gvt: fix spelling mistake: "destoried" -> "destroyed"

On 2018.03.12 12:43:58 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in gvt_err error message text. > > Signed-off-by: Colin Ian King > --- Thanks Colin, will pick up. > drivers/gpu/drm/i915/gvt/gtt.c

Re: [PATCH][drm-next] drm/i915/gvt: fix spelling mistake: "destoried" -> "destroyed"

On 2018.03.12 12:43:58 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in gvt_err error message text. > > Signed-off-by: Colin Ian King > --- Thanks Colin, will pick up. > drivers/gpu/drm/i915/gvt/gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] vfio: Simplify capability helper

am...@redhat.com> > > > Makes more sense now, thanks. I'll repost mine on top of this. > > > Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru> > > Looks good for KVMGT part. Acked-by: Zhenyu Wang <zhen...@linux.intel.com> > Below o

Re: [PATCH] vfio: Simplify capability helper

> Makes more sense now, thanks. I'll repost mine on top of this. > > > Reviewed-by: Alexey Kardashevskiy > > Looks good for KVMGT part. Acked-by: Zhenyu Wang > Below one observation, unrelated to this patch. > > > --- > > drivers/gpu/drm/i915/gvt/kvmgt.c

Re: [PATCH] drm/i915/gvt/fb_decoder: Fix out-of-bounds read

On 2017.12.09 00:37:59 -0600, Gustavo A. R. Silva wrote: > In case function skl_format_to_drm returns -EINVAL, fmt turns into a huge > number as fmt is of type u32, hence there is an out-of-bounds read when > using fmt as an index for array skl_pixel_formats at line 225: > plane->bpp =

Re: [PATCH] drm/i915/gvt/fb_decoder: Fix out-of-bounds read

On 2017.12.09 00:37:59 -0600, Gustavo A. R. Silva wrote: > In case function skl_format_to_drm returns -EINVAL, fmt turns into a huge > number as fmt is of type u32, hence there is an out-of-bounds read when > using fmt as an index for array skl_pixel_formats at line 225: > plane->bpp =

Re: linux-next: Signed-off-by missing for commits in the drm tree

On 2017.12.04 10:57:35 +1100, Stephen Rothwell wrote: > Hi all, > > There is a series of commits > > 54cff6479fd8 - c1802534e5a6 > (not all in that range) > > that are missing a Signed-off-by from their committer. > They were originally committed by Zhi himself, but I had to rebase onto

Re: linux-next: Signed-off-by missing for commits in the drm tree

On 2017.12.04 10:57:35 +1100, Stephen Rothwell wrote: > Hi all, > > There is a series of commits > > 54cff6479fd8 - c1802534e5a6 > (not all in that range) > > that are missing a Signed-off-by from their committer. > They were originally committed by Zhi himself, but I had to rebase onto

Re: [PATCH v18 0/6] drm/i915/gvt: Dma-buf support for GVT-g

On 2017.11.15 11:49:00 +0100, Gerd Hoffmann wrote: > On Wed, Nov 15, 2017 at 05:11:49PM +0800, Tina Zhang wrote: > > v17->v18: > > 1) unmap vgpu's opregion when destroying vgpu. > > 2) update comments for VFIO_DEVICE_GET_GFX_DMABUF. (Alex) > > > This patch set adds the dma-buf support for intel

Re: [PATCH v18 0/6] drm/i915/gvt: Dma-buf support for GVT-g

On 2017.11.15 11:49:00 +0100, Gerd Hoffmann wrote: > On Wed, Nov 15, 2017 at 05:11:49PM +0800, Tina Zhang wrote: > > v17->v18: > > 1) unmap vgpu's opregion when destroying vgpu. > > 2) update comments for VFIO_DEVICE_GET_GFX_DMABUF. (Alex) > > > This patch set adds the dma-buf support for intel

Re: [PATCH v18 5/6] vfio: ABI for mdev display dma-buf operation

On 2017.11.15 11:48:42 -0700, Alex Williamson wrote: > On Wed, 15 Nov 2017 17:11:54 +0800 > Tina Zhang wrote: > > > Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user query and get > > a plane and its information. So far, two types of buffers are supported: > >

Re: [PATCH v18 5/6] vfio: ABI for mdev display dma-buf operation

On 2017.11.15 11:48:42 -0700, Alex Williamson wrote: > On Wed, 15 Nov 2017 17:11:54 +0800 > Tina Zhang wrote: > > > Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user query and get > > a plane and its information. So far, two types of buffers are supported: > > buffers based on dma-buf

Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

On 2017.09.19 19:35:23 -0700, Joe Perches wrote: > On Wed, 2017-09-20 at 05:46 +0800, Zhenyu Wang wrote: > > On 2017.09.19 16:55:34 +0100, Colin King wrote: > > > From: Colin Ian King <colin.k...@canonical.com> > > > > > > An earlier fix changed

Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

On 2017.09.19 19:35:23 -0700, Joe Perches wrote: > On Wed, 2017-09-20 at 05:46 +0800, Zhenyu Wang wrote: > > On 2017.09.19 16:55:34 +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > An earlier fix changed the return type from find_bb_size howev

Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

On 2017.09.19 16:55:34 +0100, Colin King wrote: > From: Colin Ian King > > An earlier fix changed the return type from find_bb_size however the > integer return is being assigned to a unsigned int so the -ve error > check will never be detected. Make bb_size an int to

Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

On 2017.09.19 16:55:34 +0100, Colin King wrote: > From: Colin Ian King > > An earlier fix changed the return type from find_bb_size however the > integer return is being assigned to a unsigned int so the -ve error > check will never be detected. Make bb_size an int to fix this. > > Detected by

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

On 2017.07.11 11:12:36 +0200, Daniel Vetter wrote: > On Tue, Jul 11, 2017 at 08:14:08AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > +struct vfio_device_query_gfx_plane { > > > > + __u32 argsz; > > > > + __u32 flags; > > > > + struct vfio_device_gfx_plane_info plane_info; >

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

On 2017.07.11 11:12:36 +0200, Daniel Vetter wrote: > On Tue, Jul 11, 2017 at 08:14:08AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > +struct vfio_device_query_gfx_plane { > > > > + __u32 argsz; > > > > + __u32 flags; > > > > + struct vfio_device_gfx_plane_info plane_info; >

Re: [PATCH v8 3/6] drm/i915/gvt: Frame buffer decoder support for GVT-g

On 2017.06.09 14:50:39 +0800, Xiaoguang Chen wrote: > decode frambuffer attributes of primary, cursor and sprite plane > > Signed-off-by: Xiaoguang Chen ... > +/** > + * intel_vgpu_decode_primary_plane - Decode primary plane > + * @vgpu: input vgpu > + * @plane:

Re: [PATCH v8 3/6] drm/i915/gvt: Frame buffer decoder support for GVT-g

On 2017.06.09 14:50:39 +0800, Xiaoguang Chen wrote: > decode frambuffer attributes of primary, cursor and sprite plane > > Signed-off-by: Xiaoguang Chen ... > +/** > + * intel_vgpu_decode_primary_plane - Decode primary plane > + * @vgpu: input vgpu > + * @plane: primary plane to save decoded

Re: [PATCH] drm/i915/gvt: remove redundant -Wall

On 2017.05.21 00:15:27 -0700, Nick Desaulniers wrote: > This flag is already set in the top level Makefile of the kernel. > > Also, by having set CONFIG_DRM_I915_GVT, thereby appending -Wall to > ccflags, you undo all the -Wno-* cflags previously set in the Make > variable KBUILD_CFLAGS. > > For

Re: [PATCH] drm/i915/gvt: remove redundant -Wall

On 2017.05.21 00:15:27 -0700, Nick Desaulniers wrote: > This flag is already set in the top level Makefile of the kernel. > > Also, by having set CONFIG_DRM_I915_GVT, thereby appending -Wall to > ccflags, you undo all the -Wno-* cflags previously set in the Make > variable KBUILD_CFLAGS. > > For

Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g

On 2017.05.31 06:22:28 +, Chen, Xiaoguang wrote: > >> @@ -467,6 +555,15 @@ static int intel_vgpu_create(struct kobject *kobj, > >struct mdev_device *mdev) > >>vgpu->vdev.mdev = mdev; > >>mdev_set_drvdata(mdev, vgpu); > >> > >> + ret = intel_vgpu_reg_init_opregion(vgpu); > >> + if

Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g

On 2017.05.31 06:22:28 +, Chen, Xiaoguang wrote: > >> @@ -467,6 +555,15 @@ static int intel_vgpu_create(struct kobject *kobj, > >struct mdev_device *mdev) > >>vgpu->vdev.mdev = mdev; > >>mdev_set_drvdata(mdev, vgpu); > >> > >> + ret = intel_vgpu_reg_init_opregion(vgpu); > >> + if

Re: [PATCH v6 3/6] drm/i915/gvt: Frame buffer decoder support for GVT-g

On 2017.05.27 16:38:49 +0800, Xiaoguang Chen wrote: > decode frambuffer attributes of primary, cursor and sprite plane > > Signed-off-by: Xiaoguang Chen > --- > drivers/gpu/drm/i915/gvt/Makefile | 3 +- > drivers/gpu/drm/i915/gvt/display.c| 2 +- >

Re: [PATCH v6 3/6] drm/i915/gvt: Frame buffer decoder support for GVT-g

On 2017.05.27 16:38:49 +0800, Xiaoguang Chen wrote: > decode frambuffer attributes of primary, cursor and sprite plane > > Signed-off-by: Xiaoguang Chen > --- > drivers/gpu/drm/i915/gvt/Makefile | 3 +- > drivers/gpu/drm/i915/gvt/display.c| 2 +- > drivers/gpu/drm/i915/gvt/display.h

Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g

On 2017.05.27 16:38:48 +0800, Xiaoguang Chen wrote: > OpRegion is needed to support display related operation for > intel vgpu. > > A vfio device region is added to intel vgpu to deliver the > host OpRegion information to user space so user space can > construct the OpRegion for vgpu. > >

Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g

On 2017.05.27 16:38:48 +0800, Xiaoguang Chen wrote: > OpRegion is needed to support display related operation for > intel vgpu. > > A vfio device region is added to intel vgpu to deliver the > host OpRegion information to user space so user space can > construct the OpRegion for vgpu. > >

Re: [PATCH] drm/i915/gvt: fix typo: "supporte" -> "support"

On 2017.04.25 10:05:12 +0100, Colin King wrote: > From: Colin Ian King > > trivial fix to typo in WARN_ONCE message > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/gvt/handlers.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/i915/gvt: fix typo: "supporte" -> "support"

On 2017.04.25 10:05:12 +0100, Colin King wrote: > From: Colin Ian King > > trivial fix to typo in WARN_ONCE message > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/gvt/handlers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] drm/i915: disable KASAN for handlers

;jsl...@suse.cz> > Cc: Martin Liska <mli...@suse.cz> > Cc: Zhenyu Wang <zhen...@linux.intel.com> > Cc: Zhi Wang <zhi.a.w...@intel.com> > Cc: Daniel Vetter <daniel.vet...@intel.com> > Cc: Jani Nikula <jani.nik...@linux.intel.com> > Cc: David Airlie &

Re: [PATCH] drm/i915: disable KASAN for handlers

er-than=] > > It is due to many expansions of MMIO_* macros in init_generic_mmio_info. > INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an > offset. There are too many for KASAN to keep up. > > So disable KASAN for this file. > > Signed-off-by: Jiri Slaby

Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

On 2017.03.23 14:43:44 +0100, Frans Klaver wrote: > On Thu, Mar 23, 2017 at 1:22 PM, Colin King wrote: > > From: Colin Ian King > > > > info is being checked to see if it is a null pointer, however, vpgu is > > dereferencing info before this

Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

On 2017.03.23 14:43:44 +0100, Frans Klaver wrote: > On Thu, Mar 23, 2017 at 1:22 PM, Colin King wrote: > > From: Colin Ian King > > > > info is being checked to see if it is a null pointer, however, vpgu is > > dereferencing info before this check, leading to a potential null > > pointer

Re: [PATCH] kvmgt: Hold struct kvm reference

..@redhat.com> > > Cc: sta...@vger.kernel.org #v4.10 > > Cc: Jike Song <jike.s...@intel.com> > > Cc: Paolo Bonzini <pbonz...@redhat.com> > > Cc: Zhenyu Wang <zhen...@linux.intel.com> > > Cc: Zhi Wang <zhi.a.w...@intel.com> > > --- > >

Re: [PATCH] kvmgt: Hold struct kvm reference

reference. The observed failure in this case is a stuck > > cpu trying to acquire the spinlock from the invalid reference, but > > other failure modes are clearly possible. Hold a reference to avoid > > this. > > > > Signed-off-by: Alex Williamson > > Cc: sta..

Re: [igvt-g-dev] [PATCH] drm/i915/gvt: Fix kmem_cache_create() name

On 2017.01.24 13:15:43 -0700, Alex Williamson wrote: > According to kmem_cache_sanity_check(), spaces are not allowed in the > name of a cache and results in a kernel oops with CONFIG_DEBUG_VM. > Convert to underscores. > > Signed-off-by: Alex Williamson > --- Will

Re: [igvt-g-dev] [PATCH] drm/i915/gvt: Fix kmem_cache_create() name

On 2017.01.24 13:15:43 -0700, Alex Williamson wrote: > According to kmem_cache_sanity_check(), spaces are not allowed in the > name of a cache and results in a kernel oops with CONFIG_DEBUG_VM. > Convert to underscores. > > Signed-off-by: Alex Williamson > --- Will send to 4.10 fixes. Thanks!

Re: [igvt-g-dev] [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance

On 2017.01.24 12:53:45 -0700, Alex Williamson wrote: > Per the ABI specification[1], each mdev_supported_types entry should > have an available_instances, with an "s", not available_instance. > > [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev > > Signed-off-by: Alex Williamson

Re: [igvt-g-dev] [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance

On 2017.01.24 12:53:45 -0700, Alex Williamson wrote: > Per the ABI specification[1], each mdev_supported_types entry should > have an available_instances, with an "s", not available_instance. > > [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev > > Signed-off-by: Alex Williamson > --- > >

Re: linux-next: build failure after merge of the drm-intel-fixes tree

On 2017.01.02 21:48:57 -0700, Alex Williamson wrote: > > Alex, I liked to have kvmgt related mdev interface change be merged through > > vfio tree, but wasn't awared one of Jike's fix had conflict. Could you apply > > below fix in your tree? I think in general for possible interface change in > >

Re: linux-next: build failure after merge of the drm-intel-fixes tree

On 2017.01.02 21:48:57 -0700, Alex Williamson wrote: > > Alex, I liked to have kvmgt related mdev interface change be merged through > > vfio tree, but wasn't awared one of Jike's fix had conflict. Could you apply > > below fix in your tree? I think in general for possible interface change in > >

Re: linux-next: build failure after merge of the drm-intel-fixes tree

On 2017.01.03 10:42:39 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel-fixes tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/i915/gvt/kvmgt.c: In function 'intel_vgpu_open': > drivers/gpu/drm/i915/gvt/kvmgt.c:511:32: error:

Re: linux-next: build failure after merge of the drm-intel-fixes tree

On 2017.01.03 10:42:39 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel-fixes tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/i915/gvt/kvmgt.c: In function 'intel_vgpu_open': > drivers/gpu/drm/i915/gvt/kvmgt.c:511:32: error:

Re: [igvt-g-dev] [PATCH 1/1] drm/i915/gvt: verify functions types in new_mmio_info()

On 2016.12.26 14:52:23 +0100, Nicolas Iooss wrote: > The current prototype of new_mmio_info() uses void* for parameters read > and write, which are functions with precise calling conventions > (argument types and return type). Write down these conventions in > new_mmio_info() definition. > > This

Re: [igvt-g-dev] [PATCH 1/1] drm/i915/gvt: verify functions types in new_mmio_info()

On 2016.12.26 14:52:23 +0100, Nicolas Iooss wrote: > The current prototype of new_mmio_info() uses void* for parameters read > and write, which are functions with precise calling conventions > (argument types and return type). Write down these conventions in > new_mmio_info() definition. > > This

[RESEND][GIT PULL] i915/gvt KVMGT tree for 4.10

Hi, Linus This is KVMGT pull for 4.10 as explained by Daniel. The last minute rebase is to appease git pull-request since the diffstat was obvious bonghits and somehow included vfio/mdev again despite that was merged already. Thanks. The following changes since commit

[RESEND][GIT PULL] i915/gvt KVMGT tree for 4.10

Hi, Linus This is KVMGT pull for 4.10 as explained by Daniel. The last minute rebase is to appease git pull-request since the diffstat was obvious bonghits and somehow included vfio/mdev again despite that was merged already. Thanks. The following changes since commit

Re: [PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

On 2016.12.04 23:57:18 +, Eric Engestrom wrote: > 90d27a1 moved the lock before this error path but forgot to add an > unlock here. > > Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread") > Cc: Pei Zhang <pei.zh...@intel.

Re: [PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

On 2016.12.04 23:57:18 +, Eric Engestrom wrote: > 90d27a1 moved the lock before this error path but forgot to add an > unlock here. > > Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread") > Cc: Pei Zhang > Cc: Zhenyu Wang > Signed-of

Re: [PATCH v14 00/22] Add Mediated device support

On 2016.11.17 16:51:45 -0700, Alex Williamson wrote: > On Thu, 17 Nov 2016 23:29:38 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Friday, November 18, 2016 5:25 AM > > > > > > On Thu, 17 Nov 2016 02:16:12 +0530 >

Re: [PATCH v14 00/22] Add Mediated device support

On 2016.11.17 16:51:45 -0700, Alex Williamson wrote: > On Thu, 17 Nov 2016 23:29:38 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Friday, November 18, 2016 5:25 AM > > > > > > On Thu, 17 Nov 2016 02:16:12 +0530 > > > Kirti Wankhede

Re: [PATCH 2/2] drm/i915/gvt: fix compilation

On 2016.10.21 17:25:50 +0200, Arnd Bergmann wrote: > Two functions in the newly added gvt render code are obviously > broken, as they reference a variable without initialization and > don't reference another variable at all: > > drivers/gpu/drm/i915/gvt/render.c: In function >

Re: [PATCH 2/2] drm/i915/gvt: fix compilation

On 2016.10.21 17:25:50 +0200, Arnd Bergmann wrote: > Two functions in the newly added gvt render code are obviously > broken, as they reference a variable without initialization and > don't reference another variable at all: > > drivers/gpu/drm/i915/gvt/render.c: In function >

Re: [PATCH 1/2] drm/i915/gvt: add ACPI and 64BIT dependencies

On 2016.10.21 17:25:49 +0200, Arnd Bergmann wrote: > The newly added gvt code produces lots of serious warnings and errors > when either built on 32-bit x86, or built with ACPI disabled, e.g. > > drivers/gpu/drm/i915/gvt/gtt.c: In function ???read_pte64???: > drivers/gpu/drm/i915/gvt/gtt.c:277:2:

Re: [PATCH 1/2] drm/i915/gvt: add ACPI and 64BIT dependencies

On 2016.10.21 17:25:49 +0200, Arnd Bergmann wrote: > The newly added gvt code produces lots of serious warnings and errors > when either built on 32-bit x86, or built with ACPI disabled, e.g. > > drivers/gpu/drm/i915/gvt/gtt.c: In function ???read_pte64???: > drivers/gpu/drm/i915/gvt/gtt.c:277:2:

Re: [Intel-gfx] linux-next: Tree for Oct 20 (gpu/drm/i915)

On 2016.10.20 21:25:03 +0300, Jani Nikula wrote: > On Thu, 20 Oct 2016, Daniel Vetter wrote: > > On Thu, Oct 20, 2016 at 7:37 PM, Randy Dunlap wrote: > >> On 10/19/16 20:20, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20161019: > >>> >

Re: [Intel-gfx] linux-next: Tree for Oct 20 (gpu/drm/i915)

On 2016.10.20 21:25:03 +0300, Jani Nikula wrote: > On Thu, 20 Oct 2016, Daniel Vetter wrote: > > On Thu, Oct 20, 2016 at 7:37 PM, Randy Dunlap wrote: > >> On 10/19/16 20:20, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20161019: > >>> > >> > >> on i386: when CONFIG_ACPI is not

Re: [PATCH -next] drm/i915/gvt: fix return value check

On 2016.10.19 16:18:03 +, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function i915_gem_object_create() returns > ERR_PTR() not NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun

Re: [PATCH -next] drm/i915/gvt: fix return value check

On 2016.10.19 16:18:03 +, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function i915_gem_object_create() returns > ERR_PTR() not NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Hi, Yongjun, we've already

Re: linux-next: build warnings after merge of the drm-intel tree

On 2016.10.19 10:57:53 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel tree, today's linux-next build (x86_64 > allmodconfig) produced these warnings: > > drivers/gpu/drm/i915/gvt/execlist.c: In function > 'release_shadow_batch_buffer': >

Re: linux-next: build warnings after merge of the drm-intel tree

On 2016.10.19 10:57:53 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel tree, today's linux-next build (x86_64 > allmodconfig) produced these warnings: > > drivers/gpu/drm/i915/gvt/execlist.c: In function > 'release_shadow_batch_buffer': >

Re: [RFC 0/6] Non perf based Gen Graphics OA unit driver

On 2015.09.29 15:39:03 +0100, Robert Bragg wrote: > > - Logistically it might be more practical to contain this to the > graphics stack. > > It seems fair to consider that if we can't see a very compelling > benefit to building on perf, then containing this work to >

Re: [RFC 0/6] Non perf based Gen Graphics OA unit driver

On 2015.09.29 15:39:03 +0100, Robert Bragg wrote: > > - Logistically it might be more practical to contain this to the > graphics stack. > > It seems fair to consider that if we can't see a very compelling > benefit to building on perf, then containing this work to >

Re: [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

; > So we just go back to check devfn to make life normal. > > Signed-off-by: Tiejun Chen This was added historically when supporting graphics device passthrough. Looks qemu upstream can't accept multiple ISA bridge and our PCH is always on device 31: func0 as far as I know. Looks good to

Re: [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

...@intel.com This was added historically when supporting graphics device passthrough. Looks qemu upstream can't accept multiple ISA bridge and our PCH is always on device 31: func0 as far as I know. Looks good to me. Reviewed-by: Zhenyu Wang zhen...@linux.intel.com -- Open Source Technology Center, Intel

Re: [agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

On 2008.01.25 10:08:20 -0800, mark gross wrote: > > This is used for our graphics driver module to know if we have to > > do dma remapping in iommu case, both in kernel config and kernel > > boot time param config. > > ok. How soon do you need this export? > As graphics part of these patches

  1   2   >