[PATCH v2 01/15] nls: Wrap uni2char/char2uni callers

Generated with the following coccinele script: @@ expression A, B, C, D; @@ ( - A->uni2char(B, C, D) + nls_uni2char(A, B, C, D) | - A->char2uni(B, C, D) + nls_char2uni(A, B, C, D) ) Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk> --- drivers/staging/ncpfs/ncp

[PATCH v2 02/15] nls: Wrap charset field access

Which will simplify further patches. No behavior changes intended. @@ struct nls_table *c; @@ - c->charset + nls_charset_name(c) Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk> --- drivers/staging/ncpfs/ioctl.c | 13 +++-- fs/befs/linuxvfs.c

[PATCH v2 00/15] NLS refactor and UTF-8 normalization

not going to fix at this time. please refer to v1, for more information. If you are interested in fetching everything with minimal effort, you can clone a branch from: https://gitlab.collabora.com/krisman/linux.git -b nls-merge-int Changes since v1: - Fix nls_base.ko module build Gabriel

[PATCH v2 01/15] nls: Wrap uni2char/char2uni callers

Generated with the following coccinele script: @@ expression A, B, C, D; @@ ( - A->uni2char(B, C, D) + nls_uni2char(A, B, C, D) | - A->char2uni(B, C, D) + nls_char2uni(A, B, C, D) ) Signed-off-by: Gabriel Krisman Bertazi --- drivers/staging/ncpfs/ncplib_kernel.c | 8 f

[PATCH v2 02/15] nls: Wrap charset field access

Which will simplify further patches. No behavior changes intended. @@ struct nls_table *c; @@ - c->charset + nls_charset_name(c) Signed-off-by: Gabriel Krisman Bertazi --- drivers/staging/ncpfs/ioctl.c | 13 +++-- fs/befs/linuxvfs.c| 4 ++-- fs/cifs/cifs_unicod

smpboot seems to be confused on dual EPYC system

s, 64 CPUs [0.562171] smpboot: Max logical packages: 4 [0.562171] smpboot: Total of 64 processors activated (268089.53 BogoMIPS) Can someone have a look ? Best Regards, Gabriel C

smpboot seems to be confused on dual EPYC system

s, 64 CPUs [0.562171] smpboot: Max logical packages: 4 [0.562171] smpboot: Total of 64 processors activated (268089.53 BogoMIPS) Can someone have a look ? Best Regards, Gabriel C

Re: [PATCH] clk: stm32mp1: Add CLK_IGNORE_UNUSED to ck_sys_dbg clock

Thanks Stephen On 05/15/2018 08:23 PM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-04-24 00:58:43) >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> Don't disable the dbg clock if was set by bootloader. >> >> Signed-off-by: Gabr

Re: [PATCH] clk: stm32mp1: Add CLK_IGNORE_UNUSED to ck_sys_dbg clock

Thanks Stephen On 05/15/2018 08:23 PM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-04-24 00:58:43) >> From: Gabriel Fernandez >> >> Don't disable the dbg clock if was set by bootloader. >> >> Signed-off-by: Gabriel Fernandez >> --- > Applied to clk-next >

Re: commit bd9240a18edfbfa72e957fc2ba831cf1f13ea073 seems to break with intel-ucode 20180425

2018-05-14 14:58 GMT+02:00 Peter Zijlstra <pet...@infradead.org>: > On Mon, May 14, 2018 at 02:15:44PM +0200, Gabriel C wrote: >> http://ftp.frugalware.org/pub/other/people/crazy/ucode/cpuinfo-ucode-20180312 >> http://ftp.frugalware.org/pub/other/people/crazy/ucode/c

Re: commit bd9240a18edfbfa72e957fc2ba831cf1f13ea073 seems to break with intel-ucode 20180425

2018-05-14 14:58 GMT+02:00 Peter Zijlstra : > On Mon, May 14, 2018 at 02:15:44PM +0200, Gabriel C wrote: >> http://ftp.frugalware.org/pub/other/people/crazy/ucode/cpuinfo-ucode-20180312 >> http://ftp.frugalware.org/pub/other/people/crazy/ucode/cpuinfo-ucode-20180425 > >

Re: commit bd9240a18edfbfa72e957fc2ba831cf1f13ea073 seems to break with intel-ucode 20180425

2018-05-14 9:23 GMT+02:00 Peter Zijlstra <pet...@infradead.org>: > On Sat, May 12, 2018 at 12:55:35PM +0200, Gabriel C wrote: >> Hi Peter, >> >> after updating ucode to 20180425 on my laptop I always hit the >> 'TSC_DEADLINE disabled' error and so early micr

Re: commit bd9240a18edfbfa72e957fc2ba831cf1f13ea073 seems to break with intel-ucode 20180425

2018-05-14 9:23 GMT+02:00 Peter Zijlstra : > On Sat, May 12, 2018 at 12:55:35PM +0200, Gabriel C wrote: >> Hi Peter, >> >> after updating ucode to 20180425 on my laptop I always hit the >> 'TSC_DEADLINE disabled' error and so early microcode update from >> inird br

Re: clk: stm32mp1: Fix a memory leak in 'clk_stm32_register_gate_ops()'

Hi Christophe, Many thanks ! Acked-by: Gabriel Fernandez <gabriel.fernan...@st.com> On 05/13/2018 01:17 PM, Christophe Jaillet wrote: > We allocate some memory which is neither used, nor referenced by anything. > So axe it. > > Signed-off-by: Christophe JAILLET <christop

Re: clk: stm32mp1: Fix a memory leak in 'clk_stm32_register_gate_ops()'

Hi Christophe, Many thanks ! Acked-by: Gabriel Fernandez On 05/13/2018 01:17 PM, Christophe Jaillet wrote: > We allocate some memory which is neither used, nor referenced by anything. > So axe it. > > Signed-off-by: Christophe JAILLET > --- > This patch as not been compi

commit bd9240a18edfbfa72e957fc2ba831cf1f13ea073 seems to break with intel-ucode 20180425

cpuid _fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves ibpb ibrs stibp dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp Best Regards, Gabriel C

commit bd9240a18edfbfa72e957fc2ba831cf1f13ea073 seems to break with intel-ucode 20180425

cpuid _fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves ibpb ibrs stibp dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp Best Regards, Gabriel C

Re: [PATCH] clk: stm32mp1: Add CLK_IGNORE_UNUSED to ck_sys_dbg clock

Hi Stephen, This patch is not a critical fix for this merge window. Thanks Gabriel On 05/02/2018 12:10 AM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-04-24 00:58:43) >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> Don't disab

Re: [PATCH] clk: stm32mp1: Add CLK_IGNORE_UNUSED to ck_sys_dbg clock

Hi Stephen, This patch is not a critical fix for this merge window. Thanks Gabriel On 05/02/2018 12:10 AM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-04-24 00:58:43) >> From: Gabriel Fernandez >> >> Don't disable the dbg clock if was set by bootloa

Re: [PATCH 2/2] hwmon: (k10temp) Use API function to access System Management Network

2018-04-29 19:46 GMT+02:00 Guenter Roeck : > On 04/28/2018 06:54 PM, Guenter Roeck wrote: >> >> The SMN (System Management Network) on Family 17h AMD CPUs is also >> accessed >> from other drivers, specifically EDAC. Accessing it directly is racy. >> On top of that, accessing

Re: [PATCH 2/2] hwmon: (k10temp) Use API function to access System Management Network

2018-04-29 19:46 GMT+02:00 Guenter Roeck : > On 04/28/2018 06:54 PM, Guenter Roeck wrote: >> >> The SMN (System Management Network) on Family 17h AMD CPUs is also >> accessed >> from other drivers, specifically EDAC. Accessing it directly is racy. >> On top of that, accessing the SMN through root

Re: [PATCH] hwmon: (k10temp) Add support for Stoney Ridge and Bristol Ridge CPUs

{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_DF_F3) }, > -- > 2.7.4 > Is working fine for me on an A6-9220 APU. Tested-by: Gabriel Craciunescu <nix.or@gmail.com> Regards

Re: [PATCH] hwmon: (k10temp) Add support for Stoney Ridge and Bristol Ridge CPUs

t; { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M60H_NB_F3) }, > + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M70H_NB_F3) }, > { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_NB_F3) }, > { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F3) }, > { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_DF_F3) }, > -- > 2.7.4 > Is working fine for me on an A6-9220 APU. Tested-by: Gabriel Craciunescu Regards

Re: [PATCH 2/2] hwmon: (k10temp) Display both Tctl and Tdie

tr_temp2_label.dev_attr.attr, > NULL > }; > > @@ -292,6 +332,7 @@ static int k10temp_probe(struct pci_dev *pdev, > } else if (boot_cpu_data.x86 == 0x17) { > data->temp_adjust_mask = 0x8; > data->read_tempreg = read_tempreg_nb_f17; > + data->show_tdie = true; > } else { > data->read_htcreg = read_htcreg_pci; > data->read_tempreg = read_tempreg_pci; > -- > 2.7.4 > On my EPYC box Tdie and Tctl seems to have the same value. However the code is working fine and both values are displayed now. Tested-by: Gabriel Craciunescu <nix.or@gmail.com> Regards

Re: [PATCH 2/2] hwmon: (k10temp) Display both Tctl and Tdie

gt; }; > > @@ -292,6 +332,7 @@ static int k10temp_probe(struct pci_dev *pdev, > } else if (boot_cpu_data.x86 == 0x17) { > data->temp_adjust_mask = 0x8; > data->read_tempreg = read_tempreg_nb_f17; > + data->show_tdie = true; > } else { > data->read_htcreg = read_htcreg_pci; > data->read_tempreg = read_tempreg_pci; > -- > 2.7.4 > On my EPYC box Tdie and Tctl seems to have the same value. However the code is working fine and both values are displayed now. Tested-by: Gabriel Craciunescu Regards

Re: [PATCH v2] hwmon: (k10temp) Fix reading critical temperature register

_htcreg_nb_f15; > data->read_tempreg = read_tempreg_nb_f15; > } else if (boot_cpu_data.x86 == 0x17) { > data->temp_adjust_mask = 0x8; > data->read_tempreg = read_tempreg_nb_f17; > } else { > + data->read_htcreg = read_htcreg_pci; > data->read_tempreg = read_tempreg_pci; > } > > -- > 2.7.4 > Tested on 4.17.0-rc2-00398-gcdface520934 , works fine for me. Tested-by: Gabriel Craciunescu <nix.or@gmail.com> Regards

Re: [PATCH v2] hwmon: (k10temp) Fix reading critical temperature register

= read_tempreg_nb_f15; > } else if (boot_cpu_data.x86 == 0x17) { > data->temp_adjust_mask = 0x8; > data->read_tempreg = read_tempreg_nb_f17; > } else { > + data->read_htcreg = read_htcreg_pci; > data->read_tempreg = read_tempreg_pci; > } > > -- > 2.7.4 > Tested on 4.17.0-rc2-00398-gcdface520934 , works fine for me. Tested-by: Gabriel Craciunescu Regards

Re: [PATCH 2/2] hwmon: (k10temp) Use API function to access System Management Network

CE_ID_AMD_17H_RR_NB) }, > + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_RR_DF_F3) }, > {} > }; > MODULE_DEVICE_TABLE(pci, k10temp_id_table); > -- > 2.7.4 > Works fine for me on top stable and on top v4.17-rc2-398-gcdface520934 Tested-by: Gabriel Craciunescu <nix.or@gmail.com> Regards

Re: [PATCH 2/2] hwmon: (k10temp) Use API function to access System Management Network

AMD, PCI_DEVICE_ID_AMD_17H_RR_DF_F3) }, > {} > }; > MODULE_DEVICE_TABLE(pci, k10temp_id_table); > -- > 2.7.4 > Works fine for me on top stable and on top v4.17-rc2-398-gcdface520934 Tested-by: Gabriel Craciunescu Regards

Re: [PATCH 1/2] x86/amd_nb: Add support for Raven Ridge CPUs

I_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F4) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_DF_F4) }, > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_RR_DF_F4) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CNB17H_F4) }, > {} > }; > -- > 2.7.4 > Works fine for me on top stable and on top v4.17-rc2-398-gcdface520934 Tested-by: Gabriel Craciunescu <nix.or@gmail.com> Regards

Re: [PATCH 1/2] x86/amd_nb: Add support for Raven Ridge CPUs

NB_F4) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_DF_F4) }, > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_RR_DF_F4) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CNB17H_F4) }, > {} > }; > -- > 2.7.4 > Works fine for me on top stable and on top v4.17-rc2-398-gcdface520934 Tested-by: Gabriel Craciunescu Regards

Re: [PATCH 1/2] x86/amd_nb: Add support for Raven Ridge CPUs

I_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F4) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_DF_F4) }, > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_RR_DF_F4) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CNB17H_F4) }, > {} > }; > -- > 2.7.4 > Works fine for me on top stable and on top v4.17-rc2-398-gcdface520934 Tested-by: Gabriel Craciunescu <nix.or@gmail.com> Regards

Re: [PATCH 1/2] x86/amd_nb: Add support for Raven Ridge CPUs

NB_F4) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_DF_F4) }, > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_17H_RR_DF_F4) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CNB17H_F4) }, > {} > }; > -- > 2.7.4 > Works fine for me on top stable and on top v4.17-rc2-398-gcdface520934 Tested-by: Gabriel Craciunescu Regards

Re: [RFC] Passing luks passphrase from grub to systemd

ht be sensible). I'd also be thankful for comments how this might be > implemented in a better way. Somethng like this is not needed. All that is possible already from userspace. Systemd can do that on his own ( see systemd-cryptsetup-generator ) ( other init ofc too ) assuming your initrd , cryptsetup and grub is setup correctly. Regards, Gabriel C

Re: [RFC] Passing luks passphrase from grub to systemd

I'd also be thankful for comments how this might be > implemented in a better way. Somethng like this is not needed. All that is possible already from userspace. Systemd can do that on his own ( see systemd-cryptsetup-generator ) ( other init ofc too ) assuming your initrd , cryptsetup and grub is setup correctly. Regards, Gabriel C

Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

On Wed, Apr 11, 2018 at 10:18:38AM +0100, Ian Abbott wrote: > On 10/04/18 23:50, Gabriel Francisco Mandaji wrote: > >Fix most checkpatch.pl issues of type: > > > >CHECK: Alignment should match open parenthesis > >--- > Looks good, thanks. I guess the remaining case o

Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

On Wed, Apr 11, 2018 at 10:18:38AM +0100, Ian Abbott wrote: > On 10/04/18 23:50, Gabriel Francisco Mandaji wrote: > >Fix most checkpatch.pl issues of type: > > > >CHECK: Alignment should match open parenthesis > >--- > Looks good, thanks. I guess the remaining case o

Re: AMD graphics performance regression in 4.15 and later

2018-04-12 0:20 GMT+02:00 Gabriel C <nix.or@gmail.com>: > 2018-04-11 20:35 GMT+02:00 Jean-Marc Valin <jmva...@mozilla.com>: >> On 04/11/2018 05:37 AM, Christian König wrote: >>>> With your patches my EPYC box is unusable with 4.15++ kernels. >>>>

Re: AMD graphics performance regression in 4.15 and later

2018-04-12 0:20 GMT+02:00 Gabriel C : > 2018-04-11 20:35 GMT+02:00 Jean-Marc Valin : >> On 04/11/2018 05:37 AM, Christian König wrote: >>>> With your patches my EPYC box is unusable with 4.15++ kernels. >>>> The whole Desktop is acting weird. This one is using

Re: AMD graphics performance regression in 4.15 and later

op of it. > > Well, the hardware appears to be part of the issue too. I don't think > it's a coincidence that Gabriel has the problem on 2xEPYC, I have it on > 2xXeon and the previous reported had it on a Core 2 Quad that internally > has two dies. > > I've not yet tested your

Re: AMD graphics performance regression in 4.15 and later

Well, the hardware appears to be part of the issue too. I don't think > it's a coincidence that Gabriel has the problem on 2xEPYC, I have it on > 2xXeon and the previous reported had it on a Core 2 Quad that internally > has two dies. > > I've not yet tested your disable CONFIG_SWIOTLB fix

Re: AMD graphics performance regression in 4.15 and later

2018-04-11 16:26 GMT+02:00 Gabriel C <nix.or@gmail.com>: > 2018-04-11 11:37 GMT+02:00 Christian König <christian.koe...@amd.com>: >> Am 11.04.2018 um 06:00 schrieb Gabriel C: ... >> >> Please test Alex's amd-staging-drm-next branch from >> git://peopl

Re: AMD graphics performance regression in 4.15 and later

2018-04-11 16:26 GMT+02:00 Gabriel C : > 2018-04-11 11:37 GMT+02:00 Christian König : >> Am 11.04.2018 um 06:00 schrieb Gabriel C: ... >> >> Please test Alex's amd-staging-drm-next branch from >> git://people.freedesktop.org/~agd5f/linux. > > I'm on it just

Re: AMD graphics performance regression in 4.15 and later

2018-04-11 11:37 GMT+02:00 Christian König <christian.koe...@amd.com>: > Am 11.04.2018 um 06:00 schrieb Gabriel C: >> >> 2018-04-09 11:42 GMT+02:00 Christian König >> <ckoenig.leichtzumer...@gmail.com>: >>> >>> Am 07.04.2018 um 00

Re: AMD graphics performance regression in 4.15 and later

2018-04-11 11:37 GMT+02:00 Christian König : > Am 11.04.2018 um 06:00 schrieb Gabriel C: >> >> 2018-04-09 11:42 GMT+02:00 Christian König >> : >>> >>> Am 07.04.2018 um 00:00 schrieb Jean-Marc Valin: >>>> >>>> Hi Christian, >

Re: AMD graphics performance regression in 4.15 and later

>2018-04-11 6:00 GMT+02:00 Gabriel C <nix.or@gmail.com>: > 2018-04-09 11:42 GMT+02:00 Christian König <ckoenig.leichtzumer...@gmail.com>: >> Am 07.04.2018 um 00:00 schrieb Jean-Marc Valin: ... > I can help testing code for 4.17/++ if you wish but that is *different*

Re: AMD graphics performance regression in 4.15 and later

>2018-04-11 6:00 GMT+02:00 Gabriel C : > 2018-04-09 11:42 GMT+02:00 Christian König : >> Am 07.04.2018 um 00:00 schrieb Jean-Marc Valin: ... > I can help testing code for 4.17/++ if you wish but that is *different* > storry. > Quick tested an 4.16.0-11490-gb284d4d5a678 , amd

Re: AMD graphics performance regression in 4.15 and later

rland with your patches and at least please fix that for 4.16. I can help testing code for 4.17/++ if you wish but that is *different* storry. Regards, Gabriel C

Re: AMD graphics performance regression in 4.15 and later

; code path. > > Just look out for "#ifdef CONFIG_SWIOTLB" checks and disable those. > Well you really can't be serious about these suggestions ? Are you ? Telling peoples to #if 0 random code is not a solution. You broke existsing working userland with your patches and at least please fix that for 4.16. I can help testing code for 4.17/++ if you wish but that is *different* storry. Regards, Gabriel C

[PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

Fix most checkpatch.pl issues of type: CHECK: Alignment should match open parenthesis Signed-off-by: Gabriel Francisco Mandaji <gfmand...@gmail.com> --- drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/

[PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

Fix most checkpatch.pl issues of type: CHECK: Alignment should match open parenthesis Signed-off-by: Gabriel Francisco Mandaji --- drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c

Re: Did kernel 3.11 never work?

2018-03-23 16:50 GMT+01:00 Gabriel C <nix.or@gmail.com>: ... > Maybe have a look there ? > https://github.com/rapier1 > Latest kernel there is an 4.10 https://github.com/rapier1/web10g/releases/tag/kis-0.12-4.10

Re: Did kernel 3.11 never work?

2018-03-23 16:50 GMT+01:00 Gabriel C : ... > Maybe have a look there ? > https://github.com/rapier1 > Latest kernel there is an 4.10 https://github.com/rapier1/web10g/releases/tag/kis-0.12-4.10

Re: Did kernel 3.11 never work?

ned by Ben. You can try this one, maybe it'll work, who > knows. > I don't really remeber but some TCP_ESTATS_* exists in 4.x kernels. So some based-on or these patches got somewho merged. Also some work is still done from Chris Rapier on github. Maybe have a look there ? https://github.com/rapier1 Regards, Gabriel C

Re: Did kernel 3.11 never work?

n try this one, maybe it'll work, who > knows. > I don't really remeber but some TCP_ESTATS_* exists in 4.x kernels. So some based-on or these patches got somewho merged. Also some work is still done from Chris Rapier on github. Maybe have a look there ? https://github.com/rapier1 Regards, Gabriel C

Re: [PATCH RESEND 2/2] clk: stm32: Add DSI clock for STM32F469 Board

Thanks Stephen ! Best Regards Gabriel On 03/19/2018 09:45 PM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-03-08 22:57:31) >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> This patch adds DSI clock for STM32F469 board >> &g

Re: [PATCH RESEND 2/2] clk: stm32: Add DSI clock for STM32F469 Board

Thanks Stephen ! Best Regards Gabriel On 03/19/2018 09:45 PM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-03-08 22:57:31) >> From: Gabriel Fernandez >> >> This patch adds DSI clock for STM32F469 board >> >> Signed-off-by: Gabriel Fernandez >> --- > Applied to clk-next >

Re: [PATCH v3 1/2] dt-bindings: reset: add STM32MP1 resets

Many Thanks Philipp, Best Regards Gabriel On 03/19/2018 10:02 AM, Philipp Zabel wrote: > Hi Gabriel, > > On Mon, 2018-03-19 at 08:25 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> This patch adds the

Re: [PATCH v3 1/2] dt-bindings: reset: add STM32MP1 resets

Many Thanks Philipp, Best Regards Gabriel On 03/19/2018 10:02 AM, Philipp Zabel wrote: > Hi Gabriel, > > On Mon, 2018-03-19 at 08:25 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch adds the reset binding entry for STM32MP1 &

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Philipp, Thanks for reviewing. On 03/16/2018 02:29 PM, Philipp Zabel wrote: > Hi Gabriel, > > this looks mostly good to me, a few questions and comments below: > > On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez <

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Philipp, Thanks for reviewing. On 03/16/2018 02:29 PM, Philipp Zabel wrote: > Hi Gabriel, > > this looks mostly good to me, a few questions and comments below: > > On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >&g

Re: [PATCH 0/2] Introduce STM32MP1 Reset driver

Hi Philipp, Okay, i too support the idea to add custom  reset driver. Many Thanks Philipp. Best regards Gabriel On 03/14/2018 10:12 AM, Philipp Zabel wrote: > Hi Gabriel, > > On Tue, 2018-03-13 at 17:34 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez

Re: [PATCH 0/2] Introduce STM32MP1 Reset driver

Hi Philipp, Okay, i too support the idea to add custom  reset driver. Many Thanks Philipp. Best regards Gabriel On 03/14/2018 10:12 AM, Philipp Zabel wrote: > Hi Gabriel, > > On Tue, 2018-03-13 at 17:34 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >&

Re: [PATCH v2 01/12] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

Thanks Rob ! Best Regards Gabriel On 03/10/2018 12:53 AM, Rob Herring wrote: > On Thu, Mar 08, 2018 at 05:53:54PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> The RCC block is responsible of the manage

Re: [PATCH v2 01/12] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

Thanks Rob ! Best Regards Gabriel On 03/10/2018 12:53 AM, Rob Herring wrote: > On Thu, Mar 08, 2018 at 05:53:54PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> The RCC block is responsible of the management of the clock and reset >>

Re: [PATCH v2 00/12] Introduce STM32MP1 clock driver

Many Thanks Mike ! Best Regards Gabriel. On 03/11/2018 11:42 PM, Michael Turquette wrote: > Excerpts from gabriel.fernan...@st.com's message of March 8, 2018 8:53 > am: >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> v2: >>   - Don't use MF

Re: [PATCH v2 00/12] Introduce STM32MP1 clock driver

Many Thanks Mike ! Best Regards Gabriel. On 03/11/2018 11:42 PM, Michael Turquette wrote: > Excerpts from gabriel.fernan...@st.com's message of March 8, 2018 8:53 > am: >> From: Gabriel Fernandez >> >> v2: >>   - Don't use MFD, use existing binding of STM32

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

On Thu, Mar 01, 2018 at 01:58:01AM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 28, 2018 at 06:25:58PM -0500, Gabriel Somlo wrote: > > On Wed, Feb 28, 2018 at 05:32:52PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Feb 28, 2018 at 12:49:35PM +0100, Marc-André Lureau

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

On Thu, Mar 01, 2018 at 01:58:01AM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 28, 2018 at 06:25:58PM -0500, Gabriel Somlo wrote: > > On Wed, Feb 28, 2018 at 05:32:52PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Feb 28, 2018 at 12:49:35PM +0100, Marc-André Lureau

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

On Thu, Mar 01, 2018 at 01:58:22AM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 01, 2018 at 01:58:01AM +0200, Michael S. Tsirkin wrote: > > On Wed, Feb 28, 2018 at 06:25:58PM -0500, Gabriel Somlo wrote: > > > On Wed, Feb 28, 2018 at 05:32:52PM +0200, Michael S. Tsirkin wrote: &

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

On Thu, Mar 01, 2018 at 01:58:22AM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 01, 2018 at 01:58:01AM +0200, Michael S. Tsirkin wrote: > > On Wed, Feb 28, 2018 at 06:25:58PM -0500, Gabriel Somlo wrote: > > > On Wed, Feb 28, 2018 at 05:32:52PM +0200, Michael S. Tsirkin wrote: &

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

FG_FILE_DIR, dir, sizeof(files_count), > > >> dir_size); > > >> + ret = fw_cfg_read_blob(FW_CFG_FILE_DIR, dir, > > >> + sizeof(files_count), dir_size); > > >> + if (ret < 0) > > >> + goto end;

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

dir_size); > > >> + ret = fw_cfg_read_blob(FW_CFG_FILE_DIR, dir, > > >> + sizeof(files_count), dir_size); > > >> + if (ret < 0) > > >> + goto end; > > >> > > >> for (i = 0; i <

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

On Wed, Feb 28, 2018 at 12:49:35PM +0100, Marc-André Lureau wrote: > Hi > > On Tue, Feb 27, 2018 at 1:20 AM, Michael S. Tsirkin wrote: > > On Thu, Feb 15, 2018 at 10:33:09PM +0100, Marc-André Lureau wrote: > >> fw_cfg_read_blob() may fail, but does not return error. This may

Re: [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error

On Wed, Feb 28, 2018 at 12:49:35PM +0100, Marc-André Lureau wrote: > Hi > > On Tue, Feb 27, 2018 at 1:20 AM, Michael S. Tsirkin wrote: > > On Thu, Feb 15, 2018 at 10:33:09PM +0100, Marc-André Lureau wrote: > >> fw_cfg_read_blob() may fail, but does not return error. This may lead > >> to

[PATCH 0/2] Fix coding style issues in AK4458 DAC

Modify SPDX license comment style and sort headers alphabetically. Cosmin-Gabriel Samoila (2): ASoC: ak4458: Modify SPDX license format ASoC: ak4458: Sort headers alphabetically sound/soc/codecs/ak4458.c | 23 +++ sound/soc/codecs/ak4458.h | 2 +- 2 files changed, 12

[PATCH 0/2] Fix coding style issues in AK4458 DAC

Modify SPDX license comment style and sort headers alphabetically. Cosmin-Gabriel Samoila (2): ASoC: ak4458: Modify SPDX license format ASoC: ak4458: Sort headers alphabetically sound/soc/codecs/ak4458.c | 23 +++ sound/soc/codecs/ak4458.h | 2 +- 2 files changed, 12

[PATCH 1/2] ASoC: ak4458: Modify SPDX license format

Modify SPDX comment style to match the rules. Since the original code had a GPL-2.0 license and SPDX is compatible with GPL-2.0+, we also modified the MODULE_LICENSE. Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samo...@nxp.com> --- sound/soc/codecs/ak4458.c | 13 ++--- sound/soc/

[PATCH 1/2] ASoC: ak4458: Modify SPDX license format

Modify SPDX comment style to match the rules. Since the original code had a GPL-2.0 license and SPDX is compatible with GPL-2.0+, we also modified the MODULE_LICENSE. Signed-off-by: Cosmin-Gabriel Samoila --- sound/soc/codecs/ak4458.c | 13 ++--- sound/soc/codecs/ak4458.h | 2 +- 2

[PATCH 2/2] ASoC: ak4458: Sort headers alphabetically

Keep headers sorted alphabetically. Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samo...@nxp.com> --- sound/soc/codecs/ak4458.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index 8a49dd2..31ec0ba

[PATCH 2/2] ASoC: ak4458: Sort headers alphabetically

Keep headers sorted alphabetically. Signed-off-by: Cosmin-Gabriel Samoila --- sound/soc/codecs/ak4458.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index 8a49dd2..31ec0ba 100644 --- a/sound/soc/codecs

[PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

-by: Junichi Wakasugi <wakasugi...@om.asahi-kasei.co.jp> Signed-off-by: Mihai Serban <mihai.ser...@nxp.com> Signed-off-by: Shengjiu Wang <shengjiu.w...@nxp.com> Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samo...@nxp.com> --- sound/soc/codecs/Kconfig | 6 + sound/s

[PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

-by: Junichi Wakasugi Signed-off-by: Mihai Serban Signed-off-by: Shengjiu Wang Signed-off-by: Cosmin-Gabriel Samoila --- sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ak4458.c | 659 ++ sound/soc/codecs/ak4458

[PATCH v3 0/2] Add support for AK4458 DAC

snd_soc_update_bits instead of soc_read + soc_write - use GPIOD - use SPDX identifier - use dac@10 instgitead of ak4458@10 - use explicit power_on/off functions - add __maybe_unused attribute - use probe_new for i2c_probe Cosmin-Gabriel Samoila (2): ASoC: codecs: Add support for AK4458 DAC driver ASoC

[PATCH v3 0/2] Add support for AK4458 DAC

snd_soc_update_bits instead of soc_read + soc_write - use GPIOD - use SPDX identifier - use dac@10 instgitead of ak4458@10 - use explicit power_on/off functions - add __maybe_unused attribute - use probe_new for i2c_probe Cosmin-Gabriel Samoila (2): ASoC: codecs: Add support for AK4458 DAC driver ASoC

[PATCH v3 2/2] ASoC: ak4458: Add bindings for AK4458 DAC

Document the bindings for AK4458 DAC Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samo...@nxp.com> --- Documentation/devicetree/bindings/sound/ak4458.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt

[PATCH v3 2/2] ASoC: ak4458: Add bindings for AK4458 DAC

Document the bindings for AK4458 DAC Signed-off-by: Cosmin-Gabriel Samoila --- Documentation/devicetree/bindings/sound/ak4458.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt diff --git a/Documentation

[PATCH v2 1/2] ASoC: codecs: Add support for AK4458 DAC driver

-by: Junichi Wakasugi <wakasugi...@om.asahi-kasei.co.jp> Signed-off-by: Mihai Serban <mihai.ser...@nxp.com> Signed-off-by: Shengjiu Wang <shengjiu.w...@nxp.com> Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samo...@nxp.com> --- sound/soc/codecs/Kconfig | 6 + sound/s

[PATCH v2 1/2] ASoC: codecs: Add support for AK4458 DAC driver

-by: Junichi Wakasugi Signed-off-by: Mihai Serban Signed-off-by: Shengjiu Wang Signed-off-by: Cosmin-Gabriel Samoila --- sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ak4458.c | 684 ++ sound/soc/codecs/ak4458

[PATCH v2 0/2] Add support for AK4458 DAC

unused controls - remove unused macros - use snd_soc_update_bits instead of soc_read + soc_write - use GPIOD - use SPDX identifier - use dac@10 instgitead of ak4458@10 - use explicit power_on/off functions - add __maybe_unused attribute - use probe_new for i2c_probe Cosmin-Gabriel Samoila (2): ASoC

[PATCH v2 2/2] ASoC: ak4458: Add bindings for AK4458 DAC

Signed-off-by: Junichi Wakasugi <wakasugi...@om.asahi-kasei.co.jp> Signed-off-by: Mihai Serban <mihai.ser...@nxp.com> Signed-off-by: Shengjiu Wang <shengjiu.w...@nxp.com> Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samo...@nxp.com> --- Documentation/devicetree/bindin

[PATCH v2 0/2] Add support for AK4458 DAC

unused controls - remove unused macros - use snd_soc_update_bits instead of soc_read + soc_write - use GPIOD - use SPDX identifier - use dac@10 instgitead of ak4458@10 - use explicit power_on/off functions - add __maybe_unused attribute - use probe_new for i2c_probe Cosmin-Gabriel Samoila (2): ASoC

[PATCH v2 2/2] ASoC: ak4458: Add bindings for AK4458 DAC

Signed-off-by: Junichi Wakasugi Signed-off-by: Mihai Serban Signed-off-by: Shengjiu Wang Signed-off-by: Cosmin-Gabriel Samoila --- Documentation/devicetree/bindings/sound/ak4458.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH 01/14] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

On 02/07/2018 07:03 PM, Rob Herring wrote: > On Mon, Feb 5, 2018 at 1:01 AM, Gabriel FERNANDEZ > <gabriel.fernan...@st.com> wrote: >> Hi Rob, >> >> Thanks for reviewing. >> >> >> On 02/05/2018 07:09 AM, Rob Herring wrote: >>> On Fri,

Re: [PATCH 01/14] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

On 02/07/2018 07:03 PM, Rob Herring wrote: > On Mon, Feb 5, 2018 at 1:01 AM, Gabriel FERNANDEZ > wrote: >> Hi Rob, >> >> Thanks for reviewing. >> >> >> On 02/05/2018 07:09 AM, Rob Herring wrote: >>> On Fri, Feb 02, 2018 at 03:03:29PM +0100,

Re: [PATCH 01/14] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

On 02/05/2018 07:09 AM, Rob Herring wrote: > On Fri, Feb 02, 2018 at 03:03:29PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> The RCC block is responsible of the management of the clock and reset >> ge

Re: [PATCH 01/14] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

On 02/05/2018 07:09 AM, Rob Herring wrote: > On Fri, Feb 02, 2018 at 03:03:29PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> The RCC block is responsible of the management of the clock and reset >> generation for the complete circuit. &

Re: [PATCH 02/14] dt-bindings: clock: add STM32MP1 clocks

On 02/05/2018 07:09 AM, Rob Herring wrote: > On Fri, Feb 02, 2018 at 03:03:30PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> This patch adds the clock binding entry for STM32MP1 >> >> Signed-off-by: Gabr

Re: [PATCH 02/14] dt-bindings: clock: add STM32MP1 clocks

On 02/05/2018 07:09 AM, Rob Herring wrote: > On Fri, Feb 02, 2018 at 03:03:30PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch adds the clock binding entry for STM32MP1 >> >> Signed-off-by: Gabriel Fernandez >> ---

Re: [PATCH 01/14] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

Hi Rob, Thanks for reviewing. On 02/05/2018 07:09 AM, Rob Herring wrote: > On Fri, Feb 02, 2018 at 03:03:29PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> The RCC block is responsible of the management of the cl

<    1   2   3   4   5   6   7   8   9   10   >