Re: [RFC PATCH v3] acpi: indicate to platform when hot remove returns busy

2017-07-03 Thread joeyli
On Fri, Jun 30, 2017 at 01:49:07PM +0800, joeyli wrote: > Hi Rafael, > > On Thu, Jun 29, 2017 at 12:13:18AM +0200, Rafael J. Wysocki wrote: > > On Wednesday, June 21, 2017 03:45:44 PM Lee, Chun-Yi wrote: > > > In hotplug logic, it always indicates non-specific failure t

Re: [RFC v2 PATCH] x86/boot: Add the secdata section to the setup header

2017-06-30 Thread joeyli
Hi Ard, On Thu, Jun 01, 2017 at 08:46:26AM +, Ard Biesheuvel wrote: > On 1 June 2017 at 08:11, Gary Lin wrote: > > On Fri, May 12, 2017 at 04:05:34PM +0800, Gary Lin wrote: > >> A new section, secdata, in the setup header is introduced to store the > >> distro-specific security version which

Re: [RFC PATCH v3] acpi: indicate to platform when hot remove returns busy

2017-06-29 Thread joeyli
Hi Rafael, On Thu, Jun 29, 2017 at 12:13:18AM +0200, Rafael J. Wysocki wrote: > On Wednesday, June 21, 2017 03:45:44 PM Lee, Chun-Yi wrote: > > In hotplug logic, it always indicates non-specific failure to > > platform through _OST when handing acpi hot-remove event failed. Then > > platform termi

Re: [PATCH v2] acpi: handle the acpi hotplug schedule error

2017-06-29 Thread joeyli
Hi Rafael, Thanks for your review. On Thu, Jun 29, 2017 at 12:06:20AM +0200, Rafael J. Wysocki wrote: > On Wednesday, June 21, 2017 03:04:34 PM Lee, Chun-Yi wrote: > > Kernel should decrements the reference count of acpi device > > when the scheduling of acpi hotplug work is failed, and > > eval

Re: A udev rule to serve the change event of ACPI container?

2017-06-28 Thread joeyli
Hi YASUAKI, Thanks for your response. On Wed, Jun 28, 2017 at 03:53:16PM -0400, YASUAKI ISHIMATSU wrote: > > On 06/26/2017 02:26 AM, joeyli wrote: > > Hi all, > > > > If ACPI received ejection request for a ACPI container, kernel > > emits KOBJ_CHANGE uevent

A udev rule to serve the change event of ACPI container?

2017-06-25 Thread joeyli
Hi all, If ACPI received ejection request for a ACPI container, kernel emits KOBJ_CHANGE uevent when it found online children devices below the acpi container. Base on the description of caa73ea15 kernel patch, user space is expected to offline all devices below the container and the container it

Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

2017-06-20 Thread joeyli
On Tue, Jun 20, 2017 at 02:45:56PM -0700, Darren Hart wrote: > On Tue, Jun 20, 2017 at 10:46:12PM +0200, Pali Rohár wrote: > > On Tuesday 20 June 2017 19:22:46 Andy Shevchenko wrote: > > > On Tue, Jun 20, 2017 at 7:48 PM, Pali Rohár > > > wrote: > > > > On Tuesday 20 June 2017 17:06:23 Lee, Chun-Y

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

2017-06-19 Thread joeyli
Hi Pali, On Sat, Jun 17, 2017 at 06:47:54PM +0200, Pali Rohár wrote: > > So problematic drivers which use instance=1 without any comments are: > > > > acer-wmi > > asus-wmi > > mxm-wmi > > Adding authors & maintainers of those drivers in loop. > > WMI instance number is indexed from zero

Re: [PATCH v2] acpi: indicate to platform when hot remove returns busy

2017-06-09 Thread joeyli
On Fri, Jun 09, 2017 at 06:36:32PM +0300, Andy Shevchenko wrote: > On Fri, Jun 9, 2017 at 1:54 PM, Lee, Chun-Yi wrote: > > In hotplug logic, it always indicates non-specific failure to > > platform through _OST when handing acpi hot-remove event failed. Then > > platform terminates the hot-remove

Re: [PATCH] platform/x86/acer-wmi: Detect RF Button capability

2017-06-08 Thread joeyli
On Tue, Jun 06, 2017 at 01:07:22PM -0700, João Paulo Rechi Vita wrote: > If a machine reports a RF Button in the communication button device > bitmap, we need to remove it before calling Get Device Status otherwise > it will return the "Undefined device" (0xE2) error code. > > Although this may be

Re: [PATCH] acpi: handle the acpi hotplug schedule error

2017-06-07 Thread joeyli
On Wed, Jun 07, 2017 at 01:46:37PM +0300, Andy Shevchenko wrote: > On Wed, Jun 7, 2017 at 1:18 PM, joeyli wrote: > > On Wed, Jun 07, 2017 at 11:36:55AM +0300, Andy Shevchenko wrote: > >> On Wed, Jun 7, 2017 at 9:05 AM, Lee, Chun-Yi > >> wrote: > >> > Kerne

Re: [RFC PATCH] acpi: indicate to platform when hot remove returns busy

2017-06-07 Thread joeyli
On Wed, Jun 07, 2017 at 11:50:13AM +0300, Andy Shevchenko wrote: > On Wed, Jun 7, 2017 at 9:07 AM, Lee, Chun-Yi wrote: > > In hotplug logic, it always indicates non-specific failure to > > platform through _OST when handing acpi hot-remove event failed. Then > > platform terminates the hot-remove

Re: [PATCH] acpi: handle the acpi hotplug schedule error

2017-06-07 Thread joeyli
Hi Andy, Thanks for your help to review my patch. On Wed, Jun 07, 2017 at 11:36:55AM +0300, Andy Shevchenko wrote: > On Wed, Jun 7, 2017 at 9:05 AM, Lee, Chun-Yi wrote: > > Kernel should decrements the reference count of acpi device > > when scheduling acpi hotplug work is failed, and also eval

Re: [RFC PATCH] acpi: indicate to platform when hot remove returns busy

2017-06-04 Thread joeyli
On Sun, Jun 04, 2017 at 06:04:53PM +0800, joeyli wrote: > Hi Andy, > > Thanks for your help to review my patch. > > On Sat, Jun 03, 2017 at 08:37:51PM +0300, Andy Shevchenko wrote: > > On Sat, Jun 3, 2017 at 8:20 PM, Lee, Chun-Yi > > wrote: > > > In ho

Re: [RFC PATCH] acpi: indicate to platform when hot remove returns busy

2017-06-04 Thread joeyli
Hi Andy, Thanks for your help to review my patch. On Sat, Jun 03, 2017 at 08:37:51PM +0300, Andy Shevchenko wrote: > On Sat, Jun 3, 2017 at 8:20 PM, Lee, Chun-Yi wrote: > > In hotplug logic, it always indicates non-specific failure to > > platform through _OST when handing acpi hot-remove event

Re: [PATCH 5/5] Add a sysrq option to exit secure boot mode

2017-05-26 Thread joeyli
Hi, On Wed, May 24, 2017 at 03:46:03PM +0100, David Howells wrote: > From: Kyle McMartin > > Make sysrq+x exit secure boot mode on x86_64, thereby allowing the running > kernel image to be modified. This lifts the lockdown. > > Signed-off-by: Kyle McMartin > Signed-off-by: David Howells > cc

Re: [PATCH 3/5] Add the ability to lock down access to the running kernel image

2017-05-26 Thread joeyli
On Fri, May 26, 2017 at 01:43:12PM +0100, David Howells wrote: > Casey Schaufler wrote: > > > You called out five distinct features in 0/5, so how about > > a bit for each of those? > > Actually, there are more than five in that list - there are three in the first > item - and I'm not sure the r

Re: [PATCH 4/5] efi: Lock down the kernel if booted in secure boot mode

2017-05-26 Thread joeyli
On Wed, May 24, 2017 at 03:45:56PM +0100, David Howells wrote: > UEFI Secure Boot provides a mechanism for ensuring that the firmware will > only load signed bootloaders and kernels. Certain use cases may also > require that all kernel modules also be signed. Add a configuration option > that to

Re: [PATCH 3/5] Add the ability to lock down access to the running kernel image

2017-05-26 Thread joeyli
On Wed, May 24, 2017 at 03:45:45PM +0100, David Howells wrote: > Provide a single call to allow kernel code to determine whether the system > should be locked down, thereby disallowing various accesses that might > allow the running kernel image to be changed including the loading of > modules that

Re: [PATCH 2/5] efi: Add EFI_SECURE_BOOT bit

2017-05-26 Thread joeyli
On Wed, May 24, 2017 at 03:45:32PM +0100, David Howells wrote: > From: Josh Boyer > > UEFI machines can be booted in Secure Boot mode. Add a EFI_SECURE_BOOT bit > that can be passed to efi_enabled() to find out whether secure boot is > enabled. > > This will be used by the SysRq+x handler, regi

Re: [PATCH 1/5] efi: Move the x86 secure boot switch to generic code

2017-05-26 Thread joeyli
Hi David, On Wed, May 24, 2017 at 03:45:25PM +0100, David Howells wrote: > Move the switch-statement in x86's setup_arch() that inteprets the > secure_boot boot parameter to generic code. > > Suggested-by: Ard Biesheuvel > Signed-off-by: David Howells I reviewed the context for this patch. Re

Re: [PATCH v2] x86/efi: Disable runtime services on kexec kernel if booted with efi=old_map

2017-05-17 Thread joeyli
On Tue, May 16, 2017 at 06:14:23PM -0700, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Booting kexec kernel with "efi=old_map" in kernel command line hits > kernel panic as shown below. > > [0.001000] BUG: unable to handle kernel paging request at 88007fe78070 > [0.001000] IP: virt_e

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-12 Thread joeyli
On Mon, May 08, 2017 at 12:25:23PM -0700, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Booting kexec kernel with "efi=old_map" in kernel command line hits > kernel panic as shown below. > > [0.001000] BUG: unable to handle kernel paging request at 88007fe78070 > [0.001000] IP

Re: [PATCH 2/2] ACPI / scan: Avoid enumerating devices more than once

2017-04-19 Thread joeyli
On Mon, Apr 17, 2017 at 01:20:48AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > acpi_bus_attach() does not check the visited flag for devices that > have been enumerated already and some of them may be enumerated > for multiple times as a result, because some callers of > acpi_bu

Re: [PATCH 1/2] ACPI / scan: Apply default enumeration to devices with ACPI drivers

2017-04-19 Thread joeyli
On Mon, Apr 17, 2017 at 01:19:50AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The current code in acpi_bus_attach() is inconsistent with respect > to device objects with ACPI drivers bound to them, as it allows > ACPI drivers to bind to device objects with existing "physical" >

Re: [PATCH] ACPI: emits change uevents to all physical companion devices of container's children

2017-04-19 Thread joeyli
Hi, On Wed, Apr 19, 2017 at 02:30:18AM +0200, Rafael J. Wysocki wrote: > On Mon, Apr 3, 2017 at 5:55 PM, Lee, Chun-Yi wrote: > > The caa73ea1 patch, "ACPI / hotplug / driver core: Handle containers > > in a special way", introduced the offline callback of acpi container. > > In the patch descrip

Re: [PATCH 2/3] ACPI: Remove platform devices from a bus on removal

2017-04-18 Thread joeyli
On Wed, Apr 19, 2017 at 02:50:17PM +0800, joeyli wrote: > On Wed, Mar 22, 2017 at 06:33:24PM +0100, Joerg Roedel wrote: > > From: Joerg Roedel > > > > The function acpi_bus_attach() creates platform_devices if > > this is specified by the firmware. But in acpi_bus_t

Re: [PATCH 2/3] ACPI: Remove platform devices from a bus on removal

2017-04-18 Thread joeyli
On Wed, Mar 22, 2017 at 06:33:24PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > The function acpi_bus_attach() creates platform_devices if > this is specified by the firmware. But in acpi_bus_trim() > these devices are not removed, leaving a dangling reference > to the parent device. > >

Re: [PATCH 20/24] bpf: Restrict kernel image access functions when the kernel is locked down

2017-04-12 Thread joeyli
Hi David, First, thanks for your help to send out this series. On Wed, Apr 05, 2017 at 09:17:25PM +0100, David Howells wrote: > From: Chun-Yi Lee > > There are some bpf functions can be used to read kernel memory: > bpf_probe_read, bpf_probe_write_user and bpf_trace_printk. These allow > priva

Re: [PATCH 11/24] uswsusp: Disable when the kernel is locked down

2017-04-12 Thread joeyli
ry and I'm not sure how the hibernate > >>> code can verify whether or not it is in use. > >> > >> BTW, SUSE has patches adding secure boot support to the hibernate code > >> and Jiri promised me to post them last year even. :-) > > > > Oh,

Re: memory hotplug and force_remove

2017-03-31 Thread joeyli
On Fri, Mar 31, 2017 at 12:55:05PM +0200, Michal Hocko wrote: > On Fri 31-03-17 18:49:05, Joey Lee wrote: > > Hi Michal, > > > > On Fri, Mar 31, 2017 at 10:30:17AM +0200, Michal Hocko wrote: > [...] > > > @@ -241,11 +232,10 @@ static int acpi_scan_try_to_offline(struct > > > acpi_device *device)

Re: memory hotplug and force_remove

2017-03-31 Thread joeyli
Hi Michal, On Fri, Mar 31, 2017 at 10:30:17AM +0200, Michal Hocko wrote: > [Fixed up email address of Toshimitsu - the email thread starts > http://lkml.kernel.org/r/20170320192938.ga11...@dhcp22.suse.cz] > > On Tue 28-03-17 17:22:58, Rafael J. Wysocki wrote: > > On Tuesday, March 28, 2017 09:58:

Re: memory hotplug and force_remove

2017-03-30 Thread joeyli
On Thu, Mar 30, 2017 at 10:15:04PM +0200, Rafael J. Wysocki wrote: > On Friday, March 31, 2017 12:57:29 AM joeyli wrote: > > On Thu, Mar 30, 2017 at 06:20:34PM +0200, Michal Hocko wrote: > > > On Thu 30-03-17 10:47:52, Jiri Kosina wrote: > > > > On Tue, 28 Mar

Re: memory hotplug and force_remove

2017-03-30 Thread joeyli
On Thu, Mar 30, 2017 at 06:20:34PM +0200, Michal Hocko wrote: > On Thu 30-03-17 10:47:52, Jiri Kosina wrote: > > On Tue, 28 Mar 2017, Rafael J. Wysocki wrote: > > > > > > > > we have been chasing the following BUG() triggering during the > > > > > > memory > > > > > > hotremove (remove_memory): >

Re: [PATCH] acpi: check the online state of all children in container

2017-03-21 Thread joeyli
On Wed, Mar 22, 2017 at 01:58:30AM +0100, Rafael J. Wysocki wrote: > On Wednesday, March 22, 2017 09:01:48 AM Lee, Chun-Yi wrote: > > Just checking the state of container is not enough to confirm that > > the whole container is offlined. > > And why is that so? > Actually there does not have real

Re: memory hotplug and force_remove

2017-03-21 Thread joeyli
On Mon, Mar 20, 2017 at 10:24:42PM +0100, Rafael J. Wysocki wrote: > On Monday, March 20, 2017 03:29:39 PM Michal Hocko wrote: > > Hi Rafael, > > Hi, > > > we have been chasing the following BUG() triggering during the memory > > hotremove (remove_memory): > > ret = walk_memory_range(PFN_DOWN

Re: [PATCH v2] acer-wmi: setup accelerometer when machine has appropriate notify event

2017-01-02 Thread joeyli
On Tue, Dec 27, 2016 at 02:00:01PM +0200, Andy Shevchenko wrote: > On Thu, Nov 3, 2016 at 2:18 AM, Lee, Chun-Yi wrote: > > The accelerometer event relies on on the ACERWMID_EVENT_GUID notify. > > So, this patch changes the codes to setup accelerometer input device > > when detected ACERWMID_EVENT_

Re: [PATCH 0/4] UEFI: EFI_MEMORY_ATTRIBUTES_TABLE support for x86

2016-12-12 Thread joeyli
Hi Sai, On Wed, Dec 07, 2016 at 12:13:28PM -0800, Sai Praneeth Prakhya wrote: > On Wed, 2016-12-07 at 20:04 +, Matt Fleming wrote: > > On Wed, 07 Dec, at 11:01:06AM, Sai Praneeth Prakhya wrote: > > > > > > Thanks Matt! > > > > > > Would you like to see a new version of these patch series add

Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family

2016-11-02 Thread joeyli
On Thu, Nov 03, 2016 at 11:40:15AM +0800, Anthony Wong wrote: > On 1 November 2016 at 12:30, Lee, Chun-Yi wrote: > > > > The AMW0_GUID1 wmi is not only found on Acer family but also other > > machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi > > driver handled those non-Acer mac

Re: [PATCH] acer-wmi: setup accelerometer when machine has appropriate notify event

2016-11-02 Thread joeyli
Hi Darren, Thanks for your review! On Tue, Nov 01, 2016 at 10:28:51AM -0700, Darren Hart wrote: > On Tue, Nov 01, 2016 at 12:33:32PM +0800, Lee, Chun-Yi wrote: > > The accelerometer event relies on on the ACERWMID_EVENT_GUID notify. > > So, this patch changes the codes to setup accelerometer inpu

Re: [PATCH][v12] PM / hibernate: Verify the consistent of e820 memory map by md5 digest

2016-10-21 Thread joeyli
Hi Chen Yu, On Thu, Oct 20, 2016 at 04:14:52PM +0800, Chen Yu wrote: > On some platforms, there is occasional panic triggered when > trying to resume from hibernation, a typical panic looks like: > > "BUG: unable to handle kernel paging request at 880085894000 > IP: [] load_image_lzo+0x8c2/0x

Re: [PATCH][v11] PM / hibernate: Verify the consistent of e820 memory map by md5 digest

2016-10-07 Thread joeyli
Hi Chen Yu, On Sun, Sep 25, 2016 at 12:17:57PM +0800, Chen Yu wrote: > On some platforms, there is occasional panic triggered when trying to > resume from hibernation, a typical panic looks like: > > "BUG: unable to handle kernel paging request at 880085894000 > IP: [] load_image_lzo+0x8c2/0x

Re: [PATCH][v8] PM / hibernate: Verify the consistent of e820 memory map by md5 value

2016-08-30 Thread joeyli
On Mon, Aug 29, 2016 at 03:41:23PM +0200, Borislav Petkov wrote: > On Mon, Aug 29, 2016 at 09:15:00AM +0200, Pavel Machek wrote: > > Sounds about as easy as hot unplugging arbitrary memory address. IOW > > "not easy". > > Regardless, forcibly panicking the system more is still the wrong > approach

Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family

2016-08-29 Thread joeyli
Hi Bjørn, On Mon, Aug 29, 2016 at 12:11:59PM +0200, Bjørn Mork wrote: > "Lee, Chun-Yi" writes: > > > The AMW0_GUID1 wmi is not only found on Acer family but also other > > machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi > > driver handled those non-Acer machines by quirks l

Re: [PATCH][v6] PM / hibernate: Print the possible panic reason when resuming with inconsistent e820 map

2016-08-23 Thread joeyli
On Tue, Aug 23, 2016 at 06:01:55PM +0800, Chen Yu wrote: > Hi, > thanks for your interest :) > On Tue, Aug 23, 2016 at 05:45:27PM +0800, joeyli wrote: > > Hi all, > > > > On Wed, Oct 21, 2015 at 01:21:40PM +0800, Chen Yu wrote: > > > On some platforms, ther

Re: [PATCH][v6] PM / hibernate: Print the possible panic reason when resuming with inconsistent e820 map

2016-08-23 Thread joeyli
Hi all, On Wed, Oct 21, 2015 at 01:21:40PM +0800, Chen Yu wrote: > On some platforms, there is occasional panic triggered when trying to > resume from hibernation, a typical panic looks like: > > "BUG: unable to handle kernel paging request at 880085894000 > IP: [] load_image_lzo+0x8c2/0xe70

Re: [PATCH] libnvdimm, nd_blk: mask off reserved status bits

2016-07-31 Thread joeyli
Hi Ross, On Fri, Jul 29, 2016 at 02:59:12PM -0600, Ross Zwisler wrote: > The "NVDIMM Block Window Driver Writer's Guide": > > http://pmem.io/documents/ > http://pmem.io/documents/NVDIMM_DriverWritersGuide-July-2016.pdf > > defines the layout of the block window status register. For the July 201

Re: [PATCH] efi: capsule: allocate whole capsule into virtual memory

2016-07-27 Thread joeyli
Hi Austin, On Fri, Jul 15, 2016 at 10:41:31AM -0600, Austin Christ wrote: > According to UEFI 2.6 section 7.5.3, the capsule should be in contiguous > virtual memory and firmware may consume the capsule immediately. To > correctly implement this functionality, the kernel driver needs to vmap > the

Re: [PATCH v3] acpi, nfit: treat volatile virtual CD region as pmem

2016-06-27 Thread joeyli
On Mon, Jun 27, 2016 at 10:34:32AM -0700, Dan Williams wrote: > On Sun, Jun 26, 2016 at 11:46 PM, Lee, Chun-Yi > wrote: > > This patch adds logic to treat volatile virtual CD region as pmem > > region, then /dev/pmem* device can be mounted with iso9660. > > > > It's useful to work with the httpbo

Re: [PATCH v2] libnvdimm, nfit: treat volatile virtual CD region as pmem

2016-06-27 Thread joeyli
On Sat, Jun 25, 2016 at 09:08:16AM -0700, Dan Williams wrote: > On Sat, Jun 25, 2016 at 5:21 AM, joeyli wrote: > > iOn Fri, Jun 24, 2016 at 10:59:56AM -0700, Dan Williams wrote: > >> On Fri, Jun 24, 2016 at 12:51 AM, Lee, Chun-Yi > >> wrote: > >> >

Re: [PATCH v2] libnvdimm, nfit: treat volatile virtual CD region as pmem

2016-06-25 Thread joeyli
iOn Fri, Jun 24, 2016 at 10:59:56AM -0700, Dan Williams wrote: > On Fri, Jun 24, 2016 at 12:51 AM, Lee, Chun-Yi > wrote: > > This patch adds logic to treat volatile virtual CD region as pmem > > region, then /dev/pmem* device can be mounted with iso9660. > > > > It's useful to work with the httpb

Re: [PATCH] libnvdimm, nfit: treat volatile virtual CD region as read-only pmem

2016-06-11 Thread joeyli
On Thu, Jun 09, 2016 at 03:34:52PM -0700, Dan Williams wrote: > On Thu, Jun 9, 2016 at 3:08 PM, Linda Knippers wrote: > > On 6/4/2016 7:01 AM, joeyli wrote: > >> Hi Dan, > >> > >> Thanks for your review. > >> > >> On Fri, Jun 03, 2016 at 12:

Re: [PATCH] libnvdimm, nfit: treat volatile virtual CD region as read-only pmem

2016-06-11 Thread joeyli
Hi Linda, Thanks for your review and comments. On Thu, Jun 09, 2016 at 06:08:17PM -0400, Linda Knippers wrote: > On 6/4/2016 7:01 AM, joeyli wrote: > > Hi Dan, > > > > Thanks for your review. > > > > On Fri, Jun 03, 2016 at 12:27:34PM -0700, Dan Williams wrot

Re: [PATCH] libnvdimm, nfit: treat volatile virtual CD region as read-only pmem

2016-06-05 Thread joeyli
On Sat, Jun 04, 2016 at 09:24:54AM -0700, Dan Williams wrote: > On Sat, Jun 4, 2016 at 4:01 AM, joeyli wrote: > > Hi Dan, > > > > Thanks for your review. > > > > On Fri, Jun 03, 2016 at 12:27:34PM -0700, Dan Williams wrote: > >> On Fri, Jun 3, 2

Re: [PATCH] libnvdimm, nfit: treat volatile virtual CD region as read-only pmem

2016-06-05 Thread joeyli
On Sat, Jun 04, 2016 at 09:24:54AM -0700, Dan Williams wrote: > On Sat, Jun 4, 2016 at 4:01 AM, joeyli wrote: > > Hi Dan, > > > > Thanks for your review. > > > > On Fri, Jun 03, 2016 at 12:27:34PM -0700, Dan Williams wrote: > >> On Fri, Jun 3, 2

Re: [PATCH] libnvdimm, nfit: treat volatile virtual CD region as read-only pmem

2016-06-04 Thread joeyli
Hi Dan, Thanks for your review. On Fri, Jun 03, 2016 at 12:27:34PM -0700, Dan Williams wrote: > On Fri, Jun 3, 2016 at 12:13 AM, Lee, Chun-Yi wrote: > > This patch adds codes to treat a volatile virtual CD region as a > > read-only pmem region, then read-only /dev/pmem* device can be mounted >

Re: [PATCH 2/2] localmodconfig: Reset certificate paths

2016-04-08 Thread joeyli
On Sat, Apr 02, 2016 at 10:55:22AM -0700, Benjamin Poirier wrote: > When using `make localmodconfig` and friends, if the input config comes > from a kernel that was built in a different environment (for example, the > canonical case of using localmodconfig to trim a distribution kernel > config) th

Re: [PATCH 1/2] localmodconfig: Fix parsing of Kconfig "source" statements

2016-04-08 Thread joeyli
On Sat, Apr 02, 2016 at 10:55:21AM -0700, Benjamin Poirier wrote: > The parameter of Kconfig "source" statements does not need to be quoted. > The current regex causes many kconfig files to be skipped and hence, > dependencies to be missed. > > Also fix the whitespace repeat count. > > Signed-off

Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface

2015-10-05 Thread joeyli
On Mon, Oct 05, 2015 at 12:34:47PM +0200, Martin Kepplinger wrote: > Am 2015-10-05 um 12:30 schrieb joeyli: > > Hi Darren, > > > > On Sat, Oct 03, 2015 at 10:20:52AM -0700, Darren Hart wrote: > >> On Tue, Sep 29, 2015 at 05:50:32PM +0800, joeyli wrote: > >&g

Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface

2015-10-05 Thread joeyli
Hi Darren, On Sat, Oct 03, 2015 at 10:20:52AM -0700, Darren Hart wrote: > On Tue, Sep 29, 2015 at 05:50:32PM +0800, joeyli wrote: > > Hi Martin, > > > > On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote: > > > Signed-off-by: Martin Kepplinger &

Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface

2015-09-29 Thread joeyli
Hi Martin, On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote: > Signed-off-by: Martin Kepplinger > --- > This just looks odd in the logs. Feel free to ignore it or act on it > differently ;) > > Thanks for your patch and it reminds me to remove those interfaces in acer-wmi. Pl

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-29 Thread joeyli
Hi Minfei, On Tue, Sep 29, 2015 at 11:50:44AM +0800, Minfei Huang wrote: > On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > > On big machines have CPU number that's very nearly to consume whole ELF > > headers buffer that's page aligned, 4096, 8192... Then the page fault error > > randomly happened.

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-28 Thread joeyli
On Mon, Sep 28, 2015 at 04:07:57PM +0800, Baoquan He wrote: > On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > > On big machines have CPU number that's very nearly to consume whole ELF > > headers buffer that's page aligned, 4096, 8192... Then the page fault error > > randomly happened. > > > > This

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-28 Thread joeyli
Hi, On Mon, Sep 28, 2015 at 03:16:41PM +0800, Baoquan He wrote: > Hi Chun-Yi, > > On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > > On big machines have CPU number that's very nearly to consume whole ELF > > headers buffer that's page aligned, 4096, 8192... Then the page fault error > > randomly ha

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-09-12 Thread joeyli
On Wed, Sep 09, 2015 at 01:24:08PM +0100, Matt Fleming wrote: > On Thu, 27 Aug, at 06:21:44PM, joeyli wrote: > > On Fri, Aug 21, 2015 at 02:27:53PM +0100, Matt Fleming wrote: > > > On Tue, 11 Aug, at 02:16:29PM, Lee, Chun-Yi wrote: > > > > +static int __i

Re: [PATCH v2 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-09-12 Thread joeyli
On Wed, Sep 09, 2015 at 01:15:45PM +0100, Matt Fleming wrote: > On Thu, 27 Aug, at 05:04:52PM, joeyli wrote: > > > > The purpose of checking attribute of hibernation key variable is > > in case someone created a key variable on runtime environment _before_ > > this

Re: [PATCH] x86/efi: Map EFI memmap entries in-order at runtime

2015-09-09 Thread joeyli
Hi, On Wed, Sep 09, 2015 at 12:21:23PM +0100, Matt Fleming wrote: > On Wed, 09 Sep, at 08:33:07AM, joeyli wrote: > > > > Yes, the machine on my hand has EFI_PROPERTIES_TABLE enabled, and it doesn't > > boot without your patch. > > Awesome. Could you

Re: [PATCH] x86/efi: Map EFI memmap entries in-order at runtime

2015-09-08 Thread joeyli
Hi Matt, On Tue, Sep 08, 2015 at 09:41:47PM +0100, Matt Fleming wrote: > On Mon, 07 Sep, at 12:07:52PM, joeyli wrote: > > > > This patch works to me on Intel S1200V3RPS to fix issue: > > DMI: Intel Corporation (uefidk.com) Intel Server Board S1200V3RPS UEFI > > Devel

Re: [PATCH] x86/efi: Map EFI memmap entries in-order at runtime

2015-09-06 Thread joeyli
Hi, On Fri, Sep 04, 2015 at 02:14:07PM +0100, Matt Fleming wrote: > From: Matt Fleming > > Beginning with UEFI v2.5 EFI_PROPERTIES_TABLE was introduced that > signals that the firmware PE/COFF loader supports splitting code and > data sections of PE/COFF images into separate EFI memory map entr

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-08-27 Thread joeyli
On Fri, Aug 21, 2015 at 02:27:53PM +0100, Matt Fleming wrote: > On Tue, 11 Aug, at 02:16:29PM, Lee, Chun-Yi wrote: > > Add handler to parse the setup data that carrying hibernation key, it > > reserves hibernation key by memblock then copies key to a allocated page > > in later initcall stage. > >

Re: [PATCH v2 08/16] x86/efi: Carrying hibernation key by setup data

2015-08-27 Thread joeyli
On Fri, Aug 21, 2015 at 01:40:26PM +0100, Matt Fleming wrote: > On Tue, 11 Aug, at 02:16:28PM, Lee, Chun-Yi wrote: > > For forwarding hibernation key from EFI stub to boot kernel, this patch > > allocates setup data for carrying hibernation key, size and the status > > of efi operating. > > This

Re: [PATCH v2 07/16] efi: Make efi_status_to_err() public

2015-08-27 Thread joeyli
On Thu, Aug 20, 2015 at 04:07:06PM +0100, Matt Fleming wrote: > On Tue, 11 Aug, at 02:16:27PM, Lee, Chun-Yi wrote: > > Moved the function of transferring EFI status to kernel error for > > later used by EFI stub. > > Might I suggest: > > "Move the function for converting EFI status to kernel er

Re: [PATCH v2 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-08-27 Thread joeyli
On Thu, Aug 20, 2015 at 09:40:44PM +0100, Matt Fleming wrote: > On Tue, 11 Aug, at 02:16:26PM, Lee, Chun-Yi wrote: > > This patch adds codes in EFI stub for generating and storing the > > HMAC key in EFI boot service variable for signing hibernate image. > > > > Per rcf2104, the length of HMAC-SHA

Re: [PATCH v2 05/16] x86/efi: Get entropy through EFI random number generator protocol

2015-08-26 Thread joeyli
On Thu, Aug 20, 2015 at 09:26:20PM +0100, Matt Fleming wrote: > On Tue, 11 Aug, at 02:16:25PM, Lee, Chun-Yi wrote: > > + > > +static unsigned long efi_get_rng64(efi_system_table_t *sys_table, > > + void **rng_handle) > > +{ > > + const struct efi_config *efi_early = _

Re: [PATCH v2 05/16] x86/efi: Get entropy through EFI random number generator protocol

2015-08-26 Thread joeyli
On Thu, Aug 20, 2015 at 03:47:06PM +0100, Matt Fleming wrote: > On Tue, 11 Aug, at 02:16:25PM, Lee, Chun-Yi wrote: > > To grab random numbers through EFI protocol as one of the entropies > > source of swsusp key, this patch adds the logic for accessing EFI RNG > > (random number generator) protocol

Re: [PATCH v2 04/16] x86/efi: Generating random number in EFI stub

2015-08-26 Thread joeyli
Hi Matt, Thanks for your reviewing and sorry for my delay. On Thu, Aug 20, 2015 at 03:12:21PM +0100, Matt Fleming wrote: > On Tue, 11 Aug, at 02:16:24PM, Lee, Chun-Yi wrote: > > This patch adds the codes for generating random number array as the > > HMAC key that will used by later EFI stub code

Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address

2015-08-19 Thread joeyli
On Wed, Aug 19, 2015 at 05:31:45PM +0100, Matt Fleming wrote: > On Thu, 30 Jul, at 10:16:01PM, joeyli wrote: > > > > Thanks for your explanation. > > > > For my issue, I will check if rewriting the VA of runtime services can fix > > issue. > > If not, t

Re: [PATCH v2 08/16] x86/efi: Carrying hibernation key by setup data

2015-08-15 Thread joeyli
On Sat, Aug 15, 2015 at 07:07:38PM +0200, Pavel Machek wrote: > On Tue 2015-08-11 14:16:28, Lee, Chun-Yi wrote: > > For forwarding hibernation key from EFI stub to boot kernel, this patch > > allocates setup data for carrying hibernation key, size and the status > > of efi operating. > > > > Revie

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-08-13 Thread joeyli
On Tue, Aug 11, 2015 at 02:16:29PM +0800, Lee, Chun-Yi wrote: > Add handler to parse the setup data that carrying hibernation key, it > reserves hibernation key by memblock then copies key to a allocated page > in later initcall stage. > [...snip] > diff --git a/arch/x86/power/hibernate_keys.c b/a

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-08-12 Thread joeyli
Hi Yu, Thanks for your reviewing. On Thu, Aug 13, 2015 at 02:45:32AM +, Chen, Yu C wrote: > Hi Chun-yi, > On Tue, 2015-08-11 at 14:16 +0800, Lee, Chun-Yi wrote: > > > +/* A page used to keep hibernation keys */ > > +static struct hibernation_keys *hibernation_keys; > > + > > +void __init pa

Re: [RFC PATCH 05/16] x86/efi: Get entropy through EFI random number generator protocol

2015-07-31 Thread joeyli
On Fri, Jul 31, 2015 at 01:01:18PM +0100, Matt Fleming wrote: > On Fri, 2015-07-31 at 17:58 +0800, joeyli wrote: > > > > > > Can you do something to avoid each function having two very similar > > > versions of these functions? > > > > > > &

Re: [RFC PATCH 01/16] PM / hibernate: define HMAC algorithm and digest size of swsusp

2015-07-31 Thread joeyli
On Fri, Jul 31, 2015 at 02:49:36PM +0200, Pavel Machek wrote: > On Fri 2015-07-31 18:08:12, joeyli wrote: > > On Tue, Jul 28, 2015 at 02:01:56PM +0200, Pavel Machek wrote: > > > On Thu 2015-07-16 22:25:15, Lee, Chun-Yi wrote: > > > > Using HMAC-SHA1 to be the HMAC

Re: [RFC PATCH 09/16] PM / hibernate: Reserve swsusp key and earse footprints

2015-07-31 Thread joeyli
On Tue, Jul 28, 2015 at 02:35:23PM +0200, Pavel Machek wrote: > Typo in patch subject. > > > And for earsing footbprints, the codes in this patch remove setup > > And two typos here. > Sorry for subject and above typos, I will fix it. Thanks. > > data that carried swsusp key, and clean the mem

Re: [RFC PATCH 08/16] x86/efi: Carrying swsusp key by setup data

2015-07-31 Thread joeyli
On Thu, Jul 30, 2015 at 05:30:09PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > For forwarding swsusp key from EFI stub to boot kernel, this patch > > allocates setup data for carrying swsusp key, size and the status > > of efi operating. > > > > Signed-o

Re: [RFC PATCH 07/16] efi: Public the function of transferring EFI status to kernel error

2015-07-31 Thread joeyli
On Thu, Jul 30, 2015 at 05:23:22PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > Moved the function of transferring EFI status to kernel error for > > later used by EFI stub. > > > > Signed-off-by: Lee, Chun-Yi > > --- > > drivers/firmware/efi/vars.c | 3

Re: [RFC PATCH 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-07-31 Thread joeyli
On Thu, Jul 30, 2015 at 05:20:46PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > This patch adds codes in EFI stub for generating and storing the > > HMAC key in EFI boot service variable for signing hibernate image. > > > > Per rcf2104, the length of HMAC

Re: [RFC PATCH 05/16] x86/efi: Get entropy through EFI random number generator protocol

2015-07-31 Thread joeyli
On Fri, Jul 31, 2015 at 10:59:12PM +0800, joeyli wrote: > On Thu, Jul 30, 2015 at 05:11:44PM +0100, Matt Fleming wrote: > > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > > To grab random numbers through EFI protocol as one of the entropies > > > source of

Re: [RFC PATCH 05/16] x86/efi: Get entropy through EFI random number generator protocol

2015-07-31 Thread joeyli
On Thu, Jul 30, 2015 at 05:11:44PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > To grab random numbers through EFI protocol as one of the entropies > > source of swsusp key, this patch adds the logic for accessing EFI RNG > > (random number generator) prot

Re: [RFC PATCH 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-07-31 Thread joeyli
On Tue, Jul 28, 2015 at 02:30:26PM +0200, Pavel Machek wrote: > > > For generating a messy number as a 20 bytes key, the codes in EFI > > stub gets u32 random number five time and every random number is > > rolling that last u32 random number as entropy. > > Parse error here. > Sorry for I didn'

Re: [RFC PATCH 03/16] x86/boot: Public getting random boot function

2015-07-31 Thread joeyli
On Tue, Jul 28, 2015 at 02:21:33PM +0200, Pavel Machek wrote: > Hi! > > > int cmdline_find_option_bool(const char *option); > > #endif > > > > +#if CONFIG_RANDOMIZE_BASE > > Not ifdef? > > > +extern u16 i8254(void); > > That's rather poor name for global function... This i8254 function onl

Re: [RFC PATCH 02/16] x86/efi: Add get and set variable to EFI services pointer table

2015-07-31 Thread joeyli
On Thu, Jul 30, 2015 at 04:19:58PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > Add get variable and set variable function to EFI services pointer > > table for supporting later functions of hibernate signature > > verification to keep the HMAC key in efi

Re: [RFC PATCH 01/16] PM / hibernate: define HMAC algorithm and digest size of swsusp

2015-07-31 Thread joeyli
On Tue, Jul 28, 2015 at 02:01:56PM +0200, Pavel Machek wrote: > On Thu 2015-07-16 22:25:15, Lee, Chun-Yi wrote: > > Using HMAC-SHA1 to be the HMAC algorithm of signing hibernate > > snapshot image. The digest size of HMAC-SHA1 is 160 bits (20 bytes), > > this size will be also applied to the length

Re: [RFC PATCH 05/16] x86/efi: Get entropy through EFI random number generator protocol

2015-07-31 Thread joeyli
On Tue, Jul 28, 2015 at 02:28:53PM +0200, Pavel Machek wrote: > On Thu 2015-07-16 22:25:19, Lee, Chun-Yi wrote: > > To grab random numbers through EFI protocol as one of the entropies > > source of swsusp key, this patch adds the logic for accessing EFI RNG > > (random number generator) protocol th

Re: [RFC PATCH 04/16] x86/efi: Generating random number in EFI stub

2015-07-31 Thread joeyli
Hi Matt, Thanks for your review! On Thu, Jul 30, 2015 at 04:37:42PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > This patch adds the codes for generating random number array as the > > HMAC key that will used by later EFI stub codes. > > > > The origin

Re: [RFC PATCH 04/16] x86/efi: Generating random number in EFI stub

2015-07-31 Thread joeyli
Hi Pavel, Thanks for your review. On Tue, Jul 28, 2015 at 02:01:12PM +0200, Pavel Machek wrote: > Hi! > > > This patch adds the codes for generating random number array as the > > HMAC key that will used by later EFI stub codes. > > > > The original codes in efi_random copied from aslr and add

Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address

2015-07-30 Thread joeyli
On Thu, Jul 30, 2015 at 03:05:42PM +0100, Matt Fleming wrote: > On Thu, 30 Jul, at 09:39:47PM, joeyli wrote: > > > > OK, understood! Thanks for your suggestion! > > > > But, I have a question about mapping Boot Code/Data to -4G area. I > > understand > > w

Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address

2015-07-30 Thread joeyli
On Thu, Jul 30, 2015 at 02:17:23PM +0100, Matt Fleming wrote: > On Thu, 30 Jul, at 08:31:16PM, joeyli wrote: > > > > I think hibernate overwrite it. > > We absolutely must get a more detailed answer before going any further. > > Simply put, if we're remapping

Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address

2015-07-30 Thread joeyli
On Thu, Jul 30, 2015 at 01:09:16PM +0100, Matt Fleming wrote: > On Thu, 30 Jul, at 07:18:19PM, joeyli wrote: > > > > In the above case, just simply accessing EFI variable through efivars to > > reproduce issue: > > > > linux-aiip:~ # hexdump -C > > /sys/f

Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address

2015-07-30 Thread joeyli
On Thu, Jul 30, 2015 at 07:09:59PM +0800, joeyli wrote: > On Thu, Jul 30, 2015 at 11:11:31AM +0100, Matt Fleming wrote: > > On Thu, 30 Jul, at 10:03:23AM, Borislav Petkov wrote: > > > On Thu, Jul 30, 2015 at 12:53:42AM -0700, H. Peter Anvin wrote: > > > > This c

Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address

2015-07-30 Thread joeyli
On Thu, Jul 30, 2015 at 11:11:31AM +0100, Matt Fleming wrote: > On Thu, 30 Jul, at 10:03:23AM, Borislav Petkov wrote: > > On Thu, Jul 30, 2015 at 12:53:42AM -0700, H. Peter Anvin wrote: > > > This changelog is at least partially incomprehensive. It also seems > > > more than a bit aggressive to exp

<    1   2   3   4   >