Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

Hi Zhi, Please see my answer below. On 23.10.2017 14:13, Zhi Mao wrote: > Hi Claudiu > > please check the comments as below. > > Regards > Zhi > > On Mon, 2017-10-23 at 11:22 +0300, m18063 wrote: >> Hi Zhi, >> >> I have few comments regarding your

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

Hi Zhi, Please see my answer below. On 23.10.2017 14:13, Zhi Mao wrote: > Hi Claudiu > > please check the comments as below. > > Regards > Zhi > > On Mon, 2017-10-23 at 11:22 +0300, m18063 wrote: >> Hi Zhi, >> >> I have few comments regarding your

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

Hi Zhi, I have few comments regarding your patch. Please see them below. Thanks, Claudiu On 22.08.2017 05:09, Zhi Mao wrote: > Add support to MT2712 and MT7622. > Due to register offset address of pwm7 for MT2712 is not fixed 0x40, > add mtk_pwm_reg_offset array for pwm register offset. > >

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

Hi Zhi, I have few comments regarding your patch. Please see them below. Thanks, Claudiu On 22.08.2017 05:09, Zhi Mao wrote: > Add support to MT2712 and MT7622. > Due to register offset address of pwm7 for MT2712 is not fixed 0x40, > add mtk_pwm_reg_offset array for pwm register offset. > >

Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic.

Hi Wenyou, On 10.10.2017 03:39, Yang, Wenyou wrote: > Hi Claudiu, > > > On 2017/10/10 0:09, Claudiu Beznea wrote: >> Add charger device node as a sub-device node of act8945a mfd, move >> the charger's properties to this node, and use the "interrupts" >> property to replace

Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic.

Hi Wenyou, On 10.10.2017 03:39, Yang, Wenyou wrote: > Hi Claudiu, > > > On 2017/10/10 0:09, Claudiu Beznea wrote: >> Add charger device node as a sub-device node of act8945a mfd, move >> the charger's properties to this node, and use the "interrupts" >> property to replace

Re: [PATCH 00/14] at91 fixes and enhancements

Please ignore this series since I did some mistakes. I will send version 2. Thank you, Claudiu On 09.10.2017 19:09, Claudiu Beznea wrote: > Hi, > > This series contains fixes and enhancements for Atmel/Microchip boards, > mainly for SoM1-EK board, SAMA5D2 Xplained board and SAM9x5 boards. >

Re: [PATCH 00/14] at91 fixes and enhancements

Please ignore this series since I did some mistakes. I will send version 2. Thank you, Claudiu On 09.10.2017 19:09, Claudiu Beznea wrote: > Hi, > > This series contains fixes and enhancements for Atmel/Microchip boards, > mainly for SoM1-EK board, SAMA5D2 Xplained board and SAM9x5 boards. >

Re: [PATCH 0/2] extend PWM framework to support PWM dead-times

Hi Thierry, Please, do you have any inputs on my previous proposals? Thank you, Claudiu On 22.08.2017 15:24, Benjamin Gaignard wrote: > 2017-08-22 14:11 GMT+02:00 m18063 <claudiu.bez...@microchip.com>: >> Hi Thierry, >> >> I added few other comments below. Please

Re: [PATCH 0/2] extend PWM framework to support PWM dead-times

Hi Thierry, Please, do you have any inputs on my previous proposals? Thank you, Claudiu On 22.08.2017 15:24, Benjamin Gaignard wrote: > 2017-08-22 14:11 GMT+02:00 m18063 : >> Hi Thierry, >> >> I added few other comments below. Please let me know what you think. >&g

Re: [PATCH 0/2] extend PWM framework to support PWM dead-times

On 22.08.2017 15:24, Benjamin Gaignard wrote: > 2017-08-22 14:11 GMT+02:00 m18063 <claudiu.bez...@microchip.com>: >> Hi Thierry, >> >> I added few other comments below. Please let me know what you think. >> >> Thank you, >> Claudiu >> >> O

Re: [PATCH 0/2] extend PWM framework to support PWM dead-times

On 22.08.2017 15:24, Benjamin Gaignard wrote: > 2017-08-22 14:11 GMT+02:00 m18063 : >> Hi Thierry, >> >> I added few other comments below. Please let me know what you think. >> >> Thank you, >> Claudiu >> >> On 21.08.2017 14:25, Thierry Reding

Re: [PATCH 0/2] extend PWM framework to support PWM dead-times

Hi Thierry, I added few other comments below. Please let me know what you think. Thank you, Claudiu On 21.08.2017 14:25, Thierry Reding wrote: > On Mon, Aug 21, 2017 at 01:23:08PM +0300, m18063 wrote: >> Hi Thierry, >> >> Thank you for your response. I added few comments b

Re: [PATCH 0/2] extend PWM framework to support PWM dead-times

Hi Thierry, I added few other comments below. Please let me know what you think. Thank you, Claudiu On 21.08.2017 14:25, Thierry Reding wrote: > On Mon, Aug 21, 2017 at 01:23:08PM +0300, m18063 wrote: >> Hi Thierry, >> >> Thank you for your response. I added few comments b

Re: [PATCH 0/2] extend PWM framework to support PWM dead-times

Hi Thierry, Thank you for your response. I added few comments below. Thank you, Claudiu On 21.08.2017 11:25, Thierry Reding wrote: > On Tue, May 09, 2017 at 03:15:51PM +0300, Claudiu Beznea wrote: >> Hi all, >> >> Please give feedback on these patches which extends the PWM >> framework in order

Re: [PATCH 0/2] extend PWM framework to support PWM dead-times

Hi Thierry, Thank you for your response. I added few comments below. Thank you, Claudiu On 21.08.2017 11:25, Thierry Reding wrote: > On Tue, May 09, 2017 at 03:15:51PM +0300, Claudiu Beznea wrote: >> Hi all, >> >> Please give feedback on these patches which extends the PWM >> framework in order

Re: [PATCH] mtd: spi-nor: add support for Microchip sst26vf064b QSPI memory

On 14.08.2017 19:03, Cyrille Pitchen wrote: > Le 01/08/2017 à 23:57, Cyrille Pitchen a écrit : >> Hi Claudiu, >> >> Le 28/07/2017 à 11:41, Claudiu Beznea a écrit : >>> Add support for Microchip sst26vf064b QSPI memory. >>> >>> Signed-off-by: Claudiu Beznea >>> ---

Re: [PATCH] mtd: spi-nor: add support for Microchip sst26vf064b QSPI memory

On 14.08.2017 19:03, Cyrille Pitchen wrote: > Le 01/08/2017 à 23:57, Cyrille Pitchen a écrit : >> Hi Claudiu, >> >> Le 28/07/2017 à 11:41, Claudiu Beznea a écrit : >>> Add support for Microchip sst26vf064b QSPI memory. >>> >>> Signed-off-by: Claudiu Beznea >>> --- >>>

Re: [PATCH 1/2] drivers: pwm: core: implement pwm mode

Hello Thierry, I know you may be very busy but do you have any resolution regarding this series and the one with title "[PATCH v2 0/2] extends PWM framework to support PWM dead-times" Thank you, Claudiu On 09.05.2017 15:15, Claudiu Beznea - M18063 wrote: > Extends PWM framework t

Re: [PATCH 1/2] drivers: pwm: core: implement pwm mode

Hello Thierry, I know you may be very busy but do you have any resolution regarding this series and the one with title "[PATCH v2 0/2] extends PWM framework to support PWM dead-times" Thank you, Claudiu On 09.05.2017 15:15, Claudiu Beznea - M18063 wrote: > Extends PWM framework t

Re: [PATCH 3/3] dt-bindings: i2c: eeprom: document "mac-offset" binding

On 10.07.2017 06:46, Rob Herring wrote: > On Thu, Jul 06, 2017 at 01:16:57PM +0300, Claudiu Beznea wrote: >> Document "mac-offset" binding that will be used by at24 EEPROM driver. >> >> Signed-off-by: Claudiu Beznea >> --- >>

Re: [PATCH 3/3] dt-bindings: i2c: eeprom: document "mac-offset" binding

On 10.07.2017 06:46, Rob Herring wrote: > On Thu, Jul 06, 2017 at 01:16:57PM +0300, Claudiu Beznea wrote: >> Document "mac-offset" binding that will be used by at24 EEPROM driver. >> >> Signed-off-by: Claudiu Beznea >> --- >> Documentation/devicetree/bindings/eeprom/eeprom.txt | 3 +++ >> 1

Re: [PATCH v2 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support

On 05.07.2017 18:29, Nicolas Ferre wrote: > On 05/07/2017 at 17:23, Ludovic Desroches wrote: >> On Mon, Jul 03, 2017 at 03:56:11PM +0300, Claudiu Beznea wrote: >>> Add specific DTS file and bindings for sama5d27 SoM1 board. >>> >>> Signed-off-by: Claudiu Beznea >>>

Re: [PATCH v2 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support

On 05.07.2017 18:29, Nicolas Ferre wrote: > On 05/07/2017 at 17:23, Ludovic Desroches wrote: >> On Mon, Jul 03, 2017 at 03:56:11PM +0300, Claudiu Beznea wrote: >>> Add specific DTS file and bindings for sama5d27 SoM1 board. >>> >>> Signed-off-by: Claudiu Beznea >>> Signed-off-by: Cristian

Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses

On 30.06.2017 10:20, Uwe Kleine-König wrote: > Hallo, > > On Thu, Jun 29, 2017 at 02:39:10PM +0300, Claudiu Beznea wrote: >> diff --git a/include/linux/platform_data/at24.h >> b/include/linux/platform_data/at24.h >> index 271a4e2..d55c454 100644 >> --- a/include/linux/platform_data/at24.h >>

Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses

On 29.06.2017 18:32, David Lechner wrote: > On 06/29/2017 06:39 AM, Claudiu Beznea wrote: >> Add support for reading from different offsets of EEPROM. >> The offset is initialized via device tree. If nothing is >> given as input the old value, 0x90, is used. In this way >> the driver could be

Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses

On 30.06.2017 10:20, Uwe Kleine-König wrote: > Hallo, > > On Thu, Jun 29, 2017 at 02:39:10PM +0300, Claudiu Beznea wrote: >> diff --git a/include/linux/platform_data/at24.h >> b/include/linux/platform_data/at24.h >> index 271a4e2..d55c454 100644 >> --- a/include/linux/platform_data/at24.h >>

Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses

On 29.06.2017 18:32, David Lechner wrote: > On 06/29/2017 06:39 AM, Claudiu Beznea wrote: >> Add support for reading from different offsets of EEPROM. >> The offset is initialized via device tree. If nothing is >> given as input the old value, 0x90, is used. In this way >> the driver could be

Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses

On 29.06.2017 16:30, Ludovic Desroches wrote: > On Thu, Jun 29, 2017 at 02:56:03PM +0300, Andy Shevchenko wrote: >> On Thu, Jun 29, 2017 at 2:39 PM, Claudiu Beznea >> wrote: >>> Add support for reading from different offsets of EEPROM. >>> The offset is initialized

Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses

On 29.06.2017 16:30, Ludovic Desroches wrote: > On Thu, Jun 29, 2017 at 02:56:03PM +0300, Andy Shevchenko wrote: >> On Thu, Jun 29, 2017 at 2:39 PM, Claudiu Beznea >> wrote: >>> Add support for reading from different offsets of EEPROM. >>> The offset is initialized via device tree. If nothing

Re: [PATCH 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support

On 30.06.2017 15:57, Ludovic Desroches wrote: > On Fri, Jun 30, 2017 at 03:38:22PM +0300, m18063 wrote: >> Hi Ludovic, >> >> On 29.06.2017 17:58, Ludovic Desroches wrote: >>> On Thu, Jun 29, 2017 at 02:44:33PM +0300, Claudiu Beznea wrote: >>>> Add specif

Re: [PATCH 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support

On 30.06.2017 15:57, Ludovic Desroches wrote: > On Fri, Jun 30, 2017 at 03:38:22PM +0300, m18063 wrote: >> Hi Ludovic, >> >> On 29.06.2017 17:58, Ludovic Desroches wrote: >>> On Thu, Jun 29, 2017 at 02:44:33PM +0300, Claudiu Beznea wrote: >>>> Add specif

Re: [PATCH 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support

Hi Ludovic, On 29.06.2017 17:58, Ludovic Desroches wrote: > On Thu, Jun 29, 2017 at 02:44:33PM +0300, Claudiu Beznea wrote: >> Add specific DTS file and bindings for sama5d27 SoM1 board. >> >> Signed-off-by: Claudiu Beznea >> Signed-off-by: Cristian Birsan

Re: [PATCH 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support

Hi Ludovic, On 29.06.2017 17:58, Ludovic Desroches wrote: > On Thu, Jun 29, 2017 at 02:44:33PM +0300, Claudiu Beznea wrote: >> Add specific DTS file and bindings for sama5d27 SoM1 board. >> >> Signed-off-by: Claudiu Beznea >> Signed-off-by: Cristian Birsan >> --- >>

Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support

Hi Ludovic, On 29.06.2017 18:04, Ludovic Desroches wrote: > On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: >> Add specifig DTS files and bindings for sama5d27 SoM1 EK board. >> >> Signed-off-by: Claudiu Beznea >> Signed-off-by: Cristian Birsan

Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support

Hi Ludovic, On 29.06.2017 18:04, Ludovic Desroches wrote: > On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: >> Add specifig DTS files and bindings for sama5d27 SoM1 EK board. >> >> Signed-off-by: Claudiu Beznea >> Signed-off-by: Cristian Birsan >> --- >>

Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support

Hi Baruch, Alexandre On 29.06.2017 15:16, Alexandre Belloni wrote: > On 29/06/2017 at 14:59:31 +0300, Baruch Siach wrote: >> Hi Claudiu, >> >> On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: >>> Add specifig DTS files and bindings for sama5d27 SoM1 EK board. >> >> Is there any

Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support

Hi Baruch, Alexandre On 29.06.2017 15:16, Alexandre Belloni wrote: > On 29/06/2017 at 14:59:31 +0300, Baruch Siach wrote: >> Hi Claudiu, >> >> On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: >>> Add specifig DTS files and bindings for sama5d27 SoM1 EK board. >> >> Is there any

Re: [PATCH v2 5/6] pwm: mediatek: add PWM_CLK_DIV_MAX

On 23.06.2017 08:08, Zhi Mao wrote: > Replace "7" with "PWM_CLK_DIV_MAX" in function:mtk_pwm_config() > to improve the code readablity. > > Signed-off-by: Zhi Mao > --- > drivers/pwm/pwm-mediatek.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff

Re: [PATCH v2 5/6] pwm: mediatek: add PWM_CLK_DIV_MAX

On 23.06.2017 08:08, Zhi Mao wrote: > Replace "7" with "PWM_CLK_DIV_MAX" in function:mtk_pwm_config() > to improve the code readablity. > > Signed-off-by: Zhi Mao > --- > drivers/pwm/pwm-mediatek.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v2] ARM: dts: at91: sama5d2_xplained: add pwm controller

On 31.05.2017 11:50, Alexandre Belloni wrote: > Hi, > > On 23/02/2017 at 10:49:17 +0200, Claudiu Beznea wrote: >> Add pwm controller bindings for sam5d2_xplained >> and enable it. >> >> Changes since v1: >> - Correct the typo in patch subject. >> >> Signed-off-by: Claudiu Beznea

Re: [PATCH v2] ARM: dts: at91: sama5d2_xplained: add pwm controller

On 31.05.2017 11:50, Alexandre Belloni wrote: > Hi, > > On 23/02/2017 at 10:49:17 +0200, Claudiu Beznea wrote: >> Add pwm controller bindings for sam5d2_xplained >> and enable it. >> >> Changes since v1: >> - Correct the typo in patch subject. >> >> Signed-off-by: Claudiu Beznea >> --- >>

Re: [PATCH v2 1/2] drivers: pwm: core: implement pwm dead-times

Hi Andy, On 28.05.2017 01:28, Andy Shevchenko wrote: > On Tue, May 9, 2017 at 11:19 AM, Claudiu Beznea > wrote: >> Extends PWM framework to support PWM dead-times. >> The notions introduced are rising edge dead-time >> and falling edge dead-time. These are useful

Re: [PATCH v2 1/2] drivers: pwm: core: implement pwm dead-times

Hi Andy, On 28.05.2017 01:28, Andy Shevchenko wrote: > On Tue, May 9, 2017 at 11:19 AM, Claudiu Beznea > wrote: >> Extends PWM framework to support PWM dead-times. >> The notions introduced are rising edge dead-time >> and falling edge dead-time. These are useful for >> PWM controllers with

Re: [PATCH 1/2] drivers: pwm: core: implement pwm mode

Hi Andy, On 28.05.2017 01:11, Andy Shevchenko wrote: > On Tue, May 9, 2017 at 3:15 PM, Claudiu Beznea > wrote: >> Extends PWM framework to support PWM modes. The currently >> implemented PWM modes were called PWM complementary mode >> and PWM push-pull mode. For

Re: [PATCH 1/2] drivers: pwm: core: implement pwm mode

Hi Andy, On 28.05.2017 01:11, Andy Shevchenko wrote: > On Tue, May 9, 2017 at 3:15 PM, Claudiu Beznea > wrote: >> Extends PWM framework to support PWM modes. The currently >> implemented PWM modes were called PWM complementary mode >> and PWM push-pull mode. For devices that have more than one

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

On 11.04.2017 11:56, Boris Brezillon wrote: > On Tue, 11 Apr 2017 11:22:39 +0300 > m18063 <claudiu.bez...@microchip.com> wrote: > >> Hi Boris, >> >> On 10.04.2017 17:35, Boris Brezillon wrote: >>> On Mon, 10 Apr 2017 17:20:20 +0300 >>>

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

On 11.04.2017 11:56, Boris Brezillon wrote: > On Tue, 11 Apr 2017 11:22:39 +0300 > m18063 wrote: > >> Hi Boris, >> >> On 10.04.2017 17:35, Boris Brezillon wrote: >>> On Mon, 10 Apr 2017 17:20:20 +0300 >>> Claudiu Beznea wrote: >>> >&

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

On 11.04.2017 11:50, Boris Brezillon wrote: > On Tue, 11 Apr 2017 11:33:44 +0300 > m18063 <claudiu.bez...@microchip.com> wrote: > >> On 10.04.2017 19:27, Boris Brezillon wrote: >>> On Mon, 10 Apr 2017 18:01:37 +0200 >>> Boris Brezillon <

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

On 11.04.2017 11:50, Boris Brezillon wrote: > On Tue, 11 Apr 2017 11:33:44 +0300 > m18063 wrote: > >> On 10.04.2017 19:27, Boris Brezillon wrote: >>> On Mon, 10 Apr 2017 18:01:37 +0200 >>> Boris Brezillon wrote: >>> >>>> On Mon,

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

On 10.04.2017 19:27, Boris Brezillon wrote: > On Mon, 10 Apr 2017 18:01:37 +0200 > Boris Brezillon wrote: > >> On Mon, 10 Apr 2017 17:10:11 +0200 >> Thierry Reding wrote: >> >>> On Mon, Apr 10, 2017 at 04:35:58PM +0200, Boris

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

On 10.04.2017 19:27, Boris Brezillon wrote: > On Mon, 10 Apr 2017 18:01:37 +0200 > Boris Brezillon wrote: > >> On Mon, 10 Apr 2017 17:10:11 +0200 >> Thierry Reding wrote: >> >>> On Mon, Apr 10, 2017 at 04:35:58PM +0200, Boris Brezillon wrote: On Mon, 10 Apr 2017 17:20:20 +0300

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

Hi Boris, On 10.04.2017 17:35, Boris Brezillon wrote: > On Mon, 10 Apr 2017 17:20:20 +0300 > Claudiu Beznea wrote: > >> Implement suspend and resume power management specific >> function to allow PWM controller to correctly suspend >> and resume. >> >>

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

Hi Boris, On 10.04.2017 17:35, Boris Brezillon wrote: > On Mon, 10 Apr 2017 17:20:20 +0300 > Claudiu Beznea wrote: > >> Implement suspend and resume power management specific >> function to allow PWM controller to correctly suspend >> and resume. >> >> Signed-off-by: Claudiu Beznea >> --- >>

Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller

Hi Alexandre, Sorry for the late response, I am seeing just now your question bellow. Thank you, Claudiu Beznea On 23.02.2017 10:42, Alexandre Belloni wrote: > Hi, > > There is a typo in your subject, please fix. > > On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote: >> Add pwm controller

Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller

Hi Alexandre, Sorry for the late response, I am seeing just now your question bellow. Thank you, Claudiu Beznea On 23.02.2017 10:42, Alexandre Belloni wrote: > Hi, > > There is a typo in your subject, please fix. > > On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote: >> Add pwm controller

Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

On 27.03.2017 16:15, Alexandre Belloni wrote: > On 27/03/2017 at 15:02:37 +0200, Boris Brezillon wrote: >> Hi Claudiu, >> >> On Wed, 22 Mar 2017 15:29:34 +0200 >> Claudiu Beznea wrote: >> >>> static const struct platform_device_id atmel_pwm_devtypes[] = { >>> {

Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

On 27.03.2017 16:15, Alexandre Belloni wrote: > On 27/03/2017 at 15:02:37 +0200, Boris Brezillon wrote: >> Hi Claudiu, >> >> On Wed, 22 Mar 2017 15:29:34 +0200 >> Claudiu Beznea wrote: >> >>> static const struct platform_device_id atmel_pwm_devtypes[] = { >>> { >>> .name =

Re: [PATCH v2 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

Hi Boris, On 16.03.2017 13:14, Boris Brezillon wrote: > Hi Claudiu, > > On Thu, 2 Mar 2017 17:28:44 +0200 > Claudiu Beznea wrote: > >> The currently Atmel PWM controllers supported by this driver >> could change period or duty factor without channel disable, >> for

Re: [PATCH v2 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

Hi Boris, On 16.03.2017 13:14, Boris Brezillon wrote: > Hi Claudiu, > > On Thu, 2 Mar 2017 17:28:44 +0200 > Claudiu Beznea wrote: > >> The currently Atmel PWM controllers supported by this driver >> could change period or duty factor without channel disable, >> for regular channels (sama5d3

Re: [PATCH 2/2] drivers: pwm: pwm-atmel: enable pwm on sama5d2

Hi, On 03.03.2017 08:21, Rob Herring wrote: > On Tue, Feb 28, 2017 at 12:40:15PM +0200, Claudiu Beznea wrote: >> sama5d2 can use the same atmel_pwm_data as sama5d3. >> >> Signed-off-by: Claudiu Beznea >> --- >> Documentation/devicetree/bindings/pwm/atmel-pwm.txt |

Re: [PATCH 2/2] drivers: pwm: pwm-atmel: enable pwm on sama5d2

Hi, On 03.03.2017 08:21, Rob Herring wrote: > On Tue, Feb 28, 2017 at 12:40:15PM +0200, Claudiu Beznea wrote: >> sama5d2 can use the same atmel_pwm_data as sama5d3. >> >> Signed-off-by: Claudiu Beznea >> --- >> Documentation/devicetree/bindings/pwm/atmel-pwm.txt | 1 + >>

Re: [PATCH 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

Hi Boris, On 01.03.2017 16:13, Boris Brezillon wrote: > Hi Claudiu, > > On Wed, 1 Mar 2017 15:56:26 +0200 > m18063 <claudiu.bez...@microchip.com> wrote: > >> Hi Boris, >> >> Thank you for the closer review. Please see my answers >> inline. >> &g

Re: [PATCH 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

Hi Boris, On 01.03.2017 16:13, Boris Brezillon wrote: > Hi Claudiu, > > On Wed, 1 Mar 2017 15:56:26 +0200 > m18063 wrote: > >> Hi Boris, >> >> Thank you for the closer review. Please see my answers >> inline. >> >> Thank you, >> Cl

Re: [PATCH 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

Hi Boris, Thank you for the closer review. Please see my answers inline. Thank you, Claudiu On 28.02.2017 23:07, Boris Brezillon wrote: > Hi Claudiu, > > On Tue, 28 Feb 2017 12:40:14 +0200 > Claudiu Beznea wrote: > >> The currently Atmel PWM controllers supported

Re: [PATCH 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

Hi Boris, Thank you for the closer review. Please see my answers inline. Thank you, Claudiu On 28.02.2017 23:07, Boris Brezillon wrote: > Hi Claudiu, > > On Tue, 28 Feb 2017 12:40:14 +0200 > Claudiu Beznea wrote: > >> The currently Atmel PWM controllers supported by this driver >> could

Re: [PATCH 1/2] drivers: pwm: pwm-atmel: add support for pwm on sama5d2

Hi, Please ignore this patch also. I will resend it after switching to atomic PWM. Thank you, Claudiu Beznea On 23.02.2017 11:16, Alexandre Belloni wrote: > On 23/02/2017 at 10:38:39 +0200, Claudiu Beznea wrote: >> Enable PWM on sama5d2 by adding atmel_pwm_config_v3(). >> This, simply, sets the

Re: [PATCH 1/2] drivers: pwm: pwm-atmel: add support for pwm on sama5d2

Hi, Please ignore this patch also. I will resend it after switching to atomic PWM. Thank you, Claudiu Beznea On 23.02.2017 11:16, Alexandre Belloni wrote: > On 23/02/2017 at 10:38:39 +0200, Claudiu Beznea wrote: >> Enable PWM on sama5d2 by adding atmel_pwm_config_v3(). >> This, simply, sets the

Re: [PATCH 2/2] drivers: pwm: pwm-atmel: add support to allow run time changing of pwm parameters

On 23.02.2017 12:32, Alexandre Belloni wrote: > On 23/02/2017 at 12:25:58 +0200, m18063 wrote: >>> It is probably worth switching to atomic PWM instead of changing this >>> function. This would simplify the whole driver. >> I was thinking to switch to atomic PWM in a fu

Re: [PATCH 2/2] drivers: pwm: pwm-atmel: add support to allow run time changing of pwm parameters

On 23.02.2017 12:32, Alexandre Belloni wrote: > On 23/02/2017 at 12:25:58 +0200, m18063 wrote: >>> It is probably worth switching to atomic PWM instead of changing this >>> function. This would simplify the whole driver. >> I was thinking to switch to atomic PWM in a fu

Re: [PATCH 2/2] drivers: pwm: pwm-atmel: add support to allow run time changing of pwm parameters

Hi, On 23.02.2017 11:21, Alexandre Belloni wrote: > On 23/02/2017 at 10:38:40 +0200, Claudiu Beznea wrote: >> sama5d2 supports changing of pwm parameters like period and >> duty factor without first to disable pwm. Since pwm code >> is supported by more than one SoC add allow_runtime_cfg >>

Re: [PATCH 2/2] drivers: pwm: pwm-atmel: add support to allow run time changing of pwm parameters

Hi, On 23.02.2017 11:21, Alexandre Belloni wrote: > On 23/02/2017 at 10:38:40 +0200, Claudiu Beznea wrote: >> sama5d2 supports changing of pwm parameters like period and >> duty factor without first to disable pwm. Since pwm code >> is supported by more than one SoC add allow_runtime_cfg >>

Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller

Hi, I will correct it asap. Thank you, Claudiu Beznea On 23.02.2017 10:42, Alexandre Belloni wrote: > Hi, > > There is a typo in your subject, please fix. > > On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote: >> Add pwm controller bindings for sam5d2_xplained >> and enable it. >> >>

Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller

Hi, I will correct it asap. Thank you, Claudiu Beznea On 23.02.2017 10:42, Alexandre Belloni wrote: > Hi, > > There is a typo in your subject, please fix. > > On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote: >> Add pwm controller bindings for sam5d2_xplained >> and enable it. >> >>