On Wed, Feb 3, 2021 at 6:58 PM Andrii Nakryiko
wrote:
>
> On Wed, Feb 3, 2021 at 5:31 PM Nick Desaulniers
> wrote:
> >
> > On Sun, Jan 17, 2021 at 12:14 PM Arnaldo Carvalho de Melo
> > wrote:
> > >
> > > Em Fri, Jan 15, 202
On Sun, Jan 17, 2021 at 12:14 PM Arnaldo Carvalho de Melo
wrote:
>
> Em Fri, Jan 15, 2021 at 03:43:06PM -0800, Yonghong Song escreveu:
> >
> >
> > On 1/15/21 3:34 PM, Nick Desaulniers wrote:
> > > On Fri, Jan 15, 2021 at 3:24 PM Yonghong Song wrote:
> > &
On Wed, Feb 3, 2021 at 3:07 PM Masahiro Yamada wrote:
>
> Nick, the patch set is getting simpler and simpler,
> and almost good enough to be merged.
I agree. I think Sedat pointed out a binutils 2.35.2 release; thanks
to Nick Clifton for that.
>
>
> Please let me ask t
On Wed, Feb 3, 2021 at 2:24 PM Masahiro Yamada wrote:
>
> On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor wrote:
> >
> > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote:
> > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is
gt; Acked-by: Nathan Chancellor
Thanks Masahiro.
Reviewed-by: Nick Desaulniers
> ---
>
> Changes in v2:
> - Drop the spdxcheck.py change. The same fix exists in linux-next.
>
> scripts/clang-tools/gen_compile_commands.py | 2 +-
> scripts/clang-tools/run-clang-tools.py | 2
On Tue, Feb 2, 2021 at 3:36 PM Josh Poimboeuf wrote:
>
> On Tue, Feb 02, 2021 at 02:33:38PM -0800, Nick Desaulniers wrote:
> > On Mon, Feb 1, 2021 at 4:02 PM Josh Poimboeuf wrote:
> > >
> > > On Mon, Feb 01, 2021 at 03:17:40PM -0800, Nick Desaulniers wrote:
> >
On Tue, Feb 2, 2021 at 12:57 AM Julien Thierry wrote:
>
>
>
> On 2/2/21 12:17 AM, Nick Desaulniers wrote:
> > On Mon, Feb 1, 2021 at 1:44 PM Josh Poimboeuf wrote:
> >>
> >> On Fri, Jan 29, 2021 at 10:10:01AM -0800, Nick Desaulniers wrote:
> >>>
On Mon, Feb 1, 2021 at 4:02 PM Josh Poimboeuf wrote:
>
> On Mon, Feb 01, 2021 at 03:17:40PM -0800, Nick Desaulniers wrote:
> > On the earlier thread, Julien writes:
> >
> > >> I think most people interested in livepatching are using GCC built
> > >> k
On Mon, Feb 1, 2021 at 1:44 PM Josh Poimboeuf wrote:
>
> On Fri, Jan 29, 2021 at 10:10:01AM -0800, Nick Desaulniers wrote:
> > On Wed, Jan 27, 2021 at 3:27 PM Josh Poimboeuf wrote:
> > >
> > > On Wed, Jan 27, 2021 at 02:15:57PM -0800, Nick Desaulniers wrote:
0 is always
false [-Wtautological-unsigned-zero-compare]
if (arg < 0) {
~~~ ^ ~
gcc:
warning: comparison of unsigned expression in '< 0' is always false
[-Wtype-limits]
3 | if (arg < 0) {
| ^
>
> P.S. If anyone wants to file a feature request bug with the Clang
> developers, feel free. :-)
--
Thanks,
~Nick Desaulniers
On Mon, Feb 1, 2021 at 1:38 PM Theodore Ts'o wrote:
>
> On Mon, Feb 01, 2021 at 01:16:19PM -0800, Nick Desaulniers wrote:
> > I agree; Vinicius, my recommendation for -Wunreachable-* with Clang
> > was to see whether dead code identified by this more aggressive
> > d
d
to be pushed. It's not clear to maintainers that:
1. this warning is not on by default
2. we're not looking to pursue turning this on by default
If maintainers want to keep the dead code, that's fine, let them and
move on to the next instance to see if that's interesting (or not).
--
Thanks,
~Nick Desaulniers
git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
> index bc87200f9c7c..cbdb5c83c08f 100755
> --- a/scripts/spdxcheck.py
> +++ b/scripts/spdxcheck.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
> # SPDX-License-Identifier: GPL-2.0
> # Copyright Thomas Gleixner
>
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
ong
Suggested-by: Jakub Jelinek
Suggested-by: Masahiro Yamada
Suggested-by: Nathan Chancellor
Signed-off-by: Nick Desaulniers
---
Makefile | 1 +
include/asm-generic/vmlinux.lds.h | 7 ++-
lib/Kconfig.debug | 18 ++
scri
as per Masahiro.
* remove -u from test_dwarf5_support.sh as per Masahiro.
* add a -gdwarf-5 cc-option check to Kconfig as per Jakub.
Nick Desaulniers (2):
Kbuild: make DWARF version a choice
Kbuild: implement support for DWARF v5
Makefile | 6 +++---
include/asm
Suggested-by: Fangrui Song
Suggested-by: Nathan Chancellor
Suggested-by: Masahiro Yamada
Signed-off-by: Nick Desaulniers
---
Makefile | 5 ++---
lib/Kconfig.debug | 16 +++-
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile
index
On Fri, Jan 29, 2021 at 4:08 PM Sedat Dilek wrote:
>
> On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers
> wrote:
> >
> > DWARF v5 is the latest standard of the DWARF debug info format.
> >
> > DWARF5 wins significantly in terms of size and especially s
On Fri, Jan 29, 2021 at 3:25 PM Nick Desaulniers
wrote:
>
> On Fri, Jan 29, 2021 at 2:10 PM Jakub Jelinek wrote:
> >
> > On Fri, Jan 29, 2021 at 02:05:59PM -0800, Nick Desaulniers wrote:
> > > Ah, I see. Then I should update the script I add
> > > (script
On Fri, Jan 29, 2021 at 2:10 PM Jakub Jelinek wrote:
>
> On Fri, Jan 29, 2021 at 02:05:59PM -0800, Nick Desaulniers wrote:
> > Ah, I see. Then I should update the script I add
> > (scripts/test_dwarf5_support.sh) to feature detect that bug, since
> > it's the latest of
plicitly). DWARF v2 is quite irrelevant then.
Ok, so I think Arvind's suggestion of "make DEBUG_INFO_DWARF4 a menu
option, just don't add a DEBUG_INFO_DWARF2" makes a lot of sense.
Will drop DEBUG_INFO_DWARF2 in v7.
--
Thanks,
~Nick Desaulniers
On Fri, Jan 29, 2021 at 2:23 PM Sedat Dilek wrote:
>
> On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers
> wrote:
> >
> > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote:
> > >
> > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers
> > > wro
On Fri, Jan 29, 2021 at 1:11 PM Jakub Jelinek wrote:
>
> On Fri, Jan 29, 2021 at 01:05:56PM -0800, Nick Desaulniers wrote:
> > > Wasn't that fixed in GAS?
> > > https://sourceware.org/bugzilla/show_bug.cgi?id=27195
> >
> > $ make LLVM=1 -j72 defconfig
>
On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote:
>
> On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers
> wrote:
> >
> > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote:
> > >
> > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek
> > > wrote:
On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote:
>
> On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote:
> >
> > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers
> > wrote:
> > >
> > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek
> > > wro
On Fri, Jan 29, 2021 at 1:52 PM Fangrui Song wrote:
>
> On 2021-01-29, Nick Desaulniers wrote:
> >diff --git a/include/asm-generic/vmlinux.lds.h
> >b/include/asm-generic/vmlinux.lds.h
> >index 34b7e0d2346c..f8d5455cd87f 100644
> >--- a/include/asm-generic/vmli
On Fri, Jan 29, 2021 at 1:11 PM Jakub Jelinek wrote:
>
> On Fri, Jan 29, 2021 at 01:05:56PM -0800, Nick Desaulniers wrote:
> > > Wasn't that fixed in GAS?
> > > https://sourceware.org/bugzilla/show_bug.cgi?id=27195
> >
> > $ make LLVM=1 -j72 defconfig
>
the other. The profiling data is not portable when switching
toolchains between when the profile was collected, and when it was
used.
--
Thanks,
~Nick Desaulniers
On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote:
>
> On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers
> wrote:
> >
> > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote:
> > >
> > > On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers
> > >
On Fri, Jan 29, 2021 at 12:57 PM Jakub Jelinek wrote:
>
> On Fri, Jan 29, 2021 at 12:48:11PM -0800, Nick Desaulniers wrote:
> > > Should this be...?
> > >
> > > KBUILD_AFLAGS += -Wa,-gdwarf-5
> >
> > No; under the set of conditions Clang is c
On Fri, Jan 29, 2021 at 12:19 PM Nick Desaulniers
wrote:
>
> On Fri, Jan 29, 2021 at 12:17 PM Jakub Jelinek wrote:
> >
> > On Fri, Jan 29, 2021 at 11:43:17AM -0800, Nick Desaulniers wrote:
> > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a cho
On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote:
>
> On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers
> wrote:
> >
> > diff --git a/Makefile b/Makefile
> > index 20141cd9319e..bed8b3b180b8 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -
On Fri, Jan 29, 2021 at 12:17 PM Jakub Jelinek wrote:
>
> On Fri, Jan 29, 2021 at 11:43:17AM -0800, Nick Desaulniers wrote:
> > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an
> > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a
>
e are no more orphan
> warnings.
>
> Link: https://bugs.llvm.org/show_bug.cgi?id=46478
> Link: https://github.com/ClangBuiltLinux/linux/issues/1069
> Reported-by: kernel test robot
> Signed-off-by: Nathan Chancellor
Reviewed-by: Nick Desaulniers
I suspect we're going to need to add modul
ong
Suggested-by: Jakub Jelinek
Suggested-by: Masahiro Yamada
Suggested-by: Nathan Chancellor
Signed-off-by: Nick Desaulniers
---
Makefile | 12
include/asm-generic/vmlinux.lds.h | 6 +-
lib/Kconfig.debug | 18 ++
scri
-by: Fangrui Song
Suggested-by: Nathan Chancellor
Suggested-by: Masahiro Yamada
Signed-off-by: Nick Desaulniers
---
Makefile | 6 +++---
lib/Kconfig.debug | 21 -
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile
index 95ab9856f357
to test_dwarf5_support.sh.
* change echo in test_dwarf5_support.sh as per Masahiro.
* remove -u from test_dwarf5_support.sh as per Masahiro.
* add a -gdwarf-5 cc-option check to Kconfig as per Jakub.
Nick Desaulniers (2):
Kbuild: make DWARF version a choice
Kbuild: implement support for DWARF v5
Makefile
Signed-off-by: Nick Desaulniers
---
Changes V2 -> V3:
* drop changes to test-thumb.c. That file is mutually exclusive with
test-arm.c based on CONFIG_THUMB2_KERNEL. LLVM requires more fixes for
.w suffixes for thumb2 mode.
Changes V1 -> V2:
* Fix additonal swpvsb case in test-arm.c when __LINU
On Wed, Jan 27, 2021 at 3:27 PM Josh Poimboeuf wrote:
>
> On Wed, Jan 27, 2021 at 02:15:57PM -0800, Nick Desaulniers wrote:
> > > From: Raphael Gault
> > >
> > > This plugins comes into play before the final 2 RTL passes of GCC and
> > > detects switch
> On Thu, 28 Jan 2021 at 20:34, Nick Desaulniers
> wrote:
> > + TEST_RX("tbh[pc, r",7, (9f-(1f+4))>>1,", lsl #1]",
> >
> On Thu, Jan 28, 2021 at 1:03 PM Ard Biesheuvel wrote:
> Why is this change needed? Are the resulting opcodes
On Thu, Jan 28, 2021 at 1:19 PM Sedat Dilek wrote:
>
> On Thu, Jan 28, 2021 at 10:12 PM Nick Desaulniers
> wrote:
> >
> > On Thu, Jan 28, 2021 at 12:46 PM Sedat Dilek wrote:
> > >
> > > [ LLVM ]
> > >
> > > Today, I switched over to LLV
t; KCFLAGS=-fprofile-use=vmlinux.profdata LLVM_IAS=1
>
> Config: config-5.11.0-rc5-7-amd64-clang12-pgo
>
>
> [ Conclusion ]
>
> The only statement I can tell you is a "PGO optimized" rebuild with
> LLVM_IAS=1 is compilable but NOT bootable.
Thanks for the extensive testing and report. Can you compress, upload,
and post a link to your kernel image? I would like to take it for a
spin in QEMU and see if I can find what it's doing, then work
backwards from there.
--
Thanks,
~Nick Desaulniers
e.
LGTM, thanks Candle!
Reviewed-by: Nick Desaulniers
>
> Signed-off-by: Candle Sun
> ---
> Changes in v3:
> - Clean some typo.
> - Remove one comment line.
> Changes in v2:
> - Use abs() in place of address comparison.
> ---
> drivers/misc/lkdtm/perms.c | 7 +++
&g
Signed-off-by: Nick Desaulniers
---
arch/arm/probes/kprobes/test-arm.c | 288 ++---
1 file changed, 144 insertions(+), 144 deletions(-)
diff --git a/arch/arm/probes/kprobes/test-arm.c
b/arch/arm/probes/kprobes/test-arm.c
index 977369f1aa48..d31c7ab937fb 100644
--- a/arch/
Thanks for your review.
These are fixed in v5 as following link.
https://lore.kernel.org/patchwork/patch/1372271/
Nick Fan
On Thu, 2021-01-14 at 14:14 -0600, Rob Herring wrote:
> On Tue, Jan 12, 2021 at 02:49:32PM +0800, Nick Fan wrote:
> > Add devicetree schema for Arm Mali Va
Add devicetree schema for Arm Mali Valhall GPU
Define a compatible string for the Mali Valhall GPU
for Mediatek's SoC platform.
Signed-off-by: Nick Fan
---
.../bindings/gpu/arm,mali-valhall.yaml| 217 ++
1 file changed, 217 insertions(+)
create mode 100644
Add a basic GPU node for mt8192.
Signed-off-by: Nick Fan
---
This patch depends on Mediatek power and regulator support.
Listed as following.
[1]https://lore.kernel.org/patchwork/patch/1336293/
[2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013
[3]https
the compiler runtime.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1245
> Link:
> https://github.com/llvm/llvm-project/blob/llvmorg-11.0.1/compiler-rt/lib/ubsan/ubsan_handlers.cpp#L151-L190
> Acked-by: Kees Cook
> Signed-off-by: Nathan Chancellor
Thanks for
generated function declarations.
```
It would help me abuse alcoholcoffee
less to have one less fire.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1210
> Reported-by: Arnd Bergmann
> Signed-off-by: Fangrui Song
> Reviewed-by: Nick Desaulniers
> Reviewed-by: N
On Tue, Jan 12, 2021 at 5:39 PM Nick Desaulniers
wrote:
>
> On Tue, Jan 12, 2021 at 5:31 PM Nathan Chancellor
> wrote:
> >
> > On Wed, Jan 13, 2021 at 08:39:52AM +0800, kernel test robot wrote:
> > > Hi Nathan,
> > >
> > > I love your patch! Perha
> From: Raphael Gault
>
> This plugins comes into play before the final 2 RTL passes of GCC and
> detects switch-tables that are to be outputed in the ELF and writes
> information in an ".discard.switch_table_info" section which will be
> used by objtool.
>
> Signed-off-by: Raphael Gault
>
On Tue, Jan 26, 2021 at 2:53 PM David Laight wrote:
>
> From: Nick Desaulniers
> > Sent: 26 January 2021 18:40
> >
> > On Tue, Jan 26, 2021 at 6:13 AM Candle Sun wrote:
> > >
> > > On Mon, Jan 25, 2021 at 6:37 PM David Laight
> > > wrote:
nothing;
> + size = (size_t)abs((uintptr_t)do_overwritten - (uintptr_t)do_nothing);
> ptr = (unsigned char *)do_overwritten;
>
> pr_info("attempting bad %zu byte write at %px\n", size, ptr);
> --
> 2.17.0
>
--
Thanks,
~Nick Desaulniers
On Tue, Jan 26, 2021 at 1:27 PM Nathan Chancellor wrote:
>
> Use my @kernel.org for all points of contact so that I am always
> accessible.
>
> Signed-off-by: Nathan Chancellor
Acked-by: Nick Desaulniers
> ---
> .mailmap| 1 +
> MAINTAINERS | 2 +-
> 2 files
pting bad %zu byte write at %px\n", size, ptr);
> > > - memcpy((void *)ptr, (unsigned char *)do_nothing, size);
> > > - flush_icache_range((unsigned long)ptr, (unsigned long)(ptr + size));
> > > + pr_info("attempting bad %zu byte write at %px\n", size,
> > > do_overwritten);
> > > + memcpy((void *)value_dow, (void *)value_do, size);
> > > + flush_icache_range(value_dow, value_dow + (unsigned long)size);
> > > pr_err("FAIL: survived bad write\n");
> > >
> > > do_overwritten();
> > > --
> > > 2.17.0
> >
> > -
> > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1
> > 1PT, UK
> > Registration No: 1397386 (Wales)
> >
--
Thanks,
~Nick Desaulniers
oid *)value_dow, (void *)value_do, size);
> + flush_icache_range(value_dow, value_dow + (unsigned long)size);
> pr_err("FAIL: survived bad write\n");
>
> do_overwritten();
> --
> 2.17.0
>
--
Thanks,
~Nick Desaulniers
tead
> diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S
> index beba9816cc6c..6320f6a8397c 100644
> --- a/arch/parisc/kernel/entry.S
> +++ b/arch/parisc/kernel/entry.S
> @@ -997,10 +997,19 @@ intr_do_preempt:
> bb,<,n %r20, 31 - PSW_SM_I, intr_restore
> nop
>
> - BL preempt_schedule_irq, %r2
> - nop
> + /* ssm PSW_SM_I done later in intr_restore */
> +#ifdef CONFIG_MLONGCALLS
> + ldilL%intr_restore, %r2
> + load32 preempt_schedule_irq, %r1
> + bv %r0(%r1)
> + ldo R%intr_restore(%r2), %r2
> +#else
> + ldilL%intr_restore, %r2
> + BL preempt_schedule_irq
> + ldo R%intr_restore(%r2), %r2
> +#endif
> +
>
> - b,n intr_restore/* ssm PSW_SM_I done by intr_restore
> */
> #endif /* CONFIG_PREEMPTION */
>
> /*
>
>
--
Thanks,
~Nick Desaulniers
> static int group_cnt[NR_CPUS] __initdata;
>
>
> Not sure if this would be any better than your patch.
>
>Arnd
>
> --
> You received this message because you are subscribed to the Google Groups
> "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clang-built-linux+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/clang-built-linux/CAK8P3a2ZWfNeXKSm8K_SUhhwkor17jFo3xApLXjzfPqX0eUDUA%40mail.gmail.com.
--
Thanks,
~Nick Desaulniers
ls
> > for '.S' files, if it denotes range of code via SYM_*_START/END
> > annotation pair.
> >
> > Suggested-by: Mark Brown
> > Link: https://lore.kernel.org/lkml/20210112210154.gi4...@sirena.org.uk
> > Signed-off-by: Aditya Srivastava
>
> Acked-by:
>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xbb4): cannot reach printk
>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xc84): cannot reach __muldi3
> hppa64-linux-ld: mm/hugetlb.o(.init.text+0xde8): cannot reach memparse
>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xec0): cannot reach printk
>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xef0): cannot reach unknown
>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xf94): cannot reach memparse
>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xfcc): cannot reach printk
>hppa64-linux-ld: mm/hugetlb.o(.init.text+0xfe4): cannot reach unknown
>hppa64-linux-ld: mm/slab.o(.text+0x490): cannot reach __udivdi3
>hppa64-linux-ld: mm/slab.o(.text+0x4ac): cannot reach __umoddi3
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
--
Thanks,
~Nick Desaulniers
he
> > link below.
> >
> > Life is too short for buggy compilers, so raise the minimum GCC version
> > required by arm64 to 5.1.
> >
> > Reported-by: Russell King
> > Suggested-by: Arnd Bergmann
> > Signed-off-by: Will Deacon
> > Tested-by: N
urns NULL for
> .text..L.cfi.jumptable.43 at addend 0x8, because Clang doesn't emit
> jump table symbols for static functions:
>
> <__typeid__ZTSFjmiE_global_addr>:
>0: e9 00 00 00 00 jmpq 5 <__typeid__ZTSFjmiE_global_addr+0x5>
>
tion
>
> Signed-off-by: Sami Tolvanen
> Co-developed-by: Bill Wendling
> Signed-off-by: Bill Wendling
> Tested-by: Nick Desaulniers
Reviewed-by: Nick Desaulniers
Let's get this queued up, then start thinking about how we can follow
up with improvements to docs, ergonomics of pa
On Thu, Jan 21, 2021 at 1:28 PM Will Deacon wrote:
>
> On Thu, Jan 21, 2021 at 11:24:36AM -0800, Nick Desaulniers wrote:
> > On Thu, Jan 21, 2021 at 5:11 AM Will Deacon wrote:
> > >
> > > On Wed, Jan 20, 2021 at 11:02:06AM -0800, Linus Torvalds wrote:
> >
linux/compiler-gcc.h:160:3: error: Sorry, your version of GCC
> > > is too old - please use 5.1 or newer.
> > > # error Sorry, your version of GCC is too old - please use 5.1 or newer.
> > > ^
> > > 1 error generated.
> > >
> > > build error link:
> > > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/980489003#L514
> >
> > Urgh, looks like we need backports of 815f0ddb346c
> > ("include/linux/compiler*.h: make compiler-*.h mutually exclusive") then.
> >
> > Greg -- please drop my changes from 4.14, 4.9 and 4.4 for now and I'll
> > look at this next week.
>
> That backport is going to be pretty gnarly, there was a pretty decent
> tailwind of fixes around that patch IIRC.
>
> The simple solution would be to stick a !defined(__clang__) in that
> preprocessor conditional so that it truly fires only for GCC.
I agree with that approach.
--
Thanks,
~Nick Desaulniers
On Thu, Jan 21, 2021 at 5:49 PM Sedat Dilek wrote:
>
> On Fri, Jan 22, 2021 at 2:43 AM Nick Desaulniers
> wrote:
> >
> > On Wed, Jan 20, 2021 at 6:03 PM Sedat Dilek wrote:
> > >
> > > On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote:
> > >
personal GitHub.
> Come on, Bill :-).
That's quite a long list, Sedat! Do you think some of these can be
follow ups, once the core lands? I'd much prefer to land the meat of
this and follow up quickly, than tire out poor Bill! :P
--
Thanks,
~Nick Desaulniers
hen warning for
> > > > > > undefined symbols
> > > > > >
> > > > > > ...I was finally able to boot into a rebuild PGO-optimized
> > > > > > Linux-kernel.
> > > > > > For details see ClangBuiltLinux issue #1250
uilds that I could see a possible path forward:
1. land PGO upstream
2. adds docs for AutoFDO
3. consider a config for hardcoding the location of the profiling data
so that we don't need to specify it at the command line invocation of
make.
--
Thanks,
~Nick Desaulniers
-optimization
>
> Signed-off-by: Sami Tolvanen
> Co-developed-by: Bill Wendling
> Signed-off-by: Bill Wendling
> Tested-by: Nick Desaulniers
> ---
> v2: - Added "__llvm_profile_instrument_memop" based on Nathan Chancellor's
> testing.
> - Corrected do
On Thu, Jan 21, 2021 at 5:11 AM Will Deacon wrote:
>
> On Wed, Jan 20, 2021 at 11:02:06AM -0800, Linus Torvalds wrote:
> > On Wed, Jan 20, 2021 at 10:27 AM Nick Desaulniers
> > wrote:
> > >
> > > Is there a difference between: [ const unnamed struct
On Thu, Jan 21, 2021 at 11:03 AM Rafael J. Wysocki wrote:
>
> On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter wrote:
> >
> >
> > On 11/11/2020 02:11, Nick Desaulniers wrote:
> > > The "fallthrough" pseudo-keyword was added as a portable way to denote
>
On Wed, Jan 20, 2021 at 8:13 PM Arvind Sankar wrote:
>
> On Wed, Jan 20, 2021 at 03:09:53PM -0800, Nick Desaulniers wrote:
> > So I'm thinking if we extend out this pattern to the rest of the
> > functions, we can actually avoid calls to
> > kernel_neon_begin()/ker
> v3: - Added change log section based on Sedat Dilek's comments.
> v4: - Remove non-x86 Makfile changes and se "hweight64" instead of using our
> own popcount implementation, based on Nick Desaulniers's comment.
> v5: - Correct padding calculation, discov
On Tue, Jan 19, 2021 at 1:35 PM Arnd Bergmann wrote:
>
> On Tue, Jan 19, 2021 at 10:18 PM 'Nick Desaulniers' via Clang Built
> Linux wrote:
> >
> > On Tue, Jan 19, 2021 at 5:17 AM Adrian Ratiu
> > wrote:
> > > diff --git a/arch/arm/lib/xor-neon.c b
On Wed, Jan 20, 2021 at 3:09 PM Nick Desaulniers
wrote:
>
> On Tue, Jan 19, 2021 at 1:35 PM Arnd Bergmann wrote:
> >
> > On Tue, Jan 19, 2021 at 10:18 PM 'Nick Desaulniers' via Clang Built
> > Linux wrote:
> > >
> > > On Tue, Jan 19, 2021 at 5:17 A
TART_LOCAL(.Lbad_get_user_8_clac)
> arch/x86/lib/getuser.S:SYM_CODE_END(.Lbad_get_user_8_clac)
> arch/x86/lib/putuser.S:SYM_CODE_START_LOCAL(.Lbad_put_user_clac)
> arch/x86/lib/putuser.S:SYM_CODE_END(.Lbad_put_user_clac)
> arch/x86/realmode/rm/wakeup_asm.S:SYM_DATA_START_LOCAL(.Lwakeup_idt)
> arch/x86/realmode/rm/wakeup_asm.S:SYM_DATA_END(.Lwakeup_idt)
Josh, I assume objtool does not annotate code under:
arch/x86/boot/
arch/x86/entry/
arch/x86/realmode/
?
The rest, ie
arch/x86/lib/
seem potentially relevant?
--
Thanks,
~Nick Desaulniers
/* Faulting
virtual address */
+ };
ie. marking the members const vs the anonymous struct? Does anything
need to change in the use of these structures?
> --
> 2.30.0.284.gd98b1dd5eaa7-goog
>
--
Thanks,
~Nick Desaulniers
my_foo = {
.bar = 42,
};
https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html
Reviewed-by: Nick Desaulniers
>
> Cc: Kirill A. Shutemov
> Cc: Linus Torvalds
> Signed-off-by: Will Deacon
> ---
> mm/shmem.c| 6 +++---
> mm/swapfile.c | 11 ++-
> 2 files cha
ter to pmd entry matching
> * the 'address' */
> pud_t *pud; /* Pointer to pud entry matching
> --
> 2.30.0.284.gd98b1dd5eaa7-goog
>
--
Thanks,
~Nick Desaulniers
ecause you are subscribed to the Google Groups
> "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clang-built-linux+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/clang-built-linux/1611042978-21473-1-git-send-email-yangtiezhu%40loongson.cn.
--
Thanks,
~Nick Desaulniers
, based on Fangrui
> Song's comments.
> v3: - Added change log section based on Sedat Dilek's comments.
> v4: - Remove non-x86 Makfile changes and se "hweight64" instead of using our
> own popcount implementation, based on Nick Desaulniers's comment.
> v5: - Corre
were also a lot of discussions lately on "where should the
volatile qualifier be allowed, or not."
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1152r0.html
https://www.youtube.com/watch?v=KJW_DLaVXIY
(2018? ok, maybe not lately. Lately for C)
I view this similarly as "where should the const qualifier be allowed, or not."
--
Thanks,
~Nick Desaulniers
On Tue, Jan 19, 2021 at 2:04 PM Nick Desaulniers
wrote:
>
> On Tue, Jan 19, 2021 at 1:35 PM Arnd Bergmann wrote:
> >
> > On Tue, Jan 19, 2021 at 10:18 PM 'Nick Desaulniers' via Clang Built
> > Linux wrote:
> > >
> > > On Tue, Jan 19, 2021 at 5:17 A
GCC version
> required by arm64 to 5.1.
>
> Reported-by: Russell King
> Suggested-by: Arnd Bergmann
> Signed-off-by: Will Deacon
> Tested-by: Nathan Chancellor
> Reviewed-by: Nick Desaulniers
> Reviewed-by: Nathan Chancellor
> Acked-by: Linus Torvalds
> Cc: # 4.4.y,
as a per source
> file compiler option.
Yes, patch 2 in the series removes it from .c source, and passes
-ftree-vectorize during Kbuild.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1
> 1PT, UK
> Registration No: 1397386 (Wales)
>
--
Thanks,
~Nick Desaulniers
On Tue, Jan 19, 2021 at 1:35 PM Arnd Bergmann wrote:
>
> On Tue, Jan 19, 2021 at 10:18 PM 'Nick Desaulniers' via Clang Built
> Linux wrote:
> >
> > On Tue, Jan 19, 2021 at 5:17 AM Adrian Ratiu
> > wrote:
> > > diff --git a/arch/arm/lib/xor-neon.c b
ction
>
> Another weird compiler issue. It generates obviously dead code which
> jumps off the end of the function:
>
> f7: b0 01 mov$0x1,%al
> f9: 84 c0 test %al,%al
> fb: 0f 84 79 05 00 00 je 67a
>
> https://paste.centos.org/view/a1887ae3
>
> --
> Josh
>
--
Thanks,
~Nick Desaulniers
CC.
>
> Because Clang is now supported by the kernel print a clear
> Clang-specific warning.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/496
> Link: https://github.com/ClangBuiltLinux/linux/issues/503
> Reported-by: Nick Desaulniers
> Reviewed-by: Nick Desau
The following commit has been merged into the x86/entry branch of tip:
Commit-ID: 5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae
Gitweb:
https://git.kernel.org/tip/5e6dca82bcaa49348f9e5fcb48df4881f6d6c4ae
Author:Nick Desaulniers
AuthorDate:Tue, 12 Jan 2021 11:46:24 -08:00
> On Wed, Jan 13, 2021 at 8:07 PM Nick Desaulniers
> wrote:
> >
> > On Wed, Jan 13, 2021 at 12:55 PM Nathan Chancellor
> > wrote:
> > >
> > > However, I see an issue with actually using the data:
> > >
> > > $ sudo -s
> > >
On Wed, Jan 13, 2021 at 8:07 PM Nick Desaulniers
wrote:
>
> On Wed, Jan 13, 2021 at 12:55 PM Nathan Chancellor
> wrote:
> >
> > However, I see an issue with actually using the data:
> >
> > $ sudo -s
> > # mount -t debugfs none /sys/kernel/debug
&g
ious patch-series, feel free to add my:
> >
> > Tested-by: Sedat Dilek
Yeah, I'll keep it if v6 is just commit message changes.
--
Thanks,
~Nick Desaulniers
On Fri, Jan 15, 2021 at 1:48 PM Sedat Dilek wrote:
>
> On Fri, Jan 15, 2021 at 10:06 PM Nick Desaulniers
> wrote:
> >
> > From: Masahiro Yamada
> >
> > The -gdwarf-4 flag is supported by GCC 4.5+, and also by Clang.
> >
> > You can see it at https:/
On Fri, Jan 15, 2021 at 1:46 PM Sedat Dilek wrote:
>
> On Fri, Jan 15, 2021 at 10:06 PM Nick Desaulniers
> wrote:
> >
> > DWARF v5 is the latest standard of the DWARF debug info format.
> >
> > Feature detection of DWARF5 is onerous, especially given that we
ong
Suggested-by: Jakub Jelinek
Suggested-by: Masahiro Yamada
Suggested-by: Nathan Chancellor
Signed-off-by: Nick Desaulniers
---
Makefile | 6 ++
include/asm-generic/vmlinux.lds.h | 6 +-
lib/Kconfig.debug | 18 ++
scri
-by: Fangrui Song
Suggested-by: Masahiro Yamada
Signed-off-by: Nick Desaulniers
---
Makefile | 13 ++---
lib/Kconfig.debug | 21 -
2 files changed, 22 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index d49c3f39ceb4..4eb3bf7ee974 100644
--- a/Makefile
Reviewed-by: Nick Desaulniers
Reviewed-by: Nathan Chancellor
Signed-off-by: Masahiro Yamada
---
lib/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 78361f0abe3a..dd7d8d35b2a5 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
.
* remove -u from test_dwarf5_support.sh as per Masahiro.
* add a -gdwarf-5 cc-option check to Kconfig as per Jakub.
*** BLURB HERE ***
Masahiro Yamada (1):
Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4
Nick Desaulniers (2):
Kbuild: make DWARF version a choice
Kbuild
On Fri, Jan 15, 2021 at 12:13 PM Fangrui Song wrote:
>
> http://lore.kernel.org/r/20201202010850.jibrjpyu6xgkf...@google.com
> Personally I'd drop DWARF v2 as an option.
WIP :P
--
Thanks,
~Nick Desaulniers
ople (and bots) looking for objtool warnings than
> ever before, so such warnings not likely to be ignored for long.
>
> Suggested-by: Nick Desaulniers
> Signed-off-by: Josh Poimboeuf
Thank you; I feel the arguments against enabling -Werror for the
kernel apply here. The warnings are an
201 - 300 of 9552 matches
Mail list logo