Re: [PATCH 1/2] kbuild: simplify cmd_mod

2021-01-14 Thread Nick Desaulniers
) $($*-y) $($*-m)), \ > + $(@:.mod=.o))) \ > + $(undefined_syms) echo >> $@ I find the indendation to be a readability improvement. Thanks for the patch. Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers > > $(obj)/%.mod: $(obj)/%.o FORCE >

Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists

2021-01-14 Thread Nick Desaulniers
ove use an `@` before the invocation of `rm`. I don't know what that's about, but that or even this patch doesn't affect my ability to build negatively. LGTM Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers > > $(multi-used-m): FORCE > $(call if_changed,link_multi-m) &g

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Nick Desaulniers
ce: unexpected > end of section > > I haven't had a chance to take a closer look yet, but some of these > are probably related to > https://github.com/ClangBuiltLinux/linux/issues/1192. However, I can > reproduce these also with ToT Clang, not just with Clang 11. > > Sami -- Thanks, ~Nick Desaulniers

Re: [PATCH v2] module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols

2021-01-14 Thread Nick Desaulniers
ClangBuiltLinux/linux/issues/1250 > Signed-off-by: Fangrui Song Thanks for the patch. Reviewed-by: Nick Desaulniers Jessica, would you mind adding when applying: Cc: as I suspect we might want this fixed in stable tree's branches, too. It might of interest to add: Link: https://sourcew

Re: [PATCH 2/2] kbuild: handle excessively long argument lists

2021-01-14 Thread Nick Desaulniers
> From: Mahesh Kumar Kalikot Veetil > > Modules with a large number of compilation units may be > exceeding AR and LD command argument list. Handle this gracefully by > writing the long argument list in a file. The command line options > read from file are inserted in place of the original @file

Re: [RFC PATCH 4/8] mm: Separate fault info out of 'struct vm_fault'

2021-01-14 Thread Nick Desaulniers
: > > mm/filemap.c: In function ‘filemap_map_pages’: > mm/filemap.c:2963:16: error: assignment of member ‘address’ in read-only > object > 2963 | vmf->address += (xas.xa_index - last_pgoff) << PAGE_SHIFT; > |^~ > make[1]: *** [scripts/Makefile.build

Re: [PATCH v3] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Nick Desaulniers
t; although I am not sure if building the kernel with ICC is well-supported. > > [1] https://lkml.org/lkml/2021/1/10/250 > [2] https://lkml.org/lkml/2021/1/12/1708 > [3] https://lkml.org/lkml/2021/1/12/1533 Consider Nathan's request to use lore links rather than lkml.org links. https://l

Re: upstream build error (12)

2021-01-14 Thread Nick Desaulniers
issue? I did a quick skim of https://github.com/google/syzkaller/blob/master/docs/syzbot.md, but it looks like communication with syzbot is based on commit messages? -- Thanks, ~Nick Desaulniers

Re: [PATCH] Documentation/llvm: Add a section about supported architectures

2021-01-14 Thread Nick Desaulniers
On Thu, Jan 14, 2021 at 6:36 AM Jonathan Corbet wrote: > > On Wed, 13 Jan 2021 17:19:59 -0800 > Nick Desaulniers wrote: > > > Patch looks fine, but `make -j htmldocs` seems to be taking forever > > for me so I can't render it. Is this a known issue? > > >

Re: [PATCH] MIPS: Compare __SYNC_loongson3_war against 0

2021-01-14 Thread Nick Desaulniers
plicitly, use > it in an equality comparison so the shift is used as an integer value. > > Fixes: 4d1dbfe6cbec ("MIPS: atomic: Emit Loongson3 sync workarounds within > asm") > Fixes: a91f2a1dba44 ("MIPS: cmpxchg: Omit redundant barriers for Loongson3") > Reported

Re: [PATCH] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Nick Desaulniers
; -MAJOR=$(echo __clang_major__ | $compiler -E -x c - | tail -n 1) > -MINOR=$(echo __clang_minor__ | $compiler -E -x c - | tail -n 1) > -PATCHLEVEL=$(echo __clang_patchlevel__ | $compiler -E -x c - | tail -n 1) > -printf "%d%02d%02d\\n" $MAJOR $MINOR $PATCHLEVEL > diff --git a/scripts/gcc-version.sh b/scripts/gcc-version.sh > deleted file mode 100755 > index ae353432539b.. > --- a/scripts/gcc-version.sh > +++ /dev/null > @@ -1,20 +0,0 @@ > -#!/bin/sh > -# SPDX-License-Identifier: GPL-2.0 > -# > -# gcc-version gcc-command > -# > -# Print the gcc version of `gcc-command' in a 5 or 6-digit form > -# such as `29503' for gcc-2.95.3, `30301' for gcc-3.3.1, etc. > - > -compiler="$*" > - > -if [ ${#compiler} -eq 0 ]; then > - echo "Error: No compiler specified." >&2 > - printf "Usage:\n\t$0 \n" >&2 > - exit 1 > -fi > - > -MAJOR=$(echo __GNUC__ | $compiler -E -x c - | tail -n 1) > -MINOR=$(echo __GNUC_MINOR__ | $compiler -E -x c - | tail -n 1) > -PATCHLEVEL=$(echo __GNUC_PATCHLEVEL__ | $compiler -E -x c - | tail -n 1) > -printf "%d%02d%02d\\n" $MAJOR $MINOR $PATCHLEVEL > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v4] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-13 Thread Nick Desaulniers
4)'p' << 40 | \ + (u64)'r' << 32 | \ + (u64)'o' << 24 | \ + (u64)'f' << 16 | \ + (u64)'r' << 8 | \ + (u64)129) +#else + #define LLVM_PRF_MAGIC \ + ((u64)255 << 56 | \ + (u64)'l' << 48 | \ + (u64)'p' << 40 | \ + (u64)'r' << 32 | \ + (u64)'o' << 24 | \ + (u64)'f' << 16 | \ + (u64)'R' << 8 | \ + (u64)129) +#endif -- Thanks, ~Nick Desaulniers

Re: [PATCH] Documentation/llvm: Add a section about supported architectures

2021-01-13 Thread Nick Desaulniers
On Wed, Jan 13, 2021 at 5:19 PM Nick Desaulniers wrote: > > Patch looks fine, but `make -j htmldocs` seems to be taking forever > for me so I can't render it. Is this a known issue? > > $ make -j htmldocs Just took a while, lots of warning spew (but not from this addition AF

Re: [PATCH v4] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-13 Thread Nick Desaulniers
> - Corrected documentation, re PGO flags when using LTO, based on Fangrui > Song's comments. > v3: - Added change log section based on Sedat Dilek's comments. > v4: - Remove non-x86 Makfile changes and se "hweight64" instead of using our > own popcount i

Re: [PATCH] Documentation/llvm: Add a section about supported architectures

2021-01-13 Thread Nick Desaulniers
t; + * - riscv > + - Maintained > + - ``CC=clang`` > + * - s390 > + - Maintained > + - ``CC=clang`` > + * - x86 > + - Supported > + - ``LLVM=1`` > + > Getting Help > > > > base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837 > -- > 2.30.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-13 Thread Nick Desaulniers
Sedat, Thanks for testing, and congrats on https://lwn.net/Articles/839772/. I always appreciate you taking the time to help test my work, and other Clang+Linux kernel patches! On Wed, Jan 13, 2021 at 1:24 PM Sedat Dilek wrote: > > On Wed, Jan 13, 2021 at 1:32 AM Nick Desaulniers &g

Re: [PATCH] MAINTAINERS: Add a couple more files to the Clang/LLVM section

2021-01-13 Thread Nick Desaulniers
On Wed, Jan 13, 2021 at 4:41 PM Nathan Chancellor wrote: > > The K: entry should ensure that Nick and I always get CC'd on patches > that touch these files but it is better to be explicit rather than > implicit. > > Signed-off-by: Nathan Chancellor Thanks for the patch!

Re: [PATCH v4] x86/entry: emit a symbol for register restoring thunk

2021-01-13 Thread Nick Desaulniers
On Wed, Jan 13, 2021 at 8:59 AM Josh Poimboeuf wrote: > > On Tue, Jan 12, 2021 at 09:01:54PM +, Mark Brown wrote: > > On Tue, Jan 12, 2021 at 11:46:24AM -0800, Nick Desaulniers wrote: > > > > This: > > > > > when building with LLVM_IAS=1 (Clang's

[PATCH] Documentation: asm-annotation: clarify .L local symbol names

2021-01-13 Thread Nick Desaulniers
Use more precise language and move the text to a region in the docs to show that this constraint is not just for SYM_CODE_START*. Suggested-by: Mark Brown Suggested-by: Josh Poimboeuf Signed-off-by: Nick Desaulniers --- Documentation/asm-annotations.rst | 14 +- 1 file changed, 5

[tip: x86/entry] x86/entry: Emit a symbol for register restoring thunk

2021-01-13 Thread tip-bot2 for Nick Desaulniers
The following commit has been merged into the x86/entry branch of tip: Commit-ID: bde718b7e154afc99e1956b18a848401ce8e1f8e Gitweb: https://git.kernel.org/tip/bde718b7e154afc99e1956b18a848401ce8e1f8e Author:Nick Desaulniers AuthorDate:Tue, 12 Jan 2021 11:46:24 -08:00

Re: [PATCH] ubsan: Implement __ubsan_handle_alignment_assumption

2021-01-12 Thread Nick Desaulniers
it > >void __ubsan_handle_sub_overflow(void *data, > >^ > > Given that these are compiler inserted functions, there is not much of a > point to having prototypes to them. If people feel shutting these > warnings up is worthwhile, we can just add the prototypes right above > the function definition in a follow up patch. Same as stpcpy; it would be nice though. ;) -- Thanks, ~Nick Desaulniers

[PATCH v4 0/3] Kbuild: DWARF v5 support

2021-01-12 Thread Nick Desaulniers
-u from test_dwarf5_support.sh as per Masahiro. * add a -gdwarf-5 cc-option check to Kconfig as per Jakub. Masahiro Yamada (1): Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4 Nick Desaulniers (2): Kbuild: make DWARF version a choice Kbuild: implement support for DWARF

[PATCH v4 1/3] Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4

2021-01-12 Thread Nick Desaulniers
Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers --- lib/Kconfig.debug | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 78361f0abe3a..dd7d8d35b2a5 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -258,7 +258,6 @@ config

[PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-12 Thread Nick Desaulniers
-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- Makefile | 14 +- lib/Kconfig.debug | 21 - 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index d49c3f39ceb4..656fff17b331 100644 --- a/Makefile +++ b/Makefile @@ -826,12

[PATCH v4 3/3] Kbuild: implement support for DWARF v5

2021-01-12 Thread Nick Desaulniers
ted-by: Fangrui Song Suggested-by: Caroline Tice Signed-off-by: Nick Desaulniers --- Makefile | 1 + include/asm-generic/vmlinux.lds.h | 6 +- lib/Kconfig.debug | 17 + scripts/test_dwarf5_support.sh| 9 + 4 files changed,

Re: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64

2021-01-12 Thread Nick Desaulniers
gt; Cc: Catalin Marinas > Cc: Florian Weimer > Cc: Peter Zijlstra > Cc: Linus Torvalds > Cc: Nick Desaulniers > Reported-by: Russell King > Suggested-by: Arnd Bergmann > Link: https://lore.kernel.org/r/20210105154726.gd1...@shell.armlinux.org.uk > Signed-off-by: Will Dea

Re: [BUG mips llvm] MIPS: malformed R_MIPS_{HI16,LO16} with LLVM

2021-01-12 Thread Nick Desaulniers
have bit 15 set, so I think this pair won't > break the code. > Try to hunt for R_MIPS_LO16 that have this bit set, i.e. they have > '8', '9', 'a', 'b', 'c', 'd' or 'e' as their [15:12]. I don't think any of my R_MIPS_LO16 in that file have that bit set. See attached. -- Than

Re: [PATCH] ubsan: Implement __ubsan_handle_alignment_assumption

2021-01-12 Thread Nick Desaulniers
if ((word & 0x3) == 0) { num += 2; word >>= 2; } if ((word & 0x1) == 0) num += 1; return num; } int main() { int x = 3; unsigned long y = 3; printf("%d\n%lu\n", ffs(x), __ffs(y)); return 0; } ``` will print: 1 0 -- Thanks, ~Nick Desaulniers

Re: [PATCH] ubsan: Implement __ubsan_handle_alignment_assumption

2021-01-12 Thread Nick Desaulniers
e_data { > struct type_descriptor *type; > }; > > +struct alignment_assumption_data { > + struct source_location location; > + struct source_location assumption_location; > + struct type_descriptor *type; > +}; > + > #if defined(CONFIG_ARCH_SUPPORTS_INT128) > typedef __int128 s_max; > typedef unsigned __int128 u_max; > > base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837 > -- > 2.30.0 > -- Thanks, ~Nick Desaulniers

[PATCH v4] x86/entry: emit a symbol for register restoring thunk

2021-01-12 Thread Nick Desaulniers
://sourceware.org/binutils/docs/as/Symbol-Names.html Link: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d1bcae833b32f1408485ce69f844dcd7ded093a8 Reported-by: Arnd Bergmann Suggested-by: Josh Poimboeuf Suggested-by: Borislav Petkov Signed-off-by: Nick Desaulniers --- Changes v3 ->

Re: [PATCH v2] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-12 Thread Nick Desaulniers
33ULL); > + value = (value + (value >> 4)) & 0x0F0F0F0F0F0F0F0FULL; > + > + return (int)((unsigned long long)(value * 0x0101010101010101ULL) >> > 56); > +} The kernel has a portable popcnt implementation called hweight64 if you #include ; does that work here? https://en.wikipedia.org/wiki/Hamming_weight -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 2/2] arm64: dts: mt8192: Add node for the Mali GPU

2021-01-12 Thread Nick Fan
On Fri, 2021-01-08 at 15:58 +, Steven Price wrote: > On 05/01/2021 05:36, Nick Fan wrote: > > Add a basic GPU node for mt8192. > > > > Signed-off-by: Nick Fan > > --- > > This patch depends on Mediatek power and regulator support. > > >

[PATCH v4 2/2] arm64: dts: mt8192: Add node for the Mali GPU

2021-01-11 Thread Nick Fan
Add a basic GPU node for mt8192. Signed-off-by: Nick Fan --- This patch depends on Mediatek power and regulator support. Listed as following. [1]https://lore.kernel.org/patchwork/patch/1336293/ [2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013 [3]https

[PATCH v4 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2021-01-11 Thread Nick Fan
Add devicetree schema for Arm Mali Valhall GPU Define a compatible string for the Mali Valhall GPU for Mediatek's SoC platform. Signed-off-by: Nick Fan --- .../bindings/gpu/arm,mali-valhall.yaml| 252 ++ 1 file changed, 252 insertions(+) create mode 100644

Re: [PATCH v3] x86/entry: emit a symbol for register restoring thunk

2021-01-11 Thread Nick Desaulniers
> been rejected. > > Meaning what exactly? There's no way for clang's integrated assembler to > even get a cmdline option to not strip .text? I can clean that up in v5; The section symbols were not generated then stripped; they were simply never generated. -- Thanks, ~Nick Desaulniers

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Nick Desaulniers
random.o > +PGO_PROFILE_random.o := n > obj-$(CONFIG_TTY_PRINTK) += ttyprintk.o > obj-y += misc.o > obj-$(CONFIG_ATARI_DSP56K) += dsp56k.o > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index e5574e506a5c..d83cacc79b1a 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -168,6 +168,7 @@ i915-y += \ > i915_vma.o \ > intel_region_lmem.o \ > intel_wopcm.o > +PGO_PROFILE_i915_query.o := n > > # general-purpose microcontroller (GuC) support > i915-y += gt/uc/intel_uc.o \ I'd rather have these both sorted out before landing with PGO disabled on these files. -- Thanks, ~Nick Desaulniers

[PATCH v3] x86/entry: emit a symbol for register restoring thunk

2021-01-11 Thread Nick Desaulniers
/binutils/2020-December/114671.html Reported-by: Arnd Bergmann Suggested-by: Josh Poimboeuf Signed-off-by: Nick Desaulniers --- Changes v2 -> v3: * rework to use STB_LOCAL rather than STB_GLOBAL by dropping .L prefix, as per Josh. * rename oneline to drop STB_GLOBAL in commit message. * add l

Re: [BUG mips llvm] MIPS: malformed R_MIPS_{HI16,LO16} with LLVM

2021-01-11 Thread Nick Desaulniers
Hi Alexander, I'm genuinely trying to reproduce/understand this report, questions below: On Sat, Jan 9, 2021 at 11:15 AM Alexander Lobakin wrote: > > From: Nick Desaulniers > Date: Sat, 9 Jan 2021 09:50:44 -0800 > > > On Sat, Jan 9, 2021 at 9:11 AM Alexander Lobakin wrote:

Re: [BUG mips llvm] MIPS: malformed R_MIPS_{HI16,LO16} with LLVM

2021-01-09 Thread Nick Desaulniers
anks for the report. Sounds like we may indeed be producing an incorrect relocation. This is only seen for big endian triples? Getting a way for us to deterministically reproduce would be a good first step. Which config or configs beyond defconfig, and which relocations specifically are you observing this with? -- Thanks, ~Nick Desaulniers

Re: [RFC PATCH v2] selinux: security: Move selinux_state to a separate page

2021-01-08 Thread Nick Desaulniers
Via: https://lore.kernel.org/lkml/1610099389-28329-1-git-send-email-pna...@codeaurora.org/ > diff --git a/include/linux/init.h b/include/linux/init.h > index 7b53cb3..617adcf 100644 > --- a/include/linux/init.h > +++ b/include/linux/init.h > @@ -300,6 +300,10 @@ void __init

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-08 Thread Nick Desaulniers
ersion is not marked __init. Interesting, I didn't know LLVM could do that. Do you have a simpler test case? Maybe I could just fix that in LLVM. (I would guess that when synthesizing a function from an existing function, the new function needs to copy the original functions attributes as well). -- Thanks, ~Nick Desaulniers

Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues

2021-01-08 Thread Nick Desaulniers
u11 or -std=gnu17, as they rely on the implicit default C language mode when unspecified. Oops? -- Thanks, ~Nick Desaulniers

Re: [PATCH] x86: Treat R_386_PLT32 as R_386_PC32

2021-01-06 Thread Nick Desaulniers
/ClangBuiltLinux/linux/issues/1210 > Reported-by: Arnd Bergmann > Signed-off-by: Fangrui Song This fixes a build failure for me with clang-12 (ie. top of tree), thanks for the patch. Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers I also see R_386_PC32 referenced in scripts/mod/m

[PATCH v2] x86/entry: use STB_GLOBAL for register restoring thunk

2021-01-05 Thread Nick Desaulniers
Link: https://github.com/ClangBuiltLinux/linux/issues/1209 Link: https://reviews.llvm.org/D93783 Link: https://sourceware.org/pipermail/binutils/2020-December/114671.html Reported-by: Arnd Bergmann Suggested-by: Josh Poimboeuf Acked-by: Josh Poimboeuf Signed-off-by: Nick Desaulniers

Re: [PATCH] ARM: avoid cpuidle link warning

2021-01-05 Thread Nick Desaulniers
> Since commit 83109d5d5fba ("x86/build: Warn on orphan section placement"), Might be better to use: commit 5a17850e251a ("arm/build: Warn on orphan section placement") Reviewed-by: Nick Desaulniers

Re: [PATCH 6/7] spi: cadence-quadspi: Wait at least 500 ms for direct reads

2021-01-05 Thread Nick Desaulniers
from macro '__typecheck' > >(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) > > ~~ ^ ~~ > >1 warning generated. > > On arm64 size_t is defined as unsigned long and on arm is it defined as > unsigned int. So using 500U would generate the same warning on 64-bit > platforms. Maybe the fix is to do something like: max(len, (size_t)500). > Any better ideas? SGTM -- Thanks, ~Nick Desaulniers

Re: drivers/i3c/master/mipi-i3c-hci/core.c:780:21: warning: attribute declaration must precede definition

2021-01-05 Thread Nick Desaulniers
and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/202012270950.HNbQuTpw-lkp%40intel.com. -- Thanks, ~Nick Desaulniers

Re: [PATCH v2] firmware_loader: Align .builtin_fw to 8

2021-01-05 Thread Nick Desaulniers
itting developers on Chrome OS a whole > lot suddenly. Any chance it could be landed? Which tree should it go > through? Andrew, Would you mind picking up this patch for us, please? https://lore.kernel.org/lkml/20201208054646.2913063-1-mask...@google.com/ -- Thanks, ~Nick Desaulniers

[PATCH v3 2/2] arm64: dts: mt8192: Add node for the Mali GPU

2021-01-05 Thread Nick Fan
Add a basic GPU node for mt8192. Signed-off-by: Nick Fan --- This patch depends on Mediatek power and regulator support. Listed as following. [1]https://lore.kernel.org/patchwork/patch/1336293/ [2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013 [3]https

[PATCH v3 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2021-01-05 Thread Nick Fan
Add devicetree schema for Arm Mali Valhall GPU Define a compatible string for the Mali Valhall GPU for Mediatek's SoC platform. Signed-off-by: Nick Fan --- .../bindings/gpu/arm,mali-valhall.yaml| 252 ++ 1 file changed, 252 insertions(+) create mode 100644

[PATCH v2 2/2] arm64: dts: mt8192: Add node for the Mali GPU

2021-01-04 Thread Nick Fan
Add a basic GPU node for mt8192. Signed-off-by: Nick Fan --- This patch depends on Mediatek power and regulator support. Listed as following. [1]https://lore.kernel.org/patchwork/patch/1336293/ [2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013 [3]https

[PATCH v2 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2021-01-04 Thread Nick Fan
Add devicetree schema for Arm Mali Valhall GPU Define a compatible string for the Mali Valhall GPU for Mediatek's SoC platform. Signed-off-by: Nick Fan --- .../bindings/gpu/arm,mali-valhall.yaml| 252 ++ 1 file changed, 252 insertions(+) create mode 100644

[PATCH v1 1/2] dt-bindings: Convert Arm Mali Valhall GPU to DT schema

2021-01-03 Thread Nick Fan
Convert the Arm Valhall GPU binding to DT schema format. Define a compatible string for the Mali Valhall GPU for Mediatek's SoC platform. Signed-off-by: Nick Fan --- .../bindings/gpu/arm,mali-valhall.yaml| 252 ++ 1 file changed, 252 insertions(+) create mode 100644

[PATCH v1 2/2] arm64: dts: mt8192: Add node for the Mali GPU

2021-01-03 Thread Nick Fan
Add a basic GPU node for mt8192. Signed-off-by: Nick Fan --- This patch depends on Mediatek power and regulator support. Listed as following. [1]https://lore.kernel.org/patchwork/patch/1336293/ [2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013 [3]https

[PATCH 1/2] dt-bindings: Convert Arm Mali Valhall GPU to DT schema

2020-12-24 Thread Nick Fan
Convert the Arm Valhall GPU binding to DT schema format. Define a compatible string for the Mali Valhall GPU for Mediatek's SoC platform. Signed-off-by: Nick Fan --- .../bindings/gpu/arm,mali-valhall.yaml| 252 ++ 1 file changed, 252 insertions(+) create mode 100644

[PATCH 2/2] arm64: dts: mt8192: Add node for the Mali GPU

2020-12-24 Thread Nick Fan
Add a basic GPU node for mt8192. Signed-off-by: Nick Fan --- This patch depends on Mediatek power and regulator support. Listed as following. [1]https://lore.kernel.org/patchwork/patch/1336293/ [2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013 [3]https

[PATCH] x86/entry: use STB_GLOBAL for register restoring thunk

2020-12-23 Thread Nick Desaulniers
/1209 Link: https://reviews.llvm.org/D93783 Signed-off-by: Nick Desaulniers --- arch/x86/entry/thunk_64.S | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/entry/thunk_64.S b/arch/x86/entry/thunk_64.S index ccd32877a3c4..878816034a73 100644 --- a/arch/x86/entry

Re: [tip:efi/core 3/7] /tmp/slab-258052.s:9870: Error: unrecognized opcode `zext.b a2,a2'

2020-12-23 Thread Nick Desaulniers
out-netiquette > > -- > You received this message because you are subscribed to the Google Groups > "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20201223183606.GB29011%40zn.tnic. -- Thanks, ~Nick Desaulniers

[PATCH] fs: binfmt_em86: check return code of remove_arg_zero

2020-12-22 Thread Nick Desaulniers
remove_arg_zero is declared as __must_check. Looks like it can return -EFAULT on failure. Cc: Masahiro Yamada Cc: Miguel Ojeda Reported-by: Guenter Roeck Signed-off-by: Nick Desaulniers --- fs/binfmt_em86.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/binfmt_em86

[PATCH] sh: check return code of request_irq

2020-12-22 Thread Nick Desaulniers
Ojeda Cc: Paul Mundt Reported-by: Guenter Roeck Signed-off-by: Nick Desaulniers --- arch/sh/kernel/cpu/sh4a/smp-shx3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sh/kernel/cpu/sh4a/smp-shx3.c b/arch/sh/kernel/cpu/sh4a/smp-shx3.c index f8a2bec0f260..1261dc7b8

building csky with CC=clang

2020-12-22 Thread Nick Desaulniers
... scripts/Kconfig.include:40: linker 'csky-linux-gnu-ld' not found My distro doesn't package binutils-csky-linux-gnu, is there documentation on how to build the kernel targeting CSKY, starting with building GNU binutils configured with CSKY emulation? -- Thanks, ~Nick Desaulniers

Re: [PATCH] x86/cmdline: Disable jump tables for cmdline.c

2020-12-21 Thread Nick Desaulniers
On Mon, Dec 21, 2020 at 1:23 PM Arvind Sankar wrote: > > On Mon, Dec 21, 2020 at 11:14:39AM -0800, Nick Desaulniers wrote: > > On Wed, Sep 2, 2020 at 7:31 PM Arvind Sankar wrote: > > > > > > When CONFIG_RETPOLINE is disabled, Clang uses a jump table

Re: [PATCH] apparmor: fix error check

2020-12-21 Thread Nick Desaulniers
a_label_acntsxprint() fails, it won't assign to its first param. In the caller, this means assigning uninitialized memory (UB) when aa_label_acntsxprint() returns -ENOMEM for example. Thanks for the patch. Reviewed-by: Nick Desaulniers > > In aa_update_label_name(

Re: [PATCH] x86/cmdline: Disable jump tables for cmdline.c

2020-12-21 Thread Nick Desaulniers
group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20200903023056.3914690-1-nivedita%40alum.mit.edu. -- Thanks, ~Nick Desaulniers

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-18 Thread Nick Terrell
> On Dec 16, 2020, at 5:23 PM, Michał Mirosław wrote: > > On Wed, Dec 16, 2020 at 10:07:38PM +0000, Nick Terrell wrote: > [...] >> It is very large. If it helps, in the commit message I’ve provided this link >> [0], >> which provides the diff between upstream zs

[PATCH v2] arm64: link with -z norelro for LLD or aarch64-elf

2020-12-17 Thread Nick Desaulniers
: 3b92fa7485eb ("arm64: link with -z norelro regardless of CONFIG_RELOCATABLE") Reported-by: kernelci.org bot Reported-by: Quentin Perret Acked-by: Ard Biesheuvel Signed-off-by: Nick Desaulniers --- Changes V1 -> V2: * s/relocation types/program headers/ * s/newer GNU binutils/GNU binutils 2.3

Re: [PATCH] arm64: link with -z norelro for LLD or aarch64-elf

2020-12-17 Thread Nick Desaulniers
On Thu, Dec 17, 2020 at 4:01 AM Will Deacon wrote: > > On Wed, Dec 16, 2020 at 04:40:51PM -0800, Nick Desaulniers wrote: > > With newer GNU binutils, linking with BFD produces warnings for vmlinux: > > aarch64-linux-gnu-ld: warning: -z norelro ignored > > > Given that

Re: [PATCH] MIPS: boot: Fix unaligned access with CONFIG_MIPS_RAW_APPENDED_DTB

2020-12-16 Thread Nick Desaulniers
oach of yours by using unaligned loads! Reviewed-by: Nick Desaulniers > --- > arch/mips/boot/compressed/decompress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/compressed/decompress.c > b/arch/mips/boot/compressed/decompress

[PATCH] arm64: link with -z norelro for LLD or aarch64-elf

2020-12-16 Thread Nick Desaulniers
Sòng Fixes: 3b92fa7485eb ("arm64: link with -z norelro regardless of CONFIG_RELOCATABLE") Reported-by: kernelci.org bot Reported-by: Quentin Perret Signed-off-by: Nick Desaulniers --- arch/arm64/Makefile | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-16 Thread Nick Terrell
> On Dec 16, 2020, at 10:50 AM, David Sterba wrote: > > On Wed, Dec 16, 2020 at 11:58:07AM +1100, Herbert Xu wrote: >> On Wed, Dec 16, 2020 at 12:48:51AM +, Nick Terrell wrote: >>> >>> Thanks for the advice! The first zstd patches went through Herbert’s

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-15 Thread Nick Terrell
> On Dec 15, 2020, at 4:58 PM, Herbert Xu wrote: > > On Wed, Dec 16, 2020 at 12:48:51AM +0000, Nick Terrell wrote: >> >> Thanks for the advice! The first zstd patches went through Herbert’s tree, >> which is >> why I’ve sent them this way. > >

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-15 Thread Nick Terrell
> On Dec 15, 2020, at 4:00 PM, Eric Biggers wrote: > > On Tue, Dec 15, 2020 at 08:58:52PM +0000, Nick Terrell via Linux-f2fs-devel > wrote: >> >> >>> On Dec 3, 2020, at 12:51 PM, Nick Terrell wrote: >>> >>> From: Nick Terrell >>

Re: [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-15 Thread Nick Terrell
> On Dec 3, 2020, at 12:51 PM, Nick Terrell wrote: > > From: Nick Terrell > > Please pull from > > g...@github.com:terrelln/linux.git tags/v7-zstd-1.4.6 > > to get these changes. Alternatively the patchset is included. Is it possible to get this patchset merg

Re: [PATCH] arm64: link with -z norelro regardless of CONFIG_RELOCATABLE

2020-12-14 Thread Nick Desaulniers
On Mon, Dec 14, 2020 at 3:18 PM Alan Modra wrote: > > On Mon, Dec 14, 2020 at 01:44:06PM -0800, Nick Desaulniers wrote: > > aarch64-linux-gnu-ld: warning: -z norelro ignored > > > > So we set the emulation mode via -maarch64elf, and our preprocessed > > The default l

Re: [PATCH] arm64: link with -z norelro regardless of CONFIG_RELOCATABLE

2020-12-14 Thread Nick Desaulniers
On Tue, Oct 20, 2020 at 10:57 AM Will Deacon wrote: > > On Fri, 16 Oct 2020 10:53:39 -0700, Nick Desaulniers wrote: > > With CONFIG_EXPERT=y, CONFIG_KASAN=y, CONFIG_RANDOMIZE_BASE=n, > > CONFIG_RELOCATABLE=n, we observe the following failure when trying to > > link the ker

Re: objtool crashes with some clang produced .o files

2020-12-11 Thread Nick Desaulniers
On Fri, Dec 11, 2020 at 4:42 PM Nick Desaulniers wrote: > > On Fri, Dec 11, 2020 at 12:57 PM Nick Desaulniers > wrote: > > > > Thanks for the patch! > > > > Reviewed-by: Nick Desaulniers > > Link: https://github.com/ClangBuiltLinux/linux/issues/1207 &g

Re: objtool crashes with some clang produced .o files

2020-12-11 Thread Nick Desaulniers
On Fri, Dec 11, 2020 at 12:57 PM Nick Desaulniers wrote: > > Thanks for the patch! > > Reviewed-by: Nick Desaulniers > Link: https://github.com/ClangBuiltLinux/linux/issues/1207 Arnd reported another objtool warning/error from another randconfig in https://github.com/ClangB

Re: objtool crashes with some clang produced .o files

2020-12-11 Thread Nick Desaulniers
t; reloc generation as well. > > Reported-by: Arnd Bergmann > Signed-off-by: Josh Poimboeuf Thanks for the patch! Reviewed-by: Nick Desaulniers Link: https://github.com/ClangBuiltLinux/linux/issues/1207 > --- > tools/objtool/check.c | 11 +-- > tools/objtool/elf.c

Re: [PATCH 5.4 044/158] compiler.h: fix barrier_data() on clang

2020-12-11 Thread Nick Desaulniers
On Mon, Nov 23, 2020 at 10:57 AM Nick Desaulniers wrote: > > On Mon, Nov 23, 2020 at 10:50 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Nov 23, 2020 at 10:31:10AM -0800, Nick Desaulniers wrote: > > > Doesn't this depend on a v2 of > > > https://lore.

Re: [PATCH v9 06/16] kbuild: lto: add a default list of used symbols

2020-12-11 Thread Nick Desaulniers
on, like > > lto-user-symbols.txt or .list, to make it more human-friendly? > > Sure, I can rename this in the next version. Does anyone have strong > opinions about the name and/or extension? .txt extension would be fine. -- Thanks, ~Nick Desaulniers

Re: [PATCH v2] mips: lib: uncached: fix non-standard usage of variable 'sp'

2020-12-11 Thread Nick Desaulniers
/gcc~10/local-register-variables > Signed-off-by: Anders Roxell Link: https://github.com/ClangBuiltLinux/linux/issues/606 Reported-by: Nathan Chancellor Reported-by: Naresh Kamboju Reviewed-by: Nick Desaulniers > --- > arch/mips/lib/uncached.c | 4 +++- > 1 file changed, 3 inse

Re: objtool crashes with some clang produced .o files

2020-12-10 Thread Nick Desaulniers
d not determine a symbol for? I'm curious why we're even in this loop though, since we didn't do anything related to static calls...is `file->static_call_list` not populated correctly? Is the final else case from `add_jump_destinations` perhaps being hit and adding nodes to file->static_call_list incorrectly? -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 4/4] Kbuild: implement support for DWARF v5

2020-12-10 Thread Nick Desaulniers
On Fri, Dec 4, 2020 at 9:06 AM Arvind Sankar wrote: > > On Thu, Dec 03, 2020 at 03:28:14PM -0800, Nick Desaulniers wrote: > > On Thu, Dec 3, 2020 at 3:22 PM Nick Desaulniers > > wrote: > > > > > > On Tue, Nov 24, 2020 at 9:28 AM Arvind Sankar > > >

Re: [PATCH] selftests: propagate CC to selftest submakes

2020-12-10 Thread Nick Desaulniers
is being used, selftests will build with clang. > ifeq (,$(LINK.c)) > override LDFLAGS = > -override MAKEFLAGS = > +override MAKEFLAGS = CC=$(CC) > endif > > # Append kselftest to KBUILD_OUTPUT and O to avoid cluttering > -- > 2.29.2.576.ga3fc446d84-goog > -- Thanks, ~Nick Desaulniers

Re: MIPS + clang-11 + allnoconfig / tinyconfig builds failed

2020-12-10 Thread Nick Desaulniers
L: modpost: Section mismatches detected. > Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them. > make[2]: *** [/builds/1kl9SVppm6wRdzlQ3UcQKIBaUrx/scripts/Makefile.modpost:59: > vmlinux.symvers] Error 1 Anders sent a patch for this, too, IIRC. Once the above fixes land upstream, we probably need to follow up on ensuring they get picked up into the affected branches of stable. -- Thanks, ~Nick Desaulniers

Re: [PATCH] genksyms: Ignore module scoped _Static_assert()

2020-12-10 Thread Nick Desaulniers
syms -d -d < test_case.i Best of luck on that endeavor. ``` I was planning on talking about this timebomb at plumbers, but had to cut it due to the tight time constraints we were allotted. -- Thanks, ~Nick Desaulniers

Re: [PATCH] watchdog: coh901327: add COMMON_CLK dependency

2020-12-10 Thread Nick Desaulniers
mp;& COMPILE_TEST) > + depends on ARCH_U300 || (ARM && COMMON_CLK && COMPILE_TEST) > default y if MACH_U300 > select WATCHDOG_CORE > help > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH] drm/amdgpu: make DRM_AMD_DC x86-only again

2020-12-10 Thread Nick Desaulniers
On Tue, Dec 8, 2020 at 2:18 PM Arnd Bergmann wrote: > > On Tue, Dec 8, 2020 at 7:21 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > On Tue, Dec 8, 2020 at 6:26 AM Arnd Bergmann wrote: > > > > > > On Mon, Dec 7, 2020 at 11:28 PM 'Nick Desaulni

Re: [PATCH v8 00/16] Add support for Clang LTO

2020-12-08 Thread Nick Desaulniers
amount of out of tree code they have. As long as help sell/differentiate phones, I suspect our product teams will continue to ship full LTO in production. -- Thanks, ~Nick Desaulniers

Re: [PATCH] drm/amdgpu: make DRM_AMD_DC x86-only again

2020-12-08 Thread Nick Desaulniers
On Tue, Dec 8, 2020 at 6:26 AM Arnd Bergmann wrote: > > On Mon, Dec 7, 2020 at 11:28 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > On Mon, Dec 7, 2020 at 2:17 PM Arnd Bergmann wrote: > > > > > > On Mon, Dec 7, 2020 at 11:08 PM 'Nick Desaulni

Re: [PATCH v2] firmware_loader: Align .builtin_fw to 8

2020-12-08 Thread Nick Desaulniers
(I wonder why we don't use 4B alignment for 32b...but 8 is a multiple of 4, so should be fine for 32b targets). Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers Build+Boot tested aarch64 and x86_64 with ld.lld and ld.bfd. Did not test loading builtin firmware. > --- > i

Re: [PATCH] drm/amdgpu: make DRM_AMD_DC x86-only again

2020-12-07 Thread Nick Desaulniers
On Mon, Dec 7, 2020 at 2:17 PM Arnd Bergmann wrote: > > On Mon, Dec 7, 2020 at 11:08 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > On Mon, Dec 7, 2020 at 1:57 PM Arnd Bergmann wrote: > > > > > > > Right, looking at my latest rand

Re: [PATCH] drm/amdgpu: make DRM_AMD_DC x86-only again

2020-12-07 Thread Nick Desaulniers
Right, looking at my latest randconfig logs, I see the same problem on x86 > builds with clang as well, though I'm not entirely sure which other > configuration > options are needed to trigger it. > > So my patch can be disregarded, but I agree this needs a better fix, > either in clang or in the dcn driver. If you could give https://github.com/ClangBuiltLinux/frame-larger-than a spin again, I would appreciate any feedback. -- Thanks, ~Nick Desaulniers

Re: [PATCH v3 1/2] Kbuild: make DWARF version a choice

2020-12-03 Thread Nick Desaulniers
(minus Chengbin due to bounces) On Thu, Dec 3, 2020 at 5:11 PM Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > way that's forward compatible with exis

Re: [PATCH v3 0/2] Kbuild: DWARF v5 support

2020-12-03 Thread Nick Desaulniers
sigh...I ran a broken script to send the series which doesn't cc folks properly. + lkml, linux-kbuild (Might just resend, properly) On Thu, Dec 3, 2020 at 5:11 PM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > DWARF5 wins significan

[PATCH v3 2/2] Kbuild: implement support for DWARF v5

2020-12-03 Thread Nick Desaulniers
ted-by: Fangrui Song Suggested-by: Caroline Tice Signed-off-by: Nick Desaulniers --- Makefile | 1 + include/asm-generic/vmlinux.lds.h | 6 +- lib/Kconfig.debug | 14 ++ scripts/test_dwarf5_support.sh| 9 + 4 files changed, 29 inserti

[PATCH v3 1/2] Kbuild: make DWARF version a choice

2020-12-03 Thread Nick Desaulniers
-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- Makefile | 14 -- lib/Kconfig.debug | 21 - 2 files changed, 24 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile index a2ded5029084..2430e1ee7c44 100644 --- a/Makefile +++ b/Makefile @@ -826,12

Re: [PATCH] Kbuild: implement support for DWARF5

2020-12-03 Thread Nick Desaulniers
On Thu, Dec 3, 2020 at 2:56 PM Nick Desaulniers wrote: > > On Tue, Nov 3, 2020 at 4:17 PM Arvind Sankar wrote: > > > > On Tue, Nov 03, 2020 at 04:05:36PM -0800, Nick Desaulniers wrote: > > > On Tue, Nov 3, 2020 at 4:00 PM Arvind Sankar > > > wrote: > >

Re: [PATCH v2 4/4] Kbuild: implement support for DWARF v5

2020-12-03 Thread Nick Desaulniers
On Thu, Dec 3, 2020 at 3:22 PM Nick Desaulniers wrote: > > On Tue, Nov 24, 2020 at 9:28 AM Arvind Sankar wrote: > > > > On Tue, Nov 03, 2020 at 04:53:43PM -0800, Nick Desaulniers wrote: > > > DWARF v5 is the latest standard of the DWARF debug info format. > > &g

Re: [PATCH v2 4/4] Kbuild: implement support for DWARF v5

2020-12-03 Thread Nick Desaulniers
On Tue, Nov 24, 2020 at 9:28 AM Arvind Sankar wrote: > > On Tue, Nov 03, 2020 at 04:53:43PM -0800, Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > > > Feature detection of DWARF5 is onerous, especially given that we've >

<    1   2   3   4   5   6   7   8   9   10   >