On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote:
> This is the implementation of CFM netlink status
> get information interface.
>
> Add new nested netlink attributes. These attributes are used by the
> user space to get status information.
>
> GETLINK:
> Request filter RTEXT_FILTE
On Sat, 2020-10-10 at 00:56 +0300, Nikolay Aleksandrov wrote:
> On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote:
> > This is the implementation of CFM netlink configuration
> > get information interface.
> >
> > Add new nested netlink attributes. These
.
> IFLA_BRIDGE_CFM_CC_CCM_TX_PORT_TLV_VALUE:
> The transmitted Port Status TLV value field.
> The type is u8.
>
> Signed-off-by: Henrik Bjoernlund
> Reviewed-by: Horatiu Vultur
> ---
> include/uapi/linux/if_bridge.h | 6 ++
> net/bridge/br_cfm_netlink.c| 161 +
> net/bridge/br_netlink.c| 29 +-
> net/bridge/br_private.h| 6 ++
> 4 files changed, 200 insertions(+), 2 deletions(-)
>
Acked-by: Nikolay Aleksandrov
idge.h | 90 +++
> include/uapi/linux/rtnetlink.h | 1 +
> net/bridge/Makefile| 2 +-
> net/bridge/br_cfm.c| 5 +
> net/bridge/br_cfm_netlink.c| 458 +
> net/bridge/br_netlink.c| 5 +
> net/bridge/br_private.h| 17 +-
> 7 files changed, 576 insertions(+), 2 deletions(-)
> create mode 100644 net/bridge/br_cfm_netlink.c
>
Acked-by: Nikolay Aleksandrov
net/bridge/br_cfm.c | 269
> net/bridge/br_private_cfm.h | 32
> 3 files changed, 311 insertions(+)
>
Acked-by: Nikolay Aleksandrov
by
> br_cfm_cc_rdi_set()
>
> Signed-off-by: Henrik Bjoernlund
> Reviewed-by: Horatiu Vultur
> ---
> include/uapi/linux/cfm_bridge.h | 39 -
> net/bridge/br_cfm.c | 284
> net/bridge/br_private_cfm.h | 54 ++
> 3 files changed, 376 insertions(+), 1 deletion(-)
>
Acked-by: Nikolay Aleksandrov
++
> net/bridge/br_if.c | 1 +
> net/bridge/br_private.h | 10 ++
> net/bridge/br_private_cfm.h | 61 +++
> 6 files changed, 375 insertions(+)
> create mode 100644 include/uapi/linux/cfm_bridge.h
> create mode 100644 net/bridge/br_cfm.c
> create mode 100644 net/bridge/br_private_cfm.h
>
Acked-by: Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote:
> This EtherType is used by all CFM protocal frames transmitted
> according to 802.1Q section 12.14.
>
> Signed-off-by: Henrik Bjoernlund
> Reviewed-by: Horatiu Vultur
> Acked-by: Nikolay Aleksandrov
> ---
+++-
> net/bridge/br_mrp.c | 19 +++
> net/bridge/br_private.h | 18 --
> 4 files changed, 60 insertions(+), 11 deletions(-)
>
Acked-by: Nikolay Aleksandrov
+++
> net/bridge/br_device.c | 3 +++
> net/bridge/br_private.h | 3 +++
> 3 files changed, 17 insertions(+)
>
Acked-by: Nikolay Aleksandrov
+++
> net/bridge/br_device.c | 3 +++
> net/bridge/br_private.h | 3 +++
> 3 files changed, 17 insertions(+)
>
Acked-by: Nikolay Aleksandrov
On Thu, 2020-10-08 at 10:09 -0700, Jakub Kicinski wrote:
> On Thu, 8 Oct 2020 10:18:09 +0000 Nikolay Aleksandrov wrote:
> > On Wed, 2020-10-07 at 14:49 +, Nikolay Aleksandrov wrote:
> > > On Wed, 2020-10-07 at 12:07 +, Henrik Bjoernlund wrote:
> > > > Thi
On Wed, 2020-10-07 at 14:49 +, Nikolay Aleksandrov wrote:
> On Wed, 2020-10-07 at 12:07 +, Henrik Bjoernlund wrote:
> > This commit is correcting NETLINK br_fill_ifinfo() to be able to
> > handle 'filter_mask' with multiple flags asserted.
> >
> >
> Signed-off-by: Henrik Bjoernlund
> Reviewed-by: Horatiu Vultur
> Suggested-by: Nikolay Aleksandrov
> Tested-by: Horatiu Vultur
> ---
> net/bridge/br_netlink.c | 26 +++---
> 1 file changed, 11 insertions(+), 15 deletions(-)
>
The patch look
On Tue, 2020-10-06 at 14:53 +, Henrik Bjoernlund wrote:
> Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14.
>
> Connectivity Fault Management (CFM) comprises capabilities for detecting,
> verifying,
> and isolating connectivity failures in Virtual Bridged Networks.
> The
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote:
> This is addition of CFM functionality to delete MEP instances
> on a port that is removed from the bridge.
> A MEP can only exist on a port that is related to a bridge.
>
> Reviewed-by: Horatiu Vultur
> Signed-off-by: Henrik Bjoernlun
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote:
> This is the implementation of Netlink notifications out of CFM.
>
> Notifications are initiated whenever a state change happens in CFM.
>
> IFLA_BRIDGE_CFM:
> Points to the CFM information.
>
> IFLA_BRIDGE_CFM_MEP_STATUS_INFO:
>
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote:
> This is the implementation of CFM netlink configuration
> and status information interface.
>
> Add new nested netlink attributes. These attributes are used by the
> user space to create/delete/configure CFM instances and get status.
>
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote:
> This is the first commit of the implementation of the CFM protocol
> according to 802.1Q section 12.14.
>
> Connectivity Fault Management (CFM) comprises capabilities for
> detecting, verifying, and isolating connectivity failures in
>
On Thu, 2020-10-01 at 10:30 +, Henrik Bjoernlund wrote:
> This patch extends the processing of frames in the bridge. Currently MRP
> frames needs special processing and the current implementation doesn't
> allow a nice way to process different frame types. Therefore try to
> improve this by add
On Mon, 2020-10-05 at 15:07 +0200, Allan W. Nielsen wrote:
> Hi Jiri
>
> On 01.10.2020 14:49, Jiri Pirko wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> > content is safe
> >
> > Thu, Oct 01, 2020 at 12:30:18PM CEST, henrik.bjoernl...@microchip.com wrote:
On 3.10.20 г. 3:11 ч., Pujin Shi wrote:
> For older versions of gcc, the array = {0}; will cause warnings:
>
> fs/btrfs/tree-checker.c: In function 'check_root_item':
> fs/btrfs/tree-checker.c:1038:9: warning: missing braces around initializer
> [-Wmissing-braces]
> struct btrfs_root_item ri
On 21.09.20 г. 10:29 ч., qiang.zh...@windriver.com wrote:
> From: Zqiang
>
> When the btrfs fill super error, we should first close devices and
> then call deactivate_locked_super func to free fs_info.
>
> Signed-off-by: Zqiang
> ---
> fs/btrfs/super.c | 1 +
> 1 file changed, 1 insertion(+
On Mon, 2020-09-14 at 09:40 +0200, Geert Uytterhoeven wrote:
> Hi David,
>
> CC bridge
>
> On Sun, Sep 13, 2020 at 3:34 AM David Miller wrote:
> > From: Geert Uytterhoeven
> > Date: Sat, 12 Sep 2020 14:33:59 +0200
> >
> > > "dev" is not the bridge device, but the physical Ethernet interface, w
On 17.09.20 г. 4:44 ч., Dave Chinner wrote:
> On Wed, Sep 16, 2020 at 05:58:51PM +0200, Jan Kara wrote:
>> On Sat 12-09-20 09:19:11, Amir Goldstein wrote:
>>> On Tue, Jun 23, 2020 at 8:21 AM Dave Chinner wrote:
>
> So
>
> P0p1
>
> hole punch starts
8d45a590
>
> The issue was bisected to:
>
> commit 6a3c7f5c87854e948c3c234e5f5e745c7c553722
> Author: Nikolay Borisov
> Date: Thu May 28 08:05:13 2020 +
>
> btrfs: don't balance btree inode pages from buffered write path
>
> bisection log: https
On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:
> This makes it possible to include or exclude the CFM
> protocol according to 802.1Q section 12.14.
>
> Signed-off-by: Henrik Bjoernlund
> ---
> net/bridge/Kconfig | 11 +++
> net/bridge/br_device.c | 3 +++
> net/bridg
On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:
> This is addition of CFM functionality to delete MEP instances
> on a port that is removed from the bridge.
> A MEP can only exist on a port that is related to a bridge.
>
> Signed-off-by: Henrik Bjoernlund
> ---
> net/bridge/br_cfm.c
#else
>-static inline bool lockdep_tcf_chain_is_locked(struct tcf_block
>*chain)
>+static inline bool lockdep_tcf_chain_is_locked(struct tcf_chain
>*chain)
> {
> return true;
> }
Ah, you want to solve it for all. :)
Looks and sounds good to me,
Reviewed-by: Nikolay Aleksandrov
annel over Ethernet */
> #define ETH_P_IBOE 0x8915 /* Infiniband over Ethernet */
> #define ETH_P_TDLS 0x890D /* TDLS */
Acked-by: Nikolay Aleksandrov
On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:
> This is the implementation of the CFM protocol according to
> 802.1Q section 12.14.
>
> Connectivity Fault Management (CFM) comprises capabilities for
> detecting, verifying, and isolating connectivity failures in
> Virtual Bridged Netw
On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:
> This patch extends the processing of frames in the bridge. Currently MRP
> frames needs special processing and the current implementation doesn't
> allow a nice way to process different frame types. Therefore try to
> improve this by add
On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:
> This is the implementation of CFM netlink configuration
> and status information interface.
>
> Add new nested netlink attributes. These attributes are used by the
> user space to create/delete/configure CFM instances and get status.
>
On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:
> This is the implementation of Netlink notifications out of CFM.
>
> Notifications are initiated whenever a state change happens in CFM.
>
[snip]
> @@ -445,6 +458,7 @@ static int br_cfm_frame_rx(struct net_bridge_port *port,
> struct s
On Sun, 2020-09-06 at 20:21 +0200, Horatiu Vultur wrote:
> The 09/04/2020 15:44, Stephen Hemminger wrote:
> > On Fri, 4 Sep 2020 09:15:20 +
> > Henrik Bjoernlund wrote:
> >
> > > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14.
> > >
> > >
[snip]
> > > Currently this
On 28.08.20 г. 17:39 ч., Konstantin Komarov wrote:
> This patch adds NTFS Read-Write driver to fs/ntfs3.
>
> Having decades of expertise in commercial file systems development and huge
> test coverage, we at Paragon Software GmbH want to make our contribution to
> the Open Source Community by p
On 8/21/20 9:10 AM, syzbot wrote:
Hello,
syzbot found the following issue on:
HEAD commit:18445bf4 Merge tag 'spi-fix-v5.9-rc1' of git://git.kernel...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=162cbd7a90
kernel config: https://syzkaller.appspot.
On 8/21/20 6:27 PM, syzbot wrote:
Hello,
syzbot found the following issue on:
HEAD commit:da2968ff Merge tag 'pci-v5.9-fixes-1' of git://git.kernel...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=137316ca90
kernel config: https://syzkaller.appspot.
On 14.08.20 г. 15:29 ч., Konstantin Komarov wrote:
> This patch adds NTFS Read-Write driver to fs/ntfs3.
>
> Having decades of expertise in commercial file systems development and huge
> test coverage, we at Paragon Software GmbH want to make our contribution to
> the Open Source Community by p
On 07/08/2020 14:13, hongbo.w...@nxp.com wrote:
> From: "hongbo.wang"
>
> the following command will be supported:
>
> Set bridge's vlan protocol:
> ip link set br0 type bridge vlan_protocol 802.1ad
> Add VLAN:
> ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100
> Del
On 3.08.20 г. 12:39 ч., Nikolay Borisov wrote:
>
>
> On 3.08.20 г. 12:35 ч., Pavel Machek wrote:
>> btrfs_get_extent() sets variable ret, but out: error path expect error
>> to be in variable err. Fix that.
>>
>> Signed-off-by: Pavel Machek (CIP)
>
>
ode to avoid NULL
pointer dereference")
Reviewed-by: Nikolay Borisov
>
> ---
>
> Notice that patch introducing this problem is on its way to 4.19.137-stable.
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 7befb7c12bd3..4aaa01540f89 100644
> --- a/fs/btrfs
_bridge.h | 1 +
> net/dsa/slave.c| 9 +++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
This is not bridge related at all, please leave its flags out of it.
Nacked-by: Nikolay Aleksandrov
> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_brid
On 14/07/2020 18:07, Horatiu Vultur wrote:
> The 07/14/2020 16:29, Nikolay Aleksandrov wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>> content is safe
>>
>> On 14/07/2020 10:34, Horatiu Vultur wrote:
>>>
terconnect role MIM.
>
> Signed-off-by: Horatiu Vultur
> ---
> include/net/switchdev.h | 38 ++
> 1 file changed, 38 insertions(+)
>
Reviewed-by: Nikolay Aleksandrov
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> i
MRP attributes outside of MRP netlink
code?
Perhaps we should at least dump them only for MRP-aware ports, that should be
easy.
They make no sense outside of MRP anyway, but increase the size of the dump for
all
right now.
Acked-by: Nikolay Aleksandrov
> diff --git a/include/uapi/linux/if
_INFO_IN_ROLE,
> + IFLA_BRIDGE_MRP_INFO_IN_TEST_INTERVAL,
> + IFLA_BRIDGE_MRP_INFO_IN_TEST_MAX_MISS,
> __IFLA_BRIDGE_MRP_INFO_MAX,
> };
>
>
Acked-by: Nikolay Aleksandrov
NTERVAL,
> + mrp->in_test_interval))
> + goto nla_put_failure;
> + if (nla_put_u32(skb, IFLA_BRIDGE_MRP_INFO_IN_TEST_MAX_MISS,
> + mrp->in_test_max_miss))
> + goto nla_put_failure;
> +
> nla_nest_end(skb, tb);
> }
> nla_nest_end(skb, mrp_tb);
>
Acked-by: Nikolay Aleksandrov
apply to the interconnect port.
>
> Signed-off-by: Horatiu Vultur
> ---
> net/bridge/br_mrp_netlink.c | 140
> 1 file changed, 140 insertions(+)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/net/bridge/br_mrp_netlink.c b/ne
> 2 files changed, 543 insertions(+), 31 deletions(-)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/net/bridge/br_mrp.c b/net/bridge/br_mrp.c
> index fe7cf1446b58a..b36689e6e7cba 100644
> --- a/net/bridge/br_mrp.c
> +++ b/net/bridge/br_mrp.c
> @@ -4,6 +4,27 @@
>
---
> net/bridge/br_mrp_switchdev.c | 62 +++
> net/bridge/br_private_mrp.h | 7
> 2 files changed, 69 insertions(+)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/net/bridge/br_mrp_switchdev.c b/net/bridge/br_mrp_switchdev.c
> index
+
> 2 files changed, 23 insertions(+)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/net/bridge/br_mrp_netlink.c b/net/bridge/br_mrp_netlink.c
> index acce300c0cc29..4bf7aaeb29152 100644
> --- a/net/bridge/br_mrp_netlink.c
> +++ b/net/bridge/br_mrp_netlink.c
> @@ -389,3 +
P_InTest frames and check
> for lost of continuity.
>
> Signed-off-by: Horatiu Vultur
> ---
> net/bridge/br_private_mrp.h | 13 +
> 1 file changed, 13 insertions(+)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/net/bridge/br_private_mrp.h b/net/bridge/br_
---
> net/bridge/br_mrp.c | 6 +++---
> net/bridge/br_mrp_netlink.c | 2 +-
> net/bridge/br_private_mrp.h | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/net/bridge/br_mrp.c b/net/bridge/br_mrp.c
> index 90592af9
ATED BIT(16)
> #define BR_MRP_AWARE BIT(17)
> #define BR_MRP_LOST_CONT BIT(18)
> +#define BR_MRP_LOST_IN_CONT BIT(19)
>
> #define BR_DEFAULT_AGEING_TIME (300 * HZ)
>
>
Acked-by: Nikolay Aleksandrov
ltur
> ---
> include/uapi/linux/if_bridge.h | 53 +
> include/uapi/linux/mrp_bridge.h | 38 +++++++
> 2 files changed, 91 insertions(+)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/
On 12/07/2020 17:05, Horatiu Vultur wrote:
> Thie patch adds support for MRP Interconnect. Similar with the MRP ring,
> if the HW can't generate MRP_InTest frames, then the SW will try to
> generate them. And if also the SW fails to generate the frames then an
> error is return to userspace.
>
> T
On 13/07/2020 04:54, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> net/bridge/br_netlink_tunnel.c: In function '__vlan_tunnel_handle_range':
> net/bridge/br_netlink_tunnel.c:271:26: error: implicit
On 09/07/2020 13:00, Horatiu Vultur wrote:
> Thie patch adds support for MRP Interconnect. Similar with the MRP ring,
> if the HW can't generate MRP_InTest frames, then the SW will try to
> generate them. And if also the SW fails to generate the frames then an
> error is return to userspace.
>
> T
On 06/07/2020 12:18, Horatiu Vultur wrote:
> Thie patch adds support for MRP Interconnect. Similar with the MRP ring,
> if the HW can't generate MRP_InTest frames, then the SW will try to
> generate them. And if also the SW fails to generate the frames then an
> error is return to userspace.
>
> T
On 7/5/20 10:49 PM, Linus Lüssing wrote:
On Sun, Jul 05, 2020 at 10:11:39PM +0300, Nikolay Aleksandrov wrote:
On 7/5/20 10:08 PM, Linus Lüssing wrote:
On Sun, Jul 05, 2020 at 09:33:13PM +0300, Nikolay Aleksandrov wrote:
On 05/07/2020 21:22, Linus Lüssing wrote:
Commit e57f61858b7c (&quo
On 7/5/20 10:08 PM, Linus Lüssing wrote:
On Sun, Jul 05, 2020 at 09:33:13PM +0300, Nikolay Aleksandrov wrote:
On 05/07/2020 21:22, Linus Lüssing wrote:
Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in
igmp3/mld2 report handling") introduced a small bug w
pointer in
> igmp3/mld2 report handling")
> Signed-off-by: Linus Lüssing
> ---
> net/bridge/br_multicast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I'd rather be more concerned with it rejecting a valid report due to wrong
size. The ptr
size
~
> ret will not be set when olen is 0
> When olen is 0, this function does no work.
>
> So initialize ret to 0
>
> Signed-off-by: Tom Rix
And I forgot:
Reviewed-by: Nikolay Borisov
> ---
> fs/btrfs/reflink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
On 5.07.20 г. 17:20 ч., t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analysis flags a garbage return
>
> fs/btrfs/reflink.c:611:2: warning: Undefined or garbage value returned to
> caller [core.uninitialized.UndefReturn]
> return ret;
> ^~
> ret will not be
e MRP status is return only on the bridge
> interfaces.
>
> Signed-off-by: Horatiu Vultur
> ---
> include/uapi/linux/rtnetlink.h | 1 +
> net/bridge/br_netlink.c| 25 -
> 2 files changed, 25 insertions(+), 1 deletion(-)
>
Acked-by: Nikolay
t; + __IFLA_BRIDGE_MRP_INFO_MAX,
> +};
> +
> +#define IFLA_BRIDGE_MRP_INFO_MAX (__IFLA_BRIDGE_MRP_INFO_MAX - 1)
> +
> struct br_mrp_instance {
> __u32 ring_id;
> __u32 p_ifindex;
>
Acked-by: Nikolay Aleksandrov
> net/bridge/br_private.h | 7
> 2 files changed, 71 insertions(+)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/net/bridge/br_mrp_netlink.c b/net/bridge/br_mrp_netlink.c
> index 34b3a8776991f..c4f5c356811f3 100644
> --- a/net/bridge/br_mrp_netlink.c
> +++ b/net/brid
On 01/07/2020 10:22, Horatiu Vultur wrote:
> This patch extends the function br_fill_ifinfo to return also the MRP
> status for each instance on a bridge. It also adds a new filter
> RTEXT_FILTER_MRP to return the MRP status only when this is set, not to
> interfer with the vlans. The MRP status is
26e8f7ea30 ("bridge: mrp: Connect MRP API with the switchdev API")
> Signed-off-by: Horatiu Vultur
> ---
> net/bridge/br_mrp.c | 2 +-
> net/bridge/br_private.h | 2 +-
> net/bridge/br_private_mrp.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
On 25/06/2020 15:03, kernel test robot wrote:
> Hi Horatiu,
>
> Thank you for the patch! Perhaps something to improve:
>
Hi,
I think you should drop the __rcu tag for the mrp_list member and also
from the "list" member of struct br_mrp to fix most of the below.
Cheers,
Nik
> [auto build test
On 24/06/2020 11:05, Horatiu Vultur wrote:
> In case the userspace daemon dies, then when is restarted it doesn't
> know if there are any MRP instances in the kernel. Therefore extend the
> netlink interface to allow the daemon to clear all MRP instances when is
> started.
>
> Signed-off-by: Horat
On 10.06.20 г. 10:19 ч., Michał Mirosław wrote:
> Dear Developers,
>
> I found a lockdep warning in dmesg some after doing 'mdadm -S' while
> also having btrfs mounted (light to none I/O load). Disks under MD and
> btrfs are unrelated.
Huhz, I think that's genuine, because btrfs and md shared
On 03/06/2020 00:01, David Miller wrote:
> From: Nikolay Aleksandrov
> Date: Tue, 2 Jun 2020 10:23:09 +0300
>
>> On 01/06/2020 21:06, David Miller wrote:
>>> From: patrickeigens...@gmail.com
>>> Date: Mon, 1 Jun 2020 13:12:01 +0200
>>>
>>>&g
oring them. This
enables diffing subsystems which generate built-in.a files.
Signed-off-by: Nikolay Borisov
---
Resending and CCing Andrew this time.
scripts/bloat-o-meter | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
index 8c965f6a9881..d7ca46c
On 02/06/2020 10:23, Nikolay Aleksandrov wrote:
> On 01/06/2020 21:06, David Miller wrote:
>> From: patrickeigens...@gmail.com
>> Date: Mon, 1 Jun 2020 13:12:01 +0200
>>
>>> From: Patrick Eigensatz
>>>
>>> After allocating the spare nexthop group
On 01/06/2020 21:06, David Miller wrote:
> From: patrickeigens...@gmail.com
> Date: Mon, 1 Jun 2020 13:12:01 +0200
>
>> From: Patrick Eigensatz
>>
>> After allocating the spare nexthop group it should be tested for kzalloc()
>> returning NULL, instead the already used nexthop group (which cannot
re = nhg;
>
>
As Colin's similar patch[1] was rejected recently, this one also fixes the
issue.
This is targeted at -net.
Fixes: 90f33bffa382 ("nexthops: don't modify published nexthop groups")
Acked-by: Nikolay Aleksandrov
Thanks!
[1] https://lkml.org/lkml/2020/5/28/909
oring them. This
enables diffing subsystems which generate built-in.a files.
Signed-off-by: Nikolay Borisov
---
scripts/bloat-o-meter | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
index 8c965f6a9881..d7ca46c612b3 100755
--- a/scripts/bloat-o-
On 29/05/2020 13:05, Horatiu Vultur wrote:
> Each MRP instance has a priority, a lower value means a higher priority.
> The priority of MRP instance is stored in MRP_Test frame in this way
> all the MRP nodes in the ring can see other nodes priority.
>
> Signed-off-by: Horatiu Vultur
> ---
> inc
On 28/05/2020 18:53, Colin Ian King wrote:
> On 28/05/2020 15:55, Nikolay Aleksandrov wrote:
>> On 28/05/2020 17:53, Nikolay Aleksandrov wrote:
>>> On 28/05/2020 17:51, Colin King wrote:
>>>> From: Colin Ian King
>>>>
>>>> The allocation failu
On 28/05/2020 17:53, Nikolay Aleksandrov wrote:
> On 28/05/2020 17:51, Colin King wrote:
>> From: Colin Ian King
>>
>> The allocation failure check for nhg->spare is currently checking
>> the pointer nhg rather than nhg->spare which is never false. Fix
>&
exthop_grp_alloc(num_nh);
> - if (!nhg) {
> + if (!nhg->spare) {
> kfree(nhg);
> kfree(nh);
> return NULL;
>
Good catch, embarrassing copy paste error :-/
Acked-by: Nikolay Aleksandrov
-
> net/bridge/br_private_mrp.h| 2 +-
> 4 files changed, 290 insertions(+), 50 deletions(-)
>
Since this is still only in net-next the change seems fine.
Acked-by: Nikolay Aleksandrov
> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux
On 26/05/2020 17:22, Horatiu Vultur wrote:
> This patch rework the MRP netlink interface. Before, each attribute
> represented a binary structure which made it hard to be extended.
> Therefore update the MRP netlink interface such that each existing
> attribute to be a nested attribute which contai
On 25/05/2020 13:03, Michal Kubecek wrote:
> On Mon, May 25, 2020 at 11:28:27AM +, Horatiu Vultur wrote:
> [...]
>> My first approach was to extend the 'struct br_mrp_instance' with a field
>> that
>> contains the priority of the node. But this breaks the backwards
>> compatibility,
>> and th
On 25/05/2020 14:28, Horatiu Vultur wrote:
> Hi,
>
> While I was working on adding support for MRA role to MRP, I noticed that I
> might have some issues with the netlink interface, so it would be great if you
> can give me an advice on how to continue.
>
> First a node with MRA role can behave a
oint correctly
> + */
> + if (p)
> + br = p->br;
> +
> if (br->stp_enabled != BR_NO_STP) {
> NL_SET_ERR_MSG_MOD(extack, "MRP can't be enabled if STP is
> already enabled");
> return -EINVAL;
>
You should tag the fix for net-next when it's intended for it.
Acked-by: Nikolay Aleksandrov
On 21/05/2020 21:49, Horatiu Vultur wrote:
> The 05/21/2020 11:16, Nikolay Aleksandrov wrote:
>> On 20/05/2020 16:09, Horatiu Vultur wrote:
>>> It is not allow to have the same net bridge port part of multiple MRP
>>> rings. Therefore add a check if the port is used alr
ect MRP API with the switchdev API")
> Signed-off-by: Horatiu Vultur
> ---
> net/bridge/br_mrp.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
Acked-by: Nikolay Aleksandrov
> diff --git a/net/bridge/br_mrp.c b/net/bridge/br_mrp.c
> index a
On 20/05/2020 16:09, Horatiu Vultur wrote:
> It is not allow to have the same net bridge port part of multiple MRP
> rings. Therefore add a check if the port is used already in a different
> MRP. In that case return failure.
>
> Fixes: 9a9f26e8f7ea ("bridge: mrp: Connect MRP API with the switchdev
On 9.05.20 г. 8:20 ч., Jia-Ju Bai wrote:
> The functions btrfs_block_group_done() and caching_thread() are
> concurrently executed at runtime in the following call contexts:
>
> Thread 1:
> btrfs_sync_file()
> start_ordered_ops()
> btrfs_fdatawrite_range()
> btrfs_writepage
ocess(struct net_bridge_port
> *p, struct sk_buff *skb)
>
> static inline bool br_mrp_enabled(struct net_bridge *br)
> {
> - return 0;
> + return false;
> }
>
> static inline void br_mrp_port_del(struct net_bridge *br,
>
Fixes: 6536993371fab ("bridge: mrp: Integrate MRP into the bridge")
Acked-by: Nikolay Aleksandrov
On 24.09.19 г. 1:57 ч., Navid Emamdoost wrote:
> In btrfs_mount_root the last error checking was not going to the error
> handling path. Fixed it.
>
> Signed-off-by: Navid Emamdoost
NAK
deactivate_locked_super actually calls btrfs_kill_super which in turn
calls generic_shutdown_super which d
On 24.09.19 г. 9:14 ч., Pavel Machek wrote:
> AFAICT, with current code user could pass something like "lzox" and
> still get "lzo" compression. Check string lengths to prevent that.
>
> Signed-off-by: Pavel Machek
>
> diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
> index b05b3
On 28/07/2019 17:20, syzbot wrote:
> syzbot has bisected this bug to:
>
> commit 04cf31a759ef575f750a63777cee95500e410994
> Author: Michael Ellerman
> Date: Thu Mar 24 11:04:01 2016 +
>
> ftrace: Make ftrace_location_range() global
>
> bisection log: https://syzkaller.appspot.com/x/b
On 11.07.19 г. 22:52 ч., Chris Mason wrote:
> On 11 Jul 2019, at 12:00, Nikolay Borisov wrote:
>
>> On 10.07.19 г. 22:28 ч., Tejun Heo wrote:
>>> From: Chris Mason
>>>
>>> The btrfs writepages function collects a large range of pages flagged
>>
On 26.07.19 г. 16:16 ч., Paul Menzel wrote:
> Dear Linux folks,
>
>
> On a Power 8 server
>
> Linux power 5.3.0-rc1+ #1 SMP Fri Jul 26 11:34:28 CEST 2019 ppc64le
> ppc64le ppc64le GNU/Linux
>
> Kmemleak reports the warnings below.
>
> ```
> $ sudo more /sys/kernel/debug/kmemleak
> unre
On 26/07/2019 14:05, Nikolay Aleksandrov wrote:
> On 25/07/2019 23:42, Brodie Greenfield wrote:
>> We want to be able to keep more spaces available in our queue for
>> processing incoming multicast traffic (adding (S,G) entries) - this lets
>> us learn more groups faster, rath
On 25/07/2019 23:42, Brodie Greenfield wrote:
> We want to be able to keep more spaces available in our queue for
> processing incoming multicast traffic (adding (S,G) entries) - this lets
> us learn more groups faster, rather than dropping them at this stage.
>
> Signed-off-by: Brodie Greenfield
101 - 200 of 653 matches
Mail list logo