Re: [PATCH 00/15] usb: serial: avoid using usb_control_msg() directly

On Fri, Dec 4, 2020 at 2:38 PM Johan Hovold wrote: > > Hi Himadri, > > and sorry about the late feedback on this one. I'm still trying to dig > myself out of some backlog. > > On Wed, Nov 04, 2020 at 12:16:48PM +0530, Himadri Pandya wrote: > > There are many usages of

[PATCH 11/15] usb: serial: ipaq: use usb_control_msg_send()

The new usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrapper instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/ipaq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH 07/15] usb: serial: f81534: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/f81534.c | 63 +++-- 1

[PATCH 08/15] usb: serial: ftdi_sio: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/ftdi_sio.c | 182 +++--- 1

[PATCH 06/15] usb: serial: f81232: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/f81232.c | 88 - 1

[PATCH 13/15] usb: serial: iuu_phoenix: use usb_control_msg_send()

The new usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrapper instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/iuu_phoenix.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 15/15] usb: serial: kl5kusb105: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly Signed-off-by: Himadri Pandya --- drivers/usb/serial/kl5kusb105.c | 94 +++-- 1 file

[PATCH 10/15] usb: serial: io_ti: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly Signed-off-by: Himadri Pandya --- drivers/usb/serial/io_ti.c | 28 ++-- 1 file changed

[PATCH 12/15] usb: serial: ipw: use usb_control_msg_send()

The new usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrapper instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/ipw.c | 107 +-- 1 file changed, 36 insertions

[PATCH 14/15] usb: serial: keyspan_pda: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/keyspan_pda.c | 172 +-- 1

[PATCH 09/15] usb: serial: io_edgeport: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/io_edgeport.c | 73 1

[PATCH 02/15] usb: serial: belkin_sa: use usb_control_msg_send()

The new usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrapper instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/belkin_sa.c | 35 +- 1 file changed, 17 insertions

[PATCH 05/15] usb: serial: cypress_m8: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/cypress_m8.c | 38 + 1

[PATCH 04/15] usb: serial: cp210x: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/cp210x.c | 148 ++-- 1

[PATCH 01/15] usb: serial: ark3116: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/ark3116.c | 29 - 1 file

[PATCH 00/15] usb: serial: avoid using usb_control_msg() directly

There are many usages of usb_control_msg() that can use the new wrapper functions usb_contro_msg_send() & usb_control_msg_recv() for better error checks on short reads and writes. Hence use them whenever possible and avoid using usb_control_msg() directly. Himadri Pandya (15): usb: se

[PATCH 03/15] usb: serial: ch314: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/usb/serial/ch341.c | 45 -- 1

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

On Thu, Sep 24, 2020 at 5:06 PM Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 20:02 +0530 schrieb Himadri Pandya: > > > I meant that it was stupid to change it without properly understanding > > the significance of GFP_NOIO in this context. > > > > S

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

On Wed, Sep 23, 2020 at 7:51 PM Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 19:36 +0530 schrieb Himadri Pandya: > > On Wed, Sep 23, 2020 at 3:52 PM Oliver Neukum wrote: > > > > > > Am Mittwoch, den 23.09.2020, 14:35 +0530 schrieb Himadri Pandya:

Re: [PATCH 4/4] net: rndis_host: use usb_control_msg_recv() and usb_control_msg_send()

On Wed, Sep 23, 2020 at 3:52 PM Greg KH wrote: > > On Wed, Sep 23, 2020 at 02:35:19PM +0530, Himadri Pandya wrote: > > The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps > > usb_control_msg() with proper error check. Hence use the wrappers >

Re: [PATCH 1/4] net: usbnet: use usb_control_msg_recv() and usb_control_msg_send()

On Wed, Sep 23, 2020 at 3:54 PM Greg KH wrote: > > On Wed, Sep 23, 2020 at 02:35:16PM +0530, Himadri Pandya wrote: > > Potential incorrect use of usb_control_msg() has resulted in new wrapper > > functions to enforce its correct usage with proper error check. Hence > &g

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

On Wed, Sep 23, 2020 at 3:52 PM Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 14:35 +0530 schrieb Himadri Pandya: > > Hi, > > > Many usage of usb_control_msg() do not have proper error check on return > > value leaving scope for bugs on short read

[PATCH 4/4] net: rndis_host: use usb_control_msg_recv() and usb_control_msg_send()

The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps usb_control_msg() with proper error check. Hence use the wrappers instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/net/usb/rndis_host.c | 44 ++-- 1

[PATCH 1/4] net: usbnet: use usb_control_msg_recv() and usb_control_msg_send()

Potential incorrect use of usb_control_msg() has resulted in new wrapper functions to enforce its correct usage with proper error check. Hence use these new wrapper functions instead of calling usb_control_msg() directly. Signed-off-by: Himadri Pandya --- drivers/net/usb/usbnet.c | 46

[PATCH 0/4] net: usb: avoid using usb_control_msg() directly

. Himadri Pandya (4): net: usbnet: use usb_control_msg_recv() and usb_control_msg_send() net: sierra_net: use usb_control_msg_recv() net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send() net: rndis_host: use usb_control_msg_recv() and usb_control_msg_send() drivers/net

[PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

. Signed-off-by: Himadri Pandya --- drivers/net/usb/rtl8150.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 733f120c852b..e3002b675921 100644 --- a/drivers/net/usb/rtl8150.c +++ b

[PATCH 2/4] net: sierra_net: use usb_control_msg_recv()

The new usb api function usb_control_msg_recv() nicely wrapps usb_control_msg() with proper error check. Hence use it instead of directly calling usb_control_msg(). Signed-off-by: Himadri Pandya --- drivers/net/usb/sierra_net.c | 17 +++-- 1 file changed, 7 insertions(+), 10

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

On Thu, Aug 27, 2020 at 1:28 PM Sergei Shtylyov wrote: > > Hello! > > On 27.08.2020 9:53, Himadri Pandya wrote: > > > The buffer size is 2 Bytes and we expect to receive the same amount of > > data. But sometimes we receive less data and run into uninit-was-stored

[PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

+a7e220df5a81d1ab4...@syzkaller.appspotmail.com Signed-off-by: Himadri Pandya --- drivers/net/usb/asix_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index e39f41efda3e..7bc6e8f856fe 100644 --- a/drivers/net/usb

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

On Mon, Aug 24, 2020 at 11:16:55AM -0700, Jakub Kicinski wrote: > On Sun, 23 Aug 2020 13:50:42 +0530 Himadri Pandya wrote: > > Initialize the buffer before passing it to usb_read_cmd() function(s) to > > fix the uninit-was-stored issue in asix_read_cmd(). > > > > Fi

[PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

Initialize the buffer before passing it to usb_read_cmd() function(s) to fix the uninit-was-stored issue in asix_read_cmd(). Fixes: KMSAN: kernel-infoleak in raw_ioctl Reported by: syzbot+a7e220df5a81d1ab4...@syzkaller.appspotmail.com Signed-off-by: Himadri Pandya --- drivers/net/usb

[PATCH] Drivers: hv: balloon: Remove dependencies on guest page size

granularities to handle larger page sizes correctly. Signed-off-by: Himadri Pandya --- drivers/hv/hv_balloon.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index 34bd73526afd..935904830d42 100644

[PATCH 0/2] Drivers: hv: Remove dependencies on guest page size

. The second patch removes dependencies on guest page size in vmbus by using hyper-v specific page symbol and functions. Himadri Pandya (2): x86: hv: Add function to allocate zeroed page for Hyper-V Drivers: hv: vmbus: Remove dependencies on guest page size arch/x86/hyperv/hv_init.c

[PATCH 1/2] x86: hv: Add function to allocate zeroed page for Hyper-V

hyper-v's assumed page size and actual guest page size. Signed-off-by: Himadri Pandya --- arch/x86/hyperv/hv_init.c | 8 arch/x86/include/asm/mshyperv.h | 1 + 2 files changed, 9 insertions(+) diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index d314cf1e15fd

[PATCH 2/2] Drivers: hv: vmbus: Remove dependencies on guest page size

Hyper-V assumes page size to be 4K. This might not be the case for ARM64 architecture. Hence use hyper-v page size and page allocation function to avoid conflicts between different host and guest page size on ARM64. Signed-off-by: Himadri Pandya --- drivers/hv/connection.c | 14

Re: [PATCH] hv_sock: use HV_HYP_PAGE_SIZE instead of PAGE_SIZE_4K

] This patch should be applied to linux-next git tree. Thank you. - Himadri url: https://github.com/0day-ci/linux/commits/Himadri-Pandya/hv_sock-use-HV_HYP_PAGE_SIZE-instead-of-PAGE_SIZE_4K/20190726-085229 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-10

[PATCH] hv_sock: use HV_HYP_PAGE_SIZE instead of PAGE_SIZE_4K

on ARM64 architecture. Signed-off-by: Himadri Pandya --- net/vmw_vsock/hyperv_transport.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c index f2084e3f7aa4..ecb5d72d8010 100644 --- a/net

[PATCH 1/2] Drivers: hv: Specify receive buffer size using Hyper-V page size

to receive. Signed-off-by: Himadri Pandya --- drivers/hv/hv_fcopy.c| 3 ++- drivers/hv/hv_kvp.c | 3 ++- drivers/hv/hv_snapshot.c | 3 ++- drivers/hv/hv_util.c | 8 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/hv/hv_fcopy.c b/drivers/hv/hv_fcopy.c index

[PATCH 2/2] Drivers: hv: util: Specify ring buffer size using Hyper-V page size

VMbus ring buffers are sized based on the 4K page size used by Hyper-V. The Linux guest page size may not be 4K on all architectures so use the Hyper-V page size to specify the ring buffer size. Signed-off-by: Himadri Pandya --- drivers/hv/hv_util.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 0/2] Drivers: hv: Specify buffer size using Hyper-V page size

recv_buffer and VMbus ring buffers are sized based on guest page size which Hyper-V assumes to be 4KB. It might not be the case for some architectures. Hence instead use the Hyper-V page size. Himadri Pandya (2): Drivers: hv: Specify receive buffer size using Hyper-V page size Drivers: hv

[PATCH] staging: wlan-ng: Fix improper SPDX comment style

Pandya --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 81a6b0324641..6fde75d4f064 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers

Re: [PATCH] staging: fbtft: fix alignment should match open parenthesis

On 10/04/19 4:12 PM, Dan Carpenter wrote: On Wed, Apr 10, 2019 at 03:30:22PM +0530, Himadri Pandya wrote: Fix checkpatch warning "Alignment should match open parenthesis". Signed-off-by: Himadri Pandya --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 inser

[PATCH] staging: gasket: replace symbolic permissions with octal permissions

Resolve checkpatch warning for using symbolic permissions by replacing them with octal permissions. Signed-off-by: Himadri Pandya --- drivers/staging/gasket/gasket_sysfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers

[PATCH] staging: fbtft: fix alignment should match open parenthesis

Fix checkpatch warning "Alignment should match open parenthesis". Signed-off-by: Himadri Pandya --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c index 94

Re: [PATCH net-next] net: dsa: add missing of_node_put

On 22/02/19 8:06 PM, Andrew Lunn wrote: On Fri, Feb 22, 2019 at 04:48:18PM +0530, Himadri Pandya wrote: Decrement the reference count on port while returning out of the loop. Issue identified by Coccinelle. You and Wen Yang are both fixing the same issue. Maybe you can coordinate? Sure

[PATCH net-next] net: dsa: add missing of_node_put

Decrement the reference count on port while returning out of the loop. Issue identified by Coccinelle. Signed-off-by: Himadri Pandya --- net/dsa/dsa2.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index a1917025e155

Re: [Outreachy kernel] [PATCH] net: dsa: add missing of_node_put

On 20/02/19 9:23 AM, Vaishali Thakkar wrote: On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote: Hi Himadri, Thanks for the patch! For the scope of Outreachy, we prefer that you send patches in staging directory as Greg makes sure to pick them during the application period. Of course

[PATCH] net: dsa: add missing of_node_put

Decrement the reference count on port while returning out of the loop. Signed-off-by: Himadri Pandya --- net/dsa/dsa2.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index a1917025e155..396e7433dd8f 100644 --- a/net/dsa/dsa2

[RFC 0/2] Potential race condition with page lock

if it is really locked or not as there are explicit APIs to set PG_locked. I didn't get traces of history for having PG_locked being set non-atomically. I believe it could be because of performance reasons. Not sure though. Chintan Pandya (2): page-flags: Make page lock operation atomic page

[RFC 1/2] page-flags: Make page lock operation atomic

: I13bdbedc2b198af014d885e1925c93b83ed6660e Signed-off-by: Chintan Pandya --- fs/cifs/file.c | 8 fs/pipe.c | 2 +- include/linux/page-flags.h | 2 +- include/linux/pagemap.h| 6 +++--- mm/filemap.c | 4 ++-- mm/khugepaged.c| 2 +- mm/ksm.c

[RFC 2/2] page-flags: Catch the double setter of page flags

wait-until-set. So, at least, find out who is doing double setting and fix them. Change-Id: I1295fcb8527ce4b54d5d11c11287fc7516006cf0 Signed-off-by: Chintan Pandya --- include/linux/page-flags.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/page-flags.h b/include

[tip:x86/mm] ioremap: Update pgtable free interfaces with addr

Commit-ID: 785a19f9d1dd8a4ab2d0633be4656653bd3de1fc Gitweb: https://git.kernel.org/tip/785a19f9d1dd8a4ab2d0633be4656653bd3de1fc Author: Chintan Pandya AuthorDate: Wed, 27 Jun 2018 08:13:47 -0600 Committer: Thomas Gleixner CommitDate: Wed, 4 Jul 2018 21:37:08 +0200 ioremap: Update

[tip:x86/mm] ioremap: Update pgtable free interfaces with addr

Commit-ID: 785a19f9d1dd8a4ab2d0633be4656653bd3de1fc Gitweb: https://git.kernel.org/tip/785a19f9d1dd8a4ab2d0633be4656653bd3de1fc Author: Chintan Pandya AuthorDate: Wed, 27 Jun 2018 08:13:47 -0600 Committer: Thomas Gleixner CommitDate: Wed, 4 Jul 2018 21:37:08 +0200 ioremap: Update

Re: [PATCH v13 0/3] Fix issues with huge mapping in ioremap for ARM64

Hi Andrew, On 6/6/2018 9:15 PM, Will Deacon wrote: [...] On Wed, Jun 06, 2018 at 12:31:18PM +0530, Chintan Pandya wrote: This series of patches re-bring huge vmap back for arm64. Patch 1/3 has been taken by Toshi in his series of patches by name "[PATCH v3 0/3] fix free pmd/pte

Re: [PATCH v13 0/3] Fix issues with huge mapping in ioremap for ARM64

Hi Andrew, On 6/6/2018 9:15 PM, Will Deacon wrote: [...] On Wed, Jun 06, 2018 at 12:31:18PM +0530, Chintan Pandya wrote: This series of patches re-bring huge vmap back for arm64. Patch 1/3 has been taken by Toshi in his series of patches by name "[PATCH v3 0/3] fix free pmd/pte

Re: [PATCH v13 0/3] Fix issues with huge mapping in ioremap for ARM64

On 6/6/2018 9:15 PM, Will Deacon wrote: Hi Chintan, Hi Will, Thanks for sticking with this. I've reviewed the series now and I'm keen for it to land in mainline. Just a couple of things below. Thanks for all the reviews so far. On Wed, Jun 06, 2018 at 12:31:18PM +0530, Chintan Pandya

Re: [PATCH v13 0/3] Fix issues with huge mapping in ioremap for ARM64

On 6/6/2018 9:15 PM, Will Deacon wrote: Hi Chintan, Hi Will, Thanks for sticking with this. I've reviewed the series now and I'm keen for it to land in mainline. Just a couple of things below. Thanks for all the reviews so far. On Wed, Jun 06, 2018 at 12:31:18PM +0530, Chintan Pandya

[PATCH v13 2/3] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable

Add an interface to invalidate intermediate page tables from TLB for kernel. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/tlbflush.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h index dfc61d7

[PATCH v13 1/3] ioremap: Update pgtable free interfaces with addr

From: Chintan Pandya The following kernel panic was observed on ARM64 platform due to a stale TLB entry. 1. ioremap with 4K size, a valid pte page table is set. 2. iounmap it, its pte entry is set to 0. 3. ioremap the same address with 2M size, update its pmd entry with a new value. 4

[PATCH v13 3/3] arm64: Implement page table free interfaces

and also free the leaking page tables. Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidation of TLB 3) Freeing of the un-used next level page tables Signed-off-by: Chintan Pandya --- arch/arm64/mm/mmu.c | 48 1 file

[PATCH v13 2/3] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable

Add an interface to invalidate intermediate page tables from TLB for kernel. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/tlbflush.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h index dfc61d7

[PATCH v13 1/3] ioremap: Update pgtable free interfaces with addr

From: Chintan Pandya The following kernel panic was observed on ARM64 platform due to a stale TLB entry. 1. ioremap with 4K size, a valid pte page table is set. 2. iounmap it, its pte entry is set to 0. 3. ioremap the same address with 2M size, update its pmd entry with a new value. 4

[PATCH v13 3/3] arm64: Implement page table free interfaces

and also free the leaking page tables. Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidation of TLB 3) Freeing of the un-used next level page tables Signed-off-by: Chintan Pandya --- arch/arm64/mm/mmu.c | 48 1 file

[PATCH v13 0/3] Fix issues with huge mapping in ioremap for ARM64

>From V2->V3: - Use the exisiting page table free interface to do arm64 specific things >From V1->V2: - Rebased my patches on top of "[PATCH v2 1/2] mm/vmalloc: Add interfaces to free unmapped page table" - Honored BBM for ARM64 Chintan Pandya (3): ioremap: Up

[PATCH v13 0/3] Fix issues with huge mapping in ioremap for ARM64

>From V2->V3: - Use the exisiting page table free interface to do arm64 specific things >From V1->V2: - Rebased my patches on top of "[PATCH v2 1/2] mm/vmalloc: Add interfaces to free unmapped page table" - Honored BBM for ARM64 Chintan Pandya (3): ioremap: Up

Re: [PATCH v12 3/5] arm64: pgtable: Add p*d_page_vaddr helper macros

On 6/4/2018 5:43 PM, Will Deacon wrote: On Fri, Jun 01, 2018 at 06:09:16PM +0530, Chintan Pandya wrote: Add helper macros to give virtual references to page tables. These will be used while freeing dangling page tables. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/pgtable.h

Re: [PATCH v12 3/5] arm64: pgtable: Add p*d_page_vaddr helper macros

On 6/4/2018 5:43 PM, Will Deacon wrote: On Fri, Jun 01, 2018 at 06:09:16PM +0530, Chintan Pandya wrote: Add helper macros to give virtual references to page tables. These will be used while freeing dangling page tables. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/pgtable.h

Re: [PATCH v12 5/5] arm64: Allow huge io mappings again

On 6/4/2018 5:44 PM, Will Deacon wrote: On Fri, Jun 01, 2018 at 06:09:18PM +0530, Chintan Pandya wrote: Huge mappings have had stability issues due to stale TLB entry and memory leak issues. Since, those are addressed in this series of patches, it is now safe to allow huge mappings. Signed

Re: [PATCH v12 5/5] arm64: Allow huge io mappings again

On 6/4/2018 5:44 PM, Will Deacon wrote: On Fri, Jun 01, 2018 at 06:09:18PM +0530, Chintan Pandya wrote: Huge mappings have had stability issues due to stale TLB entry and memory leak issues. Since, those are addressed in this series of patches, it is now safe to allow huge mappings. Signed

Re: [PATCH v12 4/5] arm64: Implement page table free interfaces

On 6/4/2018 5:43 PM, Will Deacon wrote: On Fri, Jun 01, 2018 at 06:09:17PM +0530, Chintan Pandya wrote: Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidate TLB which could have previously valid

Re: [PATCH v12 4/5] arm64: Implement page table free interfaces

On 6/4/2018 5:43 PM, Will Deacon wrote: On Fri, Jun 01, 2018 at 06:09:17PM +0530, Chintan Pandya wrote: Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidate TLB which could have previously valid

Re: [PATCH v12 0/5] Fix issues with huge mapping in ioremap for ARM64

positively. Thanks, On 6/1/2018 6:09 PM, Chintan Pandya wrote: This series of patches re-bring huge vmap back for arm64. Patch 1/4 has been taken by Toshi in his series of patches by name "[PATCH v3 0/3] fix free pmd/pte page handlings on x86" to avoid merge conflict with this series. The

Re: [PATCH v12 0/5] Fix issues with huge mapping in ioremap for ARM64

positively. Thanks, On 6/1/2018 6:09 PM, Chintan Pandya wrote: This series of patches re-bring huge vmap back for arm64. Patch 1/4 has been taken by Toshi in his series of patches by name "[PATCH v3 0/3] fix free pmd/pte page handlings on x86" to avoid merge conflict with this series. The

[PATCH v12 3/5] arm64: pgtable: Add p*d_page_vaddr helper macros

Add helper macros to give virtual references to page tables. These will be used while freeing dangling page tables. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/pgtable.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm

[PATCH v12 3/5] arm64: pgtable: Add p*d_page_vaddr helper macros

Add helper macros to give virtual references to page tables. These will be used while freeing dangling page tables. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/pgtable.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm

[PATCH v12 1/5] ioremap: Update pgtable free interfaces with addr

From: Chintan Pandya The following kernel panic was observed on ARM64 platform due to a stale TLB entry. 1. ioremap with 4K size, a valid pte page table is set. 2. iounmap it, its pte entry is set to 0. 3. ioremap the same address with 2M size, update its pmd entry with a new value. 4

[PATCH v12 2/5] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable

Add an interface to invalidate intermediate page tables from TLB for kernel. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/tlbflush.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h index dfc61d7

[PATCH v12 1/5] ioremap: Update pgtable free interfaces with addr

From: Chintan Pandya The following kernel panic was observed on ARM64 platform due to a stale TLB entry. 1. ioremap with 4K size, a valid pte page table is set. 2. iounmap it, its pte entry is set to 0. 3. ioremap the same address with 2M size, update its pmd entry with a new value. 4

[PATCH v12 2/5] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable

Add an interface to invalidate intermediate page tables from TLB for kernel. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/tlbflush.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h index dfc61d7

[PATCH v12 4/5] arm64: Implement page table free interfaces

Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidate TLB which could have previously valid but not stale entry 3) Freeing of the un-used next level page tables Signed-off-by: Chintan Pandya --- arch/arm64

[PATCH v12 0/5] Fix issues with huge mapping in ioremap for ARM64

void redundant TLB invalidatation in one perticular case >From V2->V3: - Use the exisiting page table free interface to do arm64 specific things >From V1->V2: - Rebased my patches on top of "[PATCH v2 1/2] mm/vmalloc: Add interfaces to free unmapped page table"

[PATCH v12 5/5] arm64: Allow huge io mappings again

Huge mappings have had stability issues due to stale TLB entry and memory leak issues. Since, those are addressed in this series of patches, it is now safe to allow huge mappings. Signed-off-by: Chintan Pandya --- arch/arm64/mm/mmu.c | 18 ++ 1 file changed, 2 insertions(+), 16

[PATCH v12 4/5] arm64: Implement page table free interfaces

Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidate TLB which could have previously valid but not stale entry 3) Freeing of the un-used next level page tables Signed-off-by: Chintan Pandya --- arch/arm64

[PATCH v12 0/5] Fix issues with huge mapping in ioremap for ARM64

void redundant TLB invalidatation in one perticular case >From V2->V3: - Use the exisiting page table free interface to do arm64 specific things >From V1->V2: - Rebased my patches on top of "[PATCH v2 1/2] mm/vmalloc: Add interfaces to free unmapped page table"

[PATCH v12 5/5] arm64: Allow huge io mappings again

Huge mappings have had stability issues due to stale TLB entry and memory leak issues. Since, those are addressed in this series of patches, it is now safe to allow huge mappings. Signed-off-by: Chintan Pandya --- arch/arm64/mm/mmu.c | 18 ++ 1 file changed, 2 insertions(+), 16

[PATCH v11 3/4] arm64: Implement page table free interfaces

Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidate TLB which could have previously valid but not stale entry 3) Freeing of the un-used next level page tables Signed-off-by: Chintan Pandya <c

[PATCH v11 3/4] arm64: Implement page table free interfaces

Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidate TLB which could have previously valid but not stale entry 3) Freeing of the un-used next level page tables Signed-off-by: Chintan Pandya --- arch/arm64

[PATCH v11 2/4] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable

Add an interface to invalidate intermediate page tables from TLB for kernel. Signed-off-by: Chintan Pandya <cpan...@codeaurora.org> --- arch/arm64/include/asm/tlbflush.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/inclu

[PATCH v11 1/4] ioremap: Update pgtable free interfaces with addr

From: Chintan Pandya <cpan...@codeaurora.org> The following kernel panic was observed on ARM64 platform due to a stale TLB entry. 1. ioremap with 4K size, a valid pte page table is set. 2. iounmap it, its pte entry is set to 0. 3. ioremap the same address with 2M size, update its pmd

[PATCH v11 2/4] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable

Add an interface to invalidate intermediate page tables from TLB for kernel. Signed-off-by: Chintan Pandya --- arch/arm64/include/asm/tlbflush.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h index dfc61d7

[PATCH v11 1/4] ioremap: Update pgtable free interfaces with addr

From: Chintan Pandya The following kernel panic was observed on ARM64 platform due to a stale TLB entry. 1. ioremap with 4K size, a valid pte page table is set. 2. iounmap it, its pte entry is set to 0. 3. ioremap the same address with 2M size, update its pmd entry with a new value. 4

[PATCH v11 4/4] Revert "arm64: Enforce BBM for huge IO/VMAP mappings"

This commit 15122ee2c515a ("arm64: Enforce BBM for huge IO/VMAP mappings") is a temporary work-around until the issues with CONFIG_HAVE_ARCH_HUGE_VMAP gets fixed. Revert this change as we have fixes for the issue. Signed-off-by: Chintan Pandya <cpan...@codeaurora.org> --- arc

[PATCH v11 4/4] Revert "arm64: Enforce BBM for huge IO/VMAP mappings"

This commit 15122ee2c515a ("arm64: Enforce BBM for huge IO/VMAP mappings") is a temporary work-around until the issues with CONFIG_HAVE_ARCH_HUGE_VMAP gets fixed. Revert this change as we have fixes for the issue. Signed-off-by: Chintan Pandya --- arch/arm64/mm/mmu.c | 8 --

[PATCH v11 0/4] Fix issues with huge mapping in ioremap for ARM64

rom V2->V3: - Use the exisiting page table free interface to do arm64 specific things >From V1->V2: - Rebased my patches on top of "[PATCH v2 1/2] mm/vmalloc: Add interfaces to free unmapped page table" - Honored BBM for ARM64 Chintan Pandya (4): ioremap: Update p

[PATCH v11 0/4] Fix issues with huge mapping in ioremap for ARM64

rom V2->V3: - Use the exisiting page table free interface to do arm64 specific things >From V1->V2: - Rebased my patches on top of "[PATCH v2 1/2] mm/vmalloc: Add interfaces to free unmapped page table" - Honored BBM for ARM64 Chintan Pandya (4): ioremap: Update p

Re: [PATCH v10 3/4] arm64: Implement page table free interfaces

On 5/24/2018 7:27 PM, Chintan Pandya wrote: Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidate TLB which could have previously valid but not stale entry 3) Freeing of the un-used next level page

Re: [PATCH v10 3/4] arm64: Implement page table free interfaces

On 5/24/2018 7:27 PM, Chintan Pandya wrote: Implement pud_free_pmd_page() and pmd_free_pte_page(). Implementation requires, 1) Clearing off the current pud/pmd entry 2) Invalidate TLB which could have previously valid but not stale entry 3) Freeing of the un-used next level page

[PATCH v10 4/4] Revert "arm64: Enforce BBM for huge IO/VMAP mappings"

This commit 15122ee2c515a ("arm64: Enforce BBM for huge IO/VMAP mappings") is a temporary work-around until the issues with CONFIG_HAVE_ARCH_HUGE_VMAP gets fixed. Revert this change as we have fixes for the issue. Signed-off-by: Chintan Pandya <cpan...@codeaurora.org> --- arc

[PATCH v10 4/4] Revert "arm64: Enforce BBM for huge IO/VMAP mappings"

This commit 15122ee2c515a ("arm64: Enforce BBM for huge IO/VMAP mappings") is a temporary work-around until the issues with CONFIG_HAVE_ARCH_HUGE_VMAP gets fixed. Revert this change as we have fixes for the issue. Signed-off-by: Chintan Pandya --- arch/arm64/mm/mmu.c | 8 --

[PATCH v10 1/4] ioremap: Update pgtable free interfaces with addr

From: Chintan Pandya <cpan...@codeaurora.org> The following kernel panic was observed on ARM64 platform due to a stale TLB entry. 1. ioremap with 4K size, a valid pte page table is set. 2. iounmap it, its pte entry is set to 0. 3. ioremap the same address with 2M size, update its pmd

  1   2   3   4   >