re value for the non-volatile register.
When amp is internally shutdown by some reason, next 'AMP ON'
command can be ignored because regmap think amp is already ON.
Signed-off-by: Ryan Lee
---
sound/soc/codecs/max98373-i2c.c | 1 +
sound/soc/codecs/max98373-sdw.c | 1 +
2 files changed,
rature recovers from
thermal shutdown.
"CMON Autorestart Switch" : controls whether or not the device
automatically resumes playback when the clock returns after stopping.
Above Auto Restart functions are enabled by default.
Signed-off-by: Ryan Lee
---
sound/soc/codecs/max98373.c | 14 ++
Amp requires 10 ~ 30ms for the power ON and OFF.
Added 30ms delay for stability.
Signed-off-by: Ryan Lee
---
sound/soc/codecs/max98373.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c
index 746c829312b8..1346a98ce8a1 100644
--- a
This is the same ioctl the rest of the watchdogs support. GETTIMELEFT
returns the number of seconds in the countdown -- useful for testing
whether the watchdog is functioning.
Signed-off-by: Ryan O'Leary
---
drivers/char/ipmi/ipmi_watchdog.c | 75 +++
1 file ch
> -Original Message-
> From: Andrew Jeffery
> Sent: Monday, January 25, 2021 8:47 AM
> To: Ryan Chen ; Samuel Holland
> ; Stephen Boyd ; Joel Stanley
>
> Cc: BMC-SW ; linux-aspeed
> ; Michael Turquette
> ; Linux Kernel Mailing List
> ; linux-...@vger.kern
Hello,
How about this patch progress?
It does impact a lot of machine that when BMC boot at u-boot.
SUART is work for Host. But after boot into kernel, due to the clk
disabled.
The SUART is not work for Host anymore.
Regards,
Ryan
> -Original Mess
> -Original Message-
> From: Andrew Jeffery
> Sent: Wednesday, January 20, 2021 1:16 PM
> To: Troy Lee ; open...@lists.ozlabs.org; Joel
> Stanley ; Philipp Zabel ; open list
> ; moderated list:ARM/ASPEED MACHINE
> SUPPORT ; moderated
> list:ARM/ASPEED MACHINE
Starting from A2, the A-PLL calculation has changed. Use the
existing formula for A0/A1 and the new formula for A2 onwards.
Fixes: d3d04f6c330a ("clk: Add support for AST2600 SoC")
Signed-off-by: Ryan Chen
---
drivers/clk/clk-ast2600.c | 37 +++--
1 fi
> -Original Message-
> From: Joel Stanley
> Sent: Tuesday, January 19, 2021 11:10 AM
> To: Ryan Chen
> Cc: Joel Stanley ; Michael Turquette
> ; Stephen Boyd ;
> linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> andre...@au1.ibm.com; BMC-SW ; Andrew
> -Original Message-
> From: Joel Stanley
> Sent: Tuesday, January 19, 2021 10:20 AM
> To: Ryan Chen ; Michael Turquette
> ; Stephen Boyd ;
> linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> andre...@au1.ibm.com; BMC-SW
> Cc: j...@jms.id.au; Andre
AST2600A1/A2 have different pll calculate formula.
Signed-off-by: Ryan Chen
---
drivers/clk/clk-ast2600.c | 37 +++--
1 file changed, 27 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/clk-ast2600.c b/drivers/clk/clk-ast2600.c
index bbacaccad554
AST2600 A1/A2 have different pll, this patch fix for AST2600 A2
APLL calculate.
Ryan Chen (1):
clk: aspeed: Fix APLL calculate formula for ast2600-A2
drivers/clk/clk-ast2600.c | 37 +++--
1 file changed, 27 insertions(+), 10 deletions(-)
--
2.17.1
> -Original Message-
> From: Arnd Bergmann
> Sent: Saturday, January 16, 2021 1:05 AM
> To: Ryan Chen
> Cc: John Wang ;
> xuxiao...@bytedance.com; yulei...@bytedance.com; Robert Lippert
> ; moderated list:ARM/ASPEED MACHINE SUPPORT
> ; Greg Kroah-Hartman
> ;
On Wed, Jan 6, 2021 at 12:49 AM Arnd Bergmann wrote:
>
> On Wed, Jan 6, 2021 at 7:48 AM wrote:
> > From: Ryan Houdek
> ...
> > This does not solve the following problems:
> > 1) compat_alloc_user_space inside ioctl
> > 2) ioctls that check task mode instead o
This patch fixes vhub engine stop dma should have different register
setting.
Ryan Chen (1):
usb: gadget: aspeed: fix stop dma register setting.
drivers/usb/gadget/udc/aspeed-vhub/epn.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.17.1
The vhub engine has two dma mode, one is descriptor list, another
is single stage DMA. Each mode has different stop register setting.
Descriptor list operation (bit2) : 0 disable reset, 1: enable reset
Single mode operation (bit0) : 0 : disable, 1: enable
Signed-off-by: Ryan Chen
---
drivers
and electrical specification of SPI but runs
> > completely
> different protocol.
> > Only the flash channel is related to SPI and the other 3 channels are for
> EC/BMC/SIO.
> > Therefore, an eSPI driver might not fit into the SPI model.
>
> I agree, the naming is confusing but eSPI doesn't belong in drivers/spi.
>
> As it is a bus that is common to more than just the Aspeed BMC, we may want
> to implement it as a new bus type that has devices hanging off it, similar to
> FSI.
>
The ASPEED eSPI controller driver is slave side device, not master side. I
think it will be stay soc/aspeed first.
Because is most SoC Chip related.
Cheers,
Ryan
Hello John, Joel, Jae,
For this should be set LCLK to be CRITICAL it will fix LPC related
driver. (KCS/BT/SNOOP)
I have send the patch before.
https://patchwork.ozlabs.org/project/linux-aspeed/patch/20200928070108.14040-2-ryan_c...@aspeedtech.com/
Hello Joel,
W
> -Original Message-
> From: Zev Weiss
> Sent: Wednesday, December 23, 2020 11:54 AM
> To: Ryan Chen
> Cc: Joel Stanley ; Eddie James ;
> Mauro Carvalho Chehab ; Andrew Jeffery
> ; linux-me...@vger.kernel.org; OpenBMC Maillist
> ; Linux ARM
> ; linux-aspeed
&g
> -Original Message-
> From: Joel Stanley
> Sent: Wednesday, December 23, 2020 9:07 AM
> To: Zev Weiss ; Ryan Chen
>
> Cc: Eddie James ; Mauro Carvalho Chehab
> ; Andrew Jeffery ;
> linux-me...@vger.kernel.org; OpenBMC Maillist ;
> Linux ARM ; linux-aspeed
&g
> -Original Message-
> From: Andrew Jeffery
> Sent: Thursday, October 22, 2020 7:45 AM
> To: Ryan Chen ; Sergei Shtylyov
> ; Joel Stanley ;
> linux-arm-ker...@lists.infradead.org; linux-asp...@lists.ozlabs.org;
> linux-kernel@vger.kernel.org; linux-...@vger.kernel
> -Original Message-
> From: Joel Stanley
> Sent: Wednesday, October 14, 2020 1:28 PM
> To: Stephen Boyd
> Cc: Andrew Jeffery ; Michael Turquette
> ; Ryan Chen ;
> BMC-SW ; Linux ARM
> ; linux-aspeed
> ; linux-...@vger.kernel.org; Linux Kernel
> Mailing L
Hello Segei,
> -Original Message-
> From: Sergei Shtylyov
> Sent: Friday, October 9, 2020 4:23 PM
> To: Ryan Chen ; Joel Stanley ;
> Andrew Jeffery ; linux-arm-ker...@lists.infradead.org;
> linux-asp...@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> linux-...@vg
Signed-off-by: Ryan Kosta
---
arch/riscv/kernel/ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/ftrace.c b/arch/riscv/kernel/ftrace.c
index 99e12faa549..765b62434f3 100644
--- a/arch/riscv/kernel/ftrace.c
+++ b/arch/riscv/kernel/ftrace.c
@@ -1,4
> -Original Message-
> From: Joel Stanley
> Sent: Friday, October 9, 2020 12:55 PM
> To: Greg KH
> Cc: Ryan Chen ; Andrew Jeffery
> ; Linux ARM ;
> linux-aspeed ; Linux Kernel Mailing List
> ; linux-...@vger.kernel.org; BMC-SW
> ; Alan Stern
> Subject: Re:
> -Original Message-
> From: Greg KH
> Sent: Friday, October 9, 2020 1:47 PM
> To: Joel Stanley
> Cc: Ryan Chen ; Andrew Jeffery
> ; Linux ARM ;
> linux-aspeed ; Linux Kernel Mailing List
> ; linux-...@vger.kernel.org; BMC-SW
> ; Alan Stern
> Subject: Re:
v2:
- Fix continuation lines, align with "of_device"
v1:
- Add support for AST2600 SOC UHCI driver.
Signed-off-by: Ryan Chen
---
drivers/usb/host/uhci-platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb
v2:
-[1/3]: Add SCSI,BLK_DEV_SD,USB_STORAGE in defconfig.
-[2/3]: Fix continuation lines.
v1:
-The patches enable UHCI driver in AST2600 and also
enable USB host in aspeed-ast2600-evb.dts.
Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible
Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
Signed-off-by: Ryan Chen
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
index 89be13197780
v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.
Signed-off-by: Ryan Chen
---
arch/arm/configs/aspeed_g5_defconfig | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/configs/aspeed_g5_defconfig
b/arch/arm/configs
> -Original Message-
> From: Joel Stanley
> Sent: Wednesday, October 7, 2020 7:34 PM
> To: Ryan Chen
> Cc: Jae Hyun Yoo ; Andrew Jeffery
> ; Michael Turquette ; Stephen
> Boyd ; linux-...@vger.kernel.org; Linux ARM
> ; linux-aspeed
> ; Linux Kernel Mailing Lis
Hello Joel,
Have you take time review this patches ?
Ryan Chen
Tel : 886-3-5751185 ext:8857
> -Original Message-
> From: Ryan Chen
> Sent: Wednesday, September 30, 2020 12:08 PM
> To: Joel Stanley ; Andrew Jeffery ;
> linux-arm-ker...@lists.infradead
> -Original Message-
> From: Andrew Jeffery
> Sent: Thursday, October 1, 2020 8:32 AM
> To: Billy Tsai ; Rob Herring ;
> Joel Stanley ; devicet...@vger.kernel.org;
> linux-arm-ker...@lists.infradead.org; linux-asp...@lists.ozlabs.org;
> linux-kernel@vger.kernel.org;
Add support for AST2600 SOC UHCI driver.
Signed-off-by: Ryan Chen
---
drivers/usb/host/uhci-platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
index 70dbd95c3f06..fa40fe125c2a 100644
--- a/drivers
The patches enable UHCI driver in AST2600 and also enable
USB host in aspeed-ast2600-evb.dts.
Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts
arch/arm/boot/dts/aspeed-ast2600
Enable UHCI driver in aspeed_g5_defconfig.
Signed-off-by: Ryan Chen
---
arch/arm/configs/aspeed_g5_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/aspeed_g5_defconfig
b/arch/arm/configs/aspeed_g5_defconfig
index 2bacd8c90f4b..a57009d1a3b8 100644
--- a/arch/arm
Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
Signed-off-by: Ryan Chen
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
index 89be13197780
> From: Joel Stanley
> Sent: Tuesday, September 29, 2020 4:04 PM
> To: Ryan Chen ; Jae Hyun Yoo
> ; Andrew Jeffery
> Cc: Michael Turquette ; Stephen Boyd
> ; linux-...@vger.kernel.org; Linux ARM
> ; linux-aspeed
> ; Linux Kernel Mailing List
> ; BMC-SW
> Subjec
Hello Joel & Andrew,
Those patches are more organize for ASPEED SOC LPC register layout.
Does those patches have any feedback?
Ryan
> -Original Message-
> From: ChiaWei Wang
> Sent: Friday, September 11, 2020 4:21 PM
> To: Andrew Jeffery ; Jo
This patch is modify for ASPEED SoC some default clks can't disable
need keep default clk on.
Ryan Chen (1):
clk: aspeed: modify some default clks are critical
drivers/clk/clk-aspeed.c | 8
drivers/clk/clk-ast2600.c | 8
2 files changed, 8 insertions(+), 8 dele
ff-by: Ryan Chen
---
drivers/clk/clk-aspeed.c | 8
drivers/clk/clk-ast2600.c | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c
index 411ff5fb2c07..d348c4fd3f9f 100644
--- a/drivers/clk/clk-aspeed.c
+++ b/driver
Fix a comment typo.
Signed-off-by: Ryan Kosta
---
V3: Fix commit name
drivers/staging/nvec/nvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec040774..a80996b2f5c 100644
--- a/drivers/staging/nvec/nvec.c
Changes since v1:
* Made commit message more clear
* Added description
Note: previous patch named
"[PATCH] fix double next comment in drivers/staging/nvec/nvec.c"
>8--8<
Fixes a comment typo.
Signed-off-by: Ryan Kosta
---
Signed-off-by: Ryan Kosta
---
drivers/staging/nvec/nvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec040774..a80996b2f5c 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
div from clock source apll/4. Should not set for
apll from fsi-master driver.
> -Original Message-
> From: Joel Stanley
> Sent: Friday, September 11, 2020 9:30 AM
> To: Eddie James ; Ryan Chen
> ; Billy Tsai
> Cc: linux-...@vger.kernel.org; Linux Kernel Mailing L
; Rob Herring ;
> linux-...@vger.kernel.org; linux-in...@vger.kernel.org; Ryan Chen
>
> Subject: Re: [PATCH 3/5] i2c: aspeed: Mask IRQ status to relevant bits
>
> On Tue, Aug 25, 2020 at 02:47:51PM -0500, Eddie James wrote:
> >
> > On 8/25/20 1:38 AM, Joel Stanley wrote:
>
Check was incorrectly being applied to size of elf phdrs, instead
of the number. The ELF standard allows for up to 65535 headers, but
the check was being compared to the number of headers multiplied by
the size of a program header.
---
fs/binfmt_elf.c | 6 +++---
1 file changed, 3 insertions(+), 3
> -Original Message-
> From: Matthew Wilcox
> Sent: Tuesday, August 11, 2020 11:05 AM
> To: Burrow, Ryan - 0553 - MITLL
> Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] Bug fix to ELF Loader which rejects valid ELFs
>
> On
Check was incorrectly being applied to size of elf phdrs, instead
of the number. The ELF standard allows for up to 65535 headers, but
the check was being compared to the number of headers multiplied by
the size of a program header.
---
fs/binfmt_elf.c | 6 +++---
1 file changed, 3 insertions(+),
r at
> i2c ISR.
>
> Signed-off-by: ryan_chen
>Applied to for-current with a Fixes tag, thanks! Please, try to add one next
>time and please also check how the subsystem formats the $subject line.
[Ryan Chen] Thanks your review, will add fixes tag at subject.
> > And is there maybe a Fixes: tag for it?
> > [Ryan Chen] Yes it is a fix patch.
>
> I meant this (from submitting-patches.rst):
>It fixes the original implementation of the driver basically. It's just a
>classic posted-write fix. The write to clear the pending in
-Original Message-
From: Wolfram Sang [mailto:w...@the-dreams.de]
Sent: Wednesday, April 29, 2020 3:54 PM
To: Ryan Chen
Cc: Brendan Higgins ; Benjamin Herrenschmidt
; Joel Stanley ; Andrew Jeffery
; linux-...@vger.kernel.org; open...@lists.ozlabs.org;
linux-arm-ker
l_ops bcmgenet_ethtool_ops() as get_ts_info(), the
SOF_TIMESTAMPING_TX_SOFTWARE capability is announced.
Similar to commit a8f5cb9e7991 ("smsc95xx: use ethtool_op_get_ts_info()")
Signed-off-by: Ryan M. Collins
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 1 +
1 file changed, 1 insertion(+
On Fri, Jul 5, 2019 at 3:10 PM Alan Stern wrote:
>
> On Thu, 4 Jul 2019, Ryan Kennedy wrote:
>
> > usb_amd_find_chipset_info() is used for chipset detection for
> > several quirks. It is strange that its return value indicates
> > the need for the PLL quirk, whic
On Fri, Jul 5, 2019 at 1:22 AM Greg KH wrote:
>
> On Thu, Jul 04, 2019 at 11:35:28AM -0400, Ryan Kennedy wrote:
> > The AMD PLL USB quirk is incorrectly enabled on newer Ryzen
> > chipsets. The logic in usb_amd_find_chipset_info currently checks
> > for unaffected chips
probe_result to
something more appropriate.
Signed-off-by: Ryan Kennedy
---
drivers/usb/host/ehci-pci.c | 4 ++--
drivers/usb/host/ohci-pci.c | 2 +-
drivers/usb/host/pci-quirks.c | 30 --
drivers/usb/host/pci-quirks.h | 2 +-
drivers/usb/host/xhci-pci.c | 2
to be updated as new
chipsets are added. Note that the core of the workaround in
usb_amd_quirk_pll does correctly check the chipset.
Signed-off-by: Ryan Kennedy
---
drivers/usb/host/pci-quirks.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/dr
This series contains a minor fix for the AMD PLL USB quirk plus
some clean up to the related code.
Ryan Kennedy (2):
usb: pci-quirks: Correct AMD PLL quirk detection
usb: pci-quirks: Minor cleanup for AMD PLL quirk
drivers/usb/host/ehci-pci.c | 4 ++--
drivers/usb/host/ohci-pci.c | 2
Hello Tao,
Let me more clear. When you set (3, 15, 14) the device sometimes
response nack.
but when you set (4, 7, 7), the device always ack. Am I right?
Ryan
-Original Message-
From: Tao Ren [mailto:tao...@fb.com]
Sent: Thursday, June 20, 2019 3:57 PM
To: Ryan Chen
Hello Tao,
Our recommend about clk divider setting is follow the datasheet clock
setting table for clock divisor.
Ryan
-Original Message-
From: Linux-aspeed
[mailto:linux-aspeed-bounces+ryan_chen=aspeedtech@lists.ozlabs.org] On
Behalf Of Tao Ren
Sent
Hi Henry,
On Tue, Apr 30, 2019 at 2:45 AM Henry Chen wrote:
>
> Add dvfsrc driver for MT8183
>
> Signed-off-by: Henry Chen
> ---
> drivers/soc/mediatek/Kconfig | 15 ++
> drivers/soc/mediatek/Makefile | 1 +
> drivers/soc/mediatek/mtk-dvfsrc.c | 347
> ++
Jagan,
The compatible is for the real hardware name as Maxime previously explained.
The platform is described in the latter part.
Please use:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
Thanks,
Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd
-
uot;, "allwinner,sun50i-a64";
Perhaps this solves the issue. Please let me know thoughts.
Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd
-Original Message-
From: Jagan Teki
Sent: 05 March 2019 16:08
To: Maxime Ripard
Cc: Chen-Yu Tsai ; Rob Herring ; Mark
Ru
Use u32 rather than unsigned long for register variables for clarity and
consistency.
Signed-off-by: Ryan Case
Reviewed-by: Stephen Boyd
Reviewed-by: Evan Green
---
Changes in v2:
- Updated commit message
- Updated missed rxstale variable
drivers/tty/serial/qcom_geni_serial.c | 24
The variables of tx_wm and rx_wm were set to the same define value in
all cases, never updated, and the define was sometimes used
interchangably. Remove the variables/function and use the fixed value.
Signed-off-by: Ryan Case
Reviewed-by: Evan Green
---
Changes in v2:
- Removed CONSOLE from
A frequent side comment has been to remove the use of writel_relaxed,
readl_relaxed, and mb. This reduces driver complexity and the _relaxed
variants were not known to provide any noticeable performance benefit.
Signed-off-by: Ryan Case
Reviewed-by: Evan Green
---
Changes in v2:
- Expanded
The driver only supports FIFO mode so setting and checking this variable
is unnecessary. If DMA support is ever added then such checks can be
introduced.
Signed-off-by: Ryan Case
Reviewed-by: Evan Green
---
Changes in v2:
- Fixed commit message typo
- Coalesced lines where possible
drivers
This is a series of cleanups for issues raised in prior reviews that
were unrelated to the patches at hand.
Changes in v2:
- Updated commit messages
- Removed CONSOLE from UART_CONSOLE_RX_WM
- Coalesced lines where possible
- Updated missed rxstale variable
Ryan Case (4):
tty: serial
Signed-off-by: Ryan Case
---
drivers/tty/serial/qcom_geni_serial.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c
b/drivers/tty/serial/qcom_geni_serial.c
index 3103aa0adc86..fa67a2ced420 100644
--- a/drivers
The driver only supports FIFO mode so setting and checking this variable
is unnecessary. If DMA support is ever addedd then such checks can be
introduced.
Signed-off-by: Ryan Case
---
drivers/tty/serial/qcom_geni_serial.c | 66 ++-
1 file changed, 24 insertions(+), 42
The variables of tx_wm and rx_wm were set to the same define value in
all cases, never updated, and the define was sometimes used
interchangably. Remove the variables/function and use the fixed value.
Signed-off-by: Ryan Case
---
drivers/tty/serial/qcom_geni_serial.c | 23
This is a series of cleanups for issues raised in prior reviews that
were unrelated to the patches at hand.
Ryan Case (4):
tty: serial: qcom_geni_serial: Remove use of *_relaxed() and mb()
tty: serial: qcom_geni_serial: Remove set_rfr_wm() and related
variables
tty: serial
A frequent side comment has been to remove the use of writel_relaxed,
readl_relaxed, and mb.
Signed-off-by: Ryan Case
---
drivers/tty/serial/qcom_geni_serial.c | 187 +++---
1 file changed, 80 insertions(+), 107 deletions(-)
diff --git a/drivers/tty/serial
interrupts.
Signed-off-by: Ryan Case
---
drivers/tty/serial/qcom_geni_serial.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/tty/serial/qcom_geni_serial.c
b/drivers/tty/serial/qcom_geni_serial.c
index 0c93beb69e73..a694a47747c7 100644
--- a/drivers/tty/serial
lcke
>
> Oh nice, so this did end up being your problem with corrupt
> characters? Strange though, I still would have expected this bug to
> result in inserted serial characters, rather than edited ones.
> Either way, this looks good to me.
>
> Reviewed-by: Evan Green
UART bluetooth firmware downloads consistently working for me again.
Tested-by: Ryan Case
interrupt after filling the FIFO so we do not
receive notification again prior to actually having free space.
Signed-off-by: Ryan Case
---
Changes in v2:
Addressed Doug's comments
- Avoid M_TX_WATERMARK_EN writes when values already match
- Added note about M_TX_WATERMARK_EN triggering and lat
interrupt after filling the FIFO so we do not
receive notification again prior to actually having free space.
Signed-off-by: Ryan Case
---
drivers/tty/serial/qcom_geni_serial.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/qcom_geni_s
means
software reset is completed well.
Additional 10ms delay was added for every retrial and maximum 30ms delay can be
applied.
Signed-off-by: Ryan Lee
---
Changes since v2:
- Added commit message.
Changes since v1:
- Removed unusual repeat for amp software reset and verification.
- Amp software
>-Original Message-
>From: Mark Brown
>Sent: Thursday, November 29, 2018 3:26 AM
>To: Grant Grundler
>Cc: Ryan Lee ; Liam Girdwood
>; pe...@perex.cz; ti...@suse.com; Kuninori
>Morimoto ; Benson Leung
>; alsa-de...@alsa-project.org; LKML ker...@vger.kernel.org>
>-Original Message-
>From: Grant Grundler
>Sent: Wednesday, November 28, 2018 5:56 PM
>To: Ryan Lee
>Cc: broo...@kernel.org; Liam Girdwood ;
>pe...@perex.cz; ti...@suse.com; Grant Grundler
>; Kuninori Morimoto
>; Benson Leung
>; alsa-de...@alsa-project.org;
softlocks on large transmissions.
This patch allows larger transfers with continuous FIFO additions as
space becomes available and removes polling from the interrupt handler.
Signed-off-by: Ryan Case
---
Changes in v3:
- Reworded comment for clarity
- Fixed mips compiler warning
Changes in v2
On Thu, Nov 29, 2018 at 2:12 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Nov 28, 2018 at 3:55 PM Ryan Case wrote:
> > @@ -465,9 +470,19 @@ static void qcom_geni_serial_console_write(struct
> > console *co, const char *s,
> > }
> >
softlocks on large transmissions.
This patch allows larger transfers with continuous FIFO additions as
space becomes available and removes polling from the interrupt handler.
Signed-off-by: Ryan Case
---
Changes in v2:
- Addressed nits raised by Stephen
drivers/tty/serial/qcom_geni_serial.c | 56
>-Original Message-
>From: Mark Brown
>Sent: Wednesday, November 28, 2018 1:50 AM
>To: Ryan Lee
>Cc: Liam Girdwood ; Jaroslav Kysela
>; Takashi Iwai ; Grant Grundler
>; Kuninori Morimoto
>; Benson Leung
>; alsa-de...@alsa-project.org; linux-
>ker..
Signed-off-by: Ryan Lee
---
Changes since v1 : Removed unusual repeat for amp software reset and
verification.
Amp software reset will be performed once and it repeats
verification maximum 3 times if it is failed.
Wait 10ms before every verification trial
On Tue, Nov 27, 2018 at 6:04 PM Stephen Boyd wrote:
>
> Quoting Ryan Case (2018-11-27 17:24:44)
> > On Tue, Nov 27, 2018 at 4:20 PM Stephen Boyd wrote:
> > >
> > > Quoting Ryan Case (2018-11-26 18:25:36)
> > > > Transfers were being divided into device F
On Tue, Nov 27, 2018 at 4:20 PM Stephen Boyd wrote:
>
> Quoting Ryan Case (2018-11-26 18:25:36)
> > Transfers were being divided into device FIFO sized (64 byte max)
> > operations which would poll for completion within a spin_lock_irqsave /
> > spin_unlock_irqrestore bloc
>-Original Message-
>From: Mark Brown
>Sent: Tuesday, November 27, 2018 3:51 AM
>To: Ryan Lee
>Cc: Liam Girdwood ; Jaroslav Kysela
>; Takashi Iwai ; Grant Grundler
>; Kuninori Morimoto
>; Benson Leung
>; alsa-de...@alsa-project.org; linux-
>ker...@vger.k
Grant,
Thanks for your feedback. Please find my answers inline.
>-Original Message-
>From: Grant Grundler
>Sent: Monday, November 26, 2018 6:25 PM
>To: Ryan Lee
>Cc: Liam Girdwood ; broo...@kernel.org;
>pe...@perex.cz; ti...@suse.com; Grant Grundler
>; Kuninori Mor
>-Original Message-
>From: Grant Grundler
>Sent: Monday, November 26, 2018 6:28 PM
>To: Grant Grundler
>Cc: Ryan Lee ; Liam Girdwood
>; broo...@kernel.org; pe...@perex.cz;
>ti...@suse.com; Kuninori Morimoto ;
>Benson Leung ; alsa-de...@alsa-project.org; LKML
>
softlocks on large transmissions.
This patch allows larger transfers with continuous FIFO additions as
space becomes available and removes polling from the interrupt handler.
Signed-off-by: Ryan Case
Version: 1
---
drivers/tty/serial/qcom_geni_serial.c | 58 ++-
1 file changed
Signed-off-by: Ryan Lee
---
Changes : Created max98373_reset function to minimize code duplication.
Changed regmap_write to regmap_update_bits. Other bits except LSB
need to be masked.
Added reset verification step to make sure software reset is
completed well. Software
Address remaining comments from original driver patch series
* Move RD_FIFO_CFG to be ordered corretly
* Expand spinlock comment
Signed-off-by: Ryan Case
---
drivers/spi/spi-qcom-qspi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-qcom-qspi.c b
Signed-off-by: Ryan Lee
---
Changes : Sort 'max98373_bde_gain_tlv' in reverse order.
Fixed wrong use case of 'TLV_DB_SCALE_ITEM' - TLV_DB_SCALE_ITEM(min,
step, mute)
Max value was set in min field and negative value was set in
step field before
Signed-off-by: Ryan Lee
---
Changes : Sort 'max98373_dht_spkgain_min_tlv' in reverse order.
Fixed wrong use case of 'TLV_DB_SCALE_ITEM' - TLV_DB_SCALE_ITEM(min,
step, mute)
Max value was set in min field and negative value was set in
step field
Signed-off-by: Ryan Lee
---
Changes : Sort 'max98373_limiter_thresh_tlv' in reverse order.
Fixed wrong use case of 'TLV_DB_SCALE_ITEM' - TLV_DB_SCALE_ITEM(min,
step, mute)
Max value was set in min field and negative value was set in
step field
Signed-off-by: Ryan Lee
---
Changes : Sort 'max98373_digital_tlv' in reverse order.
Fixed wrong use case of 'TLV_DB_SCALE_ITEM' - TLV_DB_SCALE_ITEM(min,
step, mute)
Max value was set in min field and negative value was set in
step field before
.
Signed-off-by: Girish Mahadevan
Signed-off-by: Ryan Case
---
Changes in v6:
- Fixed IRQ error logging accessibility
- Minor cleanup suggested by Doug
Changes in v5:
- Fixed tabbing/spacing errors in defines
Changes in v4:
- Set bus_num to -1
- Alphabetized Makefile entry
- Grouped register and
From: Girish Mahadevan
Bindings for Qualcomm Quad SPI used on SoCs such as sdm845.
Signed-off-by: Girish Mahadevan
Signed-off-by: Ryan Case
Reviewed-by: Douglas Anderson
Reviewed-by: Rob Herring
Reviewed-by: Stephen Boyd
---
Changes in v6:
- None
Changes in v5:
- None
Changes in v4
.
Signed-off-by: Girish Mahadevan
Signed-off-by: Ryan Case
Fixed tabbing/spacing in defines
---
Changes in v5:
- Fixed tabbing/spacing errors in defines
Changes in v4:
- Set bus_num to -1
- Alphabetized Makefile entry
- Grouped register and associated flag defines
- Read and write transfers now use
1 - 100 of 492 matches
Mail list logo
