Re: [PATCH] dt-bindings: nvmem: Add YAML schemas for the generic NVMEM bindings

2019-06-27 Thread Srinivas Kandagatla
Hi Rob, On 27/06/2019 14:55, Rob Herring wrote: But you didn't update the license to (GPL-2.0 OR BSD-2-Clause). See below. I did forward what Maxime has sent me. Maxime, are you okay if I do that changes to this patch and resend? --srini

[PATCH] dt-bindings: nvmem: Add YAML schemas for the generic NVMEM bindings

2019-06-27 Thread Srinivas Kandagatla
From: Maxime Ripard The nvmem providers and consumers have a bunch of generic properties that are needed in a device tree. Add a YAML schemas for those. Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard Signed-off-by: Srinivas Kandagatla --- Hi Greg, Sorry for the delay in sending

[PATCH 3/6] nvmem: imx-ocotp: Change TIMING calculation to u-boot algorithm

2019-06-26 Thread Srinivas Kandagatla
-by: Bryan O'Donoghue Suggested-by: Leonard Crestez Reviewed-by: Leonard Crestez Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/i

[PATCH 2/6] nvmem: imx-ocotp: Ensure WAIT bits are preserved when setting timing

2019-06-26 Thread Srinivas Kandagatla
riods." This patch ensures that the relevant field is read and written back to the timing register. Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support") Signed-off-by: Bryan O'Donoghue Reviewed-by: Leonard Crestez Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-oco

[PATCH 4/6] nvmem: imx-ocotp: Add i.MX8MM support

2019-06-26 Thread Srinivas Kandagatla
address space encompasses up to 256 registers. We map the entire putative 256 OTP registers. Signed-off-by: Bryan O'Donoghue Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c

[PATCH 0/6] nvmem: patches for 5.3 set 2

2019-06-26 Thread Srinivas Kandagatla
Hi Greg, Here are imx-ocotp patches which I missed in last set. Can you please pick them up if its not too late. Thanks, srini Bryan O'Donoghue (5): nvmem: imx-ocotp: Elongate OCOTP_CTRL ADDR field to eight bits nvmem: imx-ocotp: Ensure WAIT bits are preserved when setting timing nvmem:

[PATCH 1/6] nvmem: imx-ocotp: Elongate OCOTP_CTRL ADDR field to eight bits

2019-06-26 Thread Srinivas Kandagatla
Reviewed-by: Leonard Crestez Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index bd016b928589..14c2bff2cd96 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers

[PATCH 6/6] nvmem: imx-ocotp: imx8mq is compatible with imx6 not imx7

2019-06-26 Thread Srinivas Kandagatla
uboot-style "sense" and "override" this issue only affected "write" which is very rarely used. Fixes: 163c0dbd0cb1 ("nvmem: imx-ocotp: add support for imx8mq") Signed-off-by: Leonard Crestez Reviewed-by: Peng Fan Signed-off-by: Srinivas Kandagatla --- dr

[PATCH 5/6] dt-bindings: imx-ocotp: Add i.MX8MM compatible

2019-06-26 Thread Srinivas Kandagatla
From: Bryan O'Donoghue Add compatible for i.MX8MM as per arch/arm64/boot/dts/freescale/imx8mm.dtsi Signed-off-by: Bryan O'Donoghue Cc: Rob Herring Reviewed-by: Leonard Crestez Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 1 + 1 file changed

Re: [PATCH 1/3] slimbus: fix kerneldoc comments

2019-06-20 Thread Srinivas Kandagatla
On 20/06/2019 09:46, Greg KH wrote: On Thu, Jun 20, 2019 at 09:11:27AM +0100, Srinivas Kandagatla wrote: From: Jonathan Corbet The kerneldoc comments in drivers/slimbus/stream.c were not properly formatted, leading to a distinctly unsatisfying "no structured comments found&quo

[PATCH 0/3] drivers: slimbus: patches for 5.3

2019-06-20 Thread Srinivas Kandagatla
): slimbus: fix kerneldoc comments Srinivas Kandagatla (1): slimbus: core: generate uevent for non-dt only drivers/slimbus/core.c | 5 - drivers/slimbus/qcom-ctrl.c | 4 +--- drivers/slimbus/stream.c| 12 ++-- 3 files changed, 7 insertions(+), 14 deletions(-) -- 2.21.0

[PATCH 2/3] slimbus: remove redundant dev_err message

2019-06-20 Thread Srinivas Kandagatla
From: Ding Xiang devm_ioremap_resource already contains error message, so remove the redundant dev_err message Signed-off-by: Ding Xiang Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/slimbus

[PATCH 3/3] slimbus: core: generate uevent for non-dt only

2019-06-20 Thread Srinivas Kandagatla
Rely on MODULE_ALIAS() for automatic kernel module loading, rather than basing it on the OF compatible. This ensures that drivers without of_device_id table, such as wcd9335, will be automatically loaded. Signed-off-by: Srinivas Kandagatla [bjorn: Added commit message] Signed-off-by: Bjorn

[PATCH 1/3] slimbus: fix kerneldoc comments

2019-06-20 Thread Srinivas Kandagatla
Signed-off-by: Jonathan Corbet Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/stream.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c index 2fa05324ed07..75f87b3d8b95 100644 --- a/drivers/slimbus/stream.c +++

Re: [PATCH] arm64: dts: qcom: msm8996: Correct apr-domain property

2019-06-18 Thread Srinivas Kandagatla
On 18/06/2019 06:25, Bjorn Andersson wrote: The domain specifier was changed from using "reg" to "qcom,apr-domain", update the dts accordingly. Signed-off-by: Bjorn Andersson --- LGTM Acked-by: Srinivas Kandagatla

Re: [PATCH] dmaengine: qcom-bam: fix circular buffer handling

2019-06-18 Thread Srinivas Kandagatla
On 18/06/2019 17:27, Sricharan R wrote: The Macro's expect that buffer size is power of 2. So we are infact passing the actual correct size ( MAX_DESCRIPTORS + 1 = 4096) This will make the circular buffer macros happy but question is that do we actually have that many descriptor

Re: [PATCH] dmaengine: qcom-bam: fix circular buffer handling

2019-06-18 Thread Srinivas Kandagatla
On 18/06/2019 15:56, Sricharan R wrote: So MAX_DESCRIPTORS is used in driver for masking head/tail pointers. That's why we have to pass MAX_DESCRIPTORS + 1 so that it works when the Macros does a size - 1 Isn't that incorrect to do that, pretending to have more descriptors than we

Re: [PATCH] dmaengine: qcom-bam: fix circular buffer handling

2019-06-18 Thread Srinivas Kandagatla
Hi Sricharan, On 18/06/2019 08:13, Sricharan R wrote: Hi Srini, On 6/14/2019 7:50 PM, Srinivas Kandagatla wrote: For some reason arguments to most of the circular buffers macros are used in reverse, tail is used for head and vice versa. This leads to bam thinking that there is an extra

Re: [PATCH] dmaengine: qcom-bam: fix circular buffer handling

2019-06-18 Thread Srinivas Kandagatla
Hi Sricharan, On 18/06/2019 08:13, Sricharan R wrote: Hi Srini, On 6/14/2019 7:50 PM, Srinivas Kandagatla wrote: For some reason arguments to most of the circular buffers macros are used in reverse, tail is used for head and vice versa. This leads to bam thinking that there is an extra

Re: [PATCH] ASoC: qcom: common: Fix NULL pointer in of parser

2019-06-18 Thread Srinivas Kandagatla
by moving the allocation and assignement of snd_soc_dai_link_components into the loop, giving us one pair per link. Fixes: 1e36ea360ab9 ("ASoC: qcom: common: use modern dai_link style") Signed-off-by: Bjorn Andersson I think the original patch did not realize that there are multiple links!

Re: [alsa-devel] [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-15 Thread Srinivas Kandagatla
On 11/06/2019 13:21, Pierre-Louis Bossart wrote: On 6/11/19 5:29 AM, Srinivas Kandagatla wrote: On 10/06/2019 15:12, Pierre-Louis Bossart wrote: + +    if (dev_addr == SDW_BROADCAST_DEV_NUM) { +    ctrl->fifo_status = 0; +    ret = wait_for_completion_timeout(>sp_cm

[PATCH 6/6] dt-bindings: nvmem: Convert Allwinner SID to a schema

2019-06-14 Thread Srinivas Kandagatla
Signed-off-by: Srinivas Kandagatla --- .../nvmem/allwinner,sun4i-a10-sid.yaml| 51 +++ .../bindings/nvmem/allwinner,sunxi-sid.txt| 29 --- 2 files changed, 51 insertions(+), 29 deletions(-) create mode 100644 Documentation/devicetree/bindings/nvmem/allwinner

[PATCH 5/6] nvmem: Broaden the selection of NVMEM_SNVS_LPGPR

2019-06-14 Thread Srinivas Kandagatla
-off-by: Fabio Estevam Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index 82a07c24e1db..96a8aedf1a9a 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig

[PATCH 4/6] nvmem: imx: add i.MX8 nvmem driver

2019-06-14 Thread Srinivas Kandagatla
From: Peng Fan This patch adds i.MX8 nvmem ocotp driver to access fuse via RPC to i.MX8 system controller. Cc: Srinivas Kandagatla Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Peng

[PATCH 0/6] nvmem: patches for 5.3

2019-06-14 Thread Srinivas Kandagatla
Hi Greg, Here are few nvmem patches for 5.3 which includes - new i.MX8 SCU On-Chip OTP Controller support - Few SPDX Licence header updates. - sun4i and sunxi dt bindings in yaml Can you please pick them up for 5.3. thanks, srini Fabio Estevam (1): nvmem: Broaden the selection of

[PATCH 2/6] nvmem: meson-mx-efuse: update with SPDX Licence identifier

2019-06-14 Thread Srinivas Kandagatla
From: Neil Armstrong Signed-off-by: Neil Armstrong Reviewed-by: Martin Blumenstingl Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/meson-mx-efuse.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/nvmem/meson-mx-efuse.c b/drivers/nvmem/meson-mx

[PATCH 1/6] nvmem: meson-efuse: update with SPDX Licence identifier

2019-06-14 Thread Srinivas Kandagatla
From: Neil Armstrong Signed-off-by: Neil Armstrong Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/meson-efuse.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c index 99372768446b..9f928fa9964f 100644

[PATCH 3/6] dt-bindings: fsl: scu: add ocotp binding

2019-06-14 Thread Srinivas Kandagatla
: Ulf Hansson Cc: Stephen Boyd Cc: Anson Huang Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Reviewed-by: Dong Aisheng Signed-off-by: Peng Fan Signed-off-by: Srinivas Kandagatla --- .../bindings/arm/freescale/fsl,scu.txt| 22 +++ 1 file changed, 22 insertions

[PATCH] dmaengine: qcom-bam: fix circular buffer handling

2019-06-14 Thread Srinivas Kandagatla
MAX_DESCRIPTORS (4096) are scheduled and done, so most of the drivers would not notice this, unless they are heavily using bam dma. Originally found this issue while testing SoundWire over SlimBus on DB845c which uses DMA very heavily for read/writes. Signed-off-by: Srinivas Kandagatla --- drivers

[PATCH] regmap: fix bulk writes on paged registers

2019-06-12 Thread Srinivas Kandagatla
and the code below checks for 'ret' value to be -ENOTSUPP before linearising the write buffer to send to bus->write(). Fix this by resetting the 'ret' value to -ENOTSUPP in cases where gather_writes() is not supported or single register write is not possible. Signed-off-by: Srinivas Kandaga

[RFC PATCH 0/5] ASoC: codecs: Add WSA881x Smart Speaker amplifier support

2019-06-11 Thread Srinivas Kandagatla
Srinivas Kandagatla (5): dt-bindings: soundwire: add slave bindings soundwire: core: add device tree support for slave devices soundwire: add module_sdw_driver helper macro dt-bindings: ASoC: Add WSA881x bindings ASoC: codecs: add wsa881x amplifier support .../bindings/sound/qcom

[RFC PATCH 2/5] soundwire: core: add device tree support for slave devices

2019-06-11 Thread Srinivas Kandagatla
This patch adds support to parsing device tree based SoundWire slave devices. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/bus.c | 2 +- drivers/soundwire/bus.h | 1 + drivers/soundwire/slave.c | 54 ++- 3 files changed, 55 insertions(+), 2

[RFC PATCH 4/5] dt-bindings: ASoC: Add WSA881x bindings

2019-06-11 Thread Srinivas Kandagatla
This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker Amplifier. This Amplifier also has a simple thermal sensor for over temperature and speaker protection. Signed-off-by: Srinivas Kandagatla --- .../bindings/sound/qcom,wsa881x.txt | 27 +++ 1 file

[RFC PATCH 5/5] ASoC: codecs: add wsa881x amplifier support

2019-06-11 Thread Srinivas Kandagatla
-by: Srinivas Kandagatla --- sound/soc/codecs/Kconfig |9 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/wsa881x.c | 1160 3 files changed, 1171 insertions(+) create mode 100644 sound/soc/codecs/wsa881x.c diff --git a/sound/soc/codecs/Kconfig b/sound/soc

[RFC PATCH 3/5] soundwire: add module_sdw_driver helper macro

2019-06-11 Thread Srinivas Kandagatla
This Helper macro is for SoundWire drivers which do not do anything special in module init/exit. This eliminates a lot of boilerplate. Each module may only use this macro once, and calling it replaces module_init() and module_exit() Signed-off-by: Srinivas Kandagatla --- include/linux/soundwire

[RFC PATCH 1/5] dt-bindings: soundwire: add slave bindings

2019-06-11 Thread Srinivas Kandagatla
This patch adds bindings for Soundwire Slave devices which includes how SoundWire enumeration address is represented in SoundWire slave device tree nodes. Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/soundwire/bus.txt | 48 +++ 1 file changed, 48 insertions

Re: [alsa-devel] [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-11 Thread Srinivas Kandagatla
On 10/06/2019 15:12, Pierre-Louis Bossart wrote: + +    if (dev_addr == SDW_BROADCAST_DEV_NUM) { +    ctrl->fifo_status = 0; +    ret = wait_for_completion_timeout(>sp_cmd_comp, +  msecs_to_jiffies(TIMEOUT_MS)); This is odd. The SoundWire spec does not handle

Re: [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-10 Thread Srinivas Kandagatla
Thanks for taking time to review! On 10/06/2019 07:40, Vinod Koul wrote: On 07-06-19, 09:56, Srinivas Kandagatla wrote: Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD audio codecs via slimbus or as part of SOC I/O. This patchset adds

Re: [RFC PATCH 5/6] dt-bindings: soundwire: add bindings for Qcom controller

2019-06-10 Thread Srinivas Kandagatla
On 10/06/2019 05:51, Vinod Koul wrote: On 07-06-19, 09:56, Srinivas Kandagatla wrote: This patch adds bindings for Qualcomm soundwire controller. Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD audio codecs via slimbus or as part of SOC

Re: [RFC PATCH 1/6] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-06-10 Thread Srinivas Kandagatla
On 10/06/2019 05:34, Vinod Koul wrote: On 07-06-19, 09:56, Srinivas Kandagatla wrote: On platforms which have smart speaker amplifiers connected via soundwire and modeled as aux devices in ASoC, in such usecases machine driver should be able to get sdw master stream from dai so that it can

Re: [RFC PATCH 1/6] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-06-09 Thread Srinivas Kandagatla
Thanks for taking time to review, On 08/06/2019 20:22, Cezary Rojewski wrote: On 2019-06-07 10:56, Srinivas Kandagatla wrote: On platforms which have smart speaker amplifiers connected via soundwire and modeled as aux devices in ASoC, in such usecases machine driver should be able to get sdw

Re: [alsa-devel] [RFC PATCH 5/6] dt-bindings: soundwire: add bindings for Qcom controller

2019-06-09 Thread Srinivas Kandagatla
Thanks for taking time to review, On 07/06/2019 13:50, Pierre-Louis Bossart wrote: On 6/7/19 3:56 AM, Srinivas Kandagatla wrote: This patch adds bindings for Qualcomm soundwire controller. Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD

Re: [alsa-devel] [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-09 Thread Srinivas Kandagatla
Thanks for taking time to review, On 07/06/2019 14:36, Pierre-Louis Bossart wrote: +config SOUNDWIRE_QCOM +    tristate "Qualcomm SoundWire Master driver" +    select SOUNDWIRE_BUS +    depends on SND_SOC depends on SLIMBUS if you need the SlimBus link to talk to your SoundWire Master?

Re: [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-09 Thread Srinivas Kandagatla
Thanks for taking time to review, I agre with most of the comments specially handling returns and making code more readable. Will fix them in next version. On 08/06/2019 22:53, Cezary Rojewski wrote: On 2019-06-07 10:56, Srinivas Kandagatla wrote: Qualcomm SoundWire Master controller

[RFC PATCH 4/6] soundwire: stream: make stream name a const pointer

2019-06-07 Thread Srinivas Kandagatla
Make stream name const pointer Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/stream.c| 2 +- include/linux/soundwire/sdw.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index b86992145799

[RFC PATCH 2/6] soundwire: Add compute_params callback

2019-06-07 Thread Srinivas Kandagatla
From: Vinod Koul This callback allows masters to compute the bus parameters required. Signed-off-by: Vinod Koul Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/stream.c| 9 + include/linux/soundwire/sdw.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/drivers

[RFC PATCH 0/6] soundwire: Add support to Qualcomm SoundWire master

2019-06-07 Thread Srinivas Kandagatla
and Patrick Lai's Team. TODO: Test and add PCM support. Thanks, srini Srinivas Kandagatla (5): ASoC: core: add support to snd_soc_dai_get_sdw_stream() soundwire: core: define SDW_MAX_PORT soundwire: stream: make stream name a const pointer dt-bindings: soundwire: add bindings

[RFC PATCH 1/6] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-06-07 Thread Srinivas Kandagatla
function would provide more flexibility to above configurations. Signed-off-by: Srinivas Kandagatla --- include/sound/soc-dai.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h index f5d70041108f..9f90b936fd9a 100644 --- a/include/sound

[RFC PATCH 5/6] dt-bindings: soundwire: add bindings for Qcom controller

2019-06-07 Thread Srinivas Kandagatla
This patch adds bindings for Qualcomm soundwire controller. Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD audio codecs via slimbus or as part of SOC I/O. Signed-off-by: Srinivas Kandagatla --- .../bindings/soundwire/qcom,swr.txt

[RFC PATCH 3/6] soundwire: core: define SDW_MAX_PORT

2019-06-07 Thread Srinivas Kandagatla
This patch adds SDW_MAX_PORT so that other driver can use it. Signed-off-by: Srinivas Kandagatla --- include/linux/soundwire/sdw.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h index aac68e879fae..80ca997e4e5d 100644

[RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-07 Thread Srinivas Kandagatla
amplifiers. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/Kconfig | 9 + drivers/soundwire/Makefile | 4 + drivers/soundwire/qcom.c | 983 + 3 files changed, 996 insertions(+) create mode 100644 drivers/soundwire/qcom.c diff --git a/drivers

Re: [alsa-devel] [PATCH v2] soundwire: stream: fix bad unlock balance

2019-06-06 Thread Srinivas Kandagatla
On 06/06/2019 15:28, Pierre-Louis Bossart wrote: On 6/6/19 6:22 AM, Srinivas Kandagatla wrote: multi bank switching code takes lock on condition but releases without any check resulting in below warning. This patch fixes this. Question to make sure we are talking about the same thing

Re: [alsa-devel] [PATCH v2] ASoC: msm8916-wcd-digital: Add sidetone support

2019-06-06 Thread Srinivas Kandagatla
On 06/06/2019 14:24, Amadeusz Sławiński wrote: + SOC_SINGLE_SX_TLV("IIR1 INP1 Volume", LPASS_CDC_IIR1_GAIN_B1_CTL, + 0, -84, 40, digital_gain), + SOC_SINGLE_SX_TLV("IIR1 INP2 Volume", LPASS_CDC_IIR1_GAIN_B2_CTL, + 0, -84, 40,

[PATCH v2] ASoC: msm8916-wcd-digital: Add sidetone support

2019-06-06 Thread Srinivas Kandagatla
. Signed-off-by: Srinivas Kandagatla --- Changes since v1: - added missing break in switch - Moved IIR bands enable to switch controls sound/soc/codecs/msm8916-wcd-digital.c | 282 + 1 file changed, 282 insertions(+) diff --git a/sound/soc/codecs/msm8916-wcd

Re: [PATCH] ASoC: msm8916-wcd-digital: Add sidetone support

2019-06-06 Thread Srinivas Kandagatla
Thanks for the review, On 06/06/2019 12:54, Mark Brown wrote: On Thu, Jun 06, 2019 at 12:40:02PM +0100, Srinivas Kandagatla wrote: + default: + pr_err("%s: event = %d not expected\n", __func__, event); + } dev_err() please (and a break; as well, it isn'

Re: [PATCH v2] arm64: dts: qcom: Add Dragonboard 845c

2019-06-06 Thread Srinivas Kandagatla
, which causes the board to reboot. This can be worked around using: fastboot oem select-display-panel none Signed-off-by: Bjorn Andersson --- Tested-by: Srinivas Kandagatla

[PATCH] ASoC: msm8916-wcd-digital: Add sidetone support

2019-06-06 Thread Srinivas Kandagatla
. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/msm8916-wcd-digital.c | 353 + 1 file changed, 353 insertions(+) diff --git a/sound/soc/codecs/msm8916-wcd-digital.c b/sound/soc/codecs/msm8916-wcd-digital.c index a63961861e55..ec00893ca92a 100644 --- a/sound/soc/codecs

[PATCH] soundwire: intel: set dai min and max channels correctly

2019-06-06 Thread Srinivas Kandagatla
Looks like there is a copy paste error. This patch fixes it! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 92be6ad84e8d..317873bc0555 100644

[PATCH v2] soundwire: stream: fix bad unlock balance

2019-06-06 Thread Srinivas Kandagatla
- aplay/2954 is trying to release lock (>msg_lock) at: do_bank_switch+0x21c/0x480 but there are no more locks to release! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/stream.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/strea

Re: [PATCH 02/13] bus_find_device: Unify the match callback with class_find_device

2019-06-06 Thread Srinivas Kandagatla
r Cc: Hartmut Knaack Cc: Heiko Stuebner Cc: Jason Gunthorpe Cc: Jonathan Cameron Cc: Jonathan Cameron Cc: "James E.J. Bottomley" Cc: Len Brown Cc: Mark Brown Cc: Michael Ellerman Cc: Michael Jamet Cc: "Martin K. Petersen" Cc: Peter Oberparleiter Cc: Rob Herring Cc: Sebastian

Re: [PATCH] soc: qcom: apr: Don't use reg for domain id

2019-05-23 Thread Srinivas Kandagatla
is not an appropriate solution. I agree. Replace the use of "reg" with an APR specific property. Signed-off-by: Bjorn Andersson --- Can you also change the example too. other than that am okay with the change. Reviewed-by: Srinivas Kandagatla --srini The APR device was rece

Re: [PATCH] soundwire: stream: fix bad unlock balance

2019-05-23 Thread Srinivas Kandagatla
On 23/05/2019 10:20, Sanyog Kale wrote: On Thu, May 23, 2019 at 09:43:14AM +0100, Srinivas Kandagatla wrote: On 22/05/2019 17:41, Pierre-Louis Bossart wrote: On 5/22/19 11:25 AM, Srinivas Kandagatla wrote: This patch fixes below warning due to unlocking without locking

Re: [PATCH] nvmem: Broaden the selection of NVMEM_SNVS_LPGPR

2019-05-23 Thread Srinivas Kandagatla
On 23/05/2019 01:15, Fabio Estevam wrote: The SNVS LPGR IP block is also found on other i.MX SoCs that are not covered by the current SOC_IMX6 || SOC_IMX7D logic. One example is the i.MX7ULP. To avoid keep expanding the SoC logic selection, make it broader by using the more generic ARCH_MXC

Re: [PATCH V3 RESEND 2/4] nvmem: imx: add i.MX8 nvmem driver

2019-05-23 Thread Srinivas Kandagatla
On 22/05/2019 02:46, Peng Fan wrote: This patch adds i.MX8 nvmem ocotp driver to access fuse via RPC to i.MX8 system controller. Cc: Srinivas Kandagatla Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc:linux-arm-ker...@lists.infradead.org

Re: [PATCH] soundwire: stream: fix bad unlock balance

2019-05-23 Thread Srinivas Kandagatla
On 22/05/2019 17:41, Pierre-Louis Bossart wrote: On 5/22/19 11:25 AM, Srinivas Kandagatla wrote: This patch fixes below warning due to unlocking without locking.   =   WARNING: bad unlock balance detected!   5.1.0-16506-gc1c383a6f0a2-dirty #1523 Tainted

Re: [PATCH] soundwire: stream: fix bad unlock balance

2019-05-22 Thread Srinivas Kandagatla
On 22/05/2019 17:25, Srinivas Kandagatla wrote: This patch fixes below warning due to unlocking without locking. = WARNING: bad unlock balance detected! 5.1.0-16506-gc1c383a6f0a2-dirty #1523 Tainted: GW

[PATCH] soundwire: stream: fix bad unlock balance

2019-05-22 Thread Srinivas Kandagatla
ock) at: do_bank_switch+0x21c/0x480 but there are no more locks to release! Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/stream.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index 544925ff0b40..d16268f30

[PATCH] soundwire: stream: fix out of boundary access on port properties

2019-05-22 Thread Srinivas Kandagatla
Assigning local iterator to array element and using it again for indexing would cross the array boundary. Fix this by directly referring array element without using the local variable. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/stream.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: nvmem creates multiple devices with the same name

2019-05-21 Thread Srinivas Kandagatla
On 21/05/2019 09:56, Sascha Hauer wrote: . Are there any suggestions how to register the nvmem devices with a different name? struct nvmem_config provides id field for this purpose, this will be used by nvmem to set the device name space along with name field. --srini

Re: [PATCH V3 2/4] nvmem: imx: add i.MX8 nvmem driver

2019-05-21 Thread Srinivas Kandagatla
On 15/05/2019 08:53, Peng Fan wrote: This patch adds i.MX8 nvmem ocotp driver to access fuse via RPC to i.MX8 system controller. Cc: Srinivas Kandagatla Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-arm-ker

Re: [PATCH 0/2] nvmem: meson: update with SPDX Licence identifier

2019-05-21 Thread Srinivas Kandagatla
On 20/05/2019 15:37, Neil Armstrong wrote: Update the SPDX Licence identifier for the Amlogic NVMEM drivers. Neil Armstrong (2): nvmem: meson-efuse: update with SPDX Licence identifier nvmem: meson-mx-efuse: update with SPDX Licence identifier drivers/nvmem/meson-efuse.c| 10

[PATCH v2] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-16 Thread Srinivas Kandagatla
reboots. This patch adds new NVMEM_SYSFS Kconfig to make binary sysfs entry an optional one. This provision will give more flexibility to users. This patch also moves existing sysfs code to a new file so that its not compiled in when its not really required. Signed-off-by: Srinivas Kandagatla

Re: [PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-16 Thread Srinivas Kandagatla
On 16/04/2019 10:34, Mika Westerberg wrote: On Tue, Apr 16, 2019 at 10:49:22AM +0530, Gaurav Kohli wrote: Hi Srinivas, Thanks for the patch, By default NVMEM_SYSFS should be set true, those whose don't want they can disable the same. If we go with disable option, there are chances of

[PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-15 Thread Srinivas Kandagatla
reboots. This patch adds new NVMEM_SYSFS Kconfig to make binary sysfs entry an optional one. This provision will give more flexibility to users. This patch also moves existing sysfs code to a new file so that its not compiled in when its not really required. Signed-off-by: Srinivas Kandagatla

[PATCH] slimbus: fix a NULL pointer dereference in of_qcom_slim_ngd_register

2019-04-13 Thread Srinivas Kandagatla
From: Kangjie Lu In case platform_device_alloc fails, the fix returns an error code to avoid the NULL pointer dereference. Signed-off-by: Kangjie Lu Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/slimbus

[RESEND PATCH 10/20] nvmem: Add driver for STM32 factory-programmed read only mem

2019-04-13 Thread Srinivas Kandagatla
From: Fabrice Gasnier Add a read only nvmem driver for STM32 factory-programmed memory area (on-chip non-volatile storage). Signed-off-by: Fabrice Gasnier Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/Kconfig | 10 + drivers/nvmem/Makefile | 2 + drivers/nvmem/stm32

[RESEND PATCH 15/20] nvmem: mxs-ocotp: use devm_platform_ioremap_resource() to simplify code

2019-04-13 Thread Srinivas Kandagatla
From: Anson Huang Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/mxs-ocotp.c | 4

[RESEND PATCH 02/20] nvmem: imx-ocotp: add support for imx8mq

2019-04-13 Thread Srinivas Kandagatla
From: Lucas Stach The i.MX8MQ uses the same OCOTP block as the i.MX7D, but with fourfold increase in fuse banks. Signed-off-by: Lucas Stach Reviewed-by: Abel Vesa Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[RESEND PATCH 12/20] nvmem: core: add nvmem_cell_read_u16

2019-04-13 Thread Srinivas Kandagatla
-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 37 ++ include/linux/nvmem-consumer.h | 7 +++ 2 files changed, 44 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index f24008b66826..1d00f5671368 100644 --- a/drivers/nvmem/core.c

[RESEND PATCH 09/20] dt-bindings: nvmem: Add STM32 factory-programmed romem

2019-04-13 Thread Srinivas Kandagatla
From: Fabrice Gasnier Add documentation for STMicroelectronics STM32 Factory-programmed read only memory area. Signed-off-by: Fabrice Gasnier Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../bindings/nvmem/st,stm32-romem.txt | 31 +++ 1 file

[RESEND PATCH 03/20] nvmem: imx-ocotp: broaden Kconfig dependency

2019-04-13 Thread Srinivas Kandagatla
From: Lucas Stach The i.MX OCOTP controller is used in numerous Freescale/NXP SoCs from the MXC family, so the strict dependency on the i.MX6 SoC is too narrow. Broaden it to cover all the MXC familiy members. Signed-off-by: Lucas Stach Reviewed-by: Abel Vesa Signed-off-by: Srinivas

[RESEND PATCH 05/20] nvmem: sunxi_sid: Optimize register read-out method

2019-04-13 Thread Srinivas Kandagatla
Ripard Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sunxi_sid.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c index 704c35edf796..15fbfab62595 100644 --- a/drivers/nvmem

[RESEND PATCH 16/20] nvmem: imx-iim: use devm_platform_ioremap_resource() to simplify code

2019-04-13 Thread Srinivas Kandagatla
From: Anson Huang Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-iim.c | 4

[RESEND PATCH 13/20] nvmem: core: fix read buffer in place

2019-04-13 Thread Srinivas Kandagatla
will incorrectly clear bit positions on the first byte. This commit also makes sure that any byte unused in the cell is cleared. Signed-off-by: Jorge Ramirez-Ortiz Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff

[RESEND PATCH 14/20] nvmem: imx-ocotp: use devm_platform_ioremap_resource() to simplify code

2019-04-13 Thread Srinivas Kandagatla
From: Anson Huang Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 4

[RESEND PATCH 17/20] nvmem: sunxi-sid: fix wrong description in kernel doc

2019-04-13 Thread Srinivas Kandagatla
From: Yangtao Li qfprom->sunxi-sid Acked-by: Maxime Ripard Reviewed-by: Rob Herring Signed-off-by: Yangtao Li Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[RESEND PATCH 19/20] nvmem: sunxi-sid: convert to SPDX license tags

2019-04-13 Thread Srinivas Kandagatla
From: Yangtao Li Updates license to use SPDX-License-Identifier. Acked-by: Maxime Ripard Signed-off-by: Yangtao Li Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sunxi_sid.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/nvmem/sunxi_sid.c b

[RESEND PATCH 00/20] nvmem: patches(set 1) for 5.2

2019-04-13 Thread Srinivas Kandagatla
Resending this with cc to linux-kernel@vger.kernel.org Hi Greg, Here are some nvmem patches for 5.2 which includes: - adding support to new stm32, sunix and imx providers - few general cleanups - fix for in place buffer reads. Can you please pick these for 5.2. thanks, srini Anson Huang (3):

[RESEND PATCH 20/20] nvmem: sunxi_sid: Support SID on H6

2019-04-13 Thread Srinivas Kandagatla
From: Yangtao Li Add support for H6's SID controller. It supports 4K-bit EFUSE, bigger than before. Signed-off-by: Yangtao Li Acked-by: Maxime Ripard Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sunxi_sid.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvmem

[RESEND PATCH 06/20] nvmem: sunxi_sid: Dynamically allocate nvmem_config structure

2019-04-13 Thread Srinivas Kandagatla
the nvmem_config structure at probe time, plugging in the desired parameters along the way. Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sunxi_sid.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff

[RESEND PATCH 04/20] nvmem: sunxi_sid: Read out SID for randomness without looping

2019-04-13 Thread Srinivas Kandagatla
Ripard Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sunxi_sid.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c index 570a2e354f30..704c35edf796 100644 --- a/drivers/nvmem/sunxi_sid.c +++ b/drivers/nvmem

[RESEND PATCH 08/20] nvmem: sunxi_sid: Support SID on A83T and H5

2019-04-13 Thread Srinivas Kandagatla
compatible strings, re-using the config for the A64. Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sunxi_sid.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c index 14c114620ed6

[RESEND PATCH 18/20] nvmem: sunxi-sid: add binding for H6's SID controller

2019-04-13 Thread Srinivas Kandagatla
From: Yangtao Li Add a binding for H6's SID controller. Acked-by: Maxime Ripard Reviewed-by: Rob Herring Signed-off-by: Yangtao Li Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[RESEND PATCH 11/20] nvmem: stm32: add support for STM32MP15 BSEC to control OTP data

2019-04-13 Thread Srinivas Kandagatla
to the full range of OTP data. This adds support for reading and writing OTP data using SMC services. Data content can be aligned on 16-bits or 8-bits. Then take care of it, since BSEC data is 32-bits wide. Signed-off-by: Fabrice Gasnier Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/stm32

[RESEND PATCH 07/20] nvmem: sunxi_sid: Read out data in native format

2019-04-13 Thread Srinivas Kandagatla
endian. This only affects the other SoCs. Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sunxi_sid.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem

[RESEND PATCH 01/20] dt-bindings: imx-ocotp: Add i.MX8MQ compatible

2019-04-13 Thread Srinivas Kandagatla
From: Lucas Stach Add compatible for i.MX8MQ and add i.MX7D/S, i.MX7ULP and i.M8MQ to the description. Signed-off-by: Lucas Stach Reviewed-by: Rob Herring Reviewed-by: Abel Vesa Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 4 +++- 1 file

Re: [PATCH 0/2] soundwire: fix Kconfig select/depend issues

2019-04-12 Thread Srinivas Kandagatla
On 11/04/2019 20:28, Pierre-Louis Bossart wrote: 0-day/Kbuild starts complaining about missed module dependencies and compilation issues. Since codecs and soc drivers need to be compilable independently, let's fix this using the following model: SOUNDWIRE_INTEL select ---

Re: [PATCH] ASoC: wcd9335: Fix missing regmap requirement

2019-04-10 Thread Srinivas Kandagatla
On 10/04/2019 15:23, Marc Gonzalez wrote: wcd9335.c: undefined reference to 'devm_regmap_add_irq_chip' Signed-off-by: Marc Gonzalez --- Thanks for Fix, Acked-by: Srinivas Kandagatla sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs

Re: [PATCH] nvmem: core: fix read buffer in place

2019-04-04 Thread Srinivas Kandagatla
On 20/03/2019 19:32, Jorge Ramirez-Ortiz wrote: When the bit_offset in the cell is zero, the pointer to the msb will not be properly initialized (ie, will still be pointing to the first byte in the buffer). This being the case, if there are bits to clear in the msb, those will be left

Re: [PATCH v2 0/5] nvmem: sunxi-sid: add SID controller support for H6

2019-04-04 Thread Srinivas Kandagatla
On 02/04/2019 16:45, Yangtao Li wrote: Add SID support for H6, and do some cleanup. For endianness issue, add a new ref_read func. Yangtao Li (5): nvmem: sunxi-sid: fix wrong description in kernel doc nvmem: sunxi-sid: add binding for H6's SID controller nvmem: sunxi-sid: convert to

<    5   6   7   8   9   10   11   12   13   14   >