Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-21 Thread Greg KH
On Wed, Sep 21, 2016 at 02:02:10PM +0100, Mark Rutland wrote: > > As for the drivers all living under drivers/greybus/ I understand, but > > we need the greybus core present first before we can get the drivers in. > > How about we do what happened with IIO, we take the greybus core code in > > driv

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-21 Thread Mark Rutland
Hi, Apologies for the late reply to this; I don't subscribe to LKML with my work address and didn't spot this sub-thread until now. On Fri, Sep 16, 2016 at 08:05:19AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 03:45:53PM +0100, Mark Brown wrote: > > On Wed, Sep 14, 2016 at 12:09:49PM +0200,

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-20 Thread Vaibhav Agarwal
+new email ids for myself & Vaibhav H -- thanks, ./va On 20 September 2016 at 12:11, Greg KH wrote: > On Fri, Sep 16, 2016 at 04:24:59PM +0200, Greg KH wrote: >> On Fri, Sep 16, 2016 at 03:22:08PM +0200, Greg KH wrote: >> > On Fri, Sep 16, 2016 at 11:18:07AM +0100, Mark Brown wrote: >> > > On Fr

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-19 Thread Greg KH
On Fri, Sep 16, 2016 at 04:24:59PM +0200, Greg KH wrote: > On Fri, Sep 16, 2016 at 03:22:08PM +0200, Greg KH wrote: > > On Fri, Sep 16, 2016 at 11:18:07AM +0100, Mark Brown wrote: > > > On Fri, Sep 16, 2016 at 08:05:19AM +0200, Greg KH wrote: > > > > On Thu, Sep 15, 2016 at 03:45:53PM +0100, Mark B

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-16 Thread Greg KH
On Fri, Sep 16, 2016 at 03:22:08PM +0200, Greg KH wrote: > On Fri, Sep 16, 2016 at 11:18:07AM +0100, Mark Brown wrote: > > On Fri, Sep 16, 2016 at 08:05:19AM +0200, Greg KH wrote: > > > On Thu, Sep 15, 2016 at 03:45:53PM +0100, Mark Brown wrote: > > > > > > Sending a pull request for code that's n

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-16 Thread Greg KH
On Fri, Sep 16, 2016 at 11:18:07AM +0100, Mark Brown wrote: > On Fri, Sep 16, 2016 at 08:05:19AM +0200, Greg KH wrote: > > On Thu, Sep 15, 2016 at 03:45:53PM +0100, Mark Brown wrote: > > > > Sending a pull request for code that's never been seen upstream seems > > > completely premature. > > > He

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-16 Thread Arnd Bergmann
On Friday, September 16, 2016 8:05:19 AM CEST Greg KH wrote: > On Thu, Sep 15, 2016 at 03:45:53PM +0100, Mark Brown wrote: > > On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > > > > > I'll send out a follow-up set of "simple" patches that just add the > > > files to the kernel tree, to g

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-16 Thread Mark Brown
On Fri, Sep 16, 2016 at 08:05:19AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 03:45:53PM +0100, Mark Brown wrote: > > Sending a pull request for code that's never been seen upstream seems > > completely premature. > Hey, how does code get upstream then? :) By having the actual code to the

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Greg KH
On Thu, Sep 15, 2016 at 03:45:53PM +0100, Mark Brown wrote: > On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > > > I'll send out a follow-up set of "simple" patches that just add the > > files to the kernel tree, to give people an idea of the code involved. > > Overall, it's a tiny stand

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Bryan O'Donoghue
On Thu, 2016-09-15 at 16:47 +0100, Mark Rutland wrote: > On  > I can't say this any more explicitly: > > > * The DT *cannot* know anything about get_cycles() * > > > It's no more complex than

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Mark Rutland
On Thu, Sep 15, 2016 at 04:40:00PM +0100, Bryan O'Donoghue wrote: > On Thu, 2016-09-15 at 13:46 +0100, Mark Rutland wrote: > > On Thu, Sep 15, 2016 at 12:48:08PM +0100, Bryan O'Donoghue wrote: > > > On Thu, 2016-09-15 at 12:20 +0100, Mark Rutland wrote: > > > > For example, you have absolutely no g

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Bryan O'Donoghue
On Thu, 2016-09-15 at 13:46 +0100, Mark Rutland wrote: > On Thu, Sep 15, 2016 at 12:48:08PM +0100, Bryan O'Donoghue wrote: > > > > On Thu, 2016-09-15 at 12:20 +0100, Mark Rutland wrote: > > > > > > For example, you have absolutely no guarantee as to what backs > > > get_cycles(). Despite this, th

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Mark Brown
On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > I'll send out a follow-up set of "simple" patches that just add the > files to the kernel tree, to give people an idea of the code involved. > Overall, it's a tiny stand-alone driver subsystem, only 37k lines, that > implements a protocol

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Mark Rutland
On Thu, Sep 15, 2016 at 12:48:08PM +0100, Bryan O'Donoghue wrote: > On Thu, 2016-09-15 at 12:20 +0100, Mark Rutland wrote: > > For example, you have absolutely no guarantee as to what backs > > get_cycles(). Despite this, the code assumes that get_cycles() is > > backed by something running at the

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Bryan O'Donoghue
On Thu, 2016-09-15 at 12:20 +0100, Mark Rutland wrote: > Hi, > > More questions below. Perhaps some of these will be implicitly > answered > when the linearised patches appear, and I'm happy to wait until then > to > continue the discussion, as I suspect otherwise we're all likely to > end > up ex

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Mark Rutland
Hi, More questions below. Perhaps some of these will be implicitly answered when the linearised patches appear, and I'm happy to wait until then to continue the discussion, as I suspect otherwise we're all likely to end up exasperated. Please do Cc me on those. Regardless, until those appear and

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Bryan O'Donoghue
On Thu, 2016-09-15 at 12:17 +0200, Greg KH wrote: > This > > is the first I've heard of timesync having a binding. I can't > imagine > > why it needs one. > > Ah, I'll let Bryan answer that one :) It's possible we could drop the binding. It was needed to describe the register location of the MMIO

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Bryan O'Donoghue
On Thu, 2016-09-15 at 11:35 +0100, Bryan O'Donoghue wrote: > Here's a slightly better diagram. PMIC -> refclk provided to each (timer) element below. MSM8994(timer) -- > USB WD8a                APBridgeA (timer) -> UniPro bus                WD8a -> Mo

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Bryan O'Donoghue
On Thu, 2016-09-15 at 11:13 +0100, Mark Rutland wrote: > On Thu, Sep 15, 2016 at 10:35:33AM +0100, Bryan O'Donoghue wrote: > >  > I don't think the history matters, Your comment seemed to indicate you thought we were reading a architectural timer directly - which we aren't. > and I don't think t

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Greg KH
On Wed, Sep 14, 2016 at 03:07:22PM -0500, Rob Herring wrote: > On Wed, Sep 14, 2016 at 1:07 PM, Greg KH wrote: > > On Wed, Sep 14, 2016 at 06:36:26PM +0100, Mark Rutland wrote: > >> Hi Greg, > >> > >> On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > >> > Given that it's never a good idea

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Mark Rutland
On Thu, Sep 15, 2016 at 10:35:33AM +0100, Bryan O'Donoghue wrote: > On Wed, 2016-09-14 at 20:29 +0200, Greg KH wrote: > > Bryan, any explanations you want to provide that would help in > > clarifying Mark's issues? > > As Douglas Adams would say - "don't panic". > > If you look at the final state

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-15 Thread Bryan O'Donoghue
On Wed, 2016-09-14 at 20:29 +0200, Greg KH wrote: > On Wed, Sep 14, 2016 at 08:07:54PM +0200, Greg KH wrote: > > > > On Wed, Sep 14, 2016 at 06:36:26PM +0100, Mark Rutland wrote: > > > > > > Hi Greg, > > > > > > On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > > > > > > > > Given that

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-14 Thread Rob Herring
On Wed, Sep 14, 2016 at 1:07 PM, Greg KH wrote: > On Wed, Sep 14, 2016 at 06:36:26PM +0100, Mark Rutland wrote: >> Hi Greg, >> >> On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: >> > Given that it's never a good idea to keep subsystems out of the mainline >> > kernel, I've put together th

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 20:29 +0200, Greg KH wrote: trivial note: > +static size_t gb_timesync_log_frame_time(struct gb_timesync_svc > *timesync_svc, > + char *buf, size_t buflen) > +{ > + struct gb_svc *svc = timesync_svc->svc; > + struct gb_host_devic

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-14 Thread Greg KH
On Wed, Sep 14, 2016 at 08:07:54PM +0200, Greg KH wrote: > On Wed, Sep 14, 2016 at 06:36:26PM +0100, Mark Rutland wrote: > > Hi Greg, > > > > On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > > > Given that it's never a good idea to keep subsystems out of the mainline > > > kernel, I've p

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-14 Thread Greg KH
On Wed, Sep 14, 2016 at 06:36:26PM +0100, Mark Rutland wrote: > Hi Greg, > > On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > > Given that it's never a good idea to keep subsystems out of the mainline > > kernel, I've put together this pull request that adds the greybus driver > > layer

Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1

2016-09-14 Thread Mark Rutland
Hi Greg, On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > Given that it's never a good idea to keep subsystems out of the mainline > kernel, I've put together this pull request that adds the greybus driver > layer to drivers/greybus/. Because this was 2 1/2 years of work, with > many ma