Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2008-01-07 Thread Mel Gorman
On (30/12/07 12:37), Thomas Bogendoerfer didst pronounce: > On Thu, Dec 20, 2007 at 01:27:20PM +, Mel Gorman wrote: > > On (20/12/07 13:43), Thomas Bogendoerfer didst pronounce: > > > On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: > > > > --- a/include/asm-mips/page.h > > > > +++

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2008-01-07 Thread Mel Gorman
On (30/12/07 12:37), Thomas Bogendoerfer didst pronounce: On Thu, Dec 20, 2007 at 01:27:20PM +, Mel Gorman wrote: On (20/12/07 13:43), Thomas Bogendoerfer didst pronounce: On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: --- a/include/asm-mips/page.h +++

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-30 Thread Thomas Bogendoerfer
On Thu, Dec 20, 2007 at 01:27:20PM +, Mel Gorman wrote: > On (20/12/07 13:43), Thomas Bogendoerfer didst pronounce: > > On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: > > > --- a/include/asm-mips/page.h > > > +++ b/include/asm-mips/page.h > > > @@ -37,13 +37,6 @@ > > > #include

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-30 Thread Thomas Bogendoerfer
On Thu, Dec 20, 2007 at 01:27:20PM +, Mel Gorman wrote: On (20/12/07 13:43), Thomas Bogendoerfer didst pronounce: On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: --- a/include/asm-mips/page.h +++ b/include/asm-mips/page.h @@ -37,13 +37,6 @@ #include linux/pfn.h

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-20 Thread Mel Gorman
On (20/12/07 13:43), Thomas Bogendoerfer didst pronounce: > On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: > > --- a/include/asm-mips/page.h > > +++ b/include/asm-mips/page.h > > @@ -37,13 +37,6 @@ > > #include > > #include > > > > -/* > > - * It's normally defined only for

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-20 Thread Thomas Bogendoerfer
On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: > --- a/include/asm-mips/page.h > +++ b/include/asm-mips/page.h > @@ -37,13 +37,6 @@ > #include > #include > > -/* > - * It's normally defined only for FLATMEM config but it's > - * used in our early mem init code for all memory

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-20 Thread Mel Gorman
On (18/12/07 17:09), Thomas Bogendoerfer didst pronounce: > On Tue, Dec 18, 2007 at 01:58:28PM +, Mel Gorman wrote: > > That commit is over a year old and it initially distressed me that it > > would take this long to show up on a boot test. However, you said this was > > to fix MIPS in a

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-20 Thread Mel Gorman
On (18/12/07 17:09), Thomas Bogendoerfer didst pronounce: On Tue, Dec 18, 2007 at 01:58:28PM +, Mel Gorman wrote: That commit is over a year old and it initially distressed me that it would take this long to show up on a boot test. However, you said this was to fix MIPS in a follow-on

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-20 Thread Thomas Bogendoerfer
On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: --- a/include/asm-mips/page.h +++ b/include/asm-mips/page.h @@ -37,13 +37,6 @@ #include linux/pfn.h #include asm/io.h -/* - * It's normally defined only for FLATMEM config but it's - * used in our early mem init code for all

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-20 Thread Mel Gorman
On (20/12/07 13:43), Thomas Bogendoerfer didst pronounce: On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: --- a/include/asm-mips/page.h +++ b/include/asm-mips/page.h @@ -37,13 +37,6 @@ #include linux/pfn.h #include asm/io.h -/* - * It's normally defined only for

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Thomas Bogendoerfer
On Tue, Dec 18, 2007 at 01:58:28PM +, Mel Gorman wrote: > That commit is over a year old and it initially distressed me that it > would take this long to show up on a boot test. However, you said this was > to fix MIPS in a follow-on mail and I never made it use arch-independent > zone-sizing

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Mel Gorman
On (18/12/07 13:03), Thomas Bogendoerfer didst pronounce: > When using FLAT_MEMORY and ARCH_PFN_OFFSET is not 0, the kernel > crashes in memmap_init_zone(). This bug got introduced by > commit c713216deebd95d2b0ab38fef8bb2361c0180c2d > That commit is over a year old and it initially distressed

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Thomas Bogendoerfer
On Tue, Dec 18, 2007 at 04:24:04AM -0800, Andrew Morton wrote: > On Tue, 18 Dec 2007 13:03:00 +0100 (CET) Thomas Bogendoerfer <[EMAIL > PROTECTED]> wrote: > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -3427,7 +3427,7 @@ static void __init_refok alloc_node_mem_map(struct > >

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Andrew Morton
On Tue, 18 Dec 2007 13:03:00 +0100 (CET) Thomas Bogendoerfer <[EMAIL PROTECTED]> wrote: > When using FLAT_MEMORY and ARCH_PFN_OFFSET is not 0, the kernel > crashes in memmap_init_zone(). This bug got introduced by > commit c713216deebd95d2b0ab38fef8bb2361c0180c2d > > Signed-off-by: Thomas

[PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Thomas Bogendoerfer
When using FLAT_MEMORY and ARCH_PFN_OFFSET is not 0, the kernel crashes in memmap_init_zone(). This bug got introduced by commit c713216deebd95d2b0ab38fef8bb2361c0180c2d Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- mm/page_alloc.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Thomas Bogendoerfer
When using FLAT_MEMORY and ARCH_PFN_OFFSET is not 0, the kernel crashes in memmap_init_zone(). This bug got introduced by commit c713216deebd95d2b0ab38fef8bb2361c0180c2d Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED] --- mm/page_alloc.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Andrew Morton
On Tue, 18 Dec 2007 13:03:00 +0100 (CET) Thomas Bogendoerfer [EMAIL PROTECTED] wrote: When using FLAT_MEMORY and ARCH_PFN_OFFSET is not 0, the kernel crashes in memmap_init_zone(). This bug got introduced by commit c713216deebd95d2b0ab38fef8bb2361c0180c2d Signed-off-by: Thomas Bogendoerfer

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Thomas Bogendoerfer
On Tue, Dec 18, 2007 at 04:24:04AM -0800, Andrew Morton wrote: On Tue, 18 Dec 2007 13:03:00 +0100 (CET) Thomas Bogendoerfer [EMAIL PROTECTED] wrote: --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3427,7 +3427,7 @@ static void __init_refok alloc_node_mem_map(struct pglist_data *pgdat)

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Mel Gorman
On (18/12/07 13:03), Thomas Bogendoerfer didst pronounce: When using FLAT_MEMORY and ARCH_PFN_OFFSET is not 0, the kernel crashes in memmap_init_zone(). This bug got introduced by commit c713216deebd95d2b0ab38fef8bb2361c0180c2d That commit is over a year old and it initially distressed me

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-18 Thread Thomas Bogendoerfer
On Tue, Dec 18, 2007 at 01:58:28PM +, Mel Gorman wrote: That commit is over a year old and it initially distressed me that it would take this long to show up on a boot test. However, you said this was to fix MIPS in a follow-on mail and I never made it use arch-independent zone-sizing