Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-18 Thread Wanpeng Li
On Fri, 15 Jan 2021 at 11:20, Wanpeng Li wrote: > > On Wed, 6 Jan 2021 at 08:51, Sean Christopherson wrote: > > > > +tglx > > > > On Tue, Jan 05, 2021, Nitesh Narayan Lal wrote: > > > This reverts commit d7a08882a0a4b4e176691331ee3f492996579534. > > > > > > After the introduction of the patch: >

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-14 Thread Wanpeng Li
On Wed, 6 Jan 2021 at 08:51, Sean Christopherson wrote: > > +tglx > > On Tue, Jan 05, 2021, Nitesh Narayan Lal wrote: > > This reverts commit d7a08882a0a4b4e176691331ee3f492996579534. > > > > After the introduction of the patch: > > > > 87fa7f3e9: x86/kvm: Move context tracking where it

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-12 Thread Sean Christopherson
On Tue, Jan 12, 2021, Nitesh Narayan Lal wrote: > > On 1/7/21 4:33 AM, Vitaly Kuznetsov wrote: > > Sean Christopherson writes: > > > >> On Wed, Jan 06, 2021, Vitaly Kuznetsov wrote: > >>> Looking back, I don't quite understand why we wanted to account ticks > >>> between vmexit and exiting guest

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-12 Thread Nitesh Narayan Lal
On 1/7/21 4:33 AM, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > >> On Wed, Jan 06, 2021, Vitaly Kuznetsov wrote: >>> Looking back, I don't quite understand why we wanted to account ticks >>> between vmexit and exiting guest context as 'guest' in the first place; >>> to my

Re: Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-07 Thread Xinlong Lin
On 2021-01-07 at 01:11, Sean Christopherson wrote: >On Wed, Jan 06, 2021, Vitaly Kuznetsov wrote: >> Nitesh Narayan Lal writes: >> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >> > index 3f7c1fc7a3ce..3e17c9ffcad8 100644 >> > --- a/arch/x86/kvm/x86.c >> > +++ b/arch/x86/kvm/x86.c >> >

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-07 Thread Wanpeng Li
On Thu, 7 Jan 2021 at 17:35, Vitaly Kuznetsov wrote: > > Sean Christopherson writes: > > > On Wed, Jan 06, 2021, Vitaly Kuznetsov wrote: > >> > >> Looking back, I don't quite understand why we wanted to account ticks > >> between vmexit and exiting guest context as 'guest' in the first place; >

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-07 Thread Vitaly Kuznetsov
Sean Christopherson writes: > On Wed, Jan 06, 2021, Vitaly Kuznetsov wrote: >> >> Looking back, I don't quite understand why we wanted to account ticks >> between vmexit and exiting guest context as 'guest' in the first place; >> to my understanging 'guest time' is time spent within VMX

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-06 Thread Sean Christopherson
On Wed, Jan 06, 2021, Vitaly Kuznetsov wrote: > Nitesh Narayan Lal writes: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index 3f7c1fc7a3ce..3e17c9ffcad8 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -9023,18 +9023,7 @@ static int vcpu_enter_guest(struct

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-06 Thread Vitaly Kuznetsov
Nitesh Narayan Lal writes: > This reverts commit d7a08882a0a4b4e176691331ee3f492996579534. > > After the introduction of the patch: > > 87fa7f3e9: x86/kvm: Move context tracking where it belongs > > since we have moved guest_exit_irqoff closer to the VM-Exit, explicit > enabling of irqs to

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-05 Thread Nitesh Narayan Lal
On 1/5/21 7:47 PM, Sean Christopherson wrote: > +tglx > > On Tue, Jan 05, 2021, Nitesh Narayan Lal wrote: >> This reverts commit d7a08882a0a4b4e176691331ee3f492996579534. >> >> After the introduction of the patch: >> >> 87fa7f3e9: x86/kvm: Move context tracking where it belongs >> >> since

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-05 Thread Sean Christopherson
+tglx On Tue, Jan 05, 2021, Nitesh Narayan Lal wrote: > This reverts commit d7a08882a0a4b4e176691331ee3f492996579534. > > After the introduction of the patch: > > 87fa7f3e9: x86/kvm: Move context tracking where it belongs > > since we have moved guest_exit_irqoff closer to the VM-Exit,

Re: [PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-05 Thread Wanpeng Li
On Wed, 6 Jan 2021 at 06:30, Nitesh Narayan Lal wrote: > > This reverts commit d7a08882a0a4b4e176691331ee3f492996579534. > > After the introduction of the patch: > > 87fa7f3e9: x86/kvm: Move context tracking where it belongs > > since we have moved guest_exit_irqoff closer to the VM-Exit,

[PATCH] Revert "KVM: x86: Unconditionally enable irqs in guest context"

2021-01-05 Thread Nitesh Narayan Lal
This reverts commit d7a08882a0a4b4e176691331ee3f492996579534. After the introduction of the patch: 87fa7f3e9: x86/kvm: Move context tracking where it belongs since we have moved guest_exit_irqoff closer to the VM-Exit, explicit enabling of irqs to process pending interrupts should not