Re: [PATCH] acpi: video: improve quirk check

2013-08-06 Thread Aaron Lu
On 08/04/2013 10:19 PM, Felipe Contreras wrote: > On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki wrote: >> On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: > >>> Personally I think there are better ways to fix the code for the >>> synthetic case than what you patch does, which

Re: [PATCH] acpi: video: improve quirk check

2013-08-06 Thread Aaron Lu
On 08/04/2013 10:19 PM, Felipe Contreras wrote: On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: Personally I think there are better ways to fix the code for the synthetic case than what you patch does, which

Re: [PATCH] acpi: video: improve quirk check

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 9:04 AM, Rafael J. Wysocki wrote: >> In my machine I think the issue is slightly different, I think _BCM is >> failing, at least until enabling the _DOS thing, but at the end of the >> day it's the same thing for the check; _BQC is always returning the >> same value, and

Re: [PATCH] acpi: video: improve quirk check

2013-08-05 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 09:19:56 AM Felipe Contreras wrote: > On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki wrote: > > On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: > > >> Personally I think there are better ways to fix the code for the > >> synthetic case than what you

Re: [PATCH] acpi: video: improve quirk check

2013-08-05 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 09:19:56 AM Felipe Contreras wrote: On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: Personally I think there are better ways to fix the code for the synthetic case than what you

Re: [PATCH] acpi: video: improve quirk check

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 9:04 AM, Rafael J. Wysocki r...@sisk.pl wrote: In my machine I think the issue is slightly different, I think _BCM is failing, at least until enabling the _DOS thing, but at the end of the day it's the same thing for the check; _BQC is always returning the same value,

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki wrote: > On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: >> Personally I think there are better ways to fix the code for the >> synthetic case than what you patch does, which will also make _BQC >> work. That can be discussed later

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 9:14 AM, Rafael J. Wysocki wrote: > On Sunday, August 04, 2013 01:54:21 AM Felipe Contreras wrote: >> But we cannot achieve either of those for v3.11, the only >> possibilities seem to be either a) revert efaa14c, or b) keep it and >> apply my patch. Anything else doesn't

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 8:18 PM, Aaron Lu wrote: > > On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: > >> On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: > >>> On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: > On

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 01:54:21 AM Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 8:47 PM, Aaron Lu wrote: > > On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras > > wrote: > >> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: > > >>> Do we still need to revert commit efaa14c if

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 8:47 PM, Aaron Lu wrote: > On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras > wrote: >> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: >>> Do we still need to revert commit efaa14c if this patch is applied? >> >> I guess not. At least in this machine changing

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 8:18 PM, Aaron Lu wrote: > On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: >> On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >>> On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: > If the _BCL

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 8:18 PM, Aaron Lu aaron@gmail.com wrote: On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 8:47 PM, Aaron Lu aaron@gmail.com wrote: On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote: Do we still need to revert commit efaa14c if this patch is applied? I

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 01:54:21 AM Felipe Contreras wrote: On Sat, Aug 3, 2013 at 8:47 PM, Aaron Lu aaron@gmail.com wrote: On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote: Do

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: On Sat, Aug 3, 2013 at 8:18 PM, Aaron Lu aaron@gmail.com wrote: On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: On

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 9:14 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Sunday, August 04, 2013 01:54:21 AM Felipe Contreras wrote: But we cannot achieve either of those for v3.11, the only possibilities seem to be either a) revert efaa14c, or b) keep it and apply my patch. Anything else

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: Personally I think there are better ways to fix the code for the synthetic case than what you patch does, which will also make _BQC work. That can be discussed

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: >> On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: >>> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: >>> > On Saturday, August 03, 2013 04:14:04 PM

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >> On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: >>> On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is descending, the first level (br->levels[2])

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 5:38 PM, Rafael J. Wysocki wrote: > On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote: >> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: >> > On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: >> >> On Sat, Aug 3, 2013 at 6:34 AM,

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: > > On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: > >> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: > >> > On Saturday, August 03, 2013

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: > On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: >> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: >> > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >> >> >> Yes, the patch is correct, but I still

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: > > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: > > >> Yes, the patch is correct, but I still prefer my own version :-) > >>

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >> Yes, the patch is correct, but I still prefer my own version :-) >> https://github.com/aaronlu/linux/commit/0a3d2c5b59caf80ae5bb1ca1fda0f7bf448b38c9 >> >> In case you want to

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: > On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: > >> If the _BCL package is descending, the first level (br->levels[2]) will > >> be 0, and if the number of levels matches

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: >> If the _BCL package is descending, the first level (br->levels[2]) will >> be 0, and if the number of levels matches the number of steps, we might >> confuse a returned level to

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is descending, the first level (br-levels[2]) will be 0, and if the number of levels matches the number of steps, we might confuse a returned level to mean the

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is descending, the first level (br-levels[2]) will be 0, and if the number of levels matches the

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: Yes, the patch is correct, but I still prefer my own version :-) https://github.com/aaronlu/linux/commit/0a3d2c5b59caf80ae5bb1ca1fda0f7bf448b38c9 In case you want to

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: Yes, the patch is correct, but I still prefer my own version :-)

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: Yes, the patch is correct,

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote: On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 5:38 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote: On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: On Sat, Aug 3, 2013 at

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is descending, the first level (br-levels[2]) will be

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki r...@sisk.pl wrote: On

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 8:19 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 08:07:37 PM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki wrote: >> > On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: >> >> On Fri, Aug 2, 2013 at 6:47 PM, Rafael

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 08:07:37 PM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: > >> On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote: > >> > On Friday, August 02, 2013 02:37:09 PM

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote: >> > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: >> >> If the _BCL package is descending, the

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: > >> If the _BCL package is descending, the first level (br->levels[2]) will > >> be 0, and if the number of

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: >> If the _BCL package is descending, the first level (br->levels[2]) will >> be 0, and if the number of levels matches the number of steps, we might >> confuse a returned

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: > If the _BCL package is descending, the first level (br->levels[2]) will > be 0, and if the number of levels matches the number of steps, we might > confuse a returned level to mean the index. > > For example: > > current_level =

[PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
If the _BCL package is descending, the first level (br->levels[2]) will be 0, and if the number of levels matches the number of steps, we might confuse a returned level to mean the index. For example: current_level = max_level = 100 test_level = 0 returned level = 100 In this case 100

[PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
If the _BCL package is descending, the first level (br-levels[2]) will be 0, and if the number of levels matches the number of steps, we might confuse a returned level to mean the index. For example: current_level = max_level = 100 test_level = 0 returned level = 100 In this case 100

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is descending, the first level (br-levels[2]) will be 0, and if the number of levels matches the number of steps, we might confuse a returned level to mean the index. For example: current_level =

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is descending, the first level (br-levels[2]) will be 0, and if the number of levels matches the number of steps, we might confuse a returned

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is descending, the first level (br-levels[2]) will be 0, and if the number

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 08:07:37 PM Felipe Contreras wrote: On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Friday, August 02,

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 8:19 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Friday, August 02, 2013 08:07:37 PM Felipe Contreras wrote: On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: On Fri, Aug 2, 2013 at