Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer

2014-11-05 Thread Gu Zheng
Hi Andrew, On 11/06/2014 05:00 AM, Andrew Morton wrote: > On Wed, 5 Nov 2014 09:56:20 -0500 Benjamin LaHaise wrote: > >> On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote: >>> ping... >> >> I need someone a bit more familiar with this area of code to chime in on >> reviewing this.

Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer

2014-11-05 Thread Andrew Morton
On Wed, 5 Nov 2014 09:56:20 -0500 Benjamin LaHaise wrote: > On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote: > > ping... > > I need someone a bit more familiar with this area of code to chime in on > reviewing this. Andrew, can you provide any feedback on this fix? That looks like a

Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer

2014-11-05 Thread Benjamin LaHaise
On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote: > ping... I need someone a bit more familiar with this area of code to chime in on reviewing this. Andrew, can you provide any feedback on this fix? -ben > On 10/31/2014 06:07 PM, Gu Zheng wrote: > > >

Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer

2014-11-05 Thread Gu Zheng
ping... On 10/31/2014 06:07 PM, Gu Zheng wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=86831 > > Markus reported that when shutting down mysqld (with AIO support, > on a ext3 formatted Harddrive) leads to a negative number of dirty pages > (underrun to the counter). The negative number

Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer

2014-11-05 Thread Gu Zheng
ping... On 10/31/2014 06:07 PM, Gu Zheng wrote: https://bugzilla.kernel.org/show_bug.cgi?id=86831 Markus reported that when shutting down mysqld (with AIO support, on a ext3 formatted Harddrive) leads to a negative number of dirty pages (underrun to the counter). The negative number

Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer

2014-11-05 Thread Benjamin LaHaise
On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote: ping... I need someone a bit more familiar with this area of code to chime in on reviewing this. Andrew, can you provide any feedback on this fix? -ben On 10/31/2014 06:07 PM, Gu Zheng wrote:

Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer

2014-11-05 Thread Andrew Morton
On Wed, 5 Nov 2014 09:56:20 -0500 Benjamin LaHaise b...@kvack.org wrote: On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote: ping... I need someone a bit more familiar with this area of code to chime in on reviewing this. Andrew, can you provide any feedback on this fix? That

Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer

2014-11-05 Thread Gu Zheng
Hi Andrew, On 11/06/2014 05:00 AM, Andrew Morton wrote: On Wed, 5 Nov 2014 09:56:20 -0500 Benjamin LaHaise b...@kvack.org wrote: On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote: ping... I need someone a bit more familiar with this area of code to chime in on reviewing this.