Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Joel Becker
Acked-by: Joel Becker On Thu, Jul 30, 2015 at 03:59:57PM -0700, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > With well over 200+ users of this api, there are a mere 12 users that > actually cheked the return value of this function. And all of them > really didn't do anything with

Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Alexandre Belloni
Hi, On 30/07/2015 at 15:59:57 -0700, Greg Kroah-Hartman wrote : > From: Greg Kroah-Hartman > > With well over 200+ users of this api, there are a mere 12 users that > actually cheked the return value of this function. And all of them ^ small typo here > really didn't do anything

Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Alessandro Zummo
On Thu, 30 Jul 2015 15:59:57 -0700 Greg Kroah-Hartman wrote: > If the different subsystem maintainers want to give me an ack for this, > I'd appreciate it. I'd like to just take the single patch in through > the char-misc tree in one piece. RTC Acked-by: Alessandro Zummo -- Best

Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Alexandre Belloni
Hi, On 30/07/2015 at 15:59:57 -0700, Greg Kroah-Hartman wrote : From: Greg Kroah-Hartman gre...@linuxfoundation.org With well over 200+ users of this api, there are a mere 12 users that actually cheked the return value of this function. And all of them ^ small typo here

Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Joel Becker
Acked-by: Joel Becker jl...@evilplan.org On Thu, Jul 30, 2015 at 03:59:57PM -0700, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org With well over 200+ users of this api, there are a mere 12 users that actually cheked the return value of this function. And all

Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Alessandro Zummo
On Thu, 30 Jul 2015 15:59:57 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: If the different subsystem maintainers want to give me an ack for this, I'd appreciate it. I'd like to just take the single patch in through the char-misc tree in one piece. RTC Acked-by: Alessandro

[PATCH] char: make misc_deregister a void function

2015-07-30 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman With well over 200+ users of this api, there are a mere 12 users that actually cheked the return value of this function. And all of them really didn't do anything with that information as the system or module was shutting down no matter what. So stop pretending like it

[PATCH] char: make misc_deregister a void function

2015-07-30 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org With well over 200+ users of this api, there are a mere 12 users that actually cheked the return value of this function. And all of them really didn't do anything with that information as the system or module was shutting down no matter what.