Re: [PATCH] component: add debugfs support

2017-11-15 Thread Russell King - ARM Linux
On Wed, Nov 15, 2017 at 12:04:26PM +0100, Maciej Purski wrote: > +static void component_master_debugfs_add(struct master *m); > +static void component_master_debugfs_del(struct master *m); Please avoid forward declarations. > +static int component_devices_show(struct seq_file *s, void *data) >

Re: [PATCH] component: add debugfs support

2017-11-15 Thread Russell King - ARM Linux
On Wed, Nov 15, 2017 at 12:04:26PM +0100, Maciej Purski wrote: > +static void component_master_debugfs_add(struct master *m); > +static void component_master_debugfs_del(struct master *m); Please avoid forward declarations. > +static int component_devices_show(struct seq_file *s, void *data) >

[PATCH] component: add debugfs support

2017-11-15 Thread Maciej Purski
Add 'component' directory to debugfs. Create a new file for each master, when a master is added. Remove it on a master deletion. Show a list of devices matched with master and indicate if master's components were successfully added and if the whole master is bound. Signed-off-by: Maciej Purski

[PATCH] component: add debugfs support

2017-11-15 Thread Maciej Purski
Add 'component' directory to debugfs. Create a new file for each master, when a master is added. Remove it on a master deletion. Show a list of devices matched with master and indicate if master's components were successfully added and if the whole master is bound. Signed-off-by: Maciej Purski