Re: [PATCH] configfs: export config_group_find_obj

2005-08-19 Thread Joel Becker
On Thu, Aug 18, 2005 at 02:20:23PM -0700, Joel Becker wrote: > On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote: > > On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: > > > In the dlm I use config_group_find_obj() which isn't exported. > > > > Did you notice the /*

Re: [PATCH] configfs: export config_group_find_obj

2005-08-19 Thread Joel Becker
On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote: > On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: > > In the dlm I use config_group_find_obj() which isn't exported. > > Did you notice the /* XXX Locking */? Let me go see how you use > it, if it is the best way,

Re: [PATCH] configfs: export config_group_find_obj

2005-08-19 Thread Joel Becker
On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: > In the dlm I use config_group_find_obj() which isn't exported. Did you notice the /* XXX Locking */? Let me go see how you use it, if it is the best way, we'll need to revisit the function and be sure it's happy. Joel >

Re: [PATCH] configfs: export config_group_find_obj

2005-08-19 Thread Joel Becker
On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: In the dlm I use config_group_find_obj() which isn't exported. Did you notice the /* XXX Locking */? Let me go see how you use it, if it is the best way, we'll need to revisit the function and be sure it's happy. Joel

Re: [PATCH] configfs: export config_group_find_obj

2005-08-19 Thread Joel Becker
On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote: On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: In the dlm I use config_group_find_obj() which isn't exported. Did you notice the /* XXX Locking */? Let me go see how you use it, if it is the best way, we'll

Re: [PATCH] configfs: export config_group_find_obj

2005-08-19 Thread Joel Becker
On Thu, Aug 18, 2005 at 02:20:23PM -0700, Joel Becker wrote: On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote: On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: In the dlm I use config_group_find_obj() which isn't exported. Did you notice the /* XXX Locking

[PATCH] configfs: export config_group_find_obj

2005-08-18 Thread David Teigland
In the dlm I use config_group_find_obj() which isn't exported. Signed-off-by: David Teigland <[EMAIL PROTECTED]> diff -urpN a/fs/configfs/item.c b/fs/configfs/item.c --- a/fs/configfs/item.c2005-08-17 17:19:23.0 +0800 +++ b/fs/configfs/item.c2005-08-18 14:15:51.681973168

[PATCH] configfs: export config_group_find_obj

2005-08-18 Thread David Teigland
In the dlm I use config_group_find_obj() which isn't exported. Signed-off-by: David Teigland [EMAIL PROTECTED] diff -urpN a/fs/configfs/item.c b/fs/configfs/item.c --- a/fs/configfs/item.c2005-08-17 17:19:23.0 +0800 +++ b/fs/configfs/item.c2005-08-18 14:15:51.681973168