Re: [PATCH] drm/tegra: dpaux: Modify error handling

2016-08-13 Thread Julia Lawall
On Sat, 13 Aug 2016, Amitoj Kaur Chawla wrote: > devm_pinctrl_register returns an ERR_PTR in case of error and should > have an IS_ERR check instead of a null check. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > expression e; > @@ > > e =

Re: [PATCH] drm/tegra: dpaux: Modify error handling

2016-08-13 Thread Julia Lawall
On Sat, 13 Aug 2016, Amitoj Kaur Chawla wrote: > devm_pinctrl_register returns an ERR_PTR in case of error and should > have an IS_ERR check instead of a null check. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > expression e; > @@ > > e =

[PATCH] drm/tegra: dpaux: Modify error handling

2016-08-12 Thread Amitoj Kaur Chawla
devm_pinctrl_register returns an ERR_PTR in case of error and should have an IS_ERR check instead of a null check. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ e = devm_pinxtrl_register(...); if( -!e +IS_ERR(e) ) { <+... return -

[PATCH] drm/tegra: dpaux: Modify error handling

2016-08-12 Thread Amitoj Kaur Chawla
devm_pinctrl_register returns an ERR_PTR in case of error and should have an IS_ERR check instead of a null check. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ e = devm_pinxtrl_register(...); if( -!e +IS_ERR(e) ) { <+... return -