Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-06-17 Thread Arnd Bergmann
On Fri, Jun 14, 2019 at 4:52 PM Geert Uytterhoeven wrote: > On Mon, Apr 29, 2019 at 2:40 PM Arnd Bergmann wrote: > > On Mon, Apr 29, 2019 at 10:19 AM Geert Uytterhoeven > > This looks correct to me, but there are two points that stick out to me: > > > > - why do you only do this for mmio and not

Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-06-14 Thread Geert Uytterhoeven
Hi Arnd, On Mon, Apr 29, 2019 at 2:40 PM Arnd Bergmann wrote: > On Mon, Apr 29, 2019 at 10:19 AM Geert Uytterhoeven > wrote: > > The generic definitions of mmio_{read,write}{16,32}be() in lib/iomap.c > > assume that the {read,write}[wl]() I/O accessors always use little > > endian accesses, and

Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-06-05 Thread Greg Ungerer
Hi Geert, On 4/6/19 5:34 pm, Geert Uytterhoeven wrote: On Tue, Jun 4, 2019 at 9:18 AM Greg Ungerer wrote: On 3/6/19 10:26 pm, Angelo Dureghello wrote: couldn't seen any follow up on this patch. I tested it and at least for mcf5441x it works properly and solves all issues. Do you think it

Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-06-04 Thread Geert Uytterhoeven
Hi Greg, On Tue, Jun 4, 2019 at 9:18 AM Greg Ungerer wrote: > On 3/6/19 10:26 pm, Angelo Dureghello wrote: > > couldn't seen any follow up on this patch. I tested it and at least > > for mcf5441x it works properly and solves all issues. > > > > Do you think it may be accepted as an initial fix ?

Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-06-04 Thread Greg Ungerer
Hi Angelo, On 3/6/19 10:26 pm, Angelo Dureghello wrote: couldn't seen any follow up on this patch. I tested it and at least for mcf5441x it works properly and solves all issues. Do you think it may be accepted as an initial fix ? I'll add it to the m68knommu git tree. Seeing as you wrote it

Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-06-03 Thread Angelo Dureghello
Hi Greg (and all), couldn't seen any follow up on this patch. I tested it and at least for mcf5441x it works properly and solves all issues. Do you think it may be accepted as an initial fix ? Regards, Angelo On Mon, Apr 29, 2019 at 10:19:37AM +0200, Geert Uytterhoeven wrote: > The generic

Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-05-11 Thread Angelo Dureghello
Hi, On Mon, Apr 29, 2019 at 02:39:47PM +0200, Arnd Bergmann wrote: > On Mon, Apr 29, 2019 at 10:19 AM Geert Uytterhoeven > wrote: > > > > The generic definitions of mmio_{read,write}{16,32}be() in lib/iomap.c > > assume that the {read,write}[wl]() I/O accessors always use little > > endian

Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-04-29 Thread Arnd Bergmann
On Mon, Apr 29, 2019 at 10:19 AM Geert Uytterhoeven wrote: > > The generic definitions of mmio_{read,write}{16,32}be() in lib/iomap.c > assume that the {read,write}[wl]() I/O accessors always use little > endian accesses, and swap the result. > > However, the Coldfire versions of the

[PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-04-29 Thread Geert Uytterhoeven
The generic definitions of mmio_{read,write}{16,32}be() in lib/iomap.c assume that the {read,write}[wl]() I/O accessors always use little endian accesses, and swap the result. However, the Coldfire versions of the {read,write}[wl]() I/O accessors are special, in that they use native big endian