RE: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-18 Thread Joakim Zhang
Hi Sean, > -Original Message- > From: Sean Young > Sent: 2020年9月18日 16:24 > To: Joakim Zhang > Cc: mche...@kernel.org; linux-me...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpu

Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-18 Thread Sean Young
l.org; dl-linux-imx > > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle > > system -snip- > > > Autosuspend delay should be fixed value, should be set to gpio device > > > timeout > > value, which is 125ms. > > > >

RE: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-17 Thread Joakim Zhang
Hi Sean, > -Original Message- > From: Sean Young > Sent: 2020年9月18日 4:44 > To: Joakim Zhang > Cc: mche...@kernel.org; linux-me...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpu

Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-17 Thread Sean Young
r.kernel.org; dl-linux-imx > > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle > > system > > > > > > [...] > > > @@ -92,6 +113,12 @@ static int gpio_ir_recv_probe(struct > > > platform_device *pdev) > > > > >

RE: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-17 Thread Joakim Zhang
> -Original Message- > From: Sean Young > Sent: 2020年9月15日 17:34 > To: Joakim Zhang > Cc: mche...@kernel.org; linux-me...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support

Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-16 Thread Sean Young
Hi Joakim, On Wed, Sep 16, 2020 at 10:22:11AM +, Joakim Zhang wrote: > > Hi Sean, > > Thanks for your hint, I will send a V2 soon according to your suggestions. > > We also have a concern, since you are a IR expert, may you can give us > answers. With this patch, the first frame once

RE: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-16 Thread Joakim Zhang
Joakim Zhang > Cc: mche...@kernel.org; linux-me...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle > system > > Hi Joakim, > > On Tue, Sep 15, 2020 at 10:55:17AM +, Joakim Zhang wr

Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-15 Thread Sean Young
l.org; linux-me...@vger.kernel.org; > > linux-kernel@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle > > system > > > > > > Hi Joakim, > > > > Thanks for your patch, I think it looks good i

RE: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-15 Thread Joakim Zhang
Hi Sean, Thanks a lot for your review. > -Original Message- > From: Sean Young > Sent: 2020年9月15日 17:34 > To: Joakim Zhang > Cc: mche...@kernel.org; linux-me...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH] media: rc:

Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-15 Thread Andy Shevchenko
On Tue, Sep 15, 2020 at 11:06 AM Joakim Zhang wrote: > From: Andy Shevchenko > Sent: 2020年9月15日 15:18 > To: Joakim Zhang > Cc: s...@mess.org; mche...@kernel.org; linux-me...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH] media: rc: gpi

Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-15 Thread Sean Young
Hi Joakim, Thanks for your patch, I think it looks good in principle but needs a few small fixes. On Tue, Sep 15, 2020 at 11:02:02PM +0800, Joakim Zhang wrote: > GPIO IR receive is much rely on interrupt response, uneven interrupt > latency will lead to incorrect timing, so the decoder fails

[PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-15 Thread Joakim Zhang
GPIO IR receive is much rely on interrupt response, uneven interrupt latency will lead to incorrect timing, so the decoder fails to decode it. The issue is particularly acute on systems which supports cpuidle, dynamically disable and enable cpuidle can solve this problem to a great extent.

Recall: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-15 Thread Joakim Zhang
Joakim Zhang would like to recall the message, "[PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system".

[PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system

2020-09-15 Thread Joakim Zhang
GPIO IR receive is much rely on interrupt response, uneven interrupt latency will lead to incorrect timing, so the decoder fails to decode it. The issue is particularly acute on systems which supports cpuidle, dynamically disable and enable cpuidle can solve this problem to a great extent.