Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Lukasz Luba
On 5/12/20 10:05 AM, Krzysztof Kozlowski wrote: On Tue, 12 May 2020 at 10:47, Lukasz Luba wrote: Hi Krzysztof, I am sorry, I was a bit busy recently. On 5/12/20 7:50 AM, Krzysztof Kozlowski wrote: On Fri, May 08, 2020 at 06:13:38AM -0700, Bernard Zhao wrote: Maybe dmc->df->lock is

Re:Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Bernard
: Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area>On Tue, 12 May 2020 at 10:47, Lukasz Luba wrote: >> >> Hi Krzysztof, >> >> I am sorry, I was a bit busy recently. >> >> On 5/12/20 7:50 AM, Krzysztof Kozlowski wrote: >> > On Fri, May 08, 202

Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Krzysztof Kozlowski
On Tue, 12 May 2020 at 10:47, Lukasz Luba wrote: > > Hi Krzysztof, > > I am sorry, I was a bit busy recently. > > On 5/12/20 7:50 AM, Krzysztof Kozlowski wrote: > > On Fri, May 08, 2020 at 06:13:38AM -0700, Bernard Zhao wrote: > >> Maybe dmc->df->lock is unnecessary to protect function > >>

Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Lukasz Luba
Hi Krzysztof, I am sorry, I was a bit busy recently. On 5/12/20 7:50 AM, Krzysztof Kozlowski wrote: On Fri, May 08, 2020 at 06:13:38AM -0700, Bernard Zhao wrote: Maybe dmc->df->lock is unnecessary to protect function exynos5_dmc_perf_events_check(dmc). If we have to protect, dmc->lock is more

Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Krzysztof Kozlowski
On Fri, May 08, 2020 at 06:13:38AM -0700, Bernard Zhao wrote: > Maybe dmc->df->lock is unnecessary to protect function > exynos5_dmc_perf_events_check(dmc). If we have to protect, > dmc->lock is more better and more effective. > Also, it seems not needed to protect "if (ret) & dev_warn" > branch.

Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area

2020-05-08 Thread Markus Elfring
> Maybe dmc->df->lock is unnecessary to protect function > exynos5_dmc_perf_events_check(dmc). If we have to protect, > dmc->lock is more better and more effective. > Also, it seems not needed to protect "if (ret) & dev_warn" > branch. I suggest to improve also this commit message. * Please

[PATCH] memory/samsung: reduce unnecessary mutex lock area

2020-05-08 Thread Bernard Zhao
Maybe dmc->df->lock is unnecessary to protect function exynos5_dmc_perf_events_check(dmc). If we have to protect, dmc->lock is more better and more effective. Also, it seems not needed to protect "if (ret) & dev_warn" branch. Signed-off-by: Bernard Zhao ---