Re: [PATCH] mm: memory: fixed a coding style issue

2018-01-16 Thread Michal Hocko
And now with a response as a bonus... On Tue 16-01-18 10:26:20, Michal Hocko wrote: > [Please do not top post. I also think you didn't intend to drop the CC > list - restored] > > On Tue 16-01-18 03:13:31, Robert Rickett wrote: > > Michal, > > > > Although tiny changes like this are

Re: [PATCH] mm: memory: fixed a coding style issue

2018-01-16 Thread Michal Hocko
And now with a response as a bonus... On Tue 16-01-18 10:26:20, Michal Hocko wrote: > [Please do not top post. I also think you didn't intend to drop the CC > list - restored] > > On Tue 16-01-18 03:13:31, Robert Rickett wrote: > > Michal, > > > > Although tiny changes like this are

Re: [PATCH] mm: memory: fixed a coding style issue

2018-01-16 Thread Michal Hocko
[Please do not top post. I also think you didn't intend to drop the CC list - restored] On Tue 16-01-18 03:13:31, Robert Rickett wrote: > Michal, > > Although tiny changes like this are minuscule, they are relevant to the > big picture. If developers create a tool that informs contributors

Re: [PATCH] mm: memory: fixed a coding style issue

2018-01-16 Thread Michal Hocko
[Please do not top post. I also think you didn't intend to drop the CC list - restored] On Tue 16-01-18 03:13:31, Robert Rickett wrote: > Michal, > > Although tiny changes like this are minuscule, they are relevant to the > big picture. If developers create a tool that informs contributors

Re: [PATCH] mm: memory: fixed a coding style issue

2018-01-15 Thread Michal Hocko
On Mon 15-01-18 19:17:12, Robert Donald Rickett wrote: > This is a patch to the memory.c file that fixes the > "ERROR: code indent should use tabs where possible" > found by the checkpatch.pl tool. Is this really worth it? The code is not any better readable and it just adds a churn to the

Re: [PATCH] mm: memory: fixed a coding style issue

2018-01-15 Thread Michal Hocko
On Mon 15-01-18 19:17:12, Robert Donald Rickett wrote: > This is a patch to the memory.c file that fixes the > "ERROR: code indent should use tabs where possible" > found by the checkpatch.pl tool. Is this really worth it? The code is not any better readable and it just adds a churn to the

[PATCH] mm: memory: fixed a coding style issue

2018-01-15 Thread Robert Donald Rickett
This is a patch to the memory.c file that fixes the "ERROR: code indent should use tabs where possible" found by the checkpatch.pl tool. Signed-off-by: Robert Donald Rickett --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c

[PATCH] mm: memory: fixed a coding style issue

2018-01-15 Thread Robert Donald Rickett
This is a patch to the memory.c file that fixes the "ERROR: code indent should use tabs where possible" found by the checkpatch.pl tool. Signed-off-by: Robert Donald Rickett --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index