Re: [PATCH] net: bpf: add static in net/core/filter.c

2019-10-16 Thread David Miller
From: Ben Dooks Date: Wed, 16 Oct 2019 14:11:52 +0100 > Hmm, your config it does, I get /none/ of these warnings. > > I guess a lot of this is being built whether or not is then used. When you are making changes like this, unless you have done a full grep over the tree and are %100 sure it is

Re: [Linux-kernel] [PATCH] net: bpf: add static in net/core/filter.c

2019-10-16 Thread Ben Dooks
On 16/10/2019 14:11, Ben Dooks wrote: On 16/10/2019 14:10, Daniel Borkmann wrote: On Wed, Oct 16, 2019 at 02:02:31PM +0100, Ben Dooks wrote: On 16/10/2019 13:26, Daniel Borkmann wrote: On Wed, Oct 16, 2019 at 12:04:46PM +0100, Ben Dooks (Codethink) wrote: There are a number of structs in

Re: [PATCH] net: bpf: add static in net/core/filter.c

2019-10-16 Thread Ben Dooks
On 16/10/2019 14:10, Daniel Borkmann wrote: On Wed, Oct 16, 2019 at 02:02:31PM +0100, Ben Dooks wrote: On 16/10/2019 13:26, Daniel Borkmann wrote: On Wed, Oct 16, 2019 at 12:04:46PM +0100, Ben Dooks (Codethink) wrote: There are a number of structs in net/core/filter.c that are not exported or

Re: [PATCH] net: bpf: add static in net/core/filter.c

2019-10-16 Thread Daniel Borkmann
On Wed, Oct 16, 2019 at 02:02:31PM +0100, Ben Dooks wrote: > On 16/10/2019 13:26, Daniel Borkmann wrote: > > On Wed, Oct 16, 2019 at 12:04:46PM +0100, Ben Dooks (Codethink) wrote: > > > There are a number of structs in net/core/filter.c > > > that are not exported or declared outside of the > > >

Re: [PATCH] net: bpf: add static in net/core/filter.c

2019-10-16 Thread Ben Dooks
On 16/10/2019 13:26, Daniel Borkmann wrote: On Wed, Oct 16, 2019 at 12:04:46PM +0100, Ben Dooks (Codethink) wrote: There are a number of structs in net/core/filter.c that are not exported or declared outside of the file. Fix the following warnings by making these all static:

Re: [PATCH] net: bpf: add static in net/core/filter.c

2019-10-16 Thread Daniel Borkmann
On Wed, Oct 16, 2019 at 12:04:46PM +0100, Ben Dooks (Codethink) wrote: > There are a number of structs in net/core/filter.c > that are not exported or declared outside of the > file. Fix the following warnings by making these > all static: > > net/core/filter.c:8465:31: warning: symbol

[PATCH] net: bpf: add static in net/core/filter.c

2019-10-16 Thread Ben Dooks (Codethink)
There are a number of structs in net/core/filter.c that are not exported or declared outside of the file. Fix the following warnings by making these all static: net/core/filter.c:8465:31: warning: symbol 'sk_filter_verifier_ops' was not declared. Should it be static? net/core/filter.c:8472:27: