Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

From: Corentin Labbe Date: Tue, 28 Nov 2017 17:48:22 +0100 > The driver expect "allwinner,leds-active-low" to be in PHY node, but > the binding doc expect it to be in MAC node. > > Since all board DT use it also in MAC node, the driver need to search >

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

From: Corentin Labbe Date: Tue, 28 Nov 2017 17:48:22 +0100 > The driver expect "allwinner,leds-active-low" to be in PHY node, but > the binding doc expect it to be in MAC node. > > Since all board DT use it also in MAC node, the driver need to search > allwinner,leds-active-low in MAC node. >

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 11:46 PM, Andrew Lunn wrote: > Hi ChenYu > >> It worked at one point. During some previous iteration, they lit up as >> they were supposed to. > > For a released version of the kernel? Or during development work? If > they did work, but broken, it would be

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 11:46 PM, Andrew Lunn wrote: > Hi ChenYu > >> It worked at one point. During some previous iteration, they lit up as >> they were supposed to. > > For a released version of the kernel? Or during development work? If > they did work, but broken, it would be good to know

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 04:37:12PM +0100, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > > The driver expect

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 04:37:12PM +0100, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > > The driver expect

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

Hi ChenYu > It worked at one point. During some previous iteration, they lit up as > they were supposed to. For a released version of the kernel? Or during development work? If they did work, but broken, it would be good to know which commit broke it. We can then add a fixes: tag to the patch

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

Hi ChenYu > It worked at one point. During some previous iteration, they lit up as > they were supposed to. For a released version of the kernel? Or during development work? If they did work, but broken, it would be good to know which commit broke it. We can then add a fixes: tag to the patch

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 11:37 PM, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: >> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: >> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: >> > > The driver expect

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 11:37 PM, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: >> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: >> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: >> > > The driver expect

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > > the binding doc expect

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > > the binding doc expect

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > the binding doc expect it to be in MAC node. > > > > Since all board DT use it also in MAC

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > the binding doc expect it to be in MAC node. > > > > Since all board DT use it also in MAC

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > The driver expect "allwinner,leds-active-low" to be in PHY node, but > the binding doc expect it to be in MAC node. > > Since all board DT use it also in MAC node, the driver need to search > allwinner,leds-active-low in MAC node.

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > The driver expect "allwinner,leds-active-low" to be in PHY node, but > the binding doc expect it to be in MAC node. > > Since all board DT use it also in MAC node, the driver need to search > allwinner,leds-active-low in MAC node.

[PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

The driver expect "allwinner,leds-active-low" to be in PHY node, but the binding doc expect it to be in MAC node. Since all board DT use it also in MAC node, the driver need to search allwinner,leds-active-low in MAC node. Signed-off-by: Corentin Labbe ---

[PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

The driver expect "allwinner,leds-active-low" to be in PHY node, but the binding doc expect it to be in MAC node. Since all board DT use it also in MAC node, the driver need to search allwinner,leds-active-low in MAC node. Signed-off-by: Corentin Labbe ---