Re: [PATCH] pata_acpi: take two

2007-02-09 Thread Alan
> > +#if defined(CONFIG_ATA_ACPI) > > + /* Prefer the ACPI driver for Nvidia hardware */ > > + if (pdev->vendor == PCI_VENDOR_ID_NVIDIA && ata_pata_acpi_present(pdev)) > > + return -ENODEV; > > +#endif > > /* Check for AMD7411 */ > > if (type == 3) > >

Re: [PATCH] pata_acpi: take two

2007-02-09 Thread Alan
On Wed, 7 Feb 2007 16:30:26 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 7 Feb 2007 17:22:20 + > Alan <[EMAIL PROTECTED]> wrote: > > > This is a driver for motherboard SFF style PATA ports that have ACPI > > control methods. > > It needs some work against the current libata tree

Re: [PATCH] pata_acpi: take two

2007-02-07 Thread Robert Hancock
Alan wrote: --- linux.vanilla-2.6.20-rc6-mm3/drivers/ata/pata_amd.c 2007-01-31 14:20:10.0 + +++ linux-2.6.20-rc6-mm3/drivers/ata/pata_amd.c 2007-02-06 17:04:19.0 + @@ -642,6 +642,11 @@ if (type == 1 && rev > 0x7) type = 2; +#if defined(CONFIG_AT

Re: [PATCH] pata_acpi: take two

2007-02-07 Thread Andrew Morton
On Wed, 7 Feb 2007 17:22:20 + Alan <[EMAIL PROTECTED]> wrote: > This is a driver for motherboard SFF style PATA ports that have ACPI > control methods. It needs some work against the current libata tree. drivers/ata/pata_acpi.c: In function 'pacpi_port_start': drivers/ata/pata_acpi.c:259:

Re: [PATCH] pata_acpi: take two

2007-02-07 Thread Mariusz Kozlowski
Hello, Just asking ... in: > +static void *ata_pata_find_handle(struct device *dev, int port) ... > + chan_handle = acpi_get_child(handle, port); > + if (chan_handle == NULL) > + return NULL; > + return chan_handle; > +} why not simply: return a

[PATCH] pata_acpi: take two

2007-02-07 Thread Alan
This is a driver for motherboard SFF style PATA ports that have ACPI control methods. In theory it provides support for just about any motherboard PATA controller with ACPI methods. I've tested it on a few controllers and it seems to work fine after a couple of bug fixes from the original. It also