Re: [PATCH] perf/core: clear sibling list of detached events (was "Re: [PATCH] perf: Fix sibling iteration")

2018-03-16 Thread Peter Zijlstra
On Fri, Mar 16, 2018 at 01:17:41PM +, Mark Rutland wrote: > I've given this 50 boots with the 0day scripts, and no explosions so far > (with 5 boots where a leader had an empty group_node). I've been running this for almost 2 hours now, and no splats either. I'll let it run for another few

Re: [PATCH] perf/core: clear sibling list of detached events (was "Re: [PATCH] perf: Fix sibling iteration")

2018-03-16 Thread Peter Zijlstra
On Fri, Mar 16, 2018 at 01:17:41PM +, Mark Rutland wrote: > I've given this 50 boots with the 0day scripts, and no explosions so far > (with 5 boots where a leader had an empty group_node). I've been running this for almost 2 hours now, and no splats either. I'll let it run for another few

[PATCH] perf/core: clear sibling list of detached events (was "Re: [PATCH] perf: Fix sibling iteration")

2018-03-16 Thread Mark Rutland
On Fri, Mar 16, 2018 at 11:50:17AM +0100, Peter Zijlstra wrote: > On Fri, Mar 16, 2018 at 11:39:46AM +0100, Jiri Olsa wrote: > > On Fri, Mar 16, 2018 at 11:31:29AM +0100, Peter Zijlstra wrote: > > > There is at least one more known issue with that patch, but neither Mark > > > nor me could

[PATCH] perf/core: clear sibling list of detached events (was "Re: [PATCH] perf: Fix sibling iteration")

2018-03-16 Thread Mark Rutland
On Fri, Mar 16, 2018 at 11:50:17AM +0100, Peter Zijlstra wrote: > On Fri, Mar 16, 2018 at 11:39:46AM +0100, Jiri Olsa wrote: > > On Fri, Mar 16, 2018 at 11:31:29AM +0100, Peter Zijlstra wrote: > > > There is at least one more known issue with that patch, but neither Mark > > > nor me could

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Mark Rutland
On Fri, Mar 16, 2018 at 11:50:17AM +0100, Peter Zijlstra wrote: > On Fri, Mar 16, 2018 at 11:39:46AM +0100, Jiri Olsa wrote: > > On Fri, Mar 16, 2018 at 11:31:29AM +0100, Peter Zijlstra wrote: > > > There is at least one more known issue with that patch, but neither Mark > > > nor me could

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Mark Rutland
On Fri, Mar 16, 2018 at 11:50:17AM +0100, Peter Zijlstra wrote: > On Fri, Mar 16, 2018 at 11:39:46AM +0100, Jiri Olsa wrote: > > On Fri, Mar 16, 2018 at 11:31:29AM +0100, Peter Zijlstra wrote: > > > There is at least one more known issue with that patch, but neither Mark > > > nor me could

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Alexey Budankov
On 16.03.2018 13:31, Peter Zijlstra wrote: > On Fri, Mar 16, 2018 at 12:59:34PM +0300, Alexey Budankov wrote: >> Hi, >> On 15.03.2018 20:01, Peter Zijlstra wrote: >>> Subject: perf: Fix sibling iteration >>> From: Peter Zijlstra >>> Date: Thu Mar 15 17:36:56 CET 2018 >>> >>>

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Alexey Budankov
On 16.03.2018 13:31, Peter Zijlstra wrote: > On Fri, Mar 16, 2018 at 12:59:34PM +0300, Alexey Budankov wrote: >> Hi, >> On 15.03.2018 20:01, Peter Zijlstra wrote: >>> Subject: perf: Fix sibling iteration >>> From: Peter Zijlstra >>> Date: Thu Mar 15 17:36:56 CET 2018 >>> >>> Mark noticed that the

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Jiri Olsa
On Fri, Mar 16, 2018 at 11:31:29AM +0100, Peter Zijlstra wrote: > On Fri, Mar 16, 2018 at 12:59:34PM +0300, Alexey Budankov wrote: > > Hi, > > On 15.03.2018 20:01, Peter Zijlstra wrote: > > > Subject: perf: Fix sibling iteration > > > From: Peter Zijlstra > > > Date: Thu Mar

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Jiri Olsa
On Fri, Mar 16, 2018 at 11:31:29AM +0100, Peter Zijlstra wrote: > On Fri, Mar 16, 2018 at 12:59:34PM +0300, Alexey Budankov wrote: > > Hi, > > On 15.03.2018 20:01, Peter Zijlstra wrote: > > > Subject: perf: Fix sibling iteration > > > From: Peter Zijlstra > > > Date: Thu Mar 15 17:36:56 CET 2018

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Peter Zijlstra
On Fri, Mar 16, 2018 at 12:59:34PM +0300, Alexey Budankov wrote: > Hi, > On 15.03.2018 20:01, Peter Zijlstra wrote: > > Subject: perf: Fix sibling iteration > > From: Peter Zijlstra > > Date: Thu Mar 15 17:36:56 CET 2018 > > > > Mark noticed that the change to sibling_list

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Peter Zijlstra
On Fri, Mar 16, 2018 at 12:59:34PM +0300, Alexey Budankov wrote: > Hi, > On 15.03.2018 20:01, Peter Zijlstra wrote: > > Subject: perf: Fix sibling iteration > > From: Peter Zijlstra > > Date: Thu Mar 15 17:36:56 CET 2018 > > > > Mark noticed that the change to sibling_list changed some iteration

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Alexey Budankov
Hi, On 15.03.2018 20:01, Peter Zijlstra wrote: > Subject: perf: Fix sibling iteration > From: Peter Zijlstra > Date: Thu Mar 15 17:36:56 CET 2018 > > Mark noticed that the change to sibling_list changed some iteration > semantics; because previously we used group_list as

Re: [PATCH] perf: Fix sibling iteration

2018-03-16 Thread Alexey Budankov
Hi, On 15.03.2018 20:01, Peter Zijlstra wrote: > Subject: perf: Fix sibling iteration > From: Peter Zijlstra > Date: Thu Mar 15 17:36:56 CET 2018 > > Mark noticed that the change to sibling_list changed some iteration > semantics; because previously we used group_list as list entry, > sibling

[PATCH] perf: Fix sibling iteration

2018-03-15 Thread Peter Zijlstra
Subject: perf: Fix sibling iteration From: Peter Zijlstra Date: Thu Mar 15 17:36:56 CET 2018 Mark noticed that the change to sibling_list changed some iteration semantics; because previously we used group_list as list entry, sibling events would always have an empty

[PATCH] perf: Fix sibling iteration

2018-03-15 Thread Peter Zijlstra
Subject: perf: Fix sibling iteration From: Peter Zijlstra Date: Thu Mar 15 17:36:56 CET 2018 Mark noticed that the change to sibling_list changed some iteration semantics; because previously we used group_list as list entry, sibling events would always have an empty sibling_list. But because we