On Mon, Jul 07, 2014 at 11:07:41PM +0200, Jiri Olsa wrote:
> yea, I meant it compiled for me ;-) I haven't reviewd the patch much,
> one thing I remember is that it should be separated into smaller changes..
This is because I created tools/lib/util/util.[ch] for the stuff which
ctype.* needs. I
On Mon, Jul 07, 2014 at 05:47:52PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov escreveu:
> > On Thu, Jun 26, 2014 at 02:14:33PM +0200, Jiri Olsa wrote:
> > > this one compiles ok for me
>
> > Ok, cool. So guys, can we apply this one so that
On Mon, Jul 07, 2014 at 05:47:52PM -0300, Arnaldo Carvalho de Melo wrote:
> I'll try to fix this up later today, if you haven't done it by then.
I won't because it is too late here for me to have a functioning brain
still, but don't bother - I'll take care of it tomorrow.
Thanks.
--
Em Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov escreveu:
> On Thu, Jun 26, 2014 at 02:14:33PM +0200, Jiri Olsa wrote:
> > this one compiles ok for me
> Ok, cool. So guys, can we apply this one so that I can continue with the
> next round?
Sorry, but not yet, tried to build it (the
Em Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov escreveu:
On Thu, Jun 26, 2014 at 02:14:33PM +0200, Jiri Olsa wrote:
this one compiles ok for me
Ok, cool. So guys, can we apply this one so that I can continue with the
next round?
Sorry, but not yet, tried to build it (the version
On Mon, Jul 07, 2014 at 05:47:52PM -0300, Arnaldo Carvalho de Melo wrote:
I'll try to fix this up later today, if you haven't done it by then.
I won't because it is too late here for me to have a functioning brain
still, but don't bother - I'll take care of it tomorrow.
Thanks.
--
On Mon, Jul 07, 2014 at 05:47:52PM -0300, Arnaldo Carvalho de Melo wrote:
Em Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov escreveu:
On Thu, Jun 26, 2014 at 02:14:33PM +0200, Jiri Olsa wrote:
this one compiles ok for me
Ok, cool. So guys, can we apply this one so that I can
On Mon, Jul 07, 2014 at 11:07:41PM +0200, Jiri Olsa wrote:
yea, I meant it compiled for me ;-) I haven't reviewd the patch much,
one thing I remember is that it should be separated into smaller changes..
This is because I created tools/lib/util/util.[ch] for the stuff which
ctype.* needs. I
On Mon, Jun 30, 2014 at 04:28:14PM -0300, Arnaldo Carvalho de Melo wrote:
> Yes, I think we should continue moving stuff out of tools/perf/ and
> into a place that can be shared with other tools/ living codebases.
>
> Doing so will of course help tools that live elsewhere, outside the
> kernel
Em Mon, Jun 30, 2014 at 05:18:02PM +0200, Borislav Petkov escreveu:
> On Mon, Jun 30, 2014 at 11:58:31AM -0300, Arnaldo Carvalho de Melo wrote:
> > Yeap, guess its the most sensible to do given how things went so far.
> >
> > Please submit patches when you fix things on code copied from
> >
On Mon, Jun 30, 2014 at 11:58:31AM -0300, Arnaldo Carvalho de Melo wrote:
> Yeap, guess its the most sensible to do given how things went so far.
>
> Please submit patches when you fix things on code copied from
> tools/perf/ and generally when improving it.
Sure.
Btw, should I still be working
Em Mon, Jun 30, 2014 at 04:50:31PM +0200, Robert Richter escreveu:
> On 30.06.14 12:01:15, Borislav Petkov wrote:
> > Well, do you have it as a standalong program? If so, you can put it in
> > a repo somewhere and we can start hacking away and playing with it. If
> > not, we will have to copy the
On 30.06.14 12:01:15, Borislav Petkov wrote:
> Well, do you have it as a standalong program? If so, you can put it in
> a repo somewhere and we can start hacking away and playing with it. If
> not, we will have to copy the perf code *into* the RAS daemon first so
> that we can have a separate
On Mon, Jun 30, 2014 at 11:39:39AM +0200, Jean Pihet wrote:
> That makes perfect sense since:
> - we need the RAS daemon implementation soon (not just before the
> final blackdown ;-),
Yeah :-)
> - for other tools to exist (like RAS daemon) we need to split out the
> perf code in small units.
Hi Boris,
-- added Fu Wei in the loop --
On 30 June 2014 09:07, Borislav Petkov wrote:
> On Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov wrote:
>> Ok, cool. So guys, can we apply this one so that I can continue with the
>> next round?
>
> Ok, I had this crazy idea recently:
>
> How
On Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov wrote:
> Ok, cool. So guys, can we apply this one so that I can continue with the
> next round?
Ok, I had this crazy idea recently:
How about we copy the perf tool code we need for the RAS daemon and
start hacking on it in a separate
On Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov wrote:
Ok, cool. So guys, can we apply this one so that I can continue with the
next round?
Ok, I had this crazy idea recently:
How about we copy the perf tool code we need for the RAS daemon and
start hacking on it in a separate repo,
Hi Boris,
-- added Fu Wei in the loop --
On 30 June 2014 09:07, Borislav Petkov b...@alien8.de wrote:
On Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov wrote:
Ok, cool. So guys, can we apply this one so that I can continue with the
next round?
Ok, I had this crazy idea recently:
On Mon, Jun 30, 2014 at 11:39:39AM +0200, Jean Pihet wrote:
That makes perfect sense since:
- we need the RAS daemon implementation soon (not just before the
final blackdown ;-),
Yeah :-)
- for other tools to exist (like RAS daemon) we need to split out the
perf code in small units. This
On 30.06.14 12:01:15, Borislav Petkov wrote:
Well, do you have it as a standalong program? If so, you can put it in
a repo somewhere and we can start hacking away and playing with it. If
not, we will have to copy the perf code *into* the RAS daemon first so
that we can have a separate source
Em Mon, Jun 30, 2014 at 04:50:31PM +0200, Robert Richter escreveu:
On 30.06.14 12:01:15, Borislav Petkov wrote:
Well, do you have it as a standalong program? If so, you can put it in
a repo somewhere and we can start hacking away and playing with it. If
not, we will have to copy the perf
On Mon, Jun 30, 2014 at 11:58:31AM -0300, Arnaldo Carvalho de Melo wrote:
Yeap, guess its the most sensible to do given how things went so far.
Please submit patches when you fix things on code copied from
tools/perf/ and generally when improving it.
Sure.
Btw, should I still be working on
Em Mon, Jun 30, 2014 at 05:18:02PM +0200, Borislav Petkov escreveu:
On Mon, Jun 30, 2014 at 11:58:31AM -0300, Arnaldo Carvalho de Melo wrote:
Yeap, guess its the most sensible to do given how things went so far.
Please submit patches when you fix things on code copied from
tools/perf/ and
On Mon, Jun 30, 2014 at 04:28:14PM -0300, Arnaldo Carvalho de Melo wrote:
Yes, I think we should continue moving stuff out of tools/perf/ and
into a place that can be shared with other tools/ living codebases.
Doing so will of course help tools that live elsewhere, outside the
kernel sources
On Thu, Jun 26, 2014 at 02:14:33PM +0200, Jiri Olsa wrote:
> this one compiles ok for me
Ok, cool. So guys, can we apply this one so that I can continue with the
next round?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this
On Thu, Jun 26, 2014 at 02:14:33PM +0200, Jiri Olsa wrote:
this one compiles ok for me
Ok, cool. So guys, can we apply this one so that I can continue with the
next round?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this
On Thu, Jun 26, 2014 at 12:32:23PM +0200, Borislav Petkov wrote:
> On Thu, Jun 26, 2014 at 09:38:02AM +0200, Jiri Olsa wrote:
> > yep, tip/perf/core maybe plus merges from acme/perf/core and
> > jolsa/perf/core should do it ;-)
>
> Ok, just did this (jolsa/perf/coreas up-to-date) nd I still can't
22:05:38 +0200
Subject: [PATCH] perf tool: Carve out ctype.h et al
Carve out ctype.* and util.* stuff into tools/lib/util/. We're keeping
those as standalone object files in TOOLS_OBJS and add them to the
targets that need them.
This way we don't do lib archives but single objects only.
S
On Thu, Jun 26, 2014 at 09:36:05AM +0200, Jiri Olsa wrote:
> this functionality is inside evlist/evsel/target(...) objects
Yep, and that functionality depends on generic stuff which we're trying to
export first. :-)
> the ras daemon is not in tree yet is it? cant find it..
Here's an old
On Wed, Jun 25, 2014 at 06:17:57PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> >
> > Merge remote-tracking branch 'jolsa/perf/urgent' into ptool-v0.5
> >
> > commit a93f0e551af9e194db38bfe16001e17a3a1d189a
> > Author: Simon Que
> > Date: Mon Jun 16 11:32:09 2014 -0700
> >
> >
On Wed, Jun 25, 2014 at 10:11:47PM +0200, Borislav Petkov wrote:
> On Wed, Jun 25, 2014 at 04:42:54PM -0300, Arnaldo Carvalho de Melo wrote:
> > Probably will come in a separate patchkit that is dependent on this,
> > but not strictly related?
>
> Yeah, so roughly speaking, we want to carve out
On Wed, Jun 25, 2014 at 10:11:47PM +0200, Borislav Petkov wrote:
On Wed, Jun 25, 2014 at 04:42:54PM -0300, Arnaldo Carvalho de Melo wrote:
Probably will come in a separate patchkit that is dependent on this,
but not strictly related?
Yeah, so roughly speaking, we want to carve out the code
On Wed, Jun 25, 2014 at 06:17:57PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
Merge remote-tracking branch 'jolsa/perf/urgent' into ptool-v0.5
commit a93f0e551af9e194db38bfe16001e17a3a1d189a
Author: Simon Que s...@chromium.org
Date: Mon Jun 16 11:32:09 2014 -0700
On Thu, Jun 26, 2014 at 09:36:05AM +0200, Jiri Olsa wrote:
this functionality is inside evlist/evsel/target(...) objects
Yep, and that functionality depends on generic stuff which we're trying to
export first. :-)
the ras daemon is not in tree yet is it? cant find it..
Here's an old version:
: Borislav Petkov b...@suse.de
Date: Tue, 24 Jun 2014 22:05:38 +0200
Subject: [PATCH] perf tool: Carve out ctype.h et al
Carve out ctype.* and util.* stuff into tools/lib/util/. We're keeping
those as standalone object files in TOOLS_OBJS and add them to the
targets that need them.
This way we don't do
On Thu, Jun 26, 2014 at 12:32:23PM +0200, Borislav Petkov wrote:
On Thu, Jun 26, 2014 at 09:38:02AM +0200, Jiri Olsa wrote:
yep, tip/perf/core maybe plus merges from acme/perf/core and
jolsa/perf/core should do it ;-)
Ok, just did this (jolsa/perf/coreas up-to-date) nd I still can't
Em Wed, Jun 25, 2014 at 10:38:36PM +0200, Borislav Petkov escreveu:
> On Wed, Jun 25, 2014 at 09:25:47PM +0200, Jiri Olsa wrote:
> > heya,
> > got following error;
> >
> > [jolsa@krava perf]$ make
> > BUILD: Doing 'make -j4' parallel build
> > CC util/pmu.o
> > CC
On Wed, Jun 25, 2014 at 06:17:57PM -0300, Arnaldo Carvalho de Melo wrote:
> Yeah, and albeit it can take time, its how it would be done if this
> was touching core kernel code, right? So lets try to do it that way
> ;-)
Oh sure, I'm not complaining - I'm just discussing our process and how
to
On Wed, Jun 25, 2014 at 09:25:47PM +0200, Jiri Olsa wrote:
> heya,
> got following error;
>
> [jolsa@krava perf]$ make
> BUILD: Doing 'make -j4' parallel build
> CC util/pmu.o
> CC util/parse-events-flex.o
> SUBDIR /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/
>
On Wed, Jun 25, 2014 at 04:42:54PM -0300, Arnaldo Carvalho de Melo wrote:
> Probably will come in a separate patchkit that is dependent on this,
> but not strictly related?
Yeah, so roughly speaking, we want to carve out the code which opens and
handles events in perf tool so that we can use it
Em Wed, Jun 25, 2014 at 09:25:47PM +0200, Jiri Olsa escreveu:
> Besides that we'd need all those changes separated, who is the
> other user of this library? I dont see any in the patch.
Probably will come in a separate patchkit that is dependent on
this, but not strictly related?
- Arnaldo
--
To
On Wed, Jun 25, 2014 at 11:23:04AM +0200, Borislav Petkov wrote:
> From: Borislav Petkov
>
> Carve out ctype.* and util.* stuff into tools/lib/util/. We're keeping
> those as standalone object files in TOOLS_OBJS and add them to the
> targets that need them.
>
> This way we don't do lib
From: Borislav Petkov
Carve out ctype.* and util.* stuff into tools/lib/util/. We're keeping
those as standalone object files in TOOLS_OBJS and add them to the
targets that need them.
This way we don't do lib archives but single objects only.
Signed-off-by: Borislav Petkov
---
From: Borislav Petkov b...@suse.de
Carve out ctype.* and util.* stuff into tools/lib/util/. We're keeping
those as standalone object files in TOOLS_OBJS and add them to the
targets that need them.
This way we don't do lib archives but single objects only.
Signed-off-by: Borislav Petkov
On Wed, Jun 25, 2014 at 11:23:04AM +0200, Borislav Petkov wrote:
From: Borislav Petkov b...@suse.de
Carve out ctype.* and util.* stuff into tools/lib/util/. We're keeping
those as standalone object files in TOOLS_OBJS and add them to the
targets that need them.
This way we don't do lib
Em Wed, Jun 25, 2014 at 09:25:47PM +0200, Jiri Olsa escreveu:
Besides that we'd need all those changes separated, who is the
other user of this library? I dont see any in the patch.
Probably will come in a separate patchkit that is dependent on
this, but not strictly related?
- Arnaldo
--
To
On Wed, Jun 25, 2014 at 04:42:54PM -0300, Arnaldo Carvalho de Melo wrote:
Probably will come in a separate patchkit that is dependent on this,
but not strictly related?
Yeah, so roughly speaking, we want to carve out the code which opens and
handles events in perf tool so that we can use it in
On Wed, Jun 25, 2014 at 09:25:47PM +0200, Jiri Olsa wrote:
heya,
got following error;
[jolsa@krava perf]$ make
BUILD: Doing 'make -j4' parallel build
CC util/pmu.o
CC util/parse-events-flex.o
SUBDIR /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/
On Wed, Jun 25, 2014 at 06:17:57PM -0300, Arnaldo Carvalho de Melo wrote:
Yeah, and albeit it can take time, its how it would be done if this
was touching core kernel code, right? So lets try to do it that way
;-)
Oh sure, I'm not complaining - I'm just discussing our process and how
to
Em Wed, Jun 25, 2014 at 10:38:36PM +0200, Borislav Petkov escreveu:
On Wed, Jun 25, 2014 at 09:25:47PM +0200, Jiri Olsa wrote:
heya,
got following error;
[jolsa@krava perf]$ make
BUILD: Doing 'make -j4' parallel build
CC util/pmu.o
CC util/parse-events-flex.o
50 matches
Mail list logo
