Re: [PATCH] random: Move rand_initialize() earlier

2019-04-24 Thread Kees Cook
On Wed, Apr 24, 2019 at 3:10 PM Theodore Ts'o wrote: > > On Tue, Apr 23, 2019 at 03:20:58PM -0700, Kees Cook wrote: > > > Yeah, sorry, it got lost; my bad. I'll take it and push it out at the > > > next merge window. > > > > Gentle poke. :) I still don't see this in -next... > > Oops, sorry, I

Re: [PATCH] random: Move rand_initialize() earlier

2019-04-24 Thread Theodore Ts'o
On Tue, Apr 23, 2019 at 03:20:58PM -0700, Kees Cook wrote: > > Yeah, sorry, it got lost; my bad. I'll take it and push it out at the > > next merge window. > > Gentle poke. :) I still don't see this in -next... Oops, sorry, I pushed it out to the master branch, and I forgot that the -next

Re: [PATCH] random: Move rand_initialize() earlier

2019-04-23 Thread Kees Cook
On Tue, Apr 16, 2019 at 9:09 AM Theodore Ts'o wrote: > > On Mon, Apr 15, 2019 at 10:46:34PM -0500, Kees Cook wrote: > > On Fri, Oct 12, 2018 at 9:45 AM Kees Cook wrote: > > > > > > On Fri, Oct 12, 2018 at 7:29 AM, Theodore Y. Ts'o wrote: > > > > On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees

Re: [PATCH] random: Move rand_initialize() earlier

2019-04-16 Thread Kees Cook
On Tue, Apr 16, 2019 at 11:09 AM Theodore Ts'o wrote: > > On Mon, Apr 15, 2019 at 10:46:34PM -0500, Kees Cook wrote: > > On Fri, Oct 12, 2018 at 9:45 AM Kees Cook wrote: > > > > > > On Fri, Oct 12, 2018 at 7:29 AM, Theodore Y. Ts'o wrote: > > > > On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees

Re: [PATCH] random: Move rand_initialize() earlier

2019-04-16 Thread Theodore Ts'o
On Mon, Apr 15, 2019 at 10:46:34PM -0500, Kees Cook wrote: > On Fri, Oct 12, 2018 at 9:45 AM Kees Cook wrote: > > > > On Fri, Oct 12, 2018 at 7:29 AM, Theodore Y. Ts'o wrote: > > > On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees Cook wrote: > > >> Right now rand_initialize() is run as an

Re: [PATCH] random: Move rand_initialize() earlier

2019-04-15 Thread Kees Cook
On Fri, Oct 12, 2018 at 9:45 AM Kees Cook wrote: > > On Fri, Oct 12, 2018 at 7:29 AM, Theodore Y. Ts'o wrote: > > On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees Cook wrote: > >> Right now rand_initialize() is run as an early_initcall(), but it only > >> depends on timekeeping_init() (for mixing

Re: [PATCH] random: Move rand_initialize() earlier

2018-10-12 Thread Kees Cook
On Fri, Oct 12, 2018 at 7:29 AM, Theodore Y. Ts'o wrote: > On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees Cook wrote: >> Right now rand_initialize() is run as an early_initcall(), but it only >> depends on timekeeping_init() (for mixing ktime_get_real() into the >> pools). However, the call to

Re: [PATCH] random: Move rand_initialize() earlier

2018-10-12 Thread Kees Cook
On Fri, Oct 12, 2018 at 7:29 AM, Theodore Y. Ts'o wrote: > On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees Cook wrote: >> Right now rand_initialize() is run as an early_initcall(), but it only >> depends on timekeeping_init() (for mixing ktime_get_real() into the >> pools). However, the call to

Re: [PATCH] random: Move rand_initialize() earlier

2018-10-12 Thread Theodore Y. Ts'o
On Fri, Oct 12, 2018 at 10:42:39AM +0200, Arnd Bergmann wrote: > I wonder if mixing in ktime_get_real() is flawed to start with: > This depends on read_persistent_clock64() actually returning > a meaningful time, but in many cases it does not; x86 being > a notable exception. > > We have three

Re: [PATCH] random: Move rand_initialize() earlier

2018-10-12 Thread Theodore Y. Ts'o
On Fri, Oct 12, 2018 at 10:42:39AM +0200, Arnd Bergmann wrote: > I wonder if mixing in ktime_get_real() is flawed to start with: > This depends on read_persistent_clock64() actually returning > a meaningful time, but in many cases it does not; x86 being > a notable exception. > > We have three

Re: [PATCH] random: Move rand_initialize() earlier

2018-10-12 Thread Theodore Y. Ts'o
On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees Cook wrote: > Right now rand_initialize() is run as an early_initcall(), but it only > depends on timekeeping_init() (for mixing ktime_get_real() into the > pools). However, the call to boot_init_stack_canary() for stack canary > initialization runs

Re: [PATCH] random: Move rand_initialize() earlier

2018-10-12 Thread Theodore Y. Ts'o
On Thu, Oct 11, 2018 at 03:54:21PM -0700, Kees Cook wrote: > Right now rand_initialize() is run as an early_initcall(), but it only > depends on timekeeping_init() (for mixing ktime_get_real() into the > pools). However, the call to boot_init_stack_canary() for stack canary > initialization runs

Re: [PATCH] random: Move rand_initialize() earlier

2018-10-12 Thread Arnd Bergmann
On Fri, Oct 12, 2018 at 12:54 AM Kees Cook wrote: > > Right now rand_initialize() is run as an early_initcall(), but it only > depends on timekeeping_init() (for mixing ktime_get_real() into the > pools). However, the call to boot_init_stack_canary() for stack canary > initialization runs

Re: [PATCH] random: Move rand_initialize() earlier

2018-10-12 Thread Arnd Bergmann
On Fri, Oct 12, 2018 at 12:54 AM Kees Cook wrote: > > Right now rand_initialize() is run as an early_initcall(), but it only > depends on timekeeping_init() (for mixing ktime_get_real() into the > pools). However, the call to boot_init_stack_canary() for stack canary > initialization runs

[PATCH] random: Move rand_initialize() earlier

2018-10-11 Thread Kees Cook
Right now rand_initialize() is run as an early_initcall(), but it only depends on timekeeping_init() (for mixing ktime_get_real() into the pools). However, the call to boot_init_stack_canary() for stack canary initialization runs earlier, which triggers a warning at boot: random: get_random_bytes

[PATCH] random: Move rand_initialize() earlier

2018-10-11 Thread Kees Cook
Right now rand_initialize() is run as an early_initcall(), but it only depends on timekeeping_init() (for mixing ktime_get_real() into the pools). However, the call to boot_init_stack_canary() for stack canary initialization runs earlier, which triggers a warning at boot: random: get_random_bytes