Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-13 Thread Andrew Morton
On Fri, 13 Apr 2018 09:09:18 +0200 Ioan Nicu wrote: > > > And please remember to always include all information regarding > > > end-user impact when fixing bugs. > > > > > This bug fix is applicable to versions starting from v4.6 > > Actually, this is something I broke

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-13 Thread Andrew Morton
On Fri, 13 Apr 2018 09:09:18 +0200 Ioan Nicu wrote: > > > And please remember to always include all information regarding > > > end-user impact when fixing bugs. > > > > > This bug fix is applicable to versions starting from v4.6 > > Actually, this is something I broke with my previous patch

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-13 Thread Ioan Nicu
Hi, On Thu, Apr 12, 2018 at 07:44:01PM -0400, Alexandre Bounine wrote: > > On 2018-04-12 05:28 PM, Andrew Morton wrote: > > On Thu, 12 Apr 2018 17:06:05 +0200 Ioan Nicu > > wrote: > > > > > Some of the mport_dma_req structure members were initialized late > > > inside

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-13 Thread Ioan Nicu
Hi, On Thu, Apr 12, 2018 at 07:44:01PM -0400, Alexandre Bounine wrote: > > On 2018-04-12 05:28 PM, Andrew Morton wrote: > > On Thu, 12 Apr 2018 17:06:05 +0200 Ioan Nicu > > wrote: > > > > > Some of the mport_dma_req structure members were initialized late > > > inside the do_dma_request()

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Alexandre Bounine
On 2018-04-12 05:28 PM, Andrew Morton wrote: On Thu, 12 Apr 2018 17:06:05 +0200 Ioan Nicu wrote: Some of the mport_dma_req structure members were initialized late inside the do_dma_request() function, just before submitting the request to the dma engine. But we have

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Alexandre Bounine
On 2018-04-12 05:28 PM, Andrew Morton wrote: On Thu, 12 Apr 2018 17:06:05 +0200 Ioan Nicu wrote: Some of the mport_dma_req structure members were initialized late inside the do_dma_request() function, just before submitting the request to the dma engine. But we have some error branches

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Andrew Morton
On Thu, 12 Apr 2018 17:06:05 +0200 Ioan Nicu wrote: > Some of the mport_dma_req structure members were initialized late > inside the do_dma_request() function, just before submitting the > request to the dma engine. But we have some error branches before > that. In case

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Andrew Morton
On Thu, 12 Apr 2018 17:06:05 +0200 Ioan Nicu wrote: > Some of the mport_dma_req structure members were initialized late > inside the do_dma_request() function, just before submitting the > request to the dma engine. But we have some error branches before > that. In case of such an error, the

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Alexandre Bounine
On 2018-04-12 11:06 AM, Ioan Nicu wrote: Some of the mport_dma_req structure members were initialized late inside the do_dma_request() function, just before submitting the request to the dma engine. But we have some error branches before that. In case of such an error, the code would return on

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Alexandre Bounine
On 2018-04-12 11:06 AM, Ioan Nicu wrote: Some of the mport_dma_req structure members were initialized late inside the do_dma_request() function, just before submitting the request to the dma engine. But we have some error branches before that. In case of such an error, the code would return on

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Alexander Sverdlin
On 12/04/18 17:06, Ioan Nicu wrote: > Some of the mport_dma_req structure members were initialized late > inside the do_dma_request() function, just before submitting the > request to the dma engine. But we have some error branches before > that. In case of such an error, the code would return on

Re: [PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Alexander Sverdlin
On 12/04/18 17:06, Ioan Nicu wrote: > Some of the mport_dma_req structure members were initialized late > inside the do_dma_request() function, just before submitting the > request to the dma engine. But we have some error branches before > that. In case of such an error, the code would return on

[PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Ioan Nicu
Some of the mport_dma_req structure members were initialized late inside the do_dma_request() function, just before submitting the request to the dma engine. But we have some error branches before that. In case of such an error, the code would return on the error path and trigger the calling of

[PATCH] rapidio: fix rio_dma_transfer error handling

2018-04-12 Thread Ioan Nicu
Some of the mport_dma_req structure members were initialized late inside the do_dma_request() function, just before submitting the request to the dma engine. But we have some error branches before that. In case of such an error, the code would return on the error path and trigger the calling of