Re: [PATCH] raw1394 missing failure handling

2005-03-05 Thread Gene Heskett
On Saturday 05 March 2005 13:47, Jody McIntyre wrote: >On Thu, Mar 03, 2005 at 11:55:09PM +0100, Panagiotis Issaris wrote: >> Adds the missing failure handling for a __copy_to_user call. >> >> >> Signed-off-by: Panagiotis Issaris <[EMAIL PROTECTED]> > >Sorry I didn't notice this sooner, but this

Re: [PATCH] raw1394 missing failure handling

2005-03-05 Thread Jody McIntyre
On Thu, Mar 03, 2005 at 11:55:09PM +0100, Panagiotis Issaris wrote: > Adds the missing failure handling for a __copy_to_user call. > > > Signed-off-by: Panagiotis Issaris <[EMAIL PROTECTED]> Sorry I didn't notice this sooner, but this was already fixed and has been sent to Linus (hopefully to

Re: [PATCH] raw1394 missing failure handling

2005-03-05 Thread Jody McIntyre
On Thu, Mar 03, 2005 at 11:55:09PM +0100, Panagiotis Issaris wrote: Adds the missing failure handling for a __copy_to_user call. Signed-off-by: Panagiotis Issaris [EMAIL PROTECTED] Sorry I didn't notice this sooner, but this was already fixed and has been sent to Linus (hopefully to appear

Re: [PATCH] raw1394 missing failure handling

2005-03-05 Thread Gene Heskett
On Saturday 05 March 2005 13:47, Jody McIntyre wrote: On Thu, Mar 03, 2005 at 11:55:09PM +0100, Panagiotis Issaris wrote: Adds the missing failure handling for a __copy_to_user call. Signed-off-by: Panagiotis Issaris [EMAIL PROTECTED] Sorry I didn't notice this sooner, but this was already

Re: [PATCH] raw1394 missing failure handling

2005-03-03 Thread Panagiotis Issaris
Hi Jody, My previous e-mail seemed to be messed up by Thunderbird... so now I'm using good old Mutt again. On Thu, Mar 03, 2005 at 04:48:43PM -0500 or thereabouts, Jody McIntyre wrote: > > Thanks. Here's my third try :-) > > > > With friendly regards, > > Takis > > I'll apply this to the 1394

Re: [PATCH] raw1394 missing failure handling

2005-03-03 Thread Panagiotis Issaris
Hi, Jody McIntyre wrote: I'll apply this to the 1394 tree and send it to Linus after testing if you add a Signed-off-by: line per Documentation/SubmittingPatches . Also, please cc [EMAIL PROTECTED] with ieee1394 changes. Sure! Thanks! Adds the missing failure handling for a __copy_to_user call.

Re: [PATCH] raw1394 missing failure handling

2005-03-03 Thread Jody McIntyre
> Thanks. Here's my third try :-) > > With friendly regards, > Takis I'll apply this to the 1394 tree and send it to Linus after testing if you add a Signed-off-by: line per Documentation/SubmittingPatches . Also, please cc [EMAIL PROTECTED] with ieee1394 changes. Thanks, Jody > > -- >

Re: [PATCH] raw1394 missing failure handling

2005-03-03 Thread Jody McIntyre
Thanks. Here's my third try :-) With friendly regards, Takis I'll apply this to the 1394 tree and send it to Linus after testing if you add a Signed-off-by: line per Documentation/SubmittingPatches . Also, please cc [EMAIL PROTECTED] with ieee1394 changes. Thanks, Jody -- K.U.Leuven,

Re: [PATCH] raw1394 missing failure handling

2005-03-03 Thread Panagiotis Issaris
Hi, Jody McIntyre wrote: I'll apply this to the 1394 tree and send it to Linus after testing if you add a Signed-off-by: line per Documentation/SubmittingPatches . Also, please cc [EMAIL PROTECTED] with ieee1394 changes. Sure! Thanks! Adds the missing failure handling for a __copy_to_user call.

Re: [PATCH] raw1394 missing failure handling

2005-03-03 Thread Panagiotis Issaris
Hi Jody, My previous e-mail seemed to be messed up by Thunderbird... so now I'm using good old Mutt again. On Thu, Mar 03, 2005 at 04:48:43PM -0500 or thereabouts, Jody McIntyre wrote: Thanks. Here's my third try :-) With friendly regards, Takis I'll apply this to the 1394 tree and

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, Dmitry Torokhov wrote: On Wed, 02 Mar 2005 13:28:23 +0100, Panagiotis Issaris <[EMAIL PROTECTED]> wrote: Oops. Thanks for replying! Any more problems with the updated patch? Formatting... Opening curly brace should go on the same line with "if". Thanks. Here's my third try :-) With

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Dmitry Torokhov
On Wed, 02 Mar 2005 13:28:23 +0100, Panagiotis Issaris <[EMAIL PROTECTED]> wrote: > Hi, > > Anton Altaparmakov wrote: > > >On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote: > > > > > >>In the raw1394 driver the failure handling for > >>a __copy_to_user call is missing. > >> > >> > > >

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, Anton Altaparmakov wrote: On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote: In the raw1394 driver the failure handling for a __copy_to_user call is missing. Your patch is obviously incorrect as it doesn't free the request before it returns. Oops. Thanks for replying! Any

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Sergey Vlasov
On Wed, 02 Mar 2005 12:10:50 +0100 Panagiotis Issaris wrote: > In the raw1394 driver the failure handling for > a __copy_to_user call is missing. > > With friendly regards, > Takis > > -- > K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research Group >

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Anton Altaparmakov
Hi, On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote: > In the raw1394 driver the failure handling for > a __copy_to_user call is missing. Your patch is obviously incorrect as it doesn't free the request before it returns. Best regards, Anton -- Anton Altaparmakov (replace

[PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, In the raw1394 driver the failure handling for a __copy_to_user call is missing. With friendly regards, Takis -- K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research Group http://people.mech.kuleuven.ac.be/~pissaris/ diff -pruN linux-2.6.11/drivers/ieee1394/raw1394.c

[PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, In the raw1394 driver the failure handling for a __copy_to_user call is missing. With friendly regards, Takis -- K.U.Leuven, Mechanical Eng., Mechatronics Robotics Research Group http://people.mech.kuleuven.ac.be/~pissaris/ diff -pruN linux-2.6.11/drivers/ieee1394/raw1394.c

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Anton Altaparmakov
Hi, On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote: In the raw1394 driver the failure handling for a __copy_to_user call is missing. Your patch is obviously incorrect as it doesn't free the request before it returns. Best regards, Anton -- Anton Altaparmakov aia21 at

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Sergey Vlasov
On Wed, 02 Mar 2005 12:10:50 +0100 Panagiotis Issaris wrote: In the raw1394 driver the failure handling for a __copy_to_user call is missing. With friendly regards, Takis -- K.U.Leuven, Mechanical Eng., Mechatronics Robotics Research Group

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, Anton Altaparmakov wrote: On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote: In the raw1394 driver the failure handling for a __copy_to_user call is missing. Your patch is obviously incorrect as it doesn't free the request before it returns. Oops. Thanks for replying! Any

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Dmitry Torokhov
On Wed, 02 Mar 2005 13:28:23 +0100, Panagiotis Issaris [EMAIL PROTECTED] wrote: Hi, Anton Altaparmakov wrote: On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote: In the raw1394 driver the failure handling for a __copy_to_user call is missing. Your patch is obviously

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, Dmitry Torokhov wrote: On Wed, 02 Mar 2005 13:28:23 +0100, Panagiotis Issaris [EMAIL PROTECTED] wrote: Oops. Thanks for replying! Any more problems with the updated patch? Formatting... Opening curly brace should go on the same line with if. Thanks. Here's my third try :-) With