Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-18 Thread Geyslan Gregório Bem
2013/11/18 Caizhiyong : > From: Cai Zhiyong > Date: Mon, 18 Nov 2013 20:21:49 +0800 > Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value > > This patch give a warning when calling regmap_register_patch with > parameter num_regs <= 0. > > When the

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-18 Thread Mark Brown
On Mon, Nov 18, 2013 at 12:29:02PM +, Caizhiyong wrote: > This patch give a warning when calling regmap_register_patch with > parameter num_regs <= 0. Applied, thanks. signature.asc Description: Digital signature

[PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-18 Thread Caizhiyong
From: Cai Zhiyong Date: Mon, 18 Nov 2013 20:21:49 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value This patch give a warning when calling regmap_register_patch with parameter num_regs <= 0. When the num_regs parameter is zero and krealloc doesn't fail, then the c

[PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-18 Thread Caizhiyong
From: Cai Zhiyong caizhiy...@huawei.com Date: Mon, 18 Nov 2013 20:21:49 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value This patch give a warning when calling regmap_register_patch with parameter num_regs = 0. When the num_regs parameter is zero and krealloc doesn't

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-18 Thread Mark Brown
On Mon, Nov 18, 2013 at 12:29:02PM +, Caizhiyong wrote: This patch give a warning when calling regmap_register_patch with parameter num_regs = 0. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-18 Thread Geyslan Gregório Bem
2013/11/18 Caizhiyong caizhiy...@hisilicon.com: From: Cai Zhiyong caizhiy...@huawei.com Date: Mon, 18 Nov 2013 20:21:49 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value This patch give a warning when calling regmap_register_patch with parameter num_regs = 0

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Geyslan Gregório Bem
2013/11/15 Mark Brown : > On Fri, Nov 15, 2013 at 01:52:19PM -0200, Geyslan Gregório Bem wrote: > >> + if (WARN_ONCE(num_regs <= 0, "number of registers [%d] must be >> major than 0", num_regs)) >> + return 0; > > "must be more than" but yes. Tks. Sorry for my poor english. :D

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Levente Kurusa
2013-11-15 16:52 keltezéssel, Geyslan Gregório Bem írta: > 2013/11/15 Levente Kurusa : >> 2013-11-15 14:00 keltezéssel, Geyslan Gregório Bem írta: >>> 2013/11/15 Caizhiyong : >>>> From: Cai Zhiyong >>>> Date: Mon, 11 Nov 2013 19:26:14 +0800 >>&g

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Mark Brown
On Fri, Nov 15, 2013 at 01:52:19PM -0200, Geyslan Gregório Bem wrote: > + if (WARN_ONCE(num_regs <= 0, "number of registers [%d] must be > major than 0", num_regs)) > + return 0; "must be more than" but yes. signature.asc Description: Digital signature

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Geyslan Gregório Bem
2013/11/15 Levente Kurusa : > 2013-11-15 14:00 keltezéssel, Geyslan Gregório Bem írta: >> 2013/11/15 Caizhiyong : >>> From: Cai Zhiyong >>> Date: Mon, 11 Nov 2013 19:26:14 +0800 >>> Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value &g

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Levente Kurusa
2013-11-15 14:00 keltezéssel, Geyslan Gregório Bem írta: > 2013/11/15 Caizhiyong : >> From: Cai Zhiyong >> Date: Mon, 11 Nov 2013 19:26:14 +0800 >> Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value >> >> This patch give a warning w

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Geyslan Gregório Bem
2013/11/15 Caizhiyong : > From: Cai Zhiyong > Date: Mon, 11 Nov 2013 19:26:14 +0800 > Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value > > This patch give a warning when calling regmap_register_patch with > parameter num_regs <= 0. > > When the

[PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Caizhiyong
From: Cai Zhiyong Date: Mon, 11 Nov 2013 19:26:14 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value This patch give a warning when calling regmap_register_patch with parameter num_regs <= 0. When the num_regs parameter is zero and krealloc doesn't fail, then the c

[PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Caizhiyong
From: Cai Zhiyong caizhiy...@huawei.com Date: Mon, 11 Nov 2013 19:26:14 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value This patch give a warning when calling regmap_register_patch with parameter num_regs = 0. When the num_regs parameter is zero and krealloc doesn't

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Geyslan Gregório Bem
2013/11/15 Caizhiyong caizhiy...@hisilicon.com: From: Cai Zhiyong caizhiy...@huawei.com Date: Mon, 11 Nov 2013 19:26:14 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value This patch give a warning when calling regmap_register_patch with parameter num_regs = 0

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Levente Kurusa
2013-11-15 14:00 keltezéssel, Geyslan Gregório Bem írta: 2013/11/15 Caizhiyong caizhiy...@hisilicon.com: From: Cai Zhiyong caizhiy...@huawei.com Date: Mon, 11 Nov 2013 19:26:14 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value This patch give a warning when calling

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Geyslan Gregório Bem
2013/11/15 Levente Kurusa le...@linux.com: 2013-11-15 14:00 keltezéssel, Geyslan Gregório Bem írta: 2013/11/15 Caizhiyong caizhiy...@hisilicon.com: From: Cai Zhiyong caizhiy...@huawei.com Date: Mon, 11 Nov 2013 19:26:14 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Mark Brown
On Fri, Nov 15, 2013 at 01:52:19PM -0200, Geyslan Gregório Bem wrote: + if (WARN_ONCE(num_regs = 0, number of registers [%d] must be major than 0, num_regs)) + return 0; must be more than but yes. signature.asc Description: Digital signature

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Levente Kurusa
: [PATCH] regmap: Fix 'ret' would return an uninitialized value This patch give a warning when calling regmap_register_patch with parameter num_regs = 0. When the num_regs parameter is zero and krealloc doesn't fail, then the code would return an uninitialized value. However, calling

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-15 Thread Geyslan Gregório Bem
2013/11/15 Mark Brown broo...@kernel.org: On Fri, Nov 15, 2013 at 01:52:19PM -0200, Geyslan Gregório Bem wrote: + if (WARN_ONCE(num_regs = 0, number of registers [%d] must be major than 0, num_regs)) + return 0; must be more than but yes. Tks. Sorry for my poor english.

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-14 Thread Mark Brown
On Mon, Nov 11, 2013 at 11:35:52AM +, Caizhiyong wrote: > + int ret = 0; With the if statement below you probably don't need to do this any more. > + if (num_regs <= 0) { > + WARN_ONCE(1, "Call regmap_register_patch with num_regs <= 0."); > + return 0; > +

Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-14 Thread Mark Brown
On Mon, Nov 11, 2013 at 11:35:52AM +, Caizhiyong wrote: + int ret = 0; With the if statement below you probably don't need to do this any more. + if (num_regs = 0) { + WARN_ONCE(1, Call regmap_register_patch with num_regs = 0.); + return 0; + }

[PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-11 Thread Caizhiyong
From: Cai Zhiyong Date: Mon, 11 Nov 2013 19:26:14 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value - Fix 'ret' would return an uninitialized value. - Add a warning avoid invalid 'num_regs' value passed in. When the num_regs parameter is zero and krealloc doesn't

[PATCH] regmap: Fix 'ret' would return an uninitialized value

2013-11-11 Thread Caizhiyong
From: Cai Zhiyong caizhiy...@huawei.com Date: Mon, 11 Nov 2013 19:26:14 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value - Fix 'ret' would return an uninitialized value. - Add a warning avoid invalid 'num_regs' value passed in. When the num_regs parameter is zero