Re: [PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Doug Anderson
Hi, On Tue, Apr 17, 2018 at 10:48 AM, Javier Martinez Canillas wrote: >>> Let's fix the return type of all of the current of_map_mode() >>> functions. While we're at it, we'll remove one pointless "inline". >> >> Ah, I see... the thing here is that the mode is always an

Re: [PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Doug Anderson
Hi, On Tue, Apr 17, 2018 at 10:48 AM, Javier Martinez Canillas wrote: >>> Let's fix the return type of all of the current of_map_mode() >>> functions. While we're at it, we'll remove one pointless "inline". >> >> Ah, I see... the thing here is that the mode is always an unsigned int >> since

Re: [PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Javier Martinez Canillas
On Tue, Apr 17, 2018 at 7:22 PM, Mark Brown wrote: > On Tue, Apr 17, 2018 at 10:12:04AM -0700, Douglas Anderson wrote: >> In of_get_regulation_constraints() it can clearly be seen that the >> return value of of_map_mode() is assigned to a signed integer. This >> is important

Re: [PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Javier Martinez Canillas
On Tue, Apr 17, 2018 at 7:22 PM, Mark Brown wrote: > On Tue, Apr 17, 2018 at 10:12:04AM -0700, Douglas Anderson wrote: >> In of_get_regulation_constraints() it can clearly be seen that the >> return value of of_map_mode() is assigned to a signed integer. This >> is important because the first

Re: [PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Mark Brown
On Tue, Apr 17, 2018 at 10:12:04AM -0700, Douglas Anderson wrote: > In of_get_regulation_constraints() it can clearly be seen that the > return value of of_map_mode() is assigned to a signed integer. This > is important because the first thing the regulator core does with this > value is to

Re: [PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Mark Brown
On Tue, Apr 17, 2018 at 10:12:04AM -0700, Douglas Anderson wrote: > In of_get_regulation_constraints() it can clearly be seen that the > return value of of_map_mode() is assigned to a signed integer. This > is important because the first thing the regulator core does with this > value is to

Re: [PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Mark Brown
On Tue, Apr 17, 2018 at 10:12:04AM -0700, Douglas Anderson wrote: > In of_get_regulation_constraints() it can clearly be seen that the > return value of of_map_mode() is assigned to a signed integer. This > is important because the first thing the regulator core does with this > value is to

Re: [PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Mark Brown
On Tue, Apr 17, 2018 at 10:12:04AM -0700, Douglas Anderson wrote: > In of_get_regulation_constraints() it can clearly be seen that the > return value of of_map_mode() is assigned to a signed integer. This > is important because the first thing the regulator core does with this > value is to

[PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Douglas Anderson
In of_get_regulation_constraints() it can clearly be seen that the return value of of_map_mode() is assigned to a signed integer. This is important because the first thing the regulator core does with this value is to compare it to -EINVAL. Let's fix the return type of all of the current

[PATCH] regulator: Fix return type of of_map_mode()

2018-04-17 Thread Douglas Anderson
In of_get_regulation_constraints() it can clearly be seen that the return value of of_map_mode() is assigned to a signed integer. This is important because the first thing the regulator core does with this value is to compare it to -EINVAL. Let's fix the return type of all of the current