Re: [PATCH] regulator: tps65910: Simplify setting enable_mask for regulators

2013-12-28 Thread Markus Pargmann
On Sat, Dec 28, 2013 at 11:02:35AM +0800, Axel Lin wrote: > BBCH_BBCHEN_MASK is equivalent to TPS65910_SUPPLY_STATE_ENABLED. > So all regulators have the same enable_mask setting. > Thanks for spotting this. You could also remove BBCH_BBCHEN_* from include/linux/mfd/tps65910.h. Regards, Markus

Re: [PATCH] regulator: tps65910: Simplify setting enable_mask for regulators

2013-12-28 Thread Markus Pargmann
On Sat, Dec 28, 2013 at 11:02:35AM +0800, Axel Lin wrote: BBCH_BBCHEN_MASK is equivalent to TPS65910_SUPPLY_STATE_ENABLED. So all regulators have the same enable_mask setting. Thanks for spotting this. You could also remove BBCH_BBCHEN_* from include/linux/mfd/tps65910.h. Regards, Markus

[PATCH] regulator: tps65910: Simplify setting enable_mask for regulators

2013-12-27 Thread Axel Lin
BBCH_BBCHEN_MASK is equivalent to TPS65910_SUPPLY_STATE_ENABLED. So all regulators have the same enable_mask setting. Signed-off-by: Axel Lin --- drivers/regulator/tps65910-regulator.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git

[PATCH] regulator: tps65910: Simplify setting enable_mask for regulators

2013-12-27 Thread Axel Lin
BBCH_BBCHEN_MASK is equivalent to TPS65910_SUPPLY_STATE_ENABLED. So all regulators have the same enable_mask setting. Signed-off-by: Axel Lin axel@ingics.com --- drivers/regulator/tps65910-regulator.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git