Re: [Outreachy kernel] [PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Harsha Sharma wrote: > Hi,Thanks for your feedback. > I will take care about readability from next time. Don't top post. You should respond to comments underneath the comment you are responding to. The person will have to go find that anyway, to understand what your

Re: [Outreachy kernel] [PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Harsha Sharma wrote: > Hi,Thanks for your feedback. > I will take care about readability from next time. Don't top post. You should respond to comments underneath the comment you are responding to. The person will have to go find that anyway, to understand what your

Re: [Outreachy kernel] [PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, harsha wrote: > Fixed coding style issue > > Signed-off-by: Harsha Sharma > --- > drivers/staging/rtl8712/xmit_linux.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/xmit_linux.c >

Re: [Outreachy kernel] [PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, harsha wrote: > Fixed coding style issue > > Signed-off-by: Harsha Sharma > --- > drivers/staging/rtl8712/xmit_linux.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/xmit_linux.c >

[PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread harsha
Fixed coding style issue Signed-off-by: Harsha Sharma --- drivers/staging/rtl8712/xmit_linux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index

[PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread harsha
Fixed coding style issue Signed-off-by: Harsha Sharma --- drivers/staging/rtl8712/xmit_linux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index d13fd15..03c6b0c 100644 ---