Re: [PATCH] x86/boot/compressed/64: Do not corrupt EDX on EFER.LME=1 setting

2019-02-06 Thread Wei Huang
On 2/6/19 5:52 AM, Kirill A. Shutemov wrote: > RDMSR in the trampoline code overrides EDX, but we use the register to > indicate if 5-level paging has to enabled. It leads to failure to boot > on a 5-level paging machine. > > Preserve EDX on the stack while we are dealing with EFER. > > Signed

Re: [PATCH] x86/boot/compressed/64: Do not corrupt EDX on EFER.LME=1 setting

2019-02-06 Thread Borislav Petkov
On Wed, Feb 06, 2019 at 06:47:57PM +0300, Kirill A. Shutemov wrote: > What about this: Yap, thanks! -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH] x86/boot/compressed/64: Do not corrupt EDX on EFER.LME=1 setting

2019-02-06 Thread Kirill A. Shutemov
On Wed, Feb 06, 2019 at 03:21:41PM +, Borislav Petkov wrote: > On Wed, Feb 06, 2019 at 02:52:53PM +0300, Kirill A. Shutemov wrote: > > RDMSR in the trampoline code overrides EDX, but we use the register to > > indicate if 5-level paging has to enabled. It leads to failure to boot > > on a 5-lev

Re: [PATCH] x86/boot/compressed/64: Do not corrupt EDX on EFER.LME=1 setting

2019-02-06 Thread Borislav Petkov
On Wed, Feb 06, 2019 at 02:52:53PM +0300, Kirill A. Shutemov wrote: > RDMSR in the trampoline code overrides EDX, but we use the register to > indicate if 5-level paging has to enabled. It leads to failure to boot > on a 5-level paging machine. > > Preserve EDX on the stack while we are dealing wi

[PATCH] x86/boot/compressed/64: Do not corrupt EDX on EFER.LME=1 setting

2019-02-06 Thread Kirill A. Shutemov
RDMSR in the trampoline code overrides EDX, but we use the register to indicate if 5-level paging has to enabled. It leads to failure to boot on a 5-level paging machine. Preserve EDX on the stack while we are dealing with EFER. Signed-off-by: Kirill A. Shutemov Fixes: b677dfae5aa1 ("x86/boot/co