Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

Hi Nick, On Mon, Jan 08, 2018 at 08:35:19PM -0800, Nick Desaulniers wrote: > On Sun, Jan 7, 2018 at 7:04 AM, Minchan Kim wrote: > > Sorry for the delay. I have missed this until now. ;-( > > No worries, figured patches would need a post holiday bump for review. > > > > > On

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

Hi Nick, On Mon, Jan 08, 2018 at 08:35:19PM -0800, Nick Desaulniers wrote: > On Sun, Jan 7, 2018 at 7:04 AM, Minchan Kim wrote: > > Sorry for the delay. I have missed this until now. ;-( > > No worries, figured patches would need a post holiday bump for review. > > > > > On Sun, Dec 24, 2017

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

On Sun, Jan 7, 2018 at 7:04 AM, Minchan Kim wrote: > Sorry for the delay. I have missed this until now. ;-( No worries, figured patches would need a post holiday bump for review. > > On Sun, Dec 24, 2017 at 11:33 AM, Nick Desaulniers > wrote: >>

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

On Sun, Jan 7, 2018 at 7:04 AM, Minchan Kim wrote: > Sorry for the delay. I have missed this until now. ;-( No worries, figured patches would need a post holiday bump for review. > > On Sun, Dec 24, 2017 at 11:33 AM, Nick Desaulniers > wrote: >> - link->next = -1 <<

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

On Sun, Jan 7, 2018 at 5:04 PM, Minchan Kim wrote: >> - link->next = -1 << OBJ_TAG_BITS; >> + link->next = -1U << OBJ_TAG_BITS; > > -1UL? Oh, boy, shouldn't be rather GENMASK() / GENMASK_ULL() in a way how it's done, for example,

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

On Sun, Jan 7, 2018 at 5:04 PM, Minchan Kim wrote: >> - link->next = -1 << OBJ_TAG_BITS; >> + link->next = -1U << OBJ_TAG_BITS; > > -1UL? Oh, boy, shouldn't be rather GENMASK() / GENMASK_ULL() in a way how it's done, for example, here:

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

Hello, Sorry for the delay. I have missed this until now. ;-( On Sun, Dec 24, 2017 at 11:33 AM, Nick Desaulniers wrote: > Fixes warnings about shifting unsigned literals being undefined > behavior. > > Signed-off-by: Nick Desaulniers >

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

Hello, Sorry for the delay. I have missed this until now. ;-( On Sun, Dec 24, 2017 at 11:33 AM, Nick Desaulniers wrote: > Fixes warnings about shifting unsigned literals being undefined > behavior. > > Signed-off-by: Nick Desaulniers > --- > mm/zsmalloc.c | 2 +- > 1 file changed, 1

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

Hello, What are the next steps for this patch? Note: the MAINTAINERS file does not contain a T: (tree) entry for ZSMALLOC, so I can't check to see if this has already been merged or not. Unless you work out of the mm tree?

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

Hello, What are the next steps for this patch? Note: the MAINTAINERS file does not contain a T: (tree) entry for ZSMALLOC, so I can't check to see if this has already been merged or not. Unless you work out of the mm tree?

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

On Sat, Dec 23, 2017 at 10:24 PM, Matthew Wilcox wrote: > On Sat, Dec 23, 2017 at 09:33:40PM -0500, Nick Desaulniers wrote: >> Fixes warnings about shifting unsigned literals being undefined >> behavior. > > Do you mean signed literals? A sorry, s/unsigned/negative

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

On Sat, Dec 23, 2017 at 10:24 PM, Matthew Wilcox wrote: > On Sat, Dec 23, 2017 at 09:33:40PM -0500, Nick Desaulniers wrote: >> Fixes warnings about shifting unsigned literals being undefined >> behavior. > > Do you mean signed literals? A sorry, s/unsigned/negative signed/g. The warning is:

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

On Sat, Dec 23, 2017 at 09:33:40PM -0500, Nick Desaulniers wrote: > Fixes warnings about shifting unsigned literals being undefined > behavior. Do you mean signed literals? >*/ > - link->next = -1 << OBJ_TAG_BITS; > + link->next =

Re: [PATCH] zsmalloc: use U suffix for negative literals being shifted

On Sat, Dec 23, 2017 at 09:33:40PM -0500, Nick Desaulniers wrote: > Fixes warnings about shifting unsigned literals being undefined > behavior. Do you mean signed literals? >*/ > - link->next = -1 << OBJ_TAG_BITS; > + link->next =

[PATCH] zsmalloc: use U suffix for negative literals being shifted

Fixes warnings about shifting unsigned literals being undefined behavior. Signed-off-by: Nick Desaulniers --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 685049a..5d31458 100644 ---

[PATCH] zsmalloc: use U suffix for negative literals being shifted

Fixes warnings about shifting unsigned literals being undefined behavior. Signed-off-by: Nick Desaulniers --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 685049a..5d31458 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@