Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static

2021-04-09 Thread Nick Terrell
> On Apr 8, 2021, at 8:09 PM, Miguel Ojeda > wrote: > > On Fri, Apr 9, 2021 at 2:20 AM Nick Desaulniers > wrote: >> >> Quite a few other functions are declared in a header, but I don't see >> any existing callers in tree. I wonder if the maintainer could >> consider cleaning these up so

Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static

2021-04-08 Thread Miguel Ojeda
On Fri, Apr 9, 2021 at 2:20 AM Nick Desaulniers wrote: > > Quite a few other functions are declared in a header, but I don't see > any existing callers in tree. I wonder if the maintainer could > consider cleaning these up so that we don't retain them in binaries > without dead code elimination

Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static

2021-04-08 Thread Nick Desaulniers
On Thu, Apr 8, 2021 at 5:55 AM Zhao Xuehui wrote: > > The symbol 'HUF_compressWeights_wksp' is not used outside of > huf_compress.c, so this commit marks it static. Reviewed-by: Nick Desaulniers Quite a few other functions are declared in a header, but I don't see any existing callers in tree.

[PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static

2021-04-08 Thread Zhao Xuehui
The symbol 'HUF_compressWeights_wksp' is not used outside of huf_compress.c, so this commit marks it static. Signed-off-by: Zhao Xuehui --- lib/zstd/huf_compress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/zstd/huf_compress.c b/lib/zstd/huf_compress.c index