Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-08-05 Thread Frederic Weisbecker
On Wed, Aug 05, 2015 at 07:10:57PM +0200, Oleg Nesterov wrote: > On 07/27, Frederic Weisbecker wrote: > > > > Hence those two debatable changes: > > > > _ We would like to use generic workqueues. System unbound workqueues are > > a very good candidate but they are not wide affine, only node

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-08-05 Thread Oleg Nesterov
On 07/27, Frederic Weisbecker wrote: > > Hence those two debatable changes: > > _ We would like to use generic workqueues. System unbound workqueues are > a very good candidate but they are not wide affine, only node affine. > Now probably a node is enough to perform many parallel kmod jobs. >

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-08-05 Thread Oleg Nesterov
On 07/27, Frederic Weisbecker wrote: Hence those two debatable changes: _ We would like to use generic workqueues. System unbound workqueues are a very good candidate but they are not wide affine, only node affine. Now probably a node is enough to perform many parallel kmod jobs. _ We

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-08-05 Thread Frederic Weisbecker
On Wed, Aug 05, 2015 at 07:10:57PM +0200, Oleg Nesterov wrote: On 07/27, Frederic Weisbecker wrote: Hence those two debatable changes: _ We would like to use generic workqueues. System unbound workqueues are a very good candidate but they are not wide affine, only node affine. Now

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-28 Thread Frederic Weisbecker
On Tue, Jul 28, 2015 at 02:01:14PM -0400, Tejun Heo wrote: > Hello, Frederic. > > On Mon, Jul 27, 2015 at 11:05:41PM +0200, Frederic Weisbecker wrote: > > > IMHO, system_wq should be fine and if it isn't turning off numa > > > affinity or raising max worker limit later is pretty trivial. > > > >

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-28 Thread Tejun Heo
Hello, Frederic. On Mon, Jul 27, 2015 at 11:05:41PM +0200, Frederic Weisbecker wrote: > > IMHO, system_wq should be fine and if it isn't turning off numa > > affinity or raising max worker limit later is pretty trivial. > > That's what I think too. How many workers system_unbound_wq can handle?

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-28 Thread Frederic Weisbecker
On Tue, Jul 28, 2015 at 02:01:14PM -0400, Tejun Heo wrote: Hello, Frederic. On Mon, Jul 27, 2015 at 11:05:41PM +0200, Frederic Weisbecker wrote: IMHO, system_wq should be fine and if it isn't turning off numa affinity or raising max worker limit later is pretty trivial. That's what

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-28 Thread Tejun Heo
Hello, Frederic. On Mon, Jul 27, 2015 at 11:05:41PM +0200, Frederic Weisbecker wrote: IMHO, system_wq should be fine and if it isn't turning off numa affinity or raising max worker limit later is pretty trivial. That's what I think too. How many workers system_unbound_wq can handle? If

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-27 Thread Frederic Weisbecker
On Mon, Jul 27, 2015 at 02:48:40PM -0400, Tejun Heo wrote: > On Mon, Jul 27, 2015 at 06:27:15PM +0200, Frederic Weisbecker wrote: > > Hence those two debatable changes: > > > > _ We would like to use generic workqueues. System unbound workqueues are > > a very good candidate but they are not

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-27 Thread Tejun Heo
On Mon, Jul 27, 2015 at 06:27:15PM +0200, Frederic Weisbecker wrote: > Hence those two debatable changes: > > _ We would like to use generic workqueues. System unbound workqueues are > a very good candidate but they are not wide affine, only node affine. > Now probably a node is enough to

[PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-27 Thread Frederic Weisbecker
This patchset does a bunch of cleanups and converts khelper to use system unbound workqueues. The 3 first patches should be uncontroversial. The last 2 patches are debatable. Kmod creates kernel threads that perform userspace jobs and we want those to have a large affinity in order not to contend

[PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-27 Thread Frederic Weisbecker
This patchset does a bunch of cleanups and converts khelper to use system unbound workqueues. The 3 first patches should be uncontroversial. The last 2 patches are debatable. Kmod creates kernel threads that perform userspace jobs and we want those to have a large affinity in order not to contend

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-27 Thread Tejun Heo
On Mon, Jul 27, 2015 at 06:27:15PM +0200, Frederic Weisbecker wrote: Hence those two debatable changes: _ We would like to use generic workqueues. System unbound workqueues are a very good candidate but they are not wide affine, only node affine. Now probably a node is enough to perform

Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3

2015-07-27 Thread Frederic Weisbecker
On Mon, Jul 27, 2015 at 02:48:40PM -0400, Tejun Heo wrote: On Mon, Jul 27, 2015 at 06:27:15PM +0200, Frederic Weisbecker wrote: Hence those two debatable changes: _ We would like to use generic workqueues. System unbound workqueues are a very good candidate but they are not wide