Re: [PATCH 01/11] clk: sunxi-ng: mux: Fix determine_rate for mux clocks with pre-dividers

2017-01-26 Thread Chen-Yu Tsai
On Thu, Jan 26, 2017 at 5:55 PM, Maxime Ripard wrote: > Hi Chen-Yu, > > On Tue, Jan 24, 2017 at 10:32:20AM +0800, Chen-Yu Tsai wrote: >> The determine_rate helper used ccu_mux_helper_adjust_parent_for_prediv() >> to adjust the parent_rate to account for

Re: [PATCH 01/11] clk: sunxi-ng: mux: Fix determine_rate for mux clocks with pre-dividers

2017-01-26 Thread Chen-Yu Tsai
On Thu, Jan 26, 2017 at 5:55 PM, Maxime Ripard wrote: > Hi Chen-Yu, > > On Tue, Jan 24, 2017 at 10:32:20AM +0800, Chen-Yu Tsai wrote: >> The determine_rate helper used ccu_mux_helper_adjust_parent_for_prediv() >> to adjust the parent_rate to account for pre-dividers, but then passed >> the

Re: [PATCH 01/11] clk: sunxi-ng: mux: Fix determine_rate for mux clocks with pre-dividers

2017-01-26 Thread Maxime Ripard
Hi Chen-Yu, On Tue, Jan 24, 2017 at 10:32:20AM +0800, Chen-Yu Tsai wrote: > The determine_rate helper used ccu_mux_helper_adjust_parent_for_prediv() > to adjust the parent_rate to account for pre-dividers, but then passed > the pristine parent clock rate from clk_hw_get_rate() to the round() >

Re: [PATCH 01/11] clk: sunxi-ng: mux: Fix determine_rate for mux clocks with pre-dividers

2017-01-26 Thread Maxime Ripard
Hi Chen-Yu, On Tue, Jan 24, 2017 at 10:32:20AM +0800, Chen-Yu Tsai wrote: > The determine_rate helper used ccu_mux_helper_adjust_parent_for_prediv() > to adjust the parent_rate to account for pre-dividers, but then passed > the pristine parent clock rate from clk_hw_get_rate() to the round() >

[PATCH 01/11] clk: sunxi-ng: mux: Fix determine_rate for mux clocks with pre-dividers

2017-01-23 Thread Chen-Yu Tsai
The determine_rate helper used ccu_mux_helper_adjust_parent_for_prediv() to adjust the parent_rate to account for pre-dividers, but then passed the pristine parent clock rate from clk_hw_get_rate() to the round() callback, thereby ignoring the pre-divider adjustment. In addition, it was saving the

[PATCH 01/11] clk: sunxi-ng: mux: Fix determine_rate for mux clocks with pre-dividers

2017-01-23 Thread Chen-Yu Tsai
The determine_rate helper used ccu_mux_helper_adjust_parent_for_prediv() to adjust the parent_rate to account for pre-dividers, but then passed the pristine parent clock rate from clk_hw_get_rate() to the round() callback, thereby ignoring the pre-divider adjustment. In addition, it was saving the