Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-05 Thread Linus Walleij
On Fri, Oct 2, 2015 at 12:45 PM, Sudeep Holla wrote: >> Looks correct to me. >> Acked-by: Linus Walleij > > Thanks, while you are at it, do you know what interrupt stv2_pl031 > shares so that I can fix the TODO in the comment or the code(whichever > applicable). This is shared with a hardware

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-05 Thread Linus Walleij
On Fri, Oct 2, 2015 at 12:45 PM, Sudeep Holla wrote: >> Looks correct to me. >> Acked-by: Linus Walleij > > Thanks, while you are at it, do you know what interrupt stv2_pl031 > shares so that I can fix the TODO in the comment or the code(whichever

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-03 Thread Alexandre Belloni
On 21/09/2015 at 16:46:57 +0100, Sudeep Holla wrote : > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended state,

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-03 Thread Alexandre Belloni
On 21/09/2015 at 16:46:57 +0100, Sudeep Holla wrote : > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended state,

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-02 Thread Alexandre Belloni
On 02/10/2015 at 11:45:18 +0100, Sudeep Holla wrote : > > > On 02/10/15 11:40, Linus Walleij wrote: > >On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > > > >>The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > >>be left enabled so as to allow them to work as expected

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-02 Thread Sudeep Holla
On 02/10/15 11:40, Linus Walleij wrote: On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't guarantee that it will

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-02 Thread Linus Walleij
On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended state,

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-02 Thread Alexandre Belloni
On 02/10/2015 at 11:45:18 +0100, Sudeep Holla wrote : > > > On 02/10/15 11:40, Linus Walleij wrote: > >On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > > > >>The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > >>be left enabled so as to allow

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-02 Thread Sudeep Holla
On 02/10/15 11:40, Linus Walleij wrote: On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-02 Thread Linus Walleij
On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system >

[PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Sudeep Holla
The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't guarantee that it will wake the system from a suspended state, enable_irq_wake is recommended to be used for the wakeup.

[PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Sudeep Holla
The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't guarantee that it will wake the system from a suspended state, enable_irq_wake is recommended to be used for the wakeup.