Re: [PATCH 02/29] fscrypt: Allow fscrypt_decrypt_page() to function with non-writeback pages

2016-11-24 Thread David Gstir
Eric, > On 15.11.2016, at 19:19, Eric Biggers wrote: > > On Sun, Nov 13, 2016 at 10:20:45PM +0100, Richard Weinberger wrote: >> /** >> * f2crypt_decrypt_page() - Decrypts a page in-place >> - * @page: The page to decrypt. Must be locked. >> + * @inode: The encrypted inode

Re: [PATCH 02/29] fscrypt: Allow fscrypt_decrypt_page() to function with non-writeback pages

2016-11-24 Thread David Gstir
Eric, > On 15.11.2016, at 19:19, Eric Biggers wrote: > > On Sun, Nov 13, 2016 at 10:20:45PM +0100, Richard Weinberger wrote: >> /** >> * f2crypt_decrypt_page() - Decrypts a page in-place >> - * @page: The page to decrypt. Must be locked. >> + * @inode: The encrypted inode to decrypt. >> + *

Re: [PATCH 02/29] fscrypt: Allow fscrypt_decrypt_page() to function with non-writeback pages

2016-11-15 Thread Eric Biggers
On Sun, Nov 13, 2016 at 10:20:45PM +0100, Richard Weinberger wrote: > /** > * f2crypt_decrypt_page() - Decrypts a page in-place > - * @page: The page to decrypt. Must be locked. > + * @inode: The encrypted inode to decrypt. > + * @page: The page to decrypt. Must be locked. Strictly speaking,

Re: [PATCH 02/29] fscrypt: Allow fscrypt_decrypt_page() to function with non-writeback pages

2016-11-15 Thread Eric Biggers
On Sun, Nov 13, 2016 at 10:20:45PM +0100, Richard Weinberger wrote: > /** > * f2crypt_decrypt_page() - Decrypts a page in-place > - * @page: The page to decrypt. Must be locked. > + * @inode: The encrypted inode to decrypt. > + * @page: The page to decrypt. Must be locked. Strictly speaking,

[PATCH 02/29] fscrypt: Allow fscrypt_decrypt_page() to function with non-writeback pages

2016-11-13 Thread Richard Weinberger
From: David Gstir Some filesystem might pass pages which do not have page->mapping->host set to the encrypted inode. We want the caller to explicitly pass the corresponding inode. Signed-off-by: David Gstir Signed-off-by: Richard Weinberger

[PATCH 02/29] fscrypt: Allow fscrypt_decrypt_page() to function with non-writeback pages

2016-11-13 Thread Richard Weinberger
From: David Gstir Some filesystem might pass pages which do not have page->mapping->host set to the encrypted inode. We want the caller to explicitly pass the corresponding inode. Signed-off-by: David Gstir Signed-off-by: Richard Weinberger --- fs/crypto/crypto.c | 11 ++-