Re: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping

2012-11-13 Thread Yinghai Lu
On Mon, Nov 12, 2012 at 11:03 PM, wrote: > On 2012年11月13日 14:20, Yinghai Lu wrote: >>> 2012/11/13 6:17, Yinghai Lu wrote: + nr_range = 0; >>> >>> This is unnecessary since it is set in the below. >>> + nr_range = split_mem_range(mr, nr_range, start, end); >> >>

Re: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping

2012-11-12 Thread snakky . zhang
On 2012年11月13日 14:20, Yinghai Lu wrote: On Mon, Nov 12, 2012 at 9:51 PM, Yasuaki Ishimatsu wrote: 2012/11/13 6:17, Yinghai Lu wrote: + nr_range = 0; This is unnecessary since it is set in the below. + nr_range = split_mem_range(mr, nr_range, start, end);

Re: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping

2012-11-12 Thread Yinghai Lu
On Mon, Nov 12, 2012 at 9:51 PM, Yasuaki Ishimatsu wrote: > 2012/11/13 6:17, Yinghai Lu wrote: >> + nr_range = 0; > > This is unnecessary since it is set in the below. > >> + nr_range = split_mem_range(mr, nr_range, start, end);

Re: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping

2012-11-12 Thread Yasuaki Ishimatsu
2012/11/13 6:17, Yinghai Lu wrote: > So make init_memory_mapping smaller and readable. > > Suggested-by: Ingo Molnar > Signed-off-by: Yinghai Lu > Reviewed-by: Pekka Enberg > --- > arch/x86/mm/init.c | 42 ++ > 1 files changed, 26 insertions(+), 16 d

[PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping

2012-11-12 Thread Yinghai Lu
So make init_memory_mapping smaller and readable. Suggested-by: Ingo Molnar Signed-off-by: Yinghai Lu Reviewed-by: Pekka Enberg --- arch/x86/mm/init.c | 42 ++ 1 files changed, 26 insertions(+), 16 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x