Re: [linux-sunxi] Re: [PATCH 05/15] drm/sun4i: Add TCON TOP driver

2018-05-24 Thread Jernej Škrabec
Hi, Dne četrtek, 24. maj 2018 ob 10:43:51 CEST je Maxime Ripard napisal(a): > Hi, > > On Mon, May 21, 2018 at 05:15:15PM +0200, Jernej Škrabec wrote: > > > > + /* > > > > +* Default register values might have some reserved bits set, which > > > > +* prevents TCON TOP from w

Re: [PATCH 05/15] drm/sun4i: Add TCON TOP driver

2018-05-24 Thread Maxime Ripard
Hi, On Mon, May 21, 2018 at 05:15:15PM +0200, Jernej Škrabec wrote: > > > + /* > > > + * Default register values might have some reserved bits set, which > > > + * prevents TCON TOP from working properly. Set them to 0 here. > > > + */ > > > + writel(0, tcon_top->regs + TCON_TOP_PORT_SEL_REG);

Re: [PATCH 05/15] drm/sun4i: Add TCON TOP driver

2018-05-23 Thread Rob Herring
On Sat, May 19, 2018 at 08:31:17PM +0200, Jernej Skrabec wrote: > As already described in DT binding, TCON TOP is responsible for > configuring display pipeline. In this initial driver focus is on HDMI > pipeline, so TVE and LCD configuration is not implemented. > > Implemented features: > - HDMI

Re: [PATCH 05/15] drm/sun4i: Add TCON TOP driver

2018-05-21 Thread kbuild test robot
Hi Jernej, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.17-rc6 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/c

Re: [PATCH 05/15] drm/sun4i: Add TCON TOP driver

2018-05-21 Thread Jernej Škrabec
Hi, Dne ponedeljek, 21. maj 2018 ob 10:05:17 CEST je Maxime Ripard napisal(a): > On Sat, May 19, 2018 at 08:31:17PM +0200, Jernej Skrabec wrote: > > As already described in DT binding, TCON TOP is responsible for > > configuring display pipeline. In this initial driver focus is on HDMI > > pipelin

Re: [PATCH 05/15] drm/sun4i: Add TCON TOP driver

2018-05-21 Thread Maxime Ripard
On Sat, May 19, 2018 at 08:31:17PM +0200, Jernej Skrabec wrote: > As already described in DT binding, TCON TOP is responsible for > configuring display pipeline. In this initial driver focus is on HDMI > pipeline, so TVE and LCD configuration is not implemented. > > Implemented features: > - HDMI

[PATCH 05/15] drm/sun4i: Add TCON TOP driver

2018-05-19 Thread Jernej Skrabec
As already described in DT binding, TCON TOP is responsible for configuring display pipeline. In this initial driver focus is on HDMI pipeline, so TVE and LCD configuration is not implemented. Implemented features: - HDMI source selection - clock driver (TCON and DSI gating) - connecting mixers an