Re: [PATCH 06/18] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

2017-07-20 Thread Maxime Ripard
Hi Chen-Yu, On Fri, Jul 14, 2017 at 11:40:07AM +0800, Chen-Yu Tsai wrote: > > static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder, > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > index d9791292553e..dc70bc2a42a5 100644 > > ---

Re: [PATCH 06/18] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

2017-07-20 Thread Maxime Ripard
Hi Chen-Yu, On Fri, Jul 14, 2017 at 11:40:07AM +0800, Chen-Yu Tsai wrote: > > static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder, > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > index d9791292553e..dc70bc2a42a5 100644 > > ---

Re: [PATCH 06/18] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

2017-07-13 Thread Chen-Yu Tsai
On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard wrote: > So far, we've required all the TCON-connected encoders to call the TCON > enable and disable functions. > > This was made this way because in the RGB/LVDS case, the TCON is the CRTC > and the encoder.

Re: [PATCH 06/18] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

2017-07-13 Thread Chen-Yu Tsai
On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard wrote: > So far, we've required all the TCON-connected encoders to call the TCON > enable and disable functions. > > This was made this way because in the RGB/LVDS case, the TCON is the CRTC > and the encoder. However, in all the other cases (HDMI,

[PATCH 06/18] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

2017-07-13 Thread Maxime Ripard
So far, we've required all the TCON-connected encoders to call the TCON enable and disable functions. This was made this way because in the RGB/LVDS case, the TCON is the CRTC and the encoder. However, in all the other cases (HDMI, TV, DSI, etc.), we have another encoder down the road that needs

[PATCH 06/18] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

2017-07-13 Thread Maxime Ripard
So far, we've required all the TCON-connected encoders to call the TCON enable and disable functions. This was made this way because in the RGB/LVDS case, the TCON is the CRTC and the encoder. However, in all the other cases (HDMI, TV, DSI, etc.), we have another encoder down the road that needs