Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-02 Thread Jason Gunthorpe
On Wed, Oct 02, 2013 at 01:14:18AM +0200, Peter H?we wrote: > > I botched the makefile changes for the new .c files. > > > > I believe it should be like this: > > > > obj-$(CONFIG_TCG_TPM) += tpm-core.o > > tpm-core-y := tpm.o tpm-dev.o tpm-sysfs.o > > > > > I added a suitable patch with the

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-02 Thread Jason Gunthorpe
On Wed, Oct 02, 2013 at 01:14:18AM +0200, Peter H?we wrote: I botched the makefile changes for the new .c files. I believe it should be like this: obj-$(CONFIG_TCG_TPM) += tpm-core.o tpm-core-y := tpm.o tpm-dev.o tpm-sysfs.o I added a suitable patch with the appropriate

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-01 Thread Jason Gunthorpe
On Wed, Oct 02, 2013 at 01:14:18AM +0200, Peter H?we wrote: > The makefile patch did fix it. Great, feel free squash into the broken commit, or I can respin things. > (along with a small fix for the tpm_i2c_atmel driver ;) Hum, I wonder why my compilers didn't whine, x86-64 should have

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-01 Thread Peter Hüwe
Am Mittwoch, 2. Oktober 2013, 00:57:33 schrieb Jason Gunthorpe: > > When compiling the tpm drivers as modules I get > > ERROR: "tpm_sysfs_del_device" [drivers/char/tpm/tpm.ko] undefined! > > ERROR: "tpm_dev_add_device" [drivers/char/tpm/tpm.ko] undefined! > > ERROR: "tpm_dev_del_device"

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-01 Thread Jason Gunthorpe
On Wed, Oct 02, 2013 at 12:52:40AM +0200, Peter H?we wrote: > Am Montag, 23. September 2013, 20:14:38 schrieb Jason Gunthorpe: > > CLASS-dev.c is a common idiom for Linux subsystems > > > > This pulls all the code related to the miscdev into tpm-dev.c and makes it > > static. The identical

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-01 Thread Peter Hüwe
Am Montag, 23. September 2013, 20:14:38 schrieb Jason Gunthorpe: > CLASS-dev.c is a common idiom for Linux subsystems > > This pulls all the code related to the miscdev into tpm-dev.c and makes it > static. The identical file_operation structs in the drivers are purged and > the tpm common code

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-01 Thread Peter Hüwe
Am Montag, 23. September 2013, 20:14:38 schrieb Jason Gunthorpe: CLASS-dev.c is a common idiom for Linux subsystems This pulls all the code related to the miscdev into tpm-dev.c and makes it static. The identical file_operation structs in the drivers are purged and the tpm common code

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-01 Thread Jason Gunthorpe
On Wed, Oct 02, 2013 at 12:52:40AM +0200, Peter H?we wrote: Am Montag, 23. September 2013, 20:14:38 schrieb Jason Gunthorpe: CLASS-dev.c is a common idiom for Linux subsystems This pulls all the code related to the miscdev into tpm-dev.c and makes it static. The identical file_operation

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-01 Thread Peter Hüwe
Am Mittwoch, 2. Oktober 2013, 00:57:33 schrieb Jason Gunthorpe: When compiling the tpm drivers as modules I get ERROR: tpm_sysfs_del_device [drivers/char/tpm/tpm.ko] undefined! ERROR: tpm_dev_add_device [drivers/char/tpm/tpm.ko] undefined! ERROR: tpm_dev_del_device

Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-10-01 Thread Jason Gunthorpe
On Wed, Oct 02, 2013 at 01:14:18AM +0200, Peter H?we wrote: The makefile patch did fix it. Great, feel free squash into the broken commit, or I can respin things. (along with a small fix for the tpm_i2c_atmel driver ;) Hum, I wonder why my compilers didn't whine, x86-64 should have

[PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-09-23 Thread Jason Gunthorpe
CLASS-dev.c is a common idiom for Linux subsystems This pulls all the code related to the miscdev into tpm-dev.c and makes it static. The identical file_operation structs in the drivers are purged and the tpm common code unconditionally creates the miscdev. Signed-off-by: Jason Gunthorpe ---

[PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

2013-09-23 Thread Jason Gunthorpe
CLASS-dev.c is a common idiom for Linux subsystems This pulls all the code related to the miscdev into tpm-dev.c and makes it static. The identical file_operation structs in the drivers are purged and the tpm common code unconditionally creates the miscdev. Signed-off-by: Jason Gunthorpe